Re: [meta-intel] [PATCH V3 2/2] meta-intel/common: Upgrade DPDK to v1.7.0
On Wed, 2014-10-08 at 03:42 +, Selvaraj, Sreeju ArmughanX wrote: > Hi Ross, > > As per the feedback, I have added the Upstream Status to the patches. > Please review the changes. > These were pulled in last week.. Tom > Thanks and Regards, > -Sreeju > > -Original Message- > From: Ong, Boon Leong > Sent: Wednesday, October 01, 2014 2:52 PM > To: Selvaraj, Sreeju ArmughanX; meta-intel@yoctoproject.org > Subject: RE: [meta-intel] [PATCH V3 2/2] meta-intel/common: Upgrade DPDK to > v1.7.0 > > > > > -Original Message- > > From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel- > > boun...@yoctoproject.org] On Behalf Of > > sreeju.armughanx.selva...@intel.com > > Sent: Tuesday, September 30, 2014 10:43 AM > > To: meta-intel@yoctoproject.org > > Subject: [meta-intel] [PATCH V3 2/2] meta-intel/common: Upgrade DPDK > > to > > v1.7.0 > > > > From: Sreeju Selvaraj > > > > Added support for DPDK v1.7.0 > > > > Added PACKAGECONFIG mechanism to explicitly disable the use of fuse > > and qat which are dependancies for example apps dpdk_qat and vhost. > > > > Added config variables CONFIG_EXAMPLE_DPDK_QAT and > > CONFIG_EXAMPLE_DPDK_VHOST to enable or disable the compilation of > > example apps dpdk_qat and vhost. > > > > Resolved the installation failure found in example app ip_pipeline by > > cherry picking the patch from dpdk.org. > > > > Resolved the test failure found in example app ring_pmd_autotest by > > cherry picking the patches from dpdk.org. > > > > Signed-off-by: Sreeju Selvaraj > > Acked-by: Ong Boon Leong > > > --- > > ...d-config-variables-to-enable-disable-dpdk.patch | 42 +++ > > ...examples- pipeline-build-with-all-examples.patch | 34 ++ > > ...e-extra-devices-creation- with-vdev-option.patch | 44 +++ > > .../dpdk/dpdk-1.7.0-ring-simplify-unit- > > tests.patch | 380 + > > common/recipes-extended/dpdk/dpdk_1.7.0.bb | 41 +++ > > 5 files changed, 541 insertions(+) > > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0- > > examples-Add-config-variables-to-enable-disable-dpdk.patch > > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0- > > examples-pipeline-build-with-all-examples.patch > > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-ring- > > remove-extra-devices-creation-with-vdev-option.patch > > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-ring- > > simplify-unit-tests.patch > > create mode 100644 common/recipes-extended/dpdk/dpdk_1.7.0.bb > > > > diff --git > > a/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples-Add- > > config-variables-to-enable-disable-dpdk.patch b/common/recipes- > > extended/dpdk/dpdk/dpdk-1.7.0-examples-Add-config-variables-to-enable- > > disable-dpdk.patch > > new file mode 100644 > > index 000..d0721ca > > --- /dev/null > > +++ b/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples-Add- > > config-v > > +++ ariables-to-enable-disable-dpdk.patch > > @@ -0,0 +1,42 @@ > > +From 63f8ccc5a305b193e219d288ef9e43b9a9fa6aa8 Mon Sep 17 00:00:00 > > +2001 > > +From: Sreeju Selvaraj > > +Date: Wed, 17 Sep 2014 19:10:01 +0800 > > +Subject: [PATCH] examples: Add config variables to enable/disable > > +dpdk_qat and vhost > > + > > +Upstream-Status: Inappropriate [configuration] > > + > > +This can be used to export CONFIG_EXAMPLE_DPDK_QAT=n if dpdk_qat is > > not > > +in PACKAGECONFIG and also allow to export > > CONFIG_EXAMPLE_DPDK_VHOST=n > > +if vhost is not in PACKAGECONFIG. > > + > > +Signed-off-by: Sreeju Selvaraj > > +--- > > + examples/Makefile | 4 ++-- > > + 1 file changed, 2 insertions(+), 2 deletions(-) > > + > > +diff --git a/examples/Makefile b/examples/Makefile index > > +d0624f6..885c938 100644 > > +--- a/examples/Makefile > > b/examples/Makefile > > +@@ -39,7 +39,7 @@ include $(RTE_SDK)/mk/rte.vars.mk > > + > > + DIRS-y += cmdline > > + ifneq ($(ICP_ROOT),) > > +-DIRS-y += dpdk_qat > > ++DIRS-$(CONFIG_EXAMPLE_DPDK_QAT) += dpdk_qat > > + endif > > + DIRS-y += exception_path > > + DIRS-y += helloworld > > +@@ -61,7 +61,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_METER) += qos_meter > > + DIRS-$(CONFIG_RTE_LIBRTE_SCHED) += qos_sched DIRS-y += > > +quota_watermark DIRS-y += timer -DIRS-y += vhost > > ++DIRS-$(CONFIG_EXAMPLE_DPDK_VHOST) += vhost > > + DIRS-$(CONFIG_RTE_LIBRTE_XEN_DOM0) += vhost_xen DIRS-y += vmdq > > +DIRS-y += vmdq_dcb > > +-- > > +1.9.1 > > + > > diff --git a/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples- > > pipeline-build-with-all-examples.patch b/common/recipes- > > extended/dpdk/dpdk/dpdk-1.7.0-examples-pipeline-build-with-all- > > examples.patch > > new file mode 100644 > > index 000..25f029f > > --- /dev/null > > +++ b/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples-pipeline- > > bui > > +++ ld-with-all-examples.patch > > @@ -0,0 +1,34 @@ > > +From 15aef6e666ee2eb0befa153d277d47754f3656e4 Mon Sep 17 00:00:00 > > 2001 > > +From: Thomas Monjalon > > +Date: Thu,
[meta-intel] You still haven't accepted berlin993...@gmail.com's friend request. Accept?
Click here to discover berlin993...@gmail.com's favorite websites! berlin993...@gmail.com wants to follow you Is berlin993...@gmail.com your friend? Yes No Following berlin993...@gmail.com helps you discover great websites they recommend :) Click here to unsubscribe from such emails from berlin993...@gmail.com or all friends P.O BOX 70928, Sunnyvale, CA, 94086 -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH V3 2/2] meta-intel/common: Upgrade DPDK to v1.7.0
Hi Ross, As per the feedback, I have added the Upstream Status to the patches. Please review the changes. Thanks and Regards, -Sreeju -Original Message- From: Ong, Boon Leong Sent: Wednesday, October 01, 2014 2:52 PM To: Selvaraj, Sreeju ArmughanX; meta-intel@yoctoproject.org Subject: RE: [meta-intel] [PATCH V3 2/2] meta-intel/common: Upgrade DPDK to v1.7.0 > -Original Message- > From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel- > boun...@yoctoproject.org] On Behalf Of > sreeju.armughanx.selva...@intel.com > Sent: Tuesday, September 30, 2014 10:43 AM > To: meta-intel@yoctoproject.org > Subject: [meta-intel] [PATCH V3 2/2] meta-intel/common: Upgrade DPDK > to > v1.7.0 > > From: Sreeju Selvaraj > > Added support for DPDK v1.7.0 > > Added PACKAGECONFIG mechanism to explicitly disable the use of fuse > and qat which are dependancies for example apps dpdk_qat and vhost. > > Added config variables CONFIG_EXAMPLE_DPDK_QAT and > CONFIG_EXAMPLE_DPDK_VHOST to enable or disable the compilation of > example apps dpdk_qat and vhost. > > Resolved the installation failure found in example app ip_pipeline by > cherry picking the patch from dpdk.org. > > Resolved the test failure found in example app ring_pmd_autotest by > cherry picking the patches from dpdk.org. > > Signed-off-by: Sreeju Selvaraj Acked-by: Ong Boon Leong > --- > ...d-config-variables-to-enable-disable-dpdk.patch | 42 +++ > ...examples- pipeline-build-with-all-examples.patch | 34 ++ > ...e-extra-devices-creation- with-vdev-option.patch | 44 +++ > .../dpdk/dpdk-1.7.0-ring-simplify-unit- > tests.patch | 380 + > common/recipes-extended/dpdk/dpdk_1.7.0.bb | 41 +++ > 5 files changed, 541 insertions(+) > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0- > examples-Add-config-variables-to-enable-disable-dpdk.patch > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0- > examples-pipeline-build-with-all-examples.patch > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-ring- > remove-extra-devices-creation-with-vdev-option.patch > create mode 100644 common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-ring- > simplify-unit-tests.patch > create mode 100644 common/recipes-extended/dpdk/dpdk_1.7.0.bb > > diff --git > a/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples-Add- > config-variables-to-enable-disable-dpdk.patch b/common/recipes- > extended/dpdk/dpdk/dpdk-1.7.0-examples-Add-config-variables-to-enable- > disable-dpdk.patch > new file mode 100644 > index 000..d0721ca > --- /dev/null > +++ b/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples-Add- > config-v > +++ ariables-to-enable-disable-dpdk.patch > @@ -0,0 +1,42 @@ > +From 63f8ccc5a305b193e219d288ef9e43b9a9fa6aa8 Mon Sep 17 00:00:00 > +2001 > +From: Sreeju Selvaraj > +Date: Wed, 17 Sep 2014 19:10:01 +0800 > +Subject: [PATCH] examples: Add config variables to enable/disable > +dpdk_qat and vhost > + > +Upstream-Status: Inappropriate [configuration] > + > +This can be used to export CONFIG_EXAMPLE_DPDK_QAT=n if dpdk_qat is > not > +in PACKAGECONFIG and also allow to export > CONFIG_EXAMPLE_DPDK_VHOST=n > +if vhost is not in PACKAGECONFIG. > + > +Signed-off-by: Sreeju Selvaraj > +--- > + examples/Makefile | 4 ++-- > + 1 file changed, 2 insertions(+), 2 deletions(-) > + > +diff --git a/examples/Makefile b/examples/Makefile index > +d0624f6..885c938 100644 > +--- a/examples/Makefile > b/examples/Makefile > +@@ -39,7 +39,7 @@ include $(RTE_SDK)/mk/rte.vars.mk > + > + DIRS-y += cmdline > + ifneq ($(ICP_ROOT),) > +-DIRS-y += dpdk_qat > ++DIRS-$(CONFIG_EXAMPLE_DPDK_QAT) += dpdk_qat > + endif > + DIRS-y += exception_path > + DIRS-y += helloworld > +@@ -61,7 +61,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_METER) += qos_meter > + DIRS-$(CONFIG_RTE_LIBRTE_SCHED) += qos_sched DIRS-y += > +quota_watermark DIRS-y += timer -DIRS-y += vhost > ++DIRS-$(CONFIG_EXAMPLE_DPDK_VHOST) += vhost > + DIRS-$(CONFIG_RTE_LIBRTE_XEN_DOM0) += vhost_xen DIRS-y += vmdq > +DIRS-y += vmdq_dcb > +-- > +1.9.1 > + > diff --git a/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples- > pipeline-build-with-all-examples.patch b/common/recipes- > extended/dpdk/dpdk/dpdk-1.7.0-examples-pipeline-build-with-all- > examples.patch > new file mode 100644 > index 000..25f029f > --- /dev/null > +++ b/common/recipes-extended/dpdk/dpdk/dpdk-1.7.0-examples-pipeline- > bui > +++ ld-with-all-examples.patch > @@ -0,0 +1,34 @@ > +From 15aef6e666ee2eb0befa153d277d47754f3656e4 Mon Sep 17 00:00:00 > 2001 > +From: Thomas Monjalon > +Date: Thu, 17 Jul 2014 10:30:52 +0200 > +Subject: [PATCH] examples/pipeline: build with all examples > + > +Upstream-Status: Backport > +Imported patch from: http://dpdk.org/browse/dpdk/log/ > + > +When adding this packet framework sample (commit 77a3346), it has > +been forgotten to add it into the global makefile for "make examples". > + > +Signed-off-by: Thomas Monjalon (cherry > +
Re: [meta-intel] [PATCH V3 1/2] meta-intel/common: Add include file for DPDK
Hi Ross,
Any feedback on this patch ?
Thanks and Regards,
-Sreeju
-Original Message-
From: Ong, Boon Leong
Sent: Wednesday, October 01, 2014 2:52 PM
To: Selvaraj, Sreeju ArmughanX; meta-intel@yoctoproject.org
Subject: RE: [meta-intel] [PATCH V3 1/2] meta-intel/common: Add include file
for DPDK
> -Original Message-
> From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel-
> boun...@yoctoproject.org] On Behalf Of
> sreeju.armughanx.selva...@intel.com
> Sent: Tuesday, September 30, 2014 10:43 AM
> To: meta-intel@yoctoproject.org
> Subject: [meta-intel] [PATCH V3 1/2] meta-intel/common: Add include
> file for DPDK
>
> From: Sreeju Selvaraj
>
> Added include file dpdk.inc to share the common functionality based on
> dpdk_1.6.0r2
>
> Added a new variable EXAMPLE_BUILD_DIR. this points to apps build
> directory which is different in dpdk v1.6.0r2 and v1.7.0.
> User of dpdk.inc has to define EXAMPLE_BUILD_DIR for the installation
> of example apps
>
> Signed-off-by: Sreeju Selvaraj
Acked-by: Ong Boon Leong
> ---
> common/recipes-extended/dpdk/dpdk.inc| 139
> +
> common/recipes-extended/dpdk/dpdk_1.6.0r2.bb | 150
> +++-
> ---
> 2 files changed, 154 insertions(+), 135 deletions(-) create mode
> 100644 common/recipes-extended/dpdk/dpdk.inc
>
> diff --git a/common/recipes-extended/dpdk/dpdk.inc b/common/recipes-
> extended/dpdk/dpdk.inc new file mode 100644 index 000..ef369df
> --- /dev/null
> +++ b/common/recipes-extended/dpdk/dpdk.inc
> @@ -0,0 +1,139 @@
> +DESCRIPTION = "Intel(r) Data Plane Development Kit"
> +HOMEPAGE = "http://dpdk.org";
> +LICENSE = "BSD & LGPLv2 & GPLv2"
> +LIC_FILES_CHKSUM =
> "file://LICENSE.GPL;md5=751419260aa954499f7abaabaa882bbe"
> +
> +
> +RDEPENDS_${PN} += "python-subprocess"
> +
> +inherit module
> +
> +export
> MODULE_DIR="/lib/modules/${KERNEL_VERSION}/kernel/drivers/net"
> +export RTE_SDK = "${S}"
> +export RTE_TARGET="${TARGET_ARCH}-ivshmem-${TARGET_OS}app-gcc"
> +export ICP_ROOT = "${PKG_CONFIG_SYSROOT_DIR}/usr/include"
> +export ICP_LIB_ROOT= "${PKG_CONFIG_SYSROOT_DIR}/usr/lib"
> +export RTE_KERNELDIR = "${STAGING_KERNEL_DIR}"
> +export INSTALL_PATH = "${prefix}/dpdk"
> +
> +
> +do_configure () {
> +
> ##
> ###
> + ### default value for prefix is "usr", unsetting it, so it
> + ### will not be concatenated in ${RTE_TARGET}/Makefile
> + ### which will cause compilation failure
> +
> ##
> ###
> + unset prefix
> +
> + make O=$RTE_TARGET T=$RTE_TARGET config
> +
> +}
> +
> +
> +do_compile () {
> + unset LDFLAGS TARGET_LDFLAGS BUILD_LDFLAGS
> +
> + cd ${S}/${RTE_TARGET}
> + oe_runmake EXTRA_LDFLAGS=" --sysroot=${STAGING_DIR_HOST}" \
> +EXTRA_CFLAGS=" --sysroot=${STAGING_DIR_HOST}" \
> +CROSS="${TARGET_PREFIX}" \
> +prefix="" LDFLAGS="" WERROR_FLAGS="-w" V=1
> +
> +}
> +
> +
> +do_install () {
> +
> + install -m 0755 -d ${D}/${INSTALL_PATH} \
> + ${D}/${INSTALL_PATH}/doc \
> + ${D}/${INSTALL_PATH}/tools \
> + ${D}/${INSTALL_PATH}/${RTE_TARGET} \
> + ${D}/${INSTALL_PATH}/${RTE_TARGET}/app \
> + ${D}${includedir} \
> + ${D}${includedir}/arch \
> + ${D}${includedir}/exec-env \
> + ${D}${libdir} \
> + ${D}${MODULE_DIR}
> +
> + install -m 0755 ${S}/${RTE_TARGET}/kmod/igb_uio.ko
> ${D}${MODULE_DIR}/
> + install -m 0755 ${S}/${RTE_TARGET}/kmod/rte_kni.ko
> ${D}${MODULE_DIR}/
> +
> + install -m 640 ${S}/${RTE_TARGET}/lib/*.a ${D}${libdir}
> +
> + install -m 640 ${S}/${RTE_TARGET}/.config
> ${D}/${INSTALL_PATH}/${RTE_TARGET}/
> + install -m 640 ${S}/${RTE_TARGET}/include/*.h
> ${D}${includedir}/
> + install -m 640 ${S}/${RTE_TARGET}/include/arch/*
> ${D}${includedir}/arch/
> + install -m 640 ${S}/${RTE_TARGET}/include/exec-env/*
> ${D}${includedir}/exec-env/
> + install -m 0755 ${S}/tools/*.py
> ${D}/${INSTALL_PATH}/tools/
> +
> +
> + #Install test applications
> + install -m 0755 ${S}/${RTE_TARGET}/app/test
> ${D}/${INSTALL_PATH}/${RTE_TARGET}/app
> + install -m 0755 ${S}/${RTE_TARGET}/app/testpmd
> ${D}/${INSTALL_PATH}/${RTE_TARGET}/app
> + install -m 0755 ${S}/${RTE_TARGET}/app/dump_cfg
> ${D}/${INSTALL_PATH}/${RTE_TARGET}/app
> + install -m 0755 ${S}/${RTE_TARGET}/app/cmdline_test
> ${D}/${INSTALL_PATH}/${RTE_TARGET}/app
> +
> +
> + # Install example applications
> + # It is expected that user of this include file should define
> EXAMPLES_BUILD_DIR
> + for app in ${S}/examples/*
> + d
Re: [meta-intel] [Patch v3 03/12] README: Documentation of hardware features
On 10/3/14, 15:14, "nitin.a.kam...@intel.com" wrote: >From: Nitin A Kamble Hi Nitin, This is looking better. A few mostly readability issues to address below. Generally speaking the text is more verbose than it needs to be (which is distracting to the reader and makes it harder to find the necessary information). Specific examples below. > >Starting a new documentation section to describe the layer specific >hardware >features. At this point the intel-ucode machine feature is described here. >In the future more such features will be described in this section. > >Signed-off-by: Nitin A Kamble >--- > README | 95 >++ > 1 file changed, 95 insertions(+) > >diff --git a/README b/README >index c829fdb..66b6789 100644 >--- a/README >+++ b/README >@@ -83,3 +83,98 @@ The meta-intel maintainers will do their best to >review and/or pull in > a patch or patchset within 24 hours of the time it was posted. For > larger and/or more involved patches and patchsets, the review process > may take longer. >+ >+ >+Machine Features in the meta-intel layer >+ >+ >+Many machine features are available in the oecore/poky layer for BSP use. >+The meta-intel layer makes some additional machine features available >for BSPs >+using the meta-intel layer. >+ >+Requirements >+ >+ >+The additional machine features are only available when the meta-intel >layer >+is included in the build config, and the meta-intel.inc file is included >in >+the machine configuration of the interested BSP. >+ >+To make these features available for your machine, you will need to: >+ >+1. have a configuration line as seen below in the bblayers.conf >+ BBLAYERS += "/meta-intel.git" Git convention is that .git is for bare clones, meaning no working tree is checked out. Suggest eliminating the .git here. >+2. have the following line in the machine configuration >+ require conf/machine/include/meta-intel.inc >+ >+Once the above requirements are met, then the machine features provided >by >+the meta-intel layer will be available for the BSP use. for the BSP to use. Or for use by the BSP. Or to the BSP. >+ >+Available Machine Features >+-- >+ >+As of now the meta-intel layer provides the following list of machine >features. >+In the future, more machine features may be available in this list. >+ >+* intel-ucode >+ >+These machine features can be included by listing them in the >MACHINE_FEATURES >+variable in the machine configuration file. An example would be good here, e.g. MACHINE_FEATURES += "intel-ucode" >+ >+Details of the Machine Features >+--- >+ >+* intel-ucode: This feature provides microcode updating support for Intel >+ processors. With the intel-ucode feature, images get complete support >for >+ updating the microcode on Intel processors. This second sentence is redundant and can be removed entirely. >This feature enables microcode >+ updating at early boot time by placing the microcode data files in the >+ initrd image. Consider: This feature runs at early boot via an initrd. >It also puts the user land microcode updating tool iucode_tool >+ and the microcode data file in the target images. >+ >+ Q. Why to enable this microcode feature? s/to// >+ A. Intel releases microcode updates to correct processor behavior as >+ documented in the respective processor specification updates. While >+ the regular approach to getting this microcode update is via a BIOS >+ upgrade, this can be an administrative hassle and not always >possible >+ in the field. The intel-ucode feature enables the microcode update >+ capability from the Linux OS. It provides an easy path for upgrading >+ processor microcode without need of changing BIOS. Once the feature the need to change BIOS. >+ is enabled, it is also possible to update the existing images with >+ newer microcode update in the future. with a newer >+ >+ Q. How to bundle only specific microcodes in the target image? I think "microcode" is fine here, "microcodes" sounds incorrect... Do you see "microcodes" used in any of the official documentation? "code" (without an "s") is typically used to refer to one or many lines of source or files. >+ A. The Intel microcode data file released by Intel contains microcode >+ updates for multiple processors. If the BSP image will be running >only >+ on a certain kind of processors, then the number of microcodes >bundled in >+ the target image can be filtered by specifying the >UCODE_FILTER_PARAMETERS >+ variable. A sequence of iucode-tool parameters are listed in the >+ UCODE_FILTER_PARAMETERS variable to filter the microcodes from the >+ microcode data file. For more information on these parameters refer >to >+ the iucode-tool manual page, which can be seen over here: >+ http://manned.org/iucode-tool >+ >+
Re: [meta-intel] [Patch v3 12/12] fri2-noemgd: add microcode filter parameter
On 10/3/14, 15:14, "nitin.a.kam...@intel.com" wrote: >From: Nitin A Kamble > >The fri2-noemgd BSP is targeted to a very specific platform, and it only >need microcodes related to a specific processor. So use the microcode >filtering mechanism to reduce the unutilized microcode data on the target >image. While I understand the desire to have an example of the UCODE_FILTER_PARAMETERS, the fri2 uses the intel-common-pkgarch, and as such is clearly not considered space-sensitive. I would suggest dropping this patch and adding the example below to the README instead. If this BSPs is dropped in favor of the intel-core2-32 BSP and the machine-setup-tool, then we will still have an example in the documentation. > >Signed-off-by: Nitin A Kamble >--- > meta-fri2/conf/machine/fri2-noemgd.conf | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/meta-fri2/conf/machine/fri2-noemgd.conf >b/meta-fri2/conf/machine/fri2-noemgd.conf >index 345d421..e21d7e5 100644 >--- a/meta-fri2/conf/machine/fri2-noemgd.conf >+++ b/meta-fri2/conf/machine/fri2-noemgd.conf >@@ -12,6 +12,9 @@ require conf/machine/include/meta-intel.inc > MACHINE_FEATURES += "wifi 3g pcbios efi" > MACHINE_FEATURES += "intel-ucode" > >+# Only take microcodes relevant to the Atom E640T processor from the >FRI2 board >+UCODE_FILTER_PARAMETERS = "-s 0x00020661" >+ > MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-iwlwifi-6000g2a-5" > > PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto" >-- >1.8.1.4 > >-- >___ >meta-intel mailing list >meta-intel@yoctoproject.org >https://lists.yoctoproject.org/listinfo/meta-intel > -- Darren Hart Intel Open Source Technology Center -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [Patch v3 04/12] intel-core2-32: add intel-ucode to MACHINE_FEATURES
On 10/3/14, 15:14, "nitin.a.kam...@intel.com" wrote: >From: Nitin A Kamble > >Enable the Intel microcode feature for this BSP. > >Signed-off-by: Nitin A Kamble Patches 4-11: Acked-by: Darren Hart >--- > conf/machine/intel-core2-32.conf | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/conf/machine/intel-core2-32.conf >b/conf/machine/intel-core2-32.conf >index 9c30f7d..fd7e83a 100644 >--- a/conf/machine/intel-core2-32.conf >+++ b/conf/machine/intel-core2-32.conf >@@ -13,6 +13,7 @@ PREFERRED_VERSION_linux-yocto ?= "3.17%" > MACHINE_FEATURES += "pcbios efi" > MACHINE_FEATURES += "va-impl-intel" > MACHINE_FEATURES += "wifi 3g" >+MACHINE_FEATURES += "intel-ucode" > > MACHINE_HWCODECS ?= "va-intel gst-va-intel" > >-- >1.8.1.4 > >-- >___ >meta-intel mailing list >meta-intel@yoctoproject.org >https://lists.yoctoproject.org/listinfo/meta-intel > -- Darren Hart Intel Open Source Technology Center -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [Patch v3 02/12] intel-microcode: allow filtering of microcodes
On 10/3/14, 15:14, "nitin.a.kam...@intel.com"
wrote:
>From: Nitin A Kamble
>
>By default all the microcodes available in the microcode data file are
>bundled in the target image. Provide an easier way to filter the
>microcodes
>of interest for BSPs from the recipe space.
>
> The new variable, UCODE_FILTER_PARAMETERS is introduced, which can be
>redefined containing parameters of the iucode_tool to filter the
>microcodes
>of interest for the BSP under consideration. The information on the
>iucode-tool parameters are available here: http://manned.org/iucode-tool .
>
>The filtering makes the generated microcode files very machine specific,
>hence making the recipe machine specific.
In general I have concerns about making more packages machine-specific as
it adds another barrier to consolidation of Intel BSPs.
However, since these can only be applied at runtime and are not
persistent, they can't be done once and kept off the production image.
Since we can't rely on firmware updates (where this arguably belongs), I
suppose this is a necessary item.
One suggestion, however, would be to use the intel common package arch, so
that machines using the common kernel, can also use the common microcode
(which would not use any filters). This way, we only have to rebuild the
package for machines that specifically care about making it small.
--
Darren
>
>Signed-off-by: Nitin A Kamble
>---
> .../recipes-core/microcode/intel-microcode_20140624.bb | 18
>+++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
>diff --git a/common/recipes-core/microcode/intel-microcode_20140624.bb
>b/common/recipes-core/microcode/intel-microcode_20140624.bb
>index b01d8a5..16674a8 100644
>--- a/common/recipes-core/microcode/intel-microcode_20140624.bb
>+++ b/common/recipes-core/microcode/intel-microcode_20140624.bb
>@@ -20,14 +20,26 @@ SRC_URI[sha256sum] =
>"b4662ac780438a7b2d87e6d26a7066feb807f37c6e5b6fa147089f4edb
> DEPENDS = "iucode-tool-native"
> S = "${WORKDIR}"
>
>-inherit allarch
>+PACKAGE_ARCH = "${MACHINE_ARCH}"
> inherit deploy
>
>+# Use any of the iucode_tool parameters to filter specific microcodes
>from the data file
>+# For further information, check the iucode-tool's manpage :
>http://manned.org/iucode-tool
>+UCODE_FILTER_PARAMETERS ?= ""
>+
> do_compile() {
> mkdir -p ${WORKDIR}/ucode/kernel/x86/microcode
>- ${STAGING_DIR_NATIVE}${sbindir_native}/iucode_tool --overwrite
>--write-to=${WORKDIR}/microcode_${PV}.bin ${WORKDIR}/microcode.dat
>+ ${STAGING_DIR_NATIVE}${sbindir_native}/iucode_tool \
>+ ${UCODE_FILTER_PARAMETERS} \
>+ --overwrite \
>+ --write-to=${WORKDIR}/microcode_${PV}.bin \
>+ ${WORKDIR}/microcode.dat
>
>- ${STAGING_DIR_NATIVE}${sbindir_native}/iucode_tool --overwrite
>--write-earlyfw=${WORKDIR}/microcode_${PV}.cpio ${WORKDIR}/microcode.dat
>+ ${STAGING_DIR_NATIVE}${sbindir_native}/iucode_tool \
>+ ${UCODE_FILTER_PARAMETERS} \
>+ --overwrite \
>+ --write-earlyfw=${WORKDIR}/microcode_${PV}.cpio \
>+ ${WORKDIR}/microcode.dat
> }
>
> do_install() {
>--
>1.8.1.4
>
>--
>___
>meta-intel mailing list
>meta-intel@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/meta-intel
>
--
Darren Hart
Intel Open Source Technology Center
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [Patch v3 01/12] intel-ucode: a new MACHINE_FEATURE for meta-intel BSPs
On 10/3/14, 15:14, "nitin.a.kam...@intel.com"
wrote:
>From: Nitin A Kamble
>
>With this change, the Intel microcode support can be enabled or disabled
>for each of the BSP by using the MACHINE_FEATURES variable.
> Any Intel platform BSPs can get the Intel microcode loading support
>by adding a line as seen below in the machine configuration.
>
>MACHINE_FEATURES += "intel-ucode"
>
>Signed-off-by: Nitin A Kamble
>---
Hi Nitin,
As a point of process, when sending new versions of patches, it is
customary to include a changelog after the --- after the Signed-off-by.
The format typically something like:
v2: Fix issue A reported by Joe
v3: Correct typographical errors
This aids the reviewers by providing context and reminding them of why the
next version was needed and saves them from having to review all past
discussions to ensure all commentary has been addressed.
> conf/machine/include/meta-intel.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/conf/machine/include/meta-intel.inc
>b/conf/machine/include/meta-intel.inc
>index f43903e..b94e1dd 100644
>--- a/conf/machine/include/meta-intel.inc
>+++ b/conf/machine/include/meta-intel.inc
>@@ -22,8 +22,8 @@ XSERVER_X86_ASPEED_AST = "xf86-video-ast \
>"
>
> # include the user space intel microcode loading support in the
>generated images.
>-MACHINE_ESSENTIAL_EXTRA_RDEPENDS_append = " intel-microcode iucode-tool"
>+MACHINE_ESSENTIAL_EXTRA_RDEPENDS_append =
>"${@bb.utils.contains('MACHINE_FEATURES', 'intel-ucode', '
>intel-microcode iucode-tool', '', d)}"
I'm curious about why the inclusion of the two recipes here, rather than a
single one which pulls in the necessary dependencies. Does including
"intel-microcode" every make sense without the iucode-tool ?
--
Darren Hart
Intel Open Source Technology Center
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
