Re: [meta-intel] [meta-intel-galileo] [PATCH 2/3] launcher.sh: start clloader only on galileo
On Wed, May 13, 2015 at 11:24:51AM +0100, Paul Eggleton wrote:
> Brendan's away this week. He did say he'd merged these but I just checked and
> I can't see them in the repo - maybe they weren't pushed?
Paul guessed correctly, I'd built them and then obviously must have
thought i'd pushed them already... They're in master now.
Rebecca - thanks for chasing me on this.
Cheers,
Brendan
> Cheers,
> Paul
>
> On Wednesday 13 May 2015 10:06:51 Chang, Rebecca Swee Fun wrote:
> > Has this series of patches being merged? Sorry if I sounded a bit pushing
> > you. If you have any concern about the patchset, please feedback to us so
> > that we can revert it as soon as possible.
> >
> > Thanks.
> >
> > Regards,
> > Rebecca
> >
> > > -Original Message-
> > > From: Le Foll, Brendan
> > > Sent: 02 May, 2015 12:46 AM
> > > To: Chang, Rebecca Swee Fun
> > > Cc: meta-intel@yoctoproject.org; Ong, Boon Leong; Ahmad, Josef
> > > Subject: Re: [meta-intel] [meta-intel-galileo] [PATCH 2/3] launcher.sh:
> > > start clloader only on galileo
> > >
> > > On Thu, Apr 30, 2015 at 07:32:10PM +0800,
> > >
> > > rebecca.swee.fun.ch...@intel.com wrote:
> > > > From: Josef Ahmad
> > > >
> > > > Add the dmidecode logic that comes from galileod.sh to launcher.sh.
> > > > At the moment this is pure duplication.
> > > >
> > > > Signed-off-by: Josef Ahmad
> > > > Reviewed-by: Ong Boon Leong
> > > > Tested-by: Ong Boon Leong
> > > > Signed-off-by: Chang Rebecca Swee Fun
> > > >
> > > > ---
> > > >
> > > > recipes-galileo/galileo-target/files/launcher.sh | 32
> > > >
> > > > ++--
> > > >
> > > > 1 file changed, 25 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/recipes-galileo/galileo-target/files/launcher.sh
> > > > b/recipes-galileo/galileo-target/files/launcher.sh
> > > > index 50fa378..a166345 100755
> > > > --- a/recipes-galileo/galileo-target/files/launcher.sh
> > > > +++ b/recipes-galileo/galileo-target/files/launcher.sh
> > > > @@ -11,11 +11,29 @@ mytrap()
> > > >
> > > > trap 'mytrap' USR1
> > > >
> > > > -keepgoing=true
> > > > -while $keepgoing
> > > > -do
> > > > - $CLLOADER $CLLOADER_OPTS < /dev/ttyGS0 > /dev/ttyGS0 & clPID=$!
> > > > - wait $clPID
> > > > - usleep 20
> > > > -done
> > > > +arduino_services()
> > > > +{
> > > > + keepgoing=true
> > > > + while $keepgoing
> > > > + do
> > > > + $CLLOADER $CLLOADER_OPTS < /dev/ttyGS0 > /dev/ttyGS0 & clPID=$!
> > > > + wait $clPID
> > > > + usleep 20
> > > > + done
> > > > +}
> > > > +
> > > > +galileo_board=false
> > > > +type dmidecode > /dev/null 2>&1 || die "dmidecode not installed"
> > > > +board=$(dmidecode -s baseboard-product-name) case "$board" in
> > > > +*"Galileo" )
> > > > + galileo_board=true
> > > > + ;;
> > > > +*"GalileoGen2" )
> > > > + galileo_board=true
> > > > + ;;
> > > > +esac
> > >
> > > This logic is duplicated in so many places it's untrue. I wish someone
> > > would go through and remove them so we just do this kind of hack once.
> > > Also you don't need to call dmidecode, you can just read in sysfs...
> > >
> > > Anyways for the sake of time I applied the series anyways.
> > >
> > > Cheers,
> > > Brendan
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [meta-intel-galileo] [PATCH 2/3] launcher.sh: start clloader only on galileo
Brendan's away this week. He did say he'd merged these but I just checked and
I can't see them in the repo - maybe they weren't pushed?
Cheers,
Paul
On Wednesday 13 May 2015 10:06:51 Chang, Rebecca Swee Fun wrote:
> Has this series of patches being merged? Sorry if I sounded a bit pushing
> you. If you have any concern about the patchset, please feedback to us so
> that we can revert it as soon as possible.
>
> Thanks.
>
> Regards,
> Rebecca
>
> > -Original Message-
> > From: Le Foll, Brendan
> > Sent: 02 May, 2015 12:46 AM
> > To: Chang, Rebecca Swee Fun
> > Cc: meta-intel@yoctoproject.org; Ong, Boon Leong; Ahmad, Josef
> > Subject: Re: [meta-intel] [meta-intel-galileo] [PATCH 2/3] launcher.sh:
> > start clloader only on galileo
> >
> > On Thu, Apr 30, 2015 at 07:32:10PM +0800,
> >
> > rebecca.swee.fun.ch...@intel.com wrote:
> > > From: Josef Ahmad
> > >
> > > Add the dmidecode logic that comes from galileod.sh to launcher.sh.
> > > At the moment this is pure duplication.
> > >
> > > Signed-off-by: Josef Ahmad
> > > Reviewed-by: Ong Boon Leong
> > > Tested-by: Ong Boon Leong
> > > Signed-off-by: Chang Rebecca Swee Fun
> > >
> > > ---
> > >
> > > recipes-galileo/galileo-target/files/launcher.sh | 32
> > >
> > > ++--
> > >
> > > 1 file changed, 25 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/recipes-galileo/galileo-target/files/launcher.sh
> > > b/recipes-galileo/galileo-target/files/launcher.sh
> > > index 50fa378..a166345 100755
> > > --- a/recipes-galileo/galileo-target/files/launcher.sh
> > > +++ b/recipes-galileo/galileo-target/files/launcher.sh
> > > @@ -11,11 +11,29 @@ mytrap()
> > >
> > > trap 'mytrap' USR1
> > >
> > > -keepgoing=true
> > > -while $keepgoing
> > > -do
> > > - $CLLOADER $CLLOADER_OPTS < /dev/ttyGS0 > /dev/ttyGS0 & clPID=$!
> > > - wait $clPID
> > > - usleep 20
> > > -done
> > > +arduino_services()
> > > +{
> > > + keepgoing=true
> > > + while $keepgoing
> > > + do
> > > + $CLLOADER $CLLOADER_OPTS < /dev/ttyGS0 > /dev/ttyGS0 & clPID=$!
> > > + wait $clPID
> > > + usleep 20
> > > + done
> > > +}
> > > +
> > > +galileo_board=false
> > > +type dmidecode > /dev/null 2>&1 || die "dmidecode not installed"
> > > +board=$(dmidecode -s baseboard-product-name) case "$board" in
> > > +*"Galileo" )
> > > + galileo_board=true
> > > + ;;
> > > +*"GalileoGen2" )
> > > + galileo_board=true
> > > + ;;
> > > +esac
> >
> > This logic is duplicated in so many places it's untrue. I wish someone
> > would go through and remove them so we just do this kind of hack once.
> > Also you don't need to call dmidecode, you can just read in sysfs...
> >
> > Anyways for the sake of time I applied the series anyways.
> >
> > Cheers,
> > Brendan
--
Paul Eggleton
Intel Open Source Technology Centre
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
[meta-intel] FW: [meta-intel-iot-devkit] [PATCH 0/5] Adding missing kernel configurations for meta-intel-iot-devkit
Hi Brendan, Have you got the chance to review this patchset? We have enhanced the configurations to include some missing kernel config we found in our tests. Regards, Rebecca -Original Message- From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel-boun...@yoctoproject.org] On Behalf Of Chang Rebecca Swee Fun Sent: 30 April, 2015 6:45 PM To: meta-intel@yoctoproject.org Cc: Ramajayam, Yugeraj Subject: [meta-intel] [meta-intel-iot-devkit] [PATCH 0/5] Adding missing kernel configurations for meta-intel-iot-devkit This patchset was intended to add in some important kernel configurations that are found missing in the final configuration (.config) file of linux-yocto-quark kernel. Some kernel modules were not loaded properly due to these missing kernel configurations. The missing kernel configurations in the final .config was cross-checked with LTSI kernel version 3.14 to track their dependencies. The root cause is due to missing dependent kernel config that was excluded from the .cfg files under meta-intel-iot-devkit/ recipes-kernel/linux/linux-yocto-quark/iot-devkit* This patches were build tested and verified that the feature provided by the kernel configurations are now functioning. This patchset was target to be merge into master if there is no further concern. Thanks. Regards, Rebecca YUGERAJ RAMAJAYAM (5): linux-yocto-quark: Added CONFIG_USB_NET_RNDIS_WLAN=m to usb-net.cfg linux-yocto-quark: Added CONFIG_HW_RANDOM=m and CONFIG_B43_BCMA=m linux-yocto-quark: Added CONFIG_IP_ADVANCED_ROUTER=m to netfilter-small-3.8.cfg linux-yocto-quark: Added CONFIG_USB_MASS_STORAGE=m to usb-eth-gadget.cfg linux-yocto-quark: Added CONFIG_RTL_CARDS=m to wlan-realtek.cfg .../linux/linux-yocto-quark/iot-devkit-spi/netfilter-small-3.8.cfg | 1 + recipes-kernel/linux/linux-yocto-quark/iot-devkit-spi/usb-net.cfg | 1 + recipes-kernel/linux/linux-yocto-quark/iot-devkit-spi/wlan-broadcom.cfg | 2 ++ recipes-kernel/linux/linux-yocto-quark/iot-devkit-spi/wlan-realtek.cfg | 1 + .../linux/linux-yocto-quark/iot-devkit/netfilter-small-3.8.cfg | 1 + recipes-kernel/linux/linux-yocto-quark/iot-devkit/usb-eth-gadget.cfg| 2 +- recipes-kernel/linux/linux-yocto-quark/iot-devkit/usb-net.cfg | 1 + recipes-kernel/linux/linux-yocto-quark/iot-devkit/wlan-broadcom.cfg | 2 ++ recipes-kernel/linux/linux-yocto-quark/iot-devkit/wlan-realtek.cfg | 1 + 9 files changed, 11 insertions(+), 1 deletion(-) -- 1.9.1 -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [meta-intel-galileo] [PATCH 2/3] launcher.sh: start clloader only on galileo
Hi Brendan,
Has this series of patches being merged? Sorry if I sounded a bit pushing you.
If you have any concern about the patchset, please feedback to us so that we
can revert it as soon as possible.
Thanks.
Regards,
Rebecca
> -Original Message-
> From: Le Foll, Brendan
> Sent: 02 May, 2015 12:46 AM
> To: Chang, Rebecca Swee Fun
> Cc: meta-intel@yoctoproject.org; Ong, Boon Leong; Ahmad, Josef
> Subject: Re: [meta-intel] [meta-intel-galileo] [PATCH 2/3] launcher.sh: start
> clloader only on galileo
>
> On Thu, Apr 30, 2015 at 07:32:10PM +0800,
> rebecca.swee.fun.ch...@intel.com wrote:
> > From: Josef Ahmad
> >
> > Add the dmidecode logic that comes from galileod.sh to launcher.sh.
> > At the moment this is pure duplication.
> >
> > Signed-off-by: Josef Ahmad
> > Reviewed-by: Ong Boon Leong
> > Tested-by: Ong Boon Leong
> > Signed-off-by: Chang Rebecca Swee Fun
> >
> > ---
> > recipes-galileo/galileo-target/files/launcher.sh | 32
> > ++--
> > 1 file changed, 25 insertions(+), 7 deletions(-)
> >
> > diff --git a/recipes-galileo/galileo-target/files/launcher.sh
> > b/recipes-galileo/galileo-target/files/launcher.sh
> > index 50fa378..a166345 100755
> > --- a/recipes-galileo/galileo-target/files/launcher.sh
> > +++ b/recipes-galileo/galileo-target/files/launcher.sh
> > @@ -11,11 +11,29 @@ mytrap()
> >
> > trap 'mytrap' USR1
> >
> > -keepgoing=true
> > -while $keepgoing
> > -do
> > - $CLLOADER $CLLOADER_OPTS < /dev/ttyGS0 > /dev/ttyGS0 & clPID=$!
> > - wait $clPID
> > - usleep 20
> > -done
> > +arduino_services()
> > +{
> > + keepgoing=true
> > + while $keepgoing
> > + do
> > + $CLLOADER $CLLOADER_OPTS < /dev/ttyGS0 > /dev/ttyGS0 & clPID=$!
> > + wait $clPID
> > + usleep 20
> > + done
> > +}
> > +
> > +galileo_board=false
> > +type dmidecode > /dev/null 2>&1 || die "dmidecode not installed"
> > +board=$(dmidecode -s baseboard-product-name) case "$board" in
> > +*"Galileo" )
> > + galileo_board=true
> > + ;;
> > +*"GalileoGen2" )
> > + galileo_board=true
> > + ;;
> > +esac
>
> This logic is duplicated in so many places it's untrue. I wish someone would
> go
> through and remove them so we just do this kind of hack once.
> Also you don't need to call dmidecode, you can just read in sysfs...
>
> Anyways for the sake of time I applied the series anyways.
>
> Cheers,
> Brendan
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
