Re: [meta-intel] [PATCH 2/2] xf86-video-ast: Enable ASPEED Tech Graphic Card

2013-11-18 Thread Burton, Ross
On 18 November 2013 07:57,   wrote:
> +DEPENDS += "virtual/libx11 drm xf86driproto glproto virtual/libgl 
> libpciaccess"

The configure script doesn't appear to check for GL or DRM but does
check for Xv which you've not listed.  Please start from an empty
DEPENDS and add dependencies from configure.ac.

> +EXTRA_OECONF += "--enable-dri"

configure.ac doesn't define this.

> +PR = "r1"

Should be r0 for an initial recipe, and it's not needed for new
recipes now we have the PR server.

> +COMPATIBLE_HOST = '(i.86.*-linux|x86_64.*-linux)'

Is this actually true or more copy/paste?

> +RDEPENDS_${PN} = "xserver-xorg-module-exa"

This driver doesn't use EXA, it has optional support for XAA.

This looks a lot like a driver recipe that was created by copy-pasting
an existing driver, without any validation.  Please don't do that.

Ross
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel


[meta-intel] [PATCH 2/2] xf86-video-ast: Enable ASPEED Tech Graphic Card

2013-11-18 Thread boon . leong . ong
From: Ong Boon Leong 

New recipe creation to enable ASPEED Technology graphic
card.

Signed-off-by: Ong Boon Leong 
---
 .../xorg-driver/xf86-video-ast_0.98.0.bb   |   20 
 1 file changed, 20 insertions(+)
 create mode 100644 common/recipes-graphics/xorg-driver/xf86-video-ast_0.98.0.bb

diff --git a/common/recipes-graphics/xorg-driver/xf86-video-ast_0.98.0.bb 
b/common/recipes-graphics/xorg-driver/xf86-video-ast_0.98.0.bb
new file mode 100644
index 000..6c34d11
--- /dev/null
+++ b/common/recipes-graphics/xorg-driver/xf86-video-ast_0.98.0.bb
@@ -0,0 +1,20 @@
+require recipes-graphics/xorg-driver/xorg-driver-video.inc
+
+SUMMARY = "X.Org X server -- ASpeed Technologies graphics driver"
+
+DESCRIPTION = "ast is an Xorg driver for ASpeed Technologies video cards"
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=0b8c242f0218eea5caa949b7910a774b"
+
+DEPENDS += "virtual/libx11 drm xf86driproto glproto virtual/libgl libpciaccess"
+
+EXTRA_OECONF += "--enable-dri"
+
+PR = "r1"
+
+COMPATIBLE_HOST = '(i.86.*-linux|x86_64.*-linux)'
+
+SRC_URI[md5sum] = "c3f15602db18e91842245a43a297cc42"
+SRC_URI[sha256sum] = 
"90225bc4832da9cd11e3130f0c210ed67f4f48a4ce35f1bb83bd5cc0c7d916a1"
+
+RDEPENDS_${PN} = "xserver-xorg-module-exa"
-- 
1.7.10.4

___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel