Re: [meta-intel] [meta-dpdk v2 2/2] Introduce the v18.11.1 bb
On Mon, May 27, 2019 at 01:48:52AM +, Mittal, Anuj wrote:
> On Sun, 2019-05-26 at 14:54 +0800, Kevin Hao wrote:
> > > If not, we should probably just remove it in do_install_append and
> > not
> > > carry this patch.
> >
> > Do you mean something like this in the dpdk_18.11.1.bb:
> > do_install_append () {
> > # Remove the unneeded dir
> > dir=${D}/${INSTALL_PATH}/${RTE_TARGET}/app
> > test -d $dir && rm -rf $dir
> > }
>
> Yes but I don't think you need to check if the dir is present when
> using -f with rm.
OK, I will remove the test.
Thanks,
Kevin
>
> Thanks,
> Anuj
signature.asc
Description: PGP signature
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [meta-dpdk v2 2/2] Introduce the v18.11.1 bb
On Sun, 2019-05-26 at 14:54 +0800, Kevin Hao wrote:
> > If not, we should probably just remove it in do_install_append and
> not
> > carry this patch.
>
> Do you mean something like this in the dpdk_18.11.1.bb:
> do_install_append () {
> # Remove the unneeded dir
> dir=${D}/${INSTALL_PATH}/${RTE_TARGET}/app
> test -d $dir && rm -rf $dir
> }
Yes but I don't think you need to check if the dir is present when
using -f with rm.
Thanks,
Anuj
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [meta-dpdk v2 2/2] Introduce the v18.11.1 bb
On Fri, May 24, 2019 at 03:45:07AM +, Mittal, Anuj wrote:
> Hi Kevin,
>
> I have a few comments:
>
> On Fri, 2019-05-24 at 09:36 +0800, Kevin Hao wrote:
> ...
>
> > +From d50d2a8f3da588c0aaeb95116a88be5a598b4b16 Mon Sep 17 00:00:00
> > 2001
> > +From: Kevin Hao
> > +Date: Thu, 23 May 2019 15:34:20 +0800
> > +Subject: [PATCH] Drop the unneeded files when installation
> > +
> > +These are not needed as part of image. Drop them to avoid the QA
> > +warning.
> > +
>
> Since it's only just one app, could we package it in FILES_PN-examples?
No, it is supposed to be executed on the host instead of target.
> If not, we should probably just remove it in do_install_append and not
> carry this patch.
Do you mean something like this in the dpdk_18.11.1.bb:
do_install_append () {
# Remove the unneeded dir
dir=${D}/${INSTALL_PATH}/${RTE_TARGET}/app
test -d $dir && rm -rf $dir
}
>
> We also probably don't need to delete the installation of mk folder
> since they are being packaged now:
>
> https://git.yoctoproject.org/cgit/cgit.cgi/meta-dpdk/commit/?id=4582cde191b3b06b9b8f34bcd3fdd6c8a2d5e838
Aha, the git repo which I was used to do the build for arm64 missed this commit.
>
> Can you please check?
>
> ...
>
> > diff --git a/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-
> > parellel-make-issue.patch b/recipes-extended/dpdk/dpdk/dpdk-18.11-
> > dpdk-fix-for-parellel-make-issue.patch
> > new file mode 100644
> > index ..e95c9a4ff5ce
> > --- /dev/null
> > +++ b/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-parellel-
> > make-issue.patch
> > @@ -0,0 +1,42 @@
> > +From 5e78af18b6dda83e317ccadab1654fca26aaf6dd Mon Sep 17 00:00:00
> > 2001
> > +From: Rahul Kumar Gupta
> > +Date: Fri, 2 Sep 2016 15:48:52 +0800
> > +Subject: [PATCH] dpdk: fix for parellel make issue
> > +
> > +To make sure that the path of libraries should be correct and
> > +libraries will be build before, And available at the time of
> > +linking example apps.
>
> Can you add Upstream-Status here please and try submitting it upstream?
According to the codes, the depended libraries should be added to the
app makefile prerequisites automatically. I also have done build test without
this patch and don't get any failure. So it seems that this patch is not
needed (at least for the v18.11.1 version). I will drop this patch.
>
> ...
>
> > diff --git a/recipes-extended/dpdk/dpdk_18.11.1.bb b/recipes-
> > extended/dpdk/dpdk_18.11.1.bb
> > new file mode 100644
> > index ..2cb84924a757
> > --- /dev/null
> > +++ b/recipes-extended/dpdk/dpdk_18.11.1.bb
> > @@ -0,0 +1,15 @@
> > +include dpdk.inc
> > +
> > +STABLE = "-stable"
> > +BRANCH = "18.11"
> > +SRCREV = "16ece46735c9b70b7033ca7ae095930e9038d9fd"
> > +
> > +LICENSE = "BSD & LGPLv2 & GPLv2"
>
> Should these be BSD-3-Clause & LGPLv2.1 & GPLv2 based on the files
> included below?
Hmm, this is copied from the dpdk_18.05.bb. I will adjust them according to
the license files.
Thanks,
Kevin
>
> > +LIC_FILES_CHKSUM = "file://license/gpl-
> > 2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> > +file://license/lgpl-
> > 2.1.txt;md5=4b54a1fd55a448865a0b32d41598759d \
> > +file://license/bsd-3-
> > clause.txt;md5=0f00d99239d922ffd13cabef83b33444"
> > +
> > +SRC_URI += "\
> > +file://dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch
> > \
> > +file://dpdk-18.11-Drop-the-unneeded-files-when-
> > installation.patch \
> > +"
>
>
>
signature.asc
Description: PGP signature
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [meta-dpdk v2 2/2] Introduce the v18.11.1 bb
Hi Kevin, I have a few comments: On Fri, 2019-05-24 at 09:36 +0800, Kevin Hao wrote: ... > +From d50d2a8f3da588c0aaeb95116a88be5a598b4b16 Mon Sep 17 00:00:00 > 2001 > +From: Kevin Hao > +Date: Thu, 23 May 2019 15:34:20 +0800 > +Subject: [PATCH] Drop the unneeded files when installation > + > +These are not needed as part of image. Drop them to avoid the QA > +warning. > + Since it's only just one app, could we package it in FILES_PN-examples? If not, we should probably just remove it in do_install_append and not carry this patch. We also probably don't need to delete the installation of mk folder since they are being packaged now: https://git.yoctoproject.org/cgit/cgit.cgi/meta-dpdk/commit/?id=4582cde191b3b06b9b8f34bcd3fdd6c8a2d5e838 Can you please check? ... > diff --git a/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for- > parellel-make-issue.patch b/recipes-extended/dpdk/dpdk/dpdk-18.11- > dpdk-fix-for-parellel-make-issue.patch > new file mode 100644 > index ..e95c9a4ff5ce > --- /dev/null > +++ b/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-parellel- > make-issue.patch > @@ -0,0 +1,42 @@ > +From 5e78af18b6dda83e317ccadab1654fca26aaf6dd Mon Sep 17 00:00:00 > 2001 > +From: Rahul Kumar Gupta > +Date: Fri, 2 Sep 2016 15:48:52 +0800 > +Subject: [PATCH] dpdk: fix for parellel make issue > + > +To make sure that the path of libraries should be correct and > +libraries will be build before, And available at the time of > +linking example apps. Can you add Upstream-Status here please and try submitting it upstream? ... > diff --git a/recipes-extended/dpdk/dpdk_18.11.1.bb b/recipes- > extended/dpdk/dpdk_18.11.1.bb > new file mode 100644 > index ..2cb84924a757 > --- /dev/null > +++ b/recipes-extended/dpdk/dpdk_18.11.1.bb > @@ -0,0 +1,15 @@ > +include dpdk.inc > + > +STABLE = "-stable" > +BRANCH = "18.11" > +SRCREV = "16ece46735c9b70b7033ca7ae095930e9038d9fd" > + > +LICENSE = "BSD & LGPLv2 & GPLv2" Should these be BSD-3-Clause & LGPLv2.1 & GPLv2 based on the files included below? > +LIC_FILES_CHKSUM = "file://license/gpl- > 2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ > +file://license/lgpl- > 2.1.txt;md5=4b54a1fd55a448865a0b32d41598759d \ > +file://license/bsd-3- > clause.txt;md5=0f00d99239d922ffd13cabef83b33444" > + > +SRC_URI += "\ > +file://dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch > \ > +file://dpdk-18.11-Drop-the-unneeded-files-when- > installation.patch \ > +" -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
[meta-intel] [meta-dpdk v2 2/2] Introduce the v18.11.1 bb
This is the latest LTS version. Signed-off-by: Kevin Hao --- v2: Also drop the mk files to avoid the QA warning. ...Drop-the-unneeded-files-when-installation.patch | 33 + ...dk-18.11-dpdk-fix-for-parellel-make-issue.patch | 42 ++ recipes-extended/dpdk/dpdk_18.11.1.bb | 15 3 files changed, 90 insertions(+) create mode 100644 recipes-extended/dpdk/dpdk/dpdk-18.11-Drop-the-unneeded-files-when-installation.patch create mode 100644 recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch create mode 100644 recipes-extended/dpdk/dpdk_18.11.1.bb diff --git a/recipes-extended/dpdk/dpdk/dpdk-18.11-Drop-the-unneeded-files-when-installation.patch b/recipes-extended/dpdk/dpdk/dpdk-18.11-Drop-the-unneeded-files-when-installation.patch new file mode 100644 index ..210de429b44d --- /dev/null +++ b/recipes-extended/dpdk/dpdk/dpdk-18.11-Drop-the-unneeded-files-when-installation.patch @@ -0,0 +1,33 @@ +From d50d2a8f3da588c0aaeb95116a88be5a598b4b16 Mon Sep 17 00:00:00 2001 +From: Kevin Hao +Date: Thu, 23 May 2019 15:34:20 +0800 +Subject: [PATCH] Drop the unneeded files when installation + +These are not needed as part of image. Drop them to avoid the QA +warning. + +Signed-off-by: Kevin Hao +--- + mk/rte.sdkinstall.mk | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk +index 2d34b4e5af9f..4682615030f1 100644 +--- a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk +@@ -127,11 +127,9 @@ install-sdk: + $(Q)tar -chf - -C $O include | \ + tar -xf - -C $(DESTDIR)$(includedir) $(TAR_X_FLAGS) + $(Q)$(call rte_mkdir,$(DESTDIR)$(sdkdir)) +- $(Q)cp $(CP_FLAGS) $(RTE_SDK)/mk$(DESTDIR)$(sdkdir) + $(Q)cp $(CP_FLAGS) $(RTE_SDK)/buildtools$(DESTDIR)$(sdkdir) +- $(Q)$(call rte_mkdir, $(DESTDIR)$(targetdir)/app) ++ $(Q)$(call rte_mkdir,$(DESTDIR)$(targetdir)) + $(Q)cp $(CP_FLAGS) $O/.config $(DESTDIR)$(targetdir) +- $(Q)cp $(CP_FLAGS) $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app + $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include) + $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib) + +-- +2.14.4 + diff --git a/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch b/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch new file mode 100644 index ..e95c9a4ff5ce --- /dev/null +++ b/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch @@ -0,0 +1,42 @@ +From 5e78af18b6dda83e317ccadab1654fca26aaf6dd Mon Sep 17 00:00:00 2001 +From: Rahul Kumar Gupta +Date: Fri, 2 Sep 2016 15:48:52 +0800 +Subject: [PATCH] dpdk: fix for parellel make issue + +To make sure that the path of libraries should be correct and +libraries will be build before, And available at the time of +linking example apps. + +Signed-off-by: Rahul Kumar Gupta +--- + examples/Makefile | 1 + + examples/ethtool/ethtool-app/Makefile | 1 + + 2 files changed, 2 insertions(+) + +diff --git a/examples/Makefile b/examples/Makefile +index 33fe0e586d97..1a3966f9e95a 100644 +--- a/examples/Makefile b/examples/Makefile +@@ -14,6 +14,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += bbdev_app + DIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += bond + DIRS-y += cmdline + DIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += distributor ++DEPDIRS-y += examples/ethtool/lib + DIRS-y += ethtool + DIRS-y += exception_path + DIRS-$(CONFIG_RTE_LIBRTE_EFD) += server_node_efd +diff --git a/examples/ethtool/ethtool-app/Makefile b/examples/ethtool/ethtool-app/Makefile +index 9ecfc0b89367..fb5fdc43818c 100644 +--- a/examples/ethtool/ethtool-app/Makefile b/examples/ethtool/ethtool-app/Makefile +@@ -19,6 +19,7 @@ SRCS-y := main.c ethapp.c + CFLAGS += -O3 -pthread -I$(SRCDIR)/../lib + CFLAGS += $(WERROR_FLAGS) + ++LDLIBS += -L$(ETHTOOL_LIB_PATH)/ + LDLIBS += -L$(subst ethtool-app,lib,$(RTE_OUTPUT))/lib + LDLIBS += -lrte_ethtool + +-- +2.14.4 + diff --git a/recipes-extended/dpdk/dpdk_18.11.1.bb b/recipes-extended/dpdk/dpdk_18.11.1.bb new file mode 100644 index ..2cb84924a757 --- /dev/null +++ b/recipes-extended/dpdk/dpdk_18.11.1.bb @@ -0,0 +1,15 @@ +include dpdk.inc + +STABLE = "-stable" +BRANCH = "18.11" +SRCREV = "16ece46735c9b70b7033ca7ae095930e9038d9fd" + +LICENSE = "BSD & LGPLv2 & GPLv2" +LIC_FILES_CHKSUM = "file://license/gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ + file://license/lgpl-2.1.txt;md5=4b54a1fd55a448865a0b32d41598759d \ + file://license/bsd-3-clause.txt;md5=0f00d99239d922ffd13cabef83b33444" + +SRC_URI += "\ +file://dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch \ +
