Re: [meta-intel] [PATCHv2 1/2] meta-intel/common: Initial Intel DPDK recipe under recipes-extended
On 10 July 2014 09:40, wrote:
> +++
> b/common/recipes-extended/dpdk/dpdk/dpdk-1.6.0r2-app-test-fix-build-switches-to-enable-cmdline-tests.patch
> @@ -0,0 +1,49 @@
> +From cf953d2bfa7df9aa67459b333db4d4d8a9e72fd6 Mon Sep 17 00:00:00 2001
> +From: Thomas Monjalon
> +Date: Fri, 27 Jun 2014 11:21:11 +0200
> +Subject: [PATCH] app/test: fix build switches to enable cmdline tests
> +
> +There were 2 typos since these commits (in 1.6.0 releases):
> + 21a7f4e264 fix build without librte_cmdline
> + cac6d08c8b replace --use-device option by --pci-whitelist and --vdev
> +In makefiles, the build options are prefixed with CONFIG_RTE_
> +but in .c file, it is only RTE_.
> +
> +These typos were disabling cmdline unit tests and test of "--vdev eth_ring"
> option.
> +
> +Signed-off-by: Thomas Monjalon
> +Acked-by: Pablo de Lara
Patches need to have a Signed-Off-By (presumably, you) and
Upstream-Status (in this case, Backport) at the top. This is so we
know who is responsible for bringing the patch into oe-core, and that
as a backport its likely to be removed in the future.
> +# Recipe Ingredients (source, patch, etc)
Pointless comment.
> +export INSTALL_PATH = "${prefix}/dpdk"
Urgh, if it can't be told to install into $datadir $libdir etc, then that's sad.
Ross
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCHv2 1/2] meta-intel/common: Initial Intel DPDK recipe under recipes-extended
On 10 July 2014 09:40, wrote: > This is an initial version of Intel Data Plane Development Kits > (DPDK) recipe support. This recipe is targetting on Intel DPDK > v1.6.0r2. This recipe is created under meta-intel/common because > Intel DPDK can be commonly used several Intel BSP platforms such > as Romley, Crystal-Forest & Mohon-peak. We resolved examples apps > build failure found in v1.6.0-r2 by cherry-picking patches from > v1.7.0 as they are not planned to be fixed in v1.6.0-r2. The > example app build failure are found in qos_sched, eal_flags_autotest > and cmdline_autotest. This fails a build from clean: | /data/poky-master/tmp/work/nuc-poky-linux/dpdk/1.6.0r2-r0/temp/run.do_compile.7306: 129: [: cmdline: unexpected operator | /data/poky-master/tmp/work/nuc-poky-linux/dpdk/1.6.0r2-r0/temp/run.do_compile.7306: 129: [: dpdk_qat: unexpected operator Your logic is probably expanding to empty strings. | make[1]: Entering directory `/data/poky-master/tmp/work/nuc-poky-linux/dpdk/1.6.0r2-r0/dpdk-1.6.0r2/examples/dpdk_qat/build' | CC main.o | CC crypto.o | /data/poky-master/tmp/work/nuc-poky-linux/dpdk/1.6.0r2-r0/dpdk-1.6.0r2/examples/dpdk_qat/crypto.c:64:17: fatal error: cpa.h: No such file or directory | #include "cpa.h" Missing build dependency? Before submitting, it's best to always wipe your build directory (just delete tmp/, or use wipe-sysroot) to verify that you have the correct build dependencies. Ross -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
