Re: [meta-ti] [PATCH 1/3] u-boot-ti: Drop using COREBASE
On Sun, Sep 29, 2019 at 9:40 AM Denys Dmytriyenko wrote:
>
> On Sun, Sep 29, 2019 at 08:43:33AM -0700, Khem Raj wrote:
> > COREBASE is hardcoding the path and moreover its obsolete the better way
> > is to use relative path which is automatically searched in BBPATH by
> > bitbake
>
> This was actually done on purpose - there are many versions of u-boot.bb and
> u-boot.inc in different OE layers:
> https://layers.openembedded.org/layerindex/branch/master/recipes/?q=u-boot
>
> To avoid any conflicts, I specifically include the one from OE-Core.
>
hmm I guess not pretty but seems fine here. Lets drop this patch.
> COREBASE itself is not obsolete, just ${COREBASE}/LICENSE is:
> https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-COREBASE
> https://git.openembedded.org/openembedded-core/tree/meta/conf/layer.conf#n20
> https://git.openembedded.org/openembedded-core/tree/meta/classes/insane.bbclass#n468
>
> --
> Denys
>
>
> > Signed-off-by: Khem Raj
> > ---
> > recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-bsp/u-boot/u-boot-ti.inc
> > b/recipes-bsp/u-boot/u-boot-ti.inc
> > index f1187e64..f7434712 100644
> > --- a/recipes-bsp/u-boot/u-boot-ti.inc
> > +++ b/recipes-bsp/u-boot/u-boot-ti.inc
> > @@ -13,7 +13,7 @@ UBOOT_LOCALVERSION =
> > "-g${@get_git_revision('${S}').__str__()[:10]}"
> > UBOOT_SUFFIX ?= "img"
> > SPL_BINARY ?= "MLO"
> >
> > -require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc
> > +require recipes-bsp/u-boot/u-boot.inc
> >
> > FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:"
> >
> > --
> > 2.23.0
> >
> > --
> > ___
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
--
___
meta-ti mailing list
meta-ti@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-ti
Re: [meta-ti] [PATCH 1/3] u-boot-ti: Drop using COREBASE
On Sun, Sep 29, 2019 at 08:43:33AM -0700, Khem Raj wrote:
> COREBASE is hardcoding the path and moreover its obsolete the better way
> is to use relative path which is automatically searched in BBPATH by
> bitbake
This was actually done on purpose - there are many versions of u-boot.bb and
u-boot.inc in different OE layers:
https://layers.openembedded.org/layerindex/branch/master/recipes/?q=u-boot
To avoid any conflicts, I specifically include the one from OE-Core.
COREBASE itself is not obsolete, just ${COREBASE}/LICENSE is:
https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-COREBASE
https://git.openembedded.org/openembedded-core/tree/meta/conf/layer.conf#n20
https://git.openembedded.org/openembedded-core/tree/meta/classes/insane.bbclass#n468
--
Denys
> Signed-off-by: Khem Raj
> ---
> recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-bsp/u-boot/u-boot-ti.inc
> b/recipes-bsp/u-boot/u-boot-ti.inc
> index f1187e64..f7434712 100644
> --- a/recipes-bsp/u-boot/u-boot-ti.inc
> +++ b/recipes-bsp/u-boot/u-boot-ti.inc
> @@ -13,7 +13,7 @@ UBOOT_LOCALVERSION =
> "-g${@get_git_revision('${S}').__str__()[:10]}"
> UBOOT_SUFFIX ?= "img"
> SPL_BINARY ?= "MLO"
>
> -require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc
> +require recipes-bsp/u-boot/u-boot.inc
>
> FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:"
>
> --
> 2.23.0
>
> --
> ___
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
--
___
meta-ti mailing list
meta-ti@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-ti
[meta-ti] [PATCH 1/3] u-boot-ti: Drop using COREBASE
COREBASE is hardcoding the path and moreover its obsolete the better way
is to use relative path which is automatically searched in BBPATH by
bitbake
Signed-off-by: Khem Raj
---
recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-bsp/u-boot/u-boot-ti.inc b/recipes-bsp/u-boot/u-boot-ti.inc
index f1187e64..f7434712 100644
--- a/recipes-bsp/u-boot/u-boot-ti.inc
+++ b/recipes-bsp/u-boot/u-boot-ti.inc
@@ -13,7 +13,7 @@ UBOOT_LOCALVERSION =
"-g${@get_git_revision('${S}').__str__()[:10]}"
UBOOT_SUFFIX ?= "img"
SPL_BINARY ?= "MLO"
-require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc
+require recipes-bsp/u-boot/u-boot.inc
FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:"
--
2.23.0
--
___
meta-ti mailing list
meta-ti@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-ti
