Re: [meta-virtualization] breakages in go recipes
On Thu, May 23, 2024 at 2:34 AM Martin Jansa wrote: > FWIW: My world build with oe-core > master:094273bd7d1768e14fbdcd2f239bee14c630a625 (so before the main > UNPACKDIR changes) finished with these failures from > meta-virtualization: > > ERROR: Task > (meta-virtualization/recipes-containers/cri-tools/cri-tools_git.bb: > do_patch) > failed with exit code '1' > ERROR: Task > (meta-virtualization/recipes-containers/docker-compose/docker-compose_git.bb: > do_populate_lic) > failed with exit code '1' > ERROR: Task > (meta-virtualization/recipes-containers/docker/docker-moby_git.bb: > do_patch) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-containers/nerdctl/nerdctl_git.bb: > do_patch) > failed with exit code '1' > ERROR: Task > (meta-virtualization/recipes-containers/runc/runc-opencontainers_git.bb: > do_patch) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-devtools/go/go-md2man_git.bb: > do_compile) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-devtools/go/go-md2man_git.bb: > do_populate_lic) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-devtools/yq/yq_git.bb:do_compile) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-devtools/yq/yq_git.bb: > do_populate_lic) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-networking/cni/cni_git.bb: > do_compile) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-networking/cni/cni_git.bb: > do_populate_lic) > failed with exit code '1' > ERROR: Task (meta-virtualization/recipes-networking/netns/netns_git.bb > :do_patch) > failed with exit code '1' > > the UNPACKDIR changes will probably cause few more issues, I've > already noticed one with linux-yocto_virtualization.inc and added > temporary work around here: > https://github.com/shr-project/meta-virtualization/commits/jansa/master/ > > will send what I have later today as a RFC (as I cannot even build > whole image yet) unless Theodore gets to it sooner. > Martin: Spent most of the day fighting with UNPACKDIR breakages outside of meta-virtualization. Finally got to the point where I could build your WIP changes. Found some issues with the runc recipes and have pushed fixes here: https://github.com/troth/meta-virtualization/commit/f604f1fb39fad9f496700be59333edcdc3e7a633 I'm still waiting for a full build to complete, so I have not completely verified the rest of your changes. Ted Roth -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8743): https://lists.yoctoproject.org/g/meta-virtualization/message/8743 Mute This Topic: https://lists.yoctoproject.org/mt/106252100/21656 Group Owner: meta-virtualization+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [meta-virtualization] breakages in go recipes
On Wed, May 22, 2024 at 4:05 PM Martin Jansa wrote:
> Hi,
>
> I can confirm that I'm seeing the same build failures since this
> morning and agree that the recipes need to adapt to:
>
> https://git.openembedded.org/openembedded-core/commit/?id=cc4ec43a2b657fb4c58429ab14f1edc2473c1327
>
> I've started with some WIP changes and fixed some of them in:
>
> https://github.com/shr-project/meta-virtualization/commit/30a85c0319c253632206b0d2c2c483f11a490939
> but than got side tracked by some other build failures and not sure
> when I'll be able to get back to it.
>
> I've also asked Bruce on IRC and he is aware of the issues, but might
> not have time to resolve it soon, so if you have the changes ready,
> then please send them to ML for Bruce to review when he has time and
> I'll happily build test them as well.
>
> Cheers,
>
Should I send a single patch fixing a bunch of recipes (aka many destsuffix
fixes at once) or one patch per recipe?
Ted Roth
>
> On Wed, May 22, 2024 at 11:52 PM Theodore A. Roth via
> lists.yoctoproject.org
> wrote:
> >
> > Hi,
> >
> > In our CI builds for multiple projects using meta-virtualization master
> branch, we are
> > seeing some build failures for some recipes that use GO:
> >
> > * go-md2man
> > * runc-opencontainers
> > * docker-moby
> > * podman
> > * buildah
> > * cni
> >
> > I think I've narrowed the breakages down to this commit to oe-core from
> Richard Purdie:
> >
> > * https://lists.openembedded.org/g/openembedded-core/message/199614
> >
> > The fixes for our builds seem simple enough. Just add
> ';destsuffix=${GO_SRCURI_DESTSUFFIX}'
> > to the SRC_URI. For example:
> >
> > ---
> >
> > diff --git a/recipes-devtools/go/go-md2man_git.bb b/recipes-devtools/go/
> go-md2man_git.bb
> > index 1d96bb1b..73d8d167 100644
> > --- a/recipes-devtools/go/go-md2man_git.bb
> > +++ b/recipes-devtools/go/go-md2man_git.bb
> > @@ -9,7 +9,7 @@ BBCLASSEXTEND = "native"
> > GO_IMPORT = "github.com/cpuguy83/go-md2man"
> > #GO_INSTALL = "${GO_IMPORT}/bin/go-md2man"
> >
> > -SRC_URI = "git://${GO_IMPORT}.git;branch=master;protocol=https"
> > +SRC_URI =
> "git://${GO_IMPORT}.git;branch=master;protocol=https;destsuffix=${GO_SRCURI_DESTSUFFIX}"
> >
> > SRCREV = "f79a8a8ca69da163eee19ab442bedad7a35bba5a"
> > PV = "1.0.10+git"
> >
> > ---
> >
> > I plan to finish my testing for our breakages and submit some patches,
> but it feels like there are many
> > more recipes that will need this change made (basically anything that is
> using 'inherit go').
> >
> > I'm a bit reluctant to submit patches for recipes we are not using (and
> testing) even if they seem like
> > mechanical changes, but I wanted to let the list know what I have found.
> >
> > Ted Roth
> >
> >
> >
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8739):
https://lists.yoctoproject.org/g/meta-virtualization/message/8739
Mute This Topic: https://lists.yoctoproject.org/mt/106252100/21656
Group Owner: meta-virtualization+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[meta-virtualization] breakages in go recipes
Hi,
In our CI builds for multiple projects using meta-virtualization master
branch, we are
seeing some build failures for some recipes that use GO:
* go-md2man
* runc-opencontainers
* docker-moby
* podman
* buildah
* cni
I think I've narrowed the breakages down to this commit to oe-core from
Richard Purdie:
* https://lists.openembedded.org/g/openembedded-core/message/199614
The fixes for our builds seem simple enough. Just add
';destsuffix=${GO_SRCURI_DESTSUFFIX}'
to the SRC_URI. For example:
---
diff --git a/recipes-devtools/go/go-md2man_git.bb b/recipes-devtools/go/
go-md2man_git.bb
index 1d96bb1b..73d8d167 100644
--- a/recipes-devtools/go/go-md2man_git.bb
+++ b/recipes-devtools/go/go-md2man_git.bb
@@ -9,7 +9,7 @@ BBCLASSEXTEND = "native"
GO_IMPORT = "github.com/cpuguy83/go-md2man"
#GO_INSTALL = "${GO_IMPORT}/bin/go-md2man"
-SRC_URI = "git://${GO_IMPORT}.git;branch=master;protocol=https"
+SRC_URI =
"git://${GO_IMPORT}.git;branch=master;protocol=https;destsuffix=${GO_SRCURI_DESTSUFFIX}"
SRCREV = "f79a8a8ca69da163eee19ab442bedad7a35bba5a"
PV = "1.0.10+git"
---
I plan to finish my testing for our breakages and submit some patches, but
it feels like there are many
more recipes that will need this change made (basically anything that is
using 'inherit go').
I'm a bit reluctant to submit patches for recipes we are not using (and
testing) even if they seem like
mechanical changes, but I wanted to let the list know what I have found.
Ted Roth
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8737):
https://lists.yoctoproject.org/g/meta-virtualization/message/8737
Mute This Topic: https://lists.yoctoproject.org/mt/106252100/21656
Group Owner: meta-virtualization+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[master][scarthgap][meta-virtualization][PATCH] podman: Fix missing brace in FILES
From: "Theodore A. Roth"
When converting to use {systemd_user_unitdir}, the closing brace was
omitted
Signed-off-by: Theodore A. Roth
Signed-off-by: Theodore A. Roth
---
recipes-containers/podman/podman_git.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-containers/podman/podman_git.bb
b/recipes-containers/podman/podman_git.bb
index f69dec16..32de3f0c 100644
--- a/recipes-containers/podman/podman_git.bb
+++ b/recipes-containers/podman/podman_git.bb
@@ -134,7 +134,7 @@ do_install_ptest () {
FILES:${PN} += " \
${systemd_unitdir}/system/* \
${nonarch_libdir}/systemd/* \
-${systemd_user_unitdir/* \
+${systemd_user_unitdir}/* \
${nonarch_libdir}/tmpfiles.d/* \
${datadir}/user-tmpfiles.d/* \
${sysconfdir}/cni \
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8709):
https://lists.yoctoproject.org/g/meta-virtualization/message/8709
Mute This Topic: https://lists.yoctoproject.org/mt/105846579/21656
Group Owner: meta-virtualization+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [meta-virtualization][PATCH v2] podman: fix location of user systemd service units
On Mon, Apr 22, 2024 at 9:03 AM Bruce Ashfield via lists.yoctoproject.org
wrote:
> merged to master and scarthgap.
>
> Bruce
>
> In message: [meta-virtualization][PATCH v2] podman: fix location of user
> systemd service units
> on 17/04/2024 lukasz.czechow...@thaumatec.com wrote:
>
> > From: Lukasz Czechowski
> >
> > The value of USERSYSTEMDDIR is currently set to
> > ${systemd_unitdir}/user, which might not be present in user unit
> > search path.
> > Use dedicated bitbake variable ${systemd_user_unitdir} instead.
> >
> > Signed-off-by: Lukasz Czechowski
> > Cc: Bruce Ashfield
> > ---
> > recipes-containers/podman/podman_git.bb | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes-containers/podman/podman_git.bb
> b/recipes-containers/podman/podman_git.bb
> > index 3eadd202..f69dec16 100644
> > --- a/recipes-containers/podman/podman_git.bb
> > +++ b/recipes-containers/podman/podman_git.bb
> > @@ -62,7 +62,7 @@ do_configure[noexec] = "1"
> > EXTRA_OEMAKE = " \
> > PREFIX=${prefix} BINDIR=${bindir} LIBEXECDIR=${libexecdir} \
> > ETCDIR=${sysconfdir} TMPFILESDIR=${nonarch_libdir}/tmpfiles.d \
> > - SYSTEMDDIR=${systemd_unitdir}/system
> USERSYSTEMDDIR=${systemd_unitdir}/user \
> > + SYSTEMDDIR=${systemd_unitdir}/system
> USERSYSTEMDDIR=${systemd_user_unitdir} \
> > "
> >
> > # remove 'docker' from the packageconfig if you don't want podman to
> > @@ -134,7 +134,7 @@ do_install_ptest () {
> > FILES:${PN} += " \
> > ${systemd_unitdir}/system/* \
> > ${nonarch_libdir}/systemd/* \
> > -${systemd_unitdir}/user/* \
> > +${systemd_user_unitdir/* \
>
Just noticed that this is missing the closing brace. This typo is on master
and scarthgap branches.
Would you like me to send a patch?
Ted Roth
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8707):
https://lists.yoctoproject.org/g/meta-virtualization/message/8707
Mute This Topic: https://lists.yoctoproject.org/mt/105567244/21656
Group Owner: meta-virtualization+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [meta-virtualization] Problems building podman and buildah
On Wed, Nov 8, 2023 at 11:28 PM Bruce Ashfield wrote:
>
> On Wed, Nov 8, 2023 at 8:56 PM Bruce Ashfield via
> lists.yoctoproject.org
> wrote:
> >
> > On Wed, Nov 8, 2023 at 6:42 PM Theodore A. Roth wrote:
> > >
> > > Hi,
> > >
> > > With the recent updates to meta-virtualization master branch for
> > > podman (to 4.7.1) and buildah (to 1.32.0),
> > > our builds are breaking.
> > >
> > > I'm seeing the problem when building for either raspberrypi4 or qemuarm64.
> > >
> > > The podman failure appears to be due to not using the native go-md2man
> > > binary when building the man pages.
> > > I was able to work around this by adding the following to the
> > > do_compile() and do_install() functions
> > > in the podman recipe:
> > >
> > > export GOMD2MAN="${RECIPE_SYSROOT_NATIVE}/usr/bin/go-md2man"
> > >
> >
> > Argh. I have something in progress for this.
> >
> > It works in x86. We used to inhibit the docs for this reason, but I
> > re-enabled
> > them and it looks like I didn't drag all the changes forward.
> >
>
> My proposed patch for this is on master-next.
>
> While we could use our separately build go-md2man, podman can now
> build its own .. which apparently is to avoid version skew and issues with
> the manpages.
>
> I updated the build to define the host arch properly, so the build can run
> the binary.
>
> > > I'm more than happy to send a patch if that is the correct fix.
> > >
> > > I'm stumped on the buildah failure. Here's the error messages:
> > >
> > > NOTE: Executing Tasks
> > > ERROR: buildah-1.32.0-r0 do_package_qa: QA Issue: Architecture did not
> > > match (x86-64, expected ARM) in
> > > /usr/lib/go/src/github.com/containers/buildah/internal/mkcw/embed/entrypoint
> > > [arch]
> > > ERROR: buildah-1.32.0-r0 do_package_qa: Fatal QA errors were found,
> > > failing task.
> > > ERROR: Logfile of failure stored in:
> > > /home/troth/work/bedrock/bedrock-main/build-rpi4/tmp/work/cortexa7t2hf-neon-vfpv4-trimble-linux-gnueabi/buildah/1.32.0/temp/log.do_package_qa.1252786
> > > ERROR: Task
> > > (/home/troth/work/bedrock/bedrock-main/build-rpi4/../oe/meta-virtualization/recipes-containers/buildah/buildah_git.bb:do_package_qa)
> > > failed with exit code '1'
> > > NOTE: Tasks Summary: Attempted 5377 tasks of which 5353 didn't need to
> > > be rerun and 1 failed.
> > >
> > > Summary: 1 task failed:
> > >
> > > /home/troth/work/bedrock/bedrock-main/build-rpi4/../oe/meta-virtualization/recipes-containers/buildah/buildah_git.bb:do_package_qa
> > > Summary: There were 2 ERROR messages, returning a non-zero exit code.
> > >
> > > This looks like bitbake is not using the go cross compiler to build
> > > the buildah binaries.
> > > Since I'm not versed in go development, I don't know how to fix or
> > > work around this one.
> > > Looking over the recipe and comparing it to other recipes did not
> > > yield any obvious change that I could try.
> > >
> > > Curious if anyone else is seeing either of these issues to allow me to
> > > determine if this is specific to my setup or a general problem with
> > > meta-virtualization.
> >
>
> buildah has a statically linked x86 binary as an entrypoint. We aren't
> building using the Makefiles, and I'm not seeing where it is used in
> our common use cases.
>
> So for now, I've removed the binary to avoid the QA issue.
>
> I left a hint in the commit if someone wants to force it to rebuild (and
> presumably they are using it). I didn't go that far, since I don't have
> any way to test it.
>
> Bruce
Thanks for the quick fix Bruce!
Tested your master-next fixes both on my workstation and on our CI
system. Builds are no longer failing.
Ted Roth
>
> > They are general issues.
> >
> > They did pass during my integration testing, but there might be
> > some interactions with OEcore that I missed.
> >
> > With any luck, I can have it fixed shortly.
> >
> > Bruce
> >
> > >
> > > I'm building all of this using the master branches of poky,
> > > meta-openembedded, meta-raspberrypi and meta-virtualization (all
> > > updated from upstream git servers today).
> > >
> > > Can provide any other information if needed.
> > >
> > > Ted Roth
> > >
> > >
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8453):
https://lists.yoctoproject.org/g/meta-virtualization/message/8453
Mute This Topic: https://lists.yoctoproject.org/mt/102476135/21656
Group Owner: meta-virtualization+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[meta-virtualization] Problems building podman and buildah
Hi,
With the recent updates to meta-virtualization master branch for
podman (to 4.7.1) and buildah (to 1.32.0),
our builds are breaking.
I'm seeing the problem when building for either raspberrypi4 or qemuarm64.
The podman failure appears to be due to not using the native go-md2man
binary when building the man pages.
I was able to work around this by adding the following to the
do_compile() and do_install() functions
in the podman recipe:
export GOMD2MAN="${RECIPE_SYSROOT_NATIVE}/usr/bin/go-md2man"
I'm more than happy to send a patch if that is the correct fix.
I'm stumped on the buildah failure. Here's the error messages:
NOTE: Executing Tasks
ERROR: buildah-1.32.0-r0 do_package_qa: QA Issue: Architecture did not
match (x86-64, expected ARM) in
/usr/lib/go/src/github.com/containers/buildah/internal/mkcw/embed/entrypoint
[arch]
ERROR: buildah-1.32.0-r0 do_package_qa: Fatal QA errors were found,
failing task.
ERROR: Logfile of failure stored in:
/home/troth/work/bedrock/bedrock-main/build-rpi4/tmp/work/cortexa7t2hf-neon-vfpv4-trimble-linux-gnueabi/buildah/1.32.0/temp/log.do_package_qa.1252786
ERROR: Task
(/home/troth/work/bedrock/bedrock-main/build-rpi4/../oe/meta-virtualization/recipes-containers/buildah/buildah_git.bb:do_package_qa)
failed with exit code '1'
NOTE: Tasks Summary: Attempted 5377 tasks of which 5353 didn't need to
be rerun and 1 failed.
Summary: 1 task failed:
/home/troth/work/bedrock/bedrock-main/build-rpi4/../oe/meta-virtualization/recipes-containers/buildah/buildah_git.bb:do_package_qa
Summary: There were 2 ERROR messages, returning a non-zero exit code.
This looks like bitbake is not using the go cross compiler to build
the buildah binaries.
Since I'm not versed in go development, I don't know how to fix or
work around this one.
Looking over the recipe and comparing it to other recipes did not
yield any obvious change that I could try.
Curious if anyone else is seeing either of these issues to allow me to
determine if this is specific to my setup or a general problem with
meta-virtualization.
I'm building all of this using the master branches of poky,
meta-openembedded, meta-raspberrypi and meta-virtualization (all
updated from upstream git servers today).
Can provide any other information if needed.
Ted Roth
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8449):
https://lists.yoctoproject.org/g/meta-virtualization/message/8449
Mute This Topic: https://lists.yoctoproject.org/mt/102476135/21656
Group Owner: meta-virtualization+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
