date:20190222

Re: [meta-xilinx] [PATCH] kernel-module-mali: check and honour dma_unmap_page exit code

2019-02-22 Thread Jean-Francois Dagenais

Hi Hyun,

> On Feb 21, 2019, at 17:25, Hyun Kwon  wrote:
> 
> Hi Jean-Francois,
> 
> Thanks for the patch.
> 
> On Tue, 2019-02-19 at 09:16:46 -0800, Jean-Francois Dagenais wrote:
>> Sorry, the subject should be:
>> 
>> kernel-module-mali: check and honour dma_map_page exit code
>> 
>> instead of "dma_UNmap_page"
> 
> Why using upper case, 'UN'?

It was just emphasis on what the mistake on the commit headline was... trying 
to remove the subtlety.

> 
>> 
>>> On Feb 19, 2019, at 10:39, Jean-Francois Dagenais >> > wrote:
>>> 
>>> This fixes an error when using the module in a kernel configured with
>>> the CONFIG_DMA_API_DEBUG flag.
>>> 
>>> utgard fd4b.gpu: DMA-API: device driver failed to check map 
>>> error[device address=0x325b] [size=4096 bytes] [mapped as page]
>>> ...
>>> [] check_unmap+0x44c/0x7e8
>>> [] debug_dma_unmap_page+0x60/0x68
>>> [] mali_mem_os_alloc_pages+0x230/0x498 [mali]
>>> ...
>>> 
>>> Signed-off-by: Jean-Francois Dagenais >> >
> 
> I believe the Yocto patch requires the upstreaming status. Please refer to
> other patches. You can mark it as pending. Our team can share this to ARM
> internally.

noted.

> 
>>> ---
>>> .../recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,7H1c4ml0nbgV5Y-a8ex5Nz-45BClZi0HAb8rSq_LVyywEvSS_hmK5Elx6jiQ69wE9_E1QeXVcbkuLM3wVzF94BmsSb6qcaxlV72Yhev6VOpD-Va8ik99UVY,&typo=1
>>>   |  1 +
>>> .../0007-fix-driver-failed-to-check-map-error.patch  | 16 
>>> 
>>> 2 files changed, 17 insertions(+)
>>> create mode 100644 
>>> meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch
>>> 
>>> diff --git 
>>> a/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,_43jl_v77hUeZ715j6nn3vef5fYyi5F8RndfWf7jFiMkSoYFNOFmaBY-eCWB04sK6Rs2xuAQXQQLPfB3DR-4vTWdAeyhs1FG88HNCPpxRT4IBMFxfpo,&typo=1
>>>  
>>> b/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,JaZ3yJLlmgR_Qe9c3t82B8aU2fH7lMmTxdGS2rEmZdyNWYlZXRBMelmmmJNcH07ltvr8DLau5iRr3aHww_esitrJ74H-z6N3l499VbXohkosRapNSkht&typo=1
>>> index 0f44d25..5833239 100644
>>> --- 
>>> a/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,JqkVEZw5PLC_acDxcaxe3EmRTDzQtpfOF0S4ihWN30-lP3msD4vK_acCQ9sKuS5qgR16izABptBPu3V1ZiG5Asv_MlTX6zV8I0Sis_DkCyxAetfsx3tIR_xQvQ,,&typo=1
>>> +++ 
>>> b/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,BrH3PiHKnMb_dJfDtP8QdTfn_a_1u4u6-Op5vJEWvlZOpwm8o6Girdnwajqk5AnN4y9nDiNOQlDSJVCmnVqNSjABPOdFOeXlvF-4gujGyfw,&typo=1
>>> @@ -16,6 +16,7 @@ SRC_URI = " \
>>> file://0004-staging-mali-r8p0-01rel0-Don-t-include-mali_read_phy.patch \
>>> file://0005-linux-mali_kernel_linux.c-Handle-clock-when-probed-a.patch \
>>> file://0006-arm.c-global-variable-dma_ops-is-removed-from-the-ke.patch \
>>> +   file://0007-fix-driver-failed-to-check-map-error.patch \
> 
> This list is different from what I see in the head. There's no empty index
> there. Then this can be 0012. Maybe we are looking at differnt branches. 
> Please
> confirm.

You mean meta-xilinx/master? I will check and apply there with proper sequence 
number.

> 
>>> file://0010-common-mali_pm.c-Add-PM-runtime-barrier-after-removi.patch 
>>>  \
>>> file://0011-linux-mali_kernel_linux.c-Enable-disable-clock-for-r.patch\ 
>>> 
>>> "
>>> diff --git 
>>> a/meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch
>>>  
>>> b/meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch
> 
> It would be better to make this as a git commit than just diff. I'm not sure 
> if
> there's any guideline for that though.

Indeed, however what the kernel-module-mali recipe downloads is not a git repo 
but a tarball (.tgz). If the tar extracted directory structure is the same as 
their git repo's, I can create it as a commit patch and cross my fingers.

> 
>>> new file mode 100644
>>> index 000..f553e58
>>> --- /dev/null
>>> +++ 
>>> b/meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch
>>> @@ -0,0 +1,16 @@
>>> +Index: mali/linux/mali_memory_os_alloc.c
>>> +===
>>> +--- mali.orig/linux/mali_memory_os_alloc.c
>>>  mali/linux/mali_memory_os_alloc.c
>>> +@@ -239,8 +239,9 @@ int mali_mem_os_alloc_pages(mali_mem_os_
>>> +   /* Ensure page is flushed from CPU caches. */
>>> +   dma_addr = dma_map_page(&mali_platform_device->dev, new_page,
>>> +   0, _MALI_OSK_MALI_PAGE_SIZE, 
>>> DMA_BIDIRECTIONAL);
>>> +-  dma_unmap_page(&mali_platform_de

[meta-xilinx] [meta-xilinx-bsp][PATCH] machine-xilinx-board.inc: Remove include file

2019-02-22 Thread Manjukumar Matha

As per the commit f24275598687bcec0252186cb1d9c54b426fef9f, this include
file is no longer required. Remove it from the layer

Signed-off-by: Manjukumar Matha 
---
 meta-xilinx-bsp/conf/machine/include/machine-xilinx-board.inc | 4 
 1 file changed, 4 deletions(-)
 delete mode 100644 
meta-xilinx-bsp/conf/machine/include/machine-xilinx-board.inc

diff --git a/meta-xilinx-bsp/conf/machine/include/machine-xilinx-board.inc 
b/meta-xilinx-bsp/conf/machine/include/machine-xilinx-board.inc
deleted file mode 100644
index 17041e4..000
--- a/meta-xilinx-bsp/conf/machine/include/machine-xilinx-board.inc
+++ /dev/null
@@ -1,4 +0,0 @@
-# Default Xilinx Board settings
-
-EXTRA_IMAGEDEPENDS += "virtual/bootloader"
-
-- 
2.7.4

-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

[meta-xilinx] [meta-xilinx-bsp][PATCH] tune-zynqmp.inc: Use arch-armv8a tune instead of arch-armv8

2019-02-22 Thread Manjukumar Matha

Use the updated arch-armv8a tune instead of the old tune file

Signed-off-by: Manjukumar Matha 
---
 meta-xilinx-bsp/conf/machine/include/tune-zynqmp.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-xilinx-bsp/conf/machine/include/tune-zynqmp.inc 
b/meta-xilinx-bsp/conf/machine/include/tune-zynqmp.inc
index 225fa65..cbfa47b 100644
--- a/meta-xilinx-bsp/conf/machine/include/tune-zynqmp.inc
+++ b/meta-xilinx-bsp/conf/machine/include/tune-zynqmp.inc
@@ -8,7 +8,7 @@ SOC_FAMILY ?= "zynqmp"
 
 SOC_VARIANT ?= "eg"
 
-require conf/machine/include/arm/arch-armv8.inc
+require conf/machine/include/arm/arch-armv8a.inc
 require conf/machine/include/soc-family.inc
 
 # Linux Configuration
-- 
2.7.4

-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH v2] Add support for Z-turn board

2019-02-22 Thread Manjukumar Harthikote Matha

Hi Anton,

> -Original Message-
> From: tos...@gmail.com [mailto:tos...@gmail.com]
> Sent: Saturday, January 26, 2019 1:48 PM
> To: meta-xil...@lists.yoctoproject.org; Manjukumar Harthikote Matha
> 
> Cc: Anton Gerasimov 
> Subject: [PATCH v2] Add support for Z-turn board
> 
> From: Anton Gerasimov 
> 
> Signed-off-by: Anton Gerasimov 
> ---
>  meta-xilinx-bsp/conf/machine/zturn-zynq7.conf |34 +
>  .../platform-init/platform-init.bb| 1 +
>  .../platform-init/zturn-zynq7/ps7_init_gpl.c  | 13170 
>  .../platform-init/zturn-zynq7/ps7_init_gpl.h  |   137 +
>  ...fig-extend-the-bootstrap-malloc-pool.patch |47 +
>  .../recipes-bsp/u-boot/u-boot_%.bbappend  | 3 +
>  ...ts-zynq-Add-support-for-Z-turn-board.patch |   152 +
>  .../recipes-kernel/linux/linux-xlnx.inc   | 2 +
>  8 files changed, 13546 insertions(+)
>  create mode 100644 meta-xilinx-bsp/conf/machine/zturn-zynq7.conf
>  create mode 100644 
> meta-xilinx-bsp/recipes-bsp/platform-init/platform-init/zturn-
> zynq7/ps7_init_gpl.c
>  create mode 100644 
> meta-xilinx-bsp/recipes-bsp/platform-init/platform-init/zturn-
> zynq7/ps7_init_gpl.h

Can you upstream the psu files to u-boot as well? Ideally we don't want to hold 
the psu files in layers.

Thanks,
Manju
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH] kernel-module-mali: check and honour dma_unmap_page exit code

2019-02-22 Thread Manjukumar Harthikote Matha

Hi JFD,

Please send v2 with correction suggested by Hyun

Thanks,
Manju
From: meta-xilinx-boun...@yoctoproject.org 
[mailto:meta-xilinx-boun...@yoctoproject.org] On Behalf Of Jean-Francois 
Dagenais
Sent: Friday, February 22, 2019 5:04 AM
To: Hyun Kwon 
Cc: meta-xil...@lists.yoctoproject.org; Hyun Kwon 
Subject: Re: [meta-xilinx] [PATCH] kernel-module-mali: check and honour 
dma_unmap_page exit code

Hi Hyun,


On Feb 21, 2019, at 17:25, Hyun Kwon 
mailto:hyun.k...@xilinx.com>> wrote:

Hi Jean-Francois,

Thanks for the patch.

On Tue, 2019-02-19 at 09:16:46 -0800, Jean-Francois Dagenais wrote:

Sorry, the subject should be:

kernel-module-mali: check and honour dma_map_page exit code

instead of "dma_UNmap_page"

Why using upper case, 'UN'?

It was just emphasis on what the mistake on the commit headline was... trying 
to remove the subtlety.






On Feb 19, 2019, at 10:39, Jean-Francois Dagenais 
mailto:jeff.dagen...@gmail.com>> wrote:

This fixes an error when using the module in a kernel configured with
the CONFIG_DMA_API_DEBUG flag.

utgard fd4b.gpu: DMA-API: device driver failed to check map error[device 
address=0x325b] [size=4096 bytes] [mapped as page]
...
[] check_unmap+0x44c/0x7e8
[] debug_dma_unmap_page+0x60/0x68
[] mali_mem_os_alloc_pages+0x230/0x498 [mali]
...

Signed-off-by: Jean-Francois Dagenais 
mailto:dagena...@sonatest.com>>

I believe the Yocto patch requires the upstreaming status. Please refer to
other patches. You can mark it as pending. Our team can share this to ARM
internally.

noted.




---
.../recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,7H1c4ml0nbgV5Y-a8ex5Nz-45BClZi0HAb8rSq_LVyywEvSS_hmK5Elx6jiQ69wE9_E1QeXVcbkuLM3wVzF94BmsSb6qcaxlV72Yhev6VOpD-Va8ik99UVY,&typo=1
  |  1 +
.../0007-fix-driver-failed-to-check-map-error.patch  | 16 
2 files changed, 17 insertions(+)
create mode 100644 
meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch

diff --git 
a/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,_43jl_v77hUeZ715j6nn3vef5fYyi5F8RndfWf7jFiMkSoYFNOFmaBY-eCWB04sK6Rs2xuAQXQQLPfB3DR-4vTWdAeyhs1FG88HNCPpxRT4IBMFxfpo,&typo=1
 
b/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,JaZ3yJLlmgR_Qe9c3t82B8aU2fH7lMmTxdGS2rEmZdyNWYlZXRBMelmmmJNcH07ltvr8DLau5iRr3aHww_esitrJ74H-z6N3l499VbXohkosRapNSkht&typo=1
index 0f44d25..5833239 100644
--- 
a/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,JqkVEZw5PLC_acDxcaxe3EmRTDzQtpfOF0S4ihWN30-lP3msD4vK_acCQ9sKuS5qgR16izABptBPu3V1ZiG5Asv_MlTX6zV8I0Sis_DkCyxAetfsx3tIR_xQvQ,,&typo=1
+++ 
b/meta-xilinx-bsp/recipes-graphics/mali/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fkernel-module-mali.bb&c=E,1,BrH3PiHKnMb_dJfDtP8QdTfn_a_1u4u6-Op5vJEWvlZOpwm8o6Girdnwajqk5AnN4y9nDiNOQlDSJVCmnVqNSjABPOdFOeXlvF-4gujGyfw,&typo=1
@@ -16,6 +16,7 @@ SRC_URI = " \
 
file://0004-staging-mali-r8p0-01rel0-Don-t-include-mali_read_phy.patch
 \
 
file://0005-linux-mali_kernel_linux.c-Handle-clock-when-probed-a.patch
 \
 
file://0006-arm.c-global-variable-dma_ops-is-removed-from-the-ke.patch
 \
+   
file://0007-fix-driver-failed-to-check-map-error.patch
 \

This list is different from what I see in the head. There's no empty index
there. Then this can be 0012. Maybe we are looking at differnt branches. Please
confirm.

You mean meta-xilinx/master? I will check and apply there with proper sequence 
number.




 
file://0010-common-mali_pm.c-Add-PM-runtime-barrier-after-removi.patch
 \
 
file://0011-linux-mali_kernel_linux.c-Enable-disable-clock-for-r.patch\
 "
diff --git 
a/meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch
 
b/meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch

It would be better to make this as a git commit than just diff. I'm not sure if
there's any guideline for that though.

Indeed, however what the kernel-module-mali recipe downloads is not a git repo 
but a tarball (.tgz). If the tar extracted directory structure is the same as 
their git repo's, I can create it as a commit patch and cross my fingers.




new file mode 100644
index 000..f553e58
--- /dev/null
+++ 
b/meta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali/0007-fix-driver-failed-to-check-map-error.patch
@@ -0,0 +1,16 @@
+Index: mali/linux/mali_memory_os_alloc.c
+===
+--- mali.orig/linux/mali_memory_os_alloc.c
 mali/linux/mali_memory_os_alloc.c
+@@ -239,8 +239,9 @@ int mali_mem_os_alloc_pages(mali_mem_os_
+  /* Ensure page is flushed from CPU caches. */
+

Re: [meta-xilinx] [PATCH] kernel-module-mali: check and honour dma_unmap_page exit code

[meta-xilinx] [meta-xilinx-bsp][PATCH] machine-xilinx-board.inc: Remove include file

[meta-xilinx] [meta-xilinx-bsp][PATCH] tune-zynqmp.inc: Use arch-armv8a tune instead of arch-armv8

Re: [meta-xilinx] [PATCH v2] Add support for Z-turn board

Re: [meta-xilinx] [PATCH] kernel-module-mali: check and honour dma_unmap_page exit code

5 matches

Site Navigation

Mail list logo

Footer information