File::Scan (was Re: [Mimedefang] Embedded Perl multiplexor on Debian - sarge Error)

2006-07-20 Thread David F. Skoll
Kayne Kruse wrote:

 Now Take david, hes a rather nice person.  Now that I said that, why do
 you support this monstrosity?  :)  That was some hideous code, makes me
 want to puke shellcodes in the morning! :D  Anywho, note taken and I
 yanked that crap out.

In fact, I'd never looked closely at File::Scan before.

I have removed support for File::Scan from MIMEDefang completely; the
next release won't support it.  If you want to continue to use it, you'll
have to write the supporting code in your filter file.  I can't in good
conscience have built-in support for such a terrible module.

Regards,

David.
___
NOTE: If there is a disclaimer or other legal boilerplate in the above
message, it is NULL AND VOID.  You may ignore it.

Visit http://www.mimedefang.org and http://www.roaringpenguin.com
MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com
http://lists.roaringpenguin.com/mailman/listinfo/mimedefang


[Mimedefang] Embedded Perl multiplexor on Debian - sarge Error

2006-07-19 Thread Kayne Kruse
I just noticed this error, and was curious as to what in the filter is
the FD.

Jul 19 17:03:02 mailfilter mimedefang-multiplexor[4711]: WARNING:
Something in your Perl filter appears to have opened a file descriptor
outside of any function.  With embedded Perl, you should move any code
that opens a file descriptor into filter_initialize.  On some systems,
the C library may open a descriptor, but you should verify your filter
just in case.

I dont have anything other than the standard windows suggested filter as
a base with only some filter_relay code exempting 127.0.0.1 from
filtering and filter_end spam check is doing action_discard for anything
over $req.

Im only guessing that this might be the cause:


 total 20
 dr-x--  2 root   root0 Jul 19 17:19 .
 dr-xr-xr-x  5 defang defang  0 Jul 19 17:17 ..
 lrwx--  1 root   root   64 Jul 19 17:19 0 - /dev/null
 lrwx--  1 root   root   64 Jul 19 17:19 1 - /dev/null
 lr-x--  1 root   root   64 Jul 19 17:19 10 - pipe:[11402537]
 l-wx--  1 root   root   64 Jul 19 17:19 11 - pipe:[11402543]
 lr-x--  1 root   root   64 Jul 19 17:19 12 - pipe:[11402538]
 lr-x--  1 root   root   64 Jul 19 17:19 13 - pipe:[11402544]
 l-wx--  1 root   root   64 Jul 19 17:19 14 - pipe:[11402546]
 lr-x--  1 root   root   64 Jul 19 17:19 15 - pipe:[11402545]
 lr-x--  1 root   root   64 Jul 19 17:19 16 - pipe:[11402547]
 l-wx--  1 root   root   64 Jul 19 17:19 17 - pipe:[11402549]
 lr-x--  1 root   root   64 Jul 19 17:19 18 - pipe:[11402548]
 lr-x--  1 root   root   64 Jul 19 17:19 19 - pipe:[11402550]
 lrwx--  1 root   root   64 Jul 19 17:19 2 - /dev/null
 lr-x--  1 root   root   64 Jul 19 17:19 21 - pipe:[11402551]
 lrwx--  1 root   root   64 Jul 19 17:19 3 - socket:[11402510]
 lr-x--  1 root   root   64 Jul 19 17:19 4 - pipe:[11402512]
 l-wx--  1 root   root   64 Jul 19 17:19 5 - pipe:[11402512]
 lrwx--  1 root   root   64 Jul 19 17:19 6 - socket:[11402515]
 lr-x--  1 root   root   64 Jul 19 17:19 7
 - /usr/share/perl5/File/Scan.pm
 l-wx--  1 root   root   64 Jul 19 17:19 9 - pipe:[11402536]
 

Now You see I think its Mimedefangs own open File::Scan causing this
warning.  Whats the fix for the annoyance?

Thanks,

Kayne


signature.asc
Description: This is a digitally signed message part
___
NOTE: If there is a disclaimer or other legal boilerplate in the above
message, it is NULL AND VOID.  You may ignore it.

Visit http://www.mimedefang.org and http://www.roaringpenguin.com
MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com
http://lists.roaringpenguin.com/mailman/listinfo/mimedefang


Re: [Mimedefang] Embedded Perl multiplexor on Debian - sarge Error

2006-07-19 Thread David F. Skoll
Kayne Kruse wrote:

 I just noticed this error, and was curious as to what in the filter is
 the FD.
 Jul 19 17:03:02 mailfilter mimedefang-multiplexor[4711]: WARNING:
 Something in your Perl filter appears to have opened a file descriptor
 outside of any function.  [...]

 lr-x-- 1 root root 64 Jul 19 17:19  7 - /usr/share/perl5/File/Scan.pm

 Now You see I think its Mimedefangs own open File::Scan causing this
 warning.  Whats the fix for the annoyance?

Remove File::Scan from your system.  It's buggy and evil.

The open descriptor results from the dubious practice of using
SelfLoader to load functions only on demand.  SelfLoader keeps a file
descriptor open.  File::Scan uses this to load its file patterns as
Perl routines.

Did I mention that File::Scan was evil?  Read the code sometime.
Here's a snippet:

if($type == 1) {
} elsif($type == 2) {
if($subtype == 1) {
if($total==10240) {

/\x48\x45\x4c\x4f\x44\x1d\x4d\x41\x49\xec\xc8\x1e\x52\xbc\x6e\x5d\xc3\x43\x50\x54/s
 and $virus = W32/[EMAIL PROTECTED], last LINE;
}
if($total==1024) {

/\x0f\x4d\x61\x70\x56\x5f\xc5\x77\x4f\x66\x18\x10\x1e\x55\x6e\x56\x6d\x11\x90\x2f\x62\x08\x72\x73\xb3\x30\x0c\x99\x45\x6e\x76\x22\x6f\xdf\x52\xfc\x7b\x3c\x56\x61\xfb\xe6\x62\xac\x19\x67\x44\x1a\x76\xb1\x54\x79\x70\x4c\x0f\x53\xf5\xbf\x6c\x8e\x6d\x54\x69\x79/s
 and $virus = W32/[EMAIL PROTECTED], last LINE;
}
} elsif($subtype == 2) {
if($total==4096) {


... and so on.

Regards,

David.
___
NOTE: If there is a disclaimer or other legal boilerplate in the above
message, it is NULL AND VOID.  You may ignore it.

Visit http://www.mimedefang.org and http://www.roaringpenguin.com
MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com
http://lists.roaringpenguin.com/mailman/listinfo/mimedefang


RE: [Mimedefang] Embedded Perl multiplexor on Debian - sarge Error

2006-07-19 Thread Kayne Kruse

Remove File::Scan from your system.  It's buggy and evil.

Regards,

David.



Now Take david, hes a rather nice person.  Now that I said that, why do
you support this monstrosity?  :)  That was some hideous code, makes me
want to puke shellcodes in the morning! :D  Anywho, note taken and I
yanked that crap out.

Kayne

___
NOTE: If there is a disclaimer or other legal boilerplate in the above
message, it is NULL AND VOID.  You may ignore it.

Visit http://www.mimedefang.org and http://www.roaringpenguin.com
MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com
http://lists.roaringpenguin.com/mailman/listinfo/mimedefang