Re: [Mingw-w64-public] [patch/bulk] Introduce __LONG32, part 3
Hello Corinna, my eyes ... yes, patch looks ok. Please go ahead. Thanks, Kai -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/bulk] Introduce __LONG32
2012/8/2 Ozkan Sezer : > On 8/2/12, Kai Tietz wrote: >> Hi Corinna, >> >> 2012/8/2 Corinna Vinschen : >>> Hi, >>> >>> below is about 5% of the entire patch introducing __LONG32. Reviewing >>> more than 4 lines is far from fun, so I made a break at this point. >>> Noticable are a couple of places wher I kept long, these are places >>> where the definitions are in an !_WIN64 branch. Also, in comutils >>> are two inline functions calling Interlocked functions. I changed the >>> reinterpret casts for the argument to the Interlocked function to >>> LONG *, rather than __LONG32 *, since LONG is the argument type of >>> the Win32 function, in prototype and documentation. Hope that's ok. >>> >>> >>> Thanks, >>> Corinna >> >> so patch is ok. I admit that changes of long->__LONG32 in 32-bit case >> is of lower interest for us, but well, this is something to be done >> for consistency-reasons IMHO. But for now let us concentrate on the >> 64-bit case, where this change actual matters for us. >> >> Thanks, >> Kai >> > > Just curious about how is LONG not suited as replacement but __LONG32? > > -- > O.S. LONG is a type. __LONG32 is define. So you can express things like 'signed long', or 'unsigned long' too. I admit that in many places the types LONG and ULONG could be used instead, but we have to deal with the way msdn declares those types and so we need a way to encode 'long' keyword for LP64 ABI. Cheers, Kai -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/bulk] Introduce __LONG32, part 2
Hello Corinna, 2012/8/2 Corinna Vinschen : > Hi, > > here's another about 5% of the patch introducing __LONG32... > > > Thanks, > Corinna the patch is ok. Thanks, Kai -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/bulk] Introduce __LONG32
On 8/2/12, Kai Tietz wrote: > Hi Corinna, > > 2012/8/2 Corinna Vinschen : >> Hi, >> >> below is about 5% of the entire patch introducing __LONG32. Reviewing >> more than 4 lines is far from fun, so I made a break at this point. >> Noticable are a couple of places wher I kept long, these are places >> where the definitions are in an !_WIN64 branch. Also, in comutils >> are two inline functions calling Interlocked functions. I changed the >> reinterpret casts for the argument to the Interlocked function to >> LONG *, rather than __LONG32 *, since LONG is the argument type of >> the Win32 function, in prototype and documentation. Hope that's ok. >> >> >> Thanks, >> Corinna > > so patch is ok. I admit that changes of long->__LONG32 in 32-bit case > is of lower interest for us, but well, this is something to be done > for consistency-reasons IMHO. But for now let us concentrate on the > 64-bit case, where this change actual matters for us. > > Thanks, > Kai > Just curious about how is LONG not suited as replacement but __LONG32? -- O.S. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/bulk] Introduce __LONG32
Hi Corinna, 2012/8/2 Corinna Vinschen : > Hi, > > below is about 5% of the entire patch introducing __LONG32. Reviewing > more than 4 lines is far from fun, so I made a break at this point. > Noticable are a couple of places wher I kept long, these are places > where the definitions are in an !_WIN64 branch. Also, in comutils > are two inline functions calling Interlocked functions. I changed the > reinterpret casts for the argument to the Interlocked function to > LONG *, rather than __LONG32 *, since LONG is the argument type of > the Win32 function, in prototype and documentation. Hope that's ok. > > > Thanks, > Corinna so patch is ok. I admit that changes of long->__LONG32 in 32-bit case is of lower interest for us, but well, this is something to be done for consistency-reasons IMHO. But for now let us concentrate on the 64-bit case, where this change actual matters for us. Thanks, Kai -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch] Fix types for XXX_UserSize, XXX_UserMarshal, XXX_UserUnmarshal, and XXX_UserFree functions
On 08/01/12 22:10, Kai Tietz wrote: > Hi Corinnna, > > patch looks ok to me. See if Jacek have any objections (I wouldn't assume > so). > Yeah, looks good to me. Jacek -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Dev mails on mingw-w64-public
On Aug 1 13:53, NightStrike wrote: > On Wed, Aug 1, 2012 at 9:41 AM, Corinna Vinschen wrote: > > I didn't even know there *is* a developers list. > > > > If you look on http://mingw-w64.sourceforge.net/, under the link "Public > > Mailing List:, there's only a pointer to the mingw-w64-public list. If > > you look on http://sourceforge.net/projects/mingw-w64/, under the > > "Mailing Lists" link, there are three lists only, mingw-w64-documentation, > > mingw-w64-ironcrate and mingw-w64-public. No trace of a developers list. > > Are you a member of the project and signed in to sf? I don't login to sf if I don't have to, just as with any other site. Now I logged in and can see the additional lists so I'm apparently a project member. Anyway, Kai requested that I should stick to the public list, and that's really fine with me. Corinna -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
