Re: [Mingw-w64-public] [Patch] normalize strftime and strftime_l
On 2017/5/22 2:05, Martell Malone wrote: > Context: libc++ uses strftime_l now > > Please Review The DEF files are generated from DLLs. I don't have Win10 at hand so I have asked jon_y on IRC to update them. -- Best regards, LH_Mouse -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [Patch] normalize strftime and strftime_l
On 05/22/2017 07:57 AM, Liu Hao wrote: > On 2017/5/22 2:05, Martell Malone wrote: >> Context: libc++ uses strftime_l now >> >> Please Review > The DEF files are generated from DLLs. I don't have Win10 at hand so I > have asked jon_y on IRC to update them. > Win10 msvcrt doesn't have strftime_l, checked on 1607. signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [Patch] normalize strftime and strftime_l
hmm okay. It does have strftime however so that should at least be fine right? On Mon, May 22, 2017 at 11:43 AM, JonY wrote: > On 05/22/2017 07:57 AM, Liu Hao wrote: > > On 2017/5/22 2:05, Martell Malone wrote: > >> Context: libc++ uses strftime_l now > >> > >> Please Review > > The DEF files are generated from DLLs. I don't have Win10 at hand so I > > have asked jon_y on IRC to update them. > > > > Win10 msvcrt doesn't have strftime_l, checked on 1607. > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [Patch] normalize strftime and strftime_l
On 2017/5/22 18:43, JonY wrote: > On 05/22/2017 07:57 AM, Liu Hao wrote: >> On 2017/5/22 2:05, Martell Malone wrote: >>> Context: libc++ uses strftime_l now >>> >>> Please Review >> The DEF files are generated from DLLs. I don't have Win10 at hand so I >> have asked jon_y on IRC to update them. >> > > Win10 msvcrt doesn't have strftime_l, checked on 1607. Thanks for confirmation. On my Windows 7 the function `_strftime_l` is available in MSVCR{80,90,100,110,120}.DLL, but is not available in MSVCR{T,70}.DLL. So the patch can't be applied here. When I took my last look at libcxx it required MSVCR90 to build. I am not sure which version of MSVCR* libcxx requires today but I am afraid it can't be built with only MSVCRT. That is, in order to build libcxx you have to *replace* the default `-lmsvcrt` with `-lmsvcr90` (MSVCR90 is fragile so I suggest you use `-lmsvcr100`). In the case of GCC this can be done by dumping GCC's default specs file, modifying it, then building use the modified specs. -- Best regards, LH_Mouse -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [Patch] normalize strftime and strftime_l
Thanks for spotting that strangely MSDN seems to think it does exist. https://docs.microsoft.com/en-gb/cpp/c-runtime-library/reference/strftime-wcsftime-strftime-l-wcsftime-l I have no problem in doing an emulation for "strftime_l". I would rather not use random msvcrt versions :) On Mon, May 22, 2017 at 12:14 PM, Liu Hao wrote: > On 2017/5/22 18:43, JonY wrote: > > On 05/22/2017 07:57 AM, Liu Hao wrote: > >> On 2017/5/22 2:05, Martell Malone wrote: > >>> Context: libc++ uses strftime_l now > >>> > >>> Please Review > >> The DEF files are generated from DLLs. I don't have Win10 at hand so I > >> have asked jon_y on IRC to update them. > >> > > > > Win10 msvcrt doesn't have strftime_l, checked on 1607. > Thanks for confirmation. > > On my Windows 7 the function `_strftime_l` is available in > MSVCR{80,90,100,110,120}.DLL, but is not available in MSVCR{T,70}.DLL. > So the patch can't be applied here. > > When I took my last look at libcxx it required MSVCR90 to build. I am > not sure which version of MSVCR* libcxx requires today but I am afraid > it can't be built with only MSVCRT. That is, in order to build libcxx > you have to *replace* the default `-lmsvcrt` with `-lmsvcr90` (MSVCR90 > is fragile so I suggest you use `-lmsvcr100`). In the case of GCC this > can be done by dumping GCC's default specs file, modifying it, then > building use the modified specs. > > -- > Best regards, > LH_Mouse > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public