Re: [Mingw-w64-public] STORAGE_PROTOCOL_COMMAND support in winioctl.h
Just asking. Do you have a open-source project which uses those symbols and can be compiled with mingw toolchain? Though it is not required, having a project would help to make sure that the header file is right. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] crt: Reimplement `dirname()` and `basename()`
在 2023/3/30 17:04, Corinna Vinschen 写道: Well, CMD is just one application and, given how the Windows API works, is not free from bugs... Yeah it looks like a bug in CMD. Both PowerShell and `FindFirstFile()` accepts `\\host\\\share` without issues. I would like to hear about what others think. My opinion is that the share name is part of the volume name (like `C:` and `\\?\C:`) and is not a path component. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Migration from SF and port from Autotools
On 3/20/23 16:44, مهدي شينون wrote: Hi everyone, Could you please consider migrating your project to another host other than sourcefoge where people could file bugs, propose changes and discuss things (like GitHub ot GitLab). Using mailing-list for that is a way that's not suitable for young generation (including me). Many people try to report bugs or propose changes but ended up ignored because of this insist on using this outdated technology! We had similar talks in Wine for years and we finally decided decided to migrate to Gitlab last year. I think it was a good choice. We had it running parallel to ML as an experiment first, here is the summary: https://www.winehq.org/pipermail/wine-devel/2022-June/220008.html I think most of it would apply to mingw-w64 as well. I'd like to especially point CI: Gitlab makes it easy to set up CI and mingw-w64 could really use one. It's esp. nice for reviewers: by the time you look at the patch, you already know that it doesn't break the build. Wine uses self-hosted Gitlab instance, which solves the problem of dependence on third party host. Having its own self-hosted instance just for mingw-w64 would probably be too much overhead for mingw-w64 project, so if we decided to migrate, we'd need to pick one of externally hosted solutions. BTW, SF mailing lists are especially not friendly for patches with its automatic footer messing inline patches and some attachments being silently dropped, depending on their extensions. That combined with other controversies (see https://en.wikipedia.org/wiki/SourceForge Controversies paragraph) makes me think that SF is not an optimal host for the project. Could you also port the project to a better buildsystem, like cmake or meson. Autotools is not a buildsystem to choose to develop for Windows. The honest true is that autotools work well for a number of people, mostly those who cross compile mingw-w64. This does not seem to be true when building natively on Windows. I don't have experience with building on Windows (so I'm one of those for whom it works well), but I think that if there is anything we can do to improve native experience, we should seriously consider it. Windows support should obviously be important for the project. I'd be open to discuss changing build system, but the bottom line is that it's a lot of work, it's not something we can do easily. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] crt: Reimplement `dirname()` and `basename()`
On Mar 29 22:19, LIU Hao wrote: > 在 2023-03-29 21:33, Corinna Vinschen 写道: > > I don't think this is correct. Multiple backslashes are folded into a > > single backslash by the Windows API layer. Thus \\host\\share is not > > equivalent to > > > >\\host\\ > > > > but to > > > >\\host\share > > > > Try this example, please: > > Well, I didn't use `GetFinalPathNameByHandle()`, but examined these paths in > CMD: > >C:\>dir \\192.168.1.8\\temp_share >The specified path is invalid. > >C:\>dir \\192.168.1.8\temp_share >(... directory contents follow ...) > > > As you can see, if we assume that CMD doesn't do path resolution itself, > these paths are not equivalent. Well, CMD is just one application and, given how the Windows API works, is not free from bugs... Corinna ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
[Mingw-w64-public] STORAGE_PROTOCOL_COMMAND support in winioctl.h
Hi, Some of the latest structures are missing in the 'winioctl.h' header file. I am especially looking for 'STORAGE_PROCOTOL_COMMAND' that can be used to send nvme pass-through commands. Is it possible to pull those latest structures here in MinGW? Thanks Raj ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] crt: Remove conversion functions between UTF-{16, 32} characters from MSVCRT
在 2023/3/24 16:47, LIU Hao 写道:
rom 544a196787132e0ceae01fe2f0f6c62e76da0e05 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Fri, 24 Mar 2023 16:38:51 +0800
Subject: [PATCH] crt: Remove conversion functions between UTF-{16,32}
characters from MSVCRT
Microsoft documentation says these functions operate between UTF-8 and
UTF-{16,32}. However, the function `mbrtoc16()` delegates to `mbrtowc()`
which handles only DBCS encodings; the legacy MSVCRT does not have UTF-8
support. `mbrtoc32()` on the other hand igores the `mbstate_t` argument
and is non-restartable. So neither conforms to the C standard.
This commit removes those incorrect functions from MSVCRT. In order to
get UTF-8 support, users should link against UCRT.
Reference:https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mbrtoc16-mbrtoc323?view=msvc-170
Signed-off-by: LIU Hao
---
Ping on this patch. A blank line got deleted by accident. I can fix that
locally.
Removal of stuff could be bad, but given that `mbstoc16()` has never been working, it might not be a
big loss.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
