[Mingw-w64-public] [PATCH] intrin-impl.h: do not define _xgetbv for GCC 8
GCC 8 from r248028 has defined function _xgetbv and we should avoid double definition of this function. Please review. Mateusz From 5aa15ee4a5f04cdc797deb685d23dc67275af357 Mon Sep 17 00:00:00 2001 From: Mateusz Date: Mon, 22 Jan 2018 20:58:48 +0100 Subject: [PATCH] intrin-impl.h: do not define _xgetbv for GCC 8 GCC 8 from r248028 has defined function _xgetbv and we should avoid double definition of this function. Signed-off-by: Mateusz Brzostek --- mingw-w64-headers/include/psdk_inc/intrin-impl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mingw-w64-headers/include/psdk_inc/intrin-impl.h b/mingw-w64-headers/include/psdk_inc/intrin-impl.h index ff9e6aff..88af804c 100644 --- a/mingw-w64-headers/include/psdk_inc/intrin-impl.h +++ b/mingw-w64-headers/include/psdk_inc/intrin-impl.h @@ -1775,6 +1775,7 @@ __buildmov(__movsd, unsigned __LONG32, "d") #define __INTRINSIC_DEFINED___movsd #endif /* __INTRINSIC_PROLOG */ +#if !defined(__GNUC__) || __GNUC__ < 8 /* GCC 8 has already defined _xgetbv */ /* NOTE: This should be in immintrin.h */ #if __INTRINSIC_PROLOG(_xgetbv) unsigned __int64 _xgetbv(unsigned int); @@ -1798,6 +1799,7 @@ unsigned __int64 _xgetbv(unsigned int index) #endif #define __INTRINSIC_DEFINED__xgetbv #endif /* __INTRINSIC_PROLOG */ +#endif /* __GNUC__ < 8 */ #endif /* defined(__x86_64__) || defined(_AMD64_) || defined(__i386__) || defined(_X86_) */ -- 2.14.1 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] intrin-impl.h: do not define _xgetbv for GCC 8
Hi Mateusz, On 1/22/18 9:18 PM, Mateusz wrote: GCC 8 from r248028 has defined function _xgetbv and we should avoid double definition of this function. Please review. The patch looks good to me. Thanks, Jacek -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] intrin-impl.h: do not define _xgetbv for GCC 8
W dniu 30.01.2018 o 10:51, Jacek Caban pisze: > Hi Mateusz, > > > On 1/22/18 9:18 PM, Mateusz wrote: >> GCC 8 from r248028 has defined function _xgetbv and we should >> avoid double definition of this function. >> >> Please review. >> > > The patch looks good to me. > > Thanks, > Jacek Thanks for review. Could somebody with write access commit this patch? Mateusz -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] intrin-impl.h: do not define _xgetbv for GCC 8
On Fri, 2 Feb 2018, Mateusz wrote: W dniu 30.01.2018 o 10:51, Jacek Caban pisze: Hi Mateusz, On 1/22/18 9:18 PM, Mateusz wrote: GCC 8 from r248028 has defined function _xgetbv and we should avoid double definition of this function. Please review. The patch looks good to me. Thanks, Jacek Thanks for review. Could somebody with write access commit this patch? Pushed to master. Thanks! // Martin -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
