Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
Hi Corinna, well I dislike this __CYGWIN__ define mess here, but I admit I don't have an better idea. Well, we could consider to provide a cygwin-specific intrin.h header but well ... So patch is ok. Thanks, Kai -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
On Apr 5 11:39, Kai Tietz wrote: > Hi Corinna, > > well I dislike this __CYGWIN__ define mess here, but I admit I don't It's only eight ifndef __CYGWIN__ blocks, not really a mess, IMHO. Alternatively we could move all declaration colliding with POSIX into a single block at the start of intrin.h and guard it with a single #ifndef, plus a comment to tell people to put POSIX declarations always into this block. Corinna -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
2013/4/5 Corinna Vinschen : > On Apr 5 11:39, Kai Tietz wrote: >> Hi Corinna, >> >> well I dislike this __CYGWIN__ define mess here, but I admit I don't > > It's only eight ifndef __CYGWIN__ blocks, not really a mess, IMHO. > Alternatively we could move all declaration colliding with POSIX into a > single block at the start of intrin.h and guard it with a single > #ifndef, plus a comment to tell people to put POSIX declarations always > into this block. True, there are only 8 of them. The idea to move them into a single block sounds good to me. Regards, Kai -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
On Apr 5 12:15, Kai Tietz wrote: > 2013/4/5 Corinna Vinschen : > > On Apr 5 11:39, Kai Tietz wrote: > >> Hi Corinna, > >> > >> well I dislike this __CYGWIN__ define mess here, but I admit I don't > > > > It's only eight ifndef __CYGWIN__ blocks, not really a mess, IMHO. > > Alternatively we could move all declaration colliding with POSIX into a > > single block at the start of intrin.h and guard it with a single > > #ifndef, plus a comment to tell people to put POSIX declarations always > > into this block. > > True, there are only 8 of them. The idea to move them into a single > block sounds good to me. Applied with that change. I just left the setjmp stuff intact since it seemed strange to move it, too. But if you like I can pull that into the cygwin block as well, no worries. Thanks, Corinna -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
2013/4/5 Corinna Vinschen > On Apr 5 12:15, Kai Tietz wrote: > > 2013/4/5 Corinna Vinschen : > > > On Apr 5 11:39, Kai Tietz wrote: > > >> Hi Corinna, > > >> > > >> well I dislike this __CYGWIN__ define mess here, but I admit I don't > > > > > > It's only eight ifndef __CYGWIN__ blocks, not really a mess, IMHO. > > > Alternatively we could move all declaration colliding with POSIX into a > > > single block at the start of intrin.h and guard it with a single > > > #ifndef, plus a comment to tell people to put POSIX declarations always > > > into this block. > > > > True, there are only 8 of them. The idea to move them into a single > > block sounds good to me. > > Applied with that change. I just left the setjmp stuff intact since it > seemed strange to move it, too. But if you like I can pull that into > the cygwin block as well, no worries. > > Building trunk crt gives me this error: i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt -m32 -I/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/include -D_CRTBLD -I/usr/i686-w64-mingw32/include -pipe -std=gnu99 -Wall -Wextra -Wformat -Wstrict-aliasing -Wshadow -Wpacked -Winline -Wimplicit-function-declaration -Wmissing-noreturn -Wmissing-prototypes -g -O2 -MT intrincs/lib32_libkernel32_a-membarrier.o -MD -MP -MF intrincs/.deps/lib32_libkernel32_a-membarrier.Tpo -c -o intrincs/lib32_libkernel32_a-membarrier.o `test -f 'intrincs/membarrier.c' || echo '/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/'`intrincs/membarrier.c /home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/intrincs/membarrier.c: In function 'MemoryBarrier': /home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/intrincs/membarrier.c:5:5: error: unknown type name '__LONG32' __LONG32 Barrier = 0; ^ I think something was missed. Ruben > Thanks, > Corinna > > > -- > Minimize network downtime and maximize team effectiveness. > Reduce network management and security costs.Learn how to hire > the most talented Cisco Certified professionals. Visit the > Employer Resources Portal > http://www.cisco.com/web/learning/employer_resources/index.html > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
On Apr 6 17:54, Ruben Van Boxem wrote: > 2013/4/5 Corinna Vinschen > > > On Apr 5 12:15, Kai Tietz wrote: > > > 2013/4/5 Corinna Vinschen : > > > > On Apr 5 11:39, Kai Tietz wrote: > > > >> Hi Corinna, > > > >> > > > >> well I dislike this __CYGWIN__ define mess here, but I admit I don't > > > > > > > > It's only eight ifndef __CYGWIN__ blocks, not really a mess, IMHO. > > > > Alternatively we could move all declaration colliding with POSIX into a > > > > single block at the start of intrin.h and guard it with a single > > > > #ifndef, plus a comment to tell people to put POSIX declarations always > > > > into this block. > > > > > > True, there are only 8 of them. The idea to move them into a single > > > block sounds good to me. > > > > Applied with that change. I just left the setjmp stuff intact since it > > seemed strange to move it, too. But if you like I can pull that into > > the cygwin block as well, no worries. > > > > > > Building trunk crt gives me this error: > > i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. > -I/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt -m32 > -I/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/include -D_CRTBLD > -I/usr/i686-w64-mingw32/include -pipe -std=gnu99 -Wall -Wextra -Wformat > -Wstrict-aliasing -Wshadow -Wpacked -Winline > -Wimplicit-function-declaration -Wmissing-noreturn -Wmissing-prototypes -g > -O2 -MT intrincs/lib32_libkernel32_a-membarrier.o -MD -MP -MF > intrincs/.deps/lib32_libkernel32_a-membarrier.Tpo -c -o > intrincs/lib32_libkernel32_a-membarrier.o `test -f 'intrincs/membarrier.c' > || echo > '/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/'`intrincs/membarrier.c > /home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/intrincs/membarrier.c: > In function 'MemoryBarrier': > /home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/intrincs/membarrier.c:5:5: > error: unknown type name '__LONG32' > __LONG32 Barrier = 0; > ^ > > I think something was missed. Indeed. I tested on 64 bit only. membarrier.c is only built for 32 bit and it's the only intrinsics source not including . Two solutions: - Either add #include to membarrier.c, - or revert all __LONG32 to long in 32bit-only intrinsics. Whatever the maintainers prefer. Corinna -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
2013/4/6 Corinna Vinschen : > On Apr 6 17:54, Ruben Van Boxem wrote: >> 2013/4/5 Corinna Vinschen >> >> > On Apr 5 12:15, Kai Tietz wrote: >> > > 2013/4/5 Corinna Vinschen : >> > > > On Apr 5 11:39, Kai Tietz wrote: >> > > >> Hi Corinna, >> > > >> >> > > >> well I dislike this __CYGWIN__ define mess here, but I admit I don't >> > > > >> > > > It's only eight ifndef __CYGWIN__ blocks, not really a mess, IMHO. >> > > > Alternatively we could move all declaration colliding with POSIX into a >> > > > single block at the start of intrin.h and guard it with a single >> > > > #ifndef, plus a comment to tell people to put POSIX declarations always >> > > > into this block. >> > > >> > > True, there are only 8 of them. The idea to move them into a single >> > > block sounds good to me. >> > >> > Applied with that change. I just left the setjmp stuff intact since it >> > seemed strange to move it, too. But if you like I can pull that into >> > the cygwin block as well, no worries. >> > >> > >> >> Building trunk crt gives me this error: >> >> i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. >> -I/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt -m32 >> -I/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/include -D_CRTBLD >> -I/usr/i686-w64-mingw32/include -pipe -std=gnu99 -Wall -Wextra -Wformat >> -Wstrict-aliasing -Wshadow -Wpacked -Winline >> -Wimplicit-function-declaration -Wmissing-noreturn -Wmissing-prototypes -g >> -O2 -MT intrincs/lib32_libkernel32_a-membarrier.o -MD -MP -MF >> intrincs/.deps/lib32_libkernel32_a-membarrier.Tpo -c -o >> intrincs/lib32_libkernel32_a-membarrier.o `test -f 'intrincs/membarrier.c' >> || echo >> '/home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/'`intrincs/membarrier.c >> /home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/intrincs/membarrier.c: >> In function 'MemoryBarrier': >> /home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/intrincs/membarrier.c:5:5: >> error: unknown type name '__LONG32' >> __LONG32 Barrier = 0; >> ^ >> >> I think something was missed. > > Indeed. I tested on 64 bit only. membarrier.c is only built for 32 bit > and it's the only intrinsics source not including . > > Two solutions: > > - Either add #include to membarrier.c, > > - or revert all __LONG32 to long in 32bit-only intrinsics. > > Whatever the maintainers prefer. > > > Corinna I prefer to add the header-include. Kai -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [patch/cygwin] Fix intrin.h and intrinsics to be buildable on Cygwin
On Apr 6 18:34, Kai Tietz wrote: > 2013/4/6 Corinna Vinschen : > > On Apr 6 17:54, Ruben Van Boxem wrote: > >> Building trunk crt gives me this error: > >>[...] > >> /home/ruben/AUR/mingw-w64-crt-svn/src/mingw-w64-crt/intrincs/membarrier.c:5:5: > >> error: unknown type name '__LONG32' > >> __LONG32 Barrier = 0; > >> ^ > >> > >> I think something was missed. > > > > Indeed. I tested on 64 bit only. membarrier.c is only built for 32 bit > > and it's the only intrinsics source not including . > > > > Two solutions: > > > > - Either add #include to membarrier.c, > > > > - or revert all __LONG32 to long in 32bit-only intrinsics. > > > > Whatever the maintainers prefer. > > > > > > Corinna > > I prefer to add the header-include. Done. I also added the "for x86 only" comment as all other x86-only files have. Corinna -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
