[Mingw-w64-public] Default _WIN32_WINNT version too low?
Hey, As per my discussion with LLVM devs here. 0x600 is the min version required to support libc++ win32 threading. https://reviews.llvm.org/D33384 I'm not quite sure why we currently have 0x502 as the default. It seems to be a number sitting between Windows XP and Vista. I would like to propose we bump to 0x600 which is Vista for this reason. Kind Regards Martell -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
0x0502 is Windows Server 2003 If changing default target it should be done properly. Windows Vista is EOL and it's share is lower than XP so I'd vote for Windows 7. -- Original Message -- Subject: [Mingw-w64-public] Default _WIN32_WINNT version too low? Date: Sat, 3 Jun 2017 18:27:40 +0100 To: Mingw-w64-public From: Martell Malone > Hey, > > As per my discussion with LLVM devs here. > 0x600 is the min version required to support libc++ win32 threading. > https://reviews.llvm.org/D33384 > > I'm not quite sure why we currently have 0x502 as the default. > It seems to be a number sitting between Windows XP and Vista. > I would like to propose we bump to 0x600 which is Vista for this reason. > > Kind Regards > Martell > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
On 3 June 2017 at 19:52, Mateusz Mikuła wrote: > 0x0502 is Windows Server 2003 > > If changing default target it should be done properly. Windows Vista is > EOL and it's share is lower than XP so I'd vote for Windows 7. > > > -- Original Message -- > Subject: [Mingw-w64-public] Default _WIN32_WINNT version too low? > Date: Sat, 3 Jun 2017 18:27:40 +0100 > To: Mingw-w64-public > From: Martell Malone > > Hey, > > > > As per my discussion with LLVM devs here. > > 0x600 is the min version required to support libc++ win32 threading. > > https://reviews.llvm.org/D33384 > > > > I'm not quite sure why we currently have 0x502 as the default. > > It seems to be a number sitting between Windows XP and Vista. > Besides being Windows Server 2003 it's also XP SP2. > > I would like to propose we bump to 0x600 which is Vista for this reason. > > > > Kind Regards > > Martell > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > Mingw-w64-public mailing list > > Mingw-w64-public@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
Thanks for that clarification Ricardo. It seems that when we bumped we didn't bump far enough :) Kai what are your thoughts? On Sun, Jun 4, 2017 at 12:13 AM, Ricardo Constantino wrote: > On 3 June 2017 at 19:52, Mateusz Mikuła wrote: > > > 0x0502 is Windows Server 2003 > > > > If changing default target it should be done properly. Windows Vista is > > EOL and it's share is lower than XP so I'd vote for Windows 7. > > > > > > -- Original Message -- > > Subject: [Mingw-w64-public] Default _WIN32_WINNT version too low? > > Date: Sat, 3 Jun 2017 18:27:40 +0100 > > To: Mingw-w64-public > > From: Martell Malone > > > Hey, > > > > > > As per my discussion with LLVM devs here. > > > 0x600 is the min version required to support libc++ win32 threading. > > > https://reviews.llvm.org/D33384 > > > > > > I'm not quite sure why we currently have 0x502 as the default. > > > It seems to be a number sitting between Windows XP and Vista. > > > > Besides being Windows Server 2003 it's also XP SP2. > > > > > I would like to propose we bump to 0x600 which is Vista for this > reason. > > > > > > Kind Regards > > > Martell > > > > > -- > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > ___ > > > Mingw-w64-public mailing list > > > Mingw-w64-public@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > > > > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > Mingw-w64-public mailing list > > Mingw-w64-public@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
I agree that - if we want to increase default windows version - we should bump our default to Windows 7. Windows Vista is already on the way to die ... Nevertheless, IMHO we should do that increase just for our master. Regards, Kai 2017-06-04 1:33 GMT+02:00 Martell Malone : > Thanks for that clarification Ricardo. > It seems that when we bumped we didn't bump far enough :) > Kai what are your thoughts? > > On Sun, Jun 4, 2017 at 12:13 AM, Ricardo Constantino > wrote: > >> On 3 June 2017 at 19:52, Mateusz Mikuła wrote: >> >> > 0x0502 is Windows Server 2003 >> > >> > If changing default target it should be done properly. Windows Vista is >> > EOL and it's share is lower than XP so I'd vote for Windows 7. >> > >> > >> > -- Original Message -- >> > Subject: [Mingw-w64-public] Default _WIN32_WINNT version too low? >> > Date: Sat, 3 Jun 2017 18:27:40 +0100 >> > To: Mingw-w64-public >> > From: Martell Malone >> > > Hey, >> > > >> > > As per my discussion with LLVM devs here. >> > > 0x600 is the min version required to support libc++ win32 threading. >> > > https://reviews.llvm.org/D33384 >> > > >> > > I'm not quite sure why we currently have 0x502 as the default. >> > > It seems to be a number sitting between Windows XP and Vista. >> > >> >> Besides being Windows Server 2003 it's also XP SP2. >> >> >> > > I would like to propose we bump to 0x600 which is Vista for this >> reason. >> > > >> > > Kind Regards >> > > Martell >> > > >> > -- >> > > Check out the vibrant tech community on one of the world's most >> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> > > ___ >> > > Mingw-w64-public mailing list >> > > Mingw-w64-public@lists.sourceforge.net >> > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > >> > >> > >> > -- >> > Check out the vibrant tech community on one of the world's most >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> > ___ >> > Mingw-w64-public mailing list >> > Mingw-w64-public@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > >> > >> >> -- >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> ___ >> Mingw-w64-public mailing list >> Mingw-w64-public@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
I would maybe go one step further and make this a configure option (with default value). Then a user can decide if it's necessary to increase this for any reason whatsoever. Op 9 jun. 2017 11:18 a.m. schreef "Kai Tietz via Mingw-w64-public" < mingw-w64-public@lists.sourceforge.net>: > I agree that - if we want to increase default windows version - we > should bump our default to Windows 7. Windows Vista is already on the > way to die ... > Nevertheless, IMHO we should do that increase just for our master. > > Regards, > Kai > > 2017-06-04 1:33 GMT+02:00 Martell Malone : > > Thanks for that clarification Ricardo. > > It seems that when we bumped we didn't bump far enough :) > > Kai what are your thoughts? > > > > On Sun, Jun 4, 2017 at 12:13 AM, Ricardo Constantino > > wrote: > > > >> On 3 June 2017 at 19:52, Mateusz Mikuła wrote: > >> > >> > 0x0502 is Windows Server 2003 > >> > > >> > If changing default target it should be done properly. Windows Vista > is > >> > EOL and it's share is lower than XP so I'd vote for Windows 7. > >> > > >> > > >> > -- Original Message -- > >> > Subject: [Mingw-w64-public] Default _WIN32_WINNT version too low? > >> > Date: Sat, 3 Jun 2017 18:27:40 +0100 > >> > To: Mingw-w64-public > >> > From: Martell Malone > >> > > Hey, > >> > > > >> > > As per my discussion with LLVM devs here. > >> > > 0x600 is the min version required to support libc++ win32 threading. > >> > > https://reviews.llvm.org/D33384 > >> > > > >> > > I'm not quite sure why we currently have 0x502 as the default. > >> > > It seems to be a number sitting between Windows XP and Vista. > >> > > >> > >> Besides being Windows Server 2003 it's also XP SP2. > >> > >> > >> > > I would like to propose we bump to 0x600 which is Vista for this > >> reason. > >> > > > >> > > Kind Regards > >> > > Martell > >> > > > >> > -- > >> > > Check out the vibrant tech community on one of the world's most > >> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> > > ___ > >> > > Mingw-w64-public mailing list > >> > > Mingw-w64-public@lists.sourceforge.net > >> > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > >> > > >> > > >> > > >> > -- > >> > Check out the vibrant tech community on one of the world's most > >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> > ___ > >> > Mingw-w64-public mailing list > >> > Mingw-w64-public@lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > >> > > >> > > >> > >> -- > >> Check out the vibrant tech community on one of the world's most > >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> ___ > >> Mingw-w64-public mailing list > >> Mingw-w64-public@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > >> > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > Mingw-w64-public mailing list > > Mingw-w64-public@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
In that case, I think the best course of immediate action is to bump to Windows 7 as Kai suggested. If someone has the time to implement a configure option for changing this default like Ruben suggest that would be a great. Here is a patch for the former. Please Review diff --git a/mingw-w64-headers/crt/_mingw.h.in b/mingw-w64-headers/crt/_ mingw.h.in index 2742b115..03de2212 100644 --- a/mingw-w64-headers/crt/_mingw.h.in +++ b/mingw-w64-headers/crt/_mingw.h.in @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ #ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x502 +#define _WIN32_WINNT 0x601 #endif #ifndef _INT128_DEFINED Best, Martell On Fri, Jun 9, 2017 at 4:17 PM, Ruben Van Boxem wrote: > I would maybe go one step further and make this a configure option (with > default value). Then a user can decide if it's necessary to increase this > for any reason whatsoever. > > Op 9 jun. 2017 11:18 a.m. schreef "Kai Tietz via Mingw-w64-public" < > mingw-w64-public@lists.sourceforge.net>: > > > I agree that - if we want to increase default windows version - we > > should bump our default to Windows 7. Windows Vista is already on the > > way to die ... > > Nevertheless, IMHO we should do that increase just for our master. > > > > Regards, > > Kai > > > > 2017-06-04 1:33 GMT+02:00 Martell Malone : > > > Thanks for that clarification Ricardo. > > > It seems that when we bumped we didn't bump far enough :) > > > Kai what are your thoughts? > > > > > > On Sun, Jun 4, 2017 at 12:13 AM, Ricardo Constantino < > wiia...@gmail.com> > > > wrote: > > > > > >> On 3 June 2017 at 19:52, Mateusz Mikuła wrote: > > >> > > >> > 0x0502 is Windows Server 2003 > > >> > > > >> > If changing default target it should be done properly. Windows Vista > > is > > >> > EOL and it's share is lower than XP so I'd vote for Windows 7. > > >> > > > >> > > > >> > -- Original Message -- > > >> > Subject: [Mingw-w64-public] Default _WIN32_WINNT version too low? > > >> > Date: Sat, 3 Jun 2017 18:27:40 +0100 > > >> > To: Mingw-w64-public > > >> > From: Martell Malone > > >> > > Hey, > > >> > > > > >> > > As per my discussion with LLVM devs here. > > >> > > 0x600 is the min version required to support libc++ win32 > threading. > > >> > > https://reviews.llvm.org/D33384 > > >> > > > > >> > > I'm not quite sure why we currently have 0x502 as the default. > > >> > > It seems to be a number sitting between Windows XP and Vista. > > >> > > > >> > > >> Besides being Windows Server 2003 it's also XP SP2. > > >> > > >> > > >> > > I would like to propose we bump to 0x600 which is Vista for this > > >> reason. > > >> > > > > >> > > Kind Regards > > >> > > Martell > > >> > > > > >> > -- > > >> > > Check out the vibrant tech community on one of the world's most > > >> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > >> > > ___ > > >> > > Mingw-w64-public mailing list > > >> > > Mingw-w64-public@lists.sourceforge.net > > >> > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > >> > > > >> > > > >> > > > >> > -- > > >> > Check out the vibrant tech community on one of the world's most > > >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > >> > ___ > > >> > Mingw-w64-public mailing list > > >> > Mingw-w64-public@lists.sourceforge.net > > >> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > >> > > > >> > > > >> > > >> -- > > >> Check out the vibrant tech community on one of the world's most > > >> engaging tech sites, Slashdot.org! http://sdm.link/slas
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
On 2017/6/12 23:17, Martell Malone wrote: In that case, I think the best course of immediate action is to bump to Windows 7 as Kai suggested. If someone has the time to implement a configure option for changing this default like Ruben suggest that would be a great. Here is a patch for the former. Please Review diff --git a/mingw-w64-headers/crt/_mingw.h.in b/mingw-w64-headers/crt/_ mingw.h.in index 2742b115..03de2212 100644 --- a/mingw-w64-headers/crt/_mingw.h.in +++ b/mingw-w64-headers/crt/_mingw.h.in @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ #ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x502 +#define _WIN32_WINNT 0x601 #endif #ifndef _INT128_DEFINED Upvote for this. OK for master? -- Best regards, LH_Mouse -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
I'd like to humbly request a hold on this. If it's not broken, why fix it? I've been happy to be able to tell our customers that our software works on win XP (SP2) for a long while; and I don't see anything that's changed that should require us to end that support. When we surveyed last year, several percent of our users still used XP, and we don't really want to leave them out in the cold without good reason. Building our own mingw just to configure it with a lower default support version is out of the question with our workflow, unfortunately. I don't see this as a constructive change, as it doesn't appear to actually improve anything for anybody. Can we reconsider? Regards, Riot On 12 June 2017 at 18:02, Liu Hao wrote: > On 2017/6/12 23:17, Martell Malone wrote: > >> In that case, >> I think the best course of immediate action is to bump to Windows 7 as Kai >> suggested. >> If someone has the time to implement a configure option for changing this >> default like Ruben suggest that would be a great. >> Here is a patch for the former. >> Please Review >> >> diff --git a/mingw-w64-headers/crt/_mingw.h.in b/mingw-w64-headers/crt/_ >> mingw.h.in >> index 2742b115..03de2212 100644 >> --- a/mingw-w64-headers/crt/_mingw.h.in >> +++ b/mingw-w64-headers/crt/_mingw.h.in >> @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ >> #ifndef _WIN32_WINNT >> -#define _WIN32_WINNT 0x502 >> +#define _WIN32_WINNT 0x601 >> #endif >> #ifndef _INT128_DEFINED >> >> Upvote for this. OK for master? > > -- > Best regards, > LH_Mouse > > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
Riot, do you work for Riot Games? Anyway, in this patch, the line of code being changed is guarded by #ifndef _WIN32_WINNT. So if you define _WIN32_WINNT yourself, this patch will have no effect on you. (I'm assuming that the value of _WIN32_WINNT does not affect how the MinGW libraries are compiled, and it only affects what features are available in the header files.) --David On Mon, Jun 12, 2017 at 10:36 AM, Riot wrote: > I'd like to humbly request a hold on this. > > If it's not broken, why fix it? > > I've been happy to be able to tell our customers that our software works on > win XP (SP2) for a long while; and I don't see anything that's changed that > should require us to end that support. When we surveyed last year, several > percent of our users still used XP, and we don't really want to leave them > out in the cold without good reason. Building our own mingw just to > configure it with a lower default support version is out of the question > with our workflow, unfortunately. > > I don't see this as a constructive change, as it doesn't appear to actually > improve anything for anybody. Can we reconsider? > > > Regards, > Riot > > > On 12 June 2017 at 18:02, Liu Hao wrote: > >> On 2017/6/12 23:17, Martell Malone wrote: >> >>> In that case, >>> I think the best course of immediate action is to bump to Windows 7 as Kai >>> suggested. >>> If someone has the time to implement a configure option for changing this >>> default like Ruben suggest that would be a great. >>> Here is a patch for the former. >>> Please Review >>> >>> diff --git a/mingw-w64-headers/crt/_mingw.h.in b/mingw-w64-headers/crt/_ >>> mingw.h.in >>> index 2742b115..03de2212 100644 >>> --- a/mingw-w64-headers/crt/_mingw.h.in >>> +++ b/mingw-w64-headers/crt/_mingw.h.in >>> @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ >>> #ifndef _WIN32_WINNT >>> -#define _WIN32_WINNT 0x502 >>> +#define _WIN32_WINNT 0x601 >>> #endif >>> #ifndef _INT128_DEFINED >>> >>> Upvote for this. OK for master? >> >> -- >> Best regards, >> LH_Mouse >> >> >> >> >> -- >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> ___ >> Mingw-w64-public mailing list >> Mingw-w64-public@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
Haha, no - although I do work for a game company, I'd rather not say which on-list. Am I mistaken in that the patch affects the CRT? In which case, defining _WIN32_WINNT would only be useful at the point of building mingw-w64 itself - building and maintaining our own mingw-w64 is not an option for us with our current build pipeline, as we rely on mingw-builds currently. Any change to the default would leave us in future with a toolchain unable to build for mingw-w64. Regards, Riot On 12 June 2017 at 18:46, David Grayson wrote: > Riot, do you work for Riot Games? > > Anyway, in this patch, the line of code being changed is guarded by > #ifndef _WIN32_WINNT. So if you define _WIN32_WINNT yourself, this > patch will have no effect on you. (I'm assuming that the value of > _WIN32_WINNT does not affect how the MinGW libraries are compiled, and > it only affects what features are available in the header files.) > > --David > > On Mon, Jun 12, 2017 at 10:36 AM, Riot wrote: > > I'd like to humbly request a hold on this. > > > > If it's not broken, why fix it? > > > > I've been happy to be able to tell our customers that our software works > on > > win XP (SP2) for a long while; and I don't see anything that's changed > that > > should require us to end that support. When we surveyed last year, > several > > percent of our users still used XP, and we don't really want to leave > them > > out in the cold without good reason. Building our own mingw just to > > configure it with a lower default support version is out of the question > > with our workflow, unfortunately. > > > > I don't see this as a constructive change, as it doesn't appear to > actually > > improve anything for anybody. Can we reconsider? > > > > > > Regards, > > Riot > > > > > > On 12 June 2017 at 18:02, Liu Hao wrote: > > > >> On 2017/6/12 23:17, Martell Malone wrote: > >> > >>> In that case, > >>> I think the best course of immediate action is to bump to Windows 7 as > Kai > >>> suggested. > >>> If someone has the time to implement a configure option for changing > this > >>> default like Ruben suggest that would be a great. > >>> Here is a patch for the former. > >>> Please Review > >>> > >>> diff --git a/mingw-w64-headers/crt/_mingw.h.in > b/mingw-w64-headers/crt/_ > >>> mingw.h.in > >>> index 2742b115..03de2212 100644 > >>> --- a/mingw-w64-headers/crt/_mingw.h.in > >>> +++ b/mingw-w64-headers/crt/_mingw.h.in > >>> @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ > >>> #ifndef _WIN32_WINNT > >>> -#define _WIN32_WINNT 0x502 > >>> +#define _WIN32_WINNT 0x601 > >>> #endif > >>> #ifndef _INT128_DEFINED > >>> > >>> Upvote for this. OK for master? > >> > >> -- > >> Best regards, > >> LH_Mouse > >> > >> > >> > >> > >> -- > >> Check out the vibrant tech community on one of the world's most > >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> ___ > >> Mingw-w64-public mailing list > >> Mingw-w64-public@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > >> > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > Mingw-w64-public mailing list > > Mingw-w64-public@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
*sorry, I meant unable to build for win xp sp2 using mingw-w64. It's not a show stopper as that's a very small minority of our customers who are affected, and they're already used to everyone else dropping support for them - but it seems unnecessary to take away something that's working fine, and removing which doesn't benefit anyone. On 12 June 2017 at 19:01, Riot wrote: > Haha, no - although I do work for a game company, I'd rather not say which > on-list. > > Am I mistaken in that the patch affects the CRT? In which case, defining > _WIN32_WINNT would only be useful at the point of building mingw-w64 itself > - building and maintaining our own mingw-w64 is not an option for us with > our current build pipeline, as we rely on mingw-builds currently. Any > change to the default would leave us in future with a toolchain unable to > build for mingw-w64. > > Regards, > Riot > > On 12 June 2017 at 18:46, David Grayson wrote: > >> Riot, do you work for Riot Games? >> >> Anyway, in this patch, the line of code being changed is guarded by >> #ifndef _WIN32_WINNT. So if you define _WIN32_WINNT yourself, this >> patch will have no effect on you. (I'm assuming that the value of >> _WIN32_WINNT does not affect how the MinGW libraries are compiled, and >> it only affects what features are available in the header files.) >> >> --David >> >> On Mon, Jun 12, 2017 at 10:36 AM, Riot wrote: >> > I'd like to humbly request a hold on this. >> > >> > If it's not broken, why fix it? >> > >> > I've been happy to be able to tell our customers that our software >> works on >> > win XP (SP2) for a long while; and I don't see anything that's changed >> that >> > should require us to end that support. When we surveyed last year, >> several >> > percent of our users still used XP, and we don't really want to leave >> them >> > out in the cold without good reason. Building our own mingw just to >> > configure it with a lower default support version is out of the question >> > with our workflow, unfortunately. >> > >> > I don't see this as a constructive change, as it doesn't appear to >> actually >> > improve anything for anybody. Can we reconsider? >> > >> > >> > Regards, >> > Riot >> > >> > >> > On 12 June 2017 at 18:02, Liu Hao wrote: >> > >> >> On 2017/6/12 23:17, Martell Malone wrote: >> >> >> >>> In that case, >> >>> I think the best course of immediate action is to bump to Windows 7 >> as Kai >> >>> suggested. >> >>> If someone has the time to implement a configure option for changing >> this >> >>> default like Ruben suggest that would be a great. >> >>> Here is a patch for the former. >> >>> Please Review >> >>> >> >>> diff --git a/mingw-w64-headers/crt/_mingw.h.in >> b/mingw-w64-headers/crt/_ >> >>> mingw.h.in >> >>> index 2742b115..03de2212 100644 >> >>> --- a/mingw-w64-headers/crt/_mingw.h.in >> >>> +++ b/mingw-w64-headers/crt/_mingw.h.in >> >>> @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ >> >>> #ifndef _WIN32_WINNT >> >>> -#define _WIN32_WINNT 0x502 >> >>> +#define _WIN32_WINNT 0x601 >> >>> #endif >> >>> #ifndef _INT128_DEFINED >> >>> >> >>> Upvote for this. OK for master? >> >> >> >> -- >> >> Best regards, >> >> LH_Mouse >> >> >> >> >> >> >> >> >> >> -- >> >> Check out the vibrant tech community on one of the world's most >> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> >> ___ >> >> Mingw-w64-public mailing list >> >> Mingw-w64-public@lists.sourceforge.net >> >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> >> >> > >> -- >> > Check out the vibrant tech community on one of the world's most >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> > ___ >> > Mingw-w64-public mailing list >> > Mingw-w64-public@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> >> >> -- >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> ___ >> Mingw-w64-public mailing list >> Mingw-w64-public@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
> > Am I mistaken in that the patch affects the CRT? In which case, defining > _WIN32_WINNT would only be useful at the point of building mingw-w64 itself > - building and maintaining our own mingw-w64 is not an option for us with > our current build pipeline, as we rely on mingw-builds currently. Any > change to the default would leave us in future with a toolchain unable to > build for mingw-w64. That is assuming you use an import not available on xp which we currently do not do. You should still get xp support as a result, note however already in tree we have def files with functions not available on xp Thus you are already in a semi broken state, the current standard from what I am seeing on the mailing list is if windows 10 has a function we are willing to define it in defs. We have branches for your specific use case of supporting some small amount of xp users. Jon_y spent a great amount of time managing the v5 branch, this is it's exact use case. The master branch should generally not support out of life products and move into the future. On Mon, Jun 12, 2017 at 7:05 PM, Riot wrote: > *sorry, I meant unable to build for win xp sp2 using mingw-w64. > > It's not a show stopper as that's a very small minority of our customers > who are affected, and they're already used to everyone else dropping > support for them - but it seems unnecessary to take away something that's > working fine, and removing which doesn't benefit anyone. > > On 12 June 2017 at 19:01, Riot wrote: > > > Haha, no - although I do work for a game company, I'd rather not say > which > > on-list. > > > > Am I mistaken in that the patch affects the CRT? In which case, defining > > _WIN32_WINNT would only be useful at the point of building mingw-w64 > itself > > - building and maintaining our own mingw-w64 is not an option for us with > > our current build pipeline, as we rely on mingw-builds currently. Any > > change to the default would leave us in future with a toolchain unable to > > build for mingw-w64. > > > > Regards, > > Riot > > > > On 12 June 2017 at 18:46, David Grayson wrote: > > > >> Riot, do you work for Riot Games? > >> > >> Anyway, in this patch, the line of code being changed is guarded by > >> #ifndef _WIN32_WINNT. So if you define _WIN32_WINNT yourself, this > >> patch will have no effect on you. (I'm assuming that the value of > >> _WIN32_WINNT does not affect how the MinGW libraries are compiled, and > >> it only affects what features are available in the header files.) > >> > >> --David > >> > >> On Mon, Jun 12, 2017 at 10:36 AM, Riot wrote: > >> > I'd like to humbly request a hold on this. > >> > > >> > If it's not broken, why fix it? > >> > > >> > I've been happy to be able to tell our customers that our software > >> works on > >> > win XP (SP2) for a long while; and I don't see anything that's changed > >> that > >> > should require us to end that support. When we surveyed last year, > >> several > >> > percent of our users still used XP, and we don't really want to leave > >> them > >> > out in the cold without good reason. Building our own mingw just to > >> > configure it with a lower default support version is out of the > question > >> > with our workflow, unfortunately. > >> > > >> > I don't see this as a constructive change, as it doesn't appear to > >> actually > >> > improve anything for anybody. Can we reconsider? > >> > > >> > > >> > Regards, > >> > Riot > >> > > >> > > >> > On 12 June 2017 at 18:02, Liu Hao wrote: > >> > > >> >> On 2017/6/12 23:17, Martell Malone wrote: > >> >> > >> >>> In that case, > >> >>> I think the best course of immediate action is to bump to Windows 7 > >> as Kai > >> >>> suggested. > >> >>> If someone has the time to implement a configure option for changing > >> this > >> >>> default like Ruben suggest that would be a great. > >> >>> Here is a patch for the former. > >> >>> Please Review > >> >>> > >> >>> diff --git a/mingw-w64-headers/crt/_mingw.h.in > >> b/mingw-w64-headers/crt/_ > >> >>> mingw.h.in > >> >>> index 2742b115..03de2212 100644 > >> >>> --- a/mingw-w64-headers/crt/_mingw.h.in > >> >>> +++ b/mingw-w64-headers/crt/_mingw.h.in > >> >>> @@ -222,7 +222,7 @@ limitations in handling dllimport attribute. */ > >> >>> #ifndef _WIN32_WINNT > >> >>> -#define _WIN32_WINNT 0x502 > >> >>> +#define _WIN32_WINNT 0x601 > >> >>> #endif > >> >>> #ifndef _INT128_DEFINED > >> >>> > >> >>> Upvote for this. OK for master? > >> >> > >> >> -- > >> >> Best regards, > >> >> LH_Mouse > >> >> > >> >> > >> >> > >> >> > >> >> -- > >> >> Check out the vibrant tech community on one of the world's most > >> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> >> ___ > >> >> Mingw-w64-public mailing list > >> >> Mingw-w64-public@lists.sourceforge.net > >> >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > >> >> > >> > ---
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
Hi, The implication of this change would be that you need a separate toolchain to target these OSes and 5.x is not going to be abandoned tomorrow, which gives you plenty of time. I've followed the support from browsers and FF 53 which is an ESR is the last browser to support XP. Since it's recent and ESR, support will last a few more months but that's about it. The possibility for you would be the aforementioned patch and default to something more recent to XP but still allow to target it. That's the moment you're welcome to do it and post it for review on the list. Targeting XP will not be supported but that's actually the current situation anyway since the majority of people here are not testing XP anymore. -- Adrien Nader -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
I figured this would be a good point to revive this discussion. LLVM/Clang progress for mingw-w64 has come on quite a lot since I brought this up. The last time we had an issue around libcxx needing 0x600 for c++ threads without winpthreads. Now libunwind is in the same situation. Martin has been working hard to get libunwind in shape for mingw-w64 but the locks also require 0x600. (This is the same api used in libc++) https://reviews.llvm.org/D38704 I thought FF 52 was the last version but https://support.mozilla.org/en-US/kb/end-support-windows-xp-and-vista Also it seems to be well past that time now anyway. https://www.mozilla.org/media/img/firefox/organizations/release-overview-high-res.78cf477dd915.png A little longer term I think with this transition we should also be able to create a new pthreads library using the same api's available after vista. This should give us room to have c11 threads and just wrap pthreads around this much like musl libc does. On Mon, Jun 12, 2017 at 7:18 PM, Adrien Nader wrote: > Hi, > > The implication of this change would be that you need a separate > toolchain to target these OSes and 5.x is not going to be abandoned > tomorrow, which gives you plenty of time. > > I've followed the support from browsers and FF 53 which is an ESR is the > last browser to support XP. Since it's recent and ESR, support will last > a few more months but that's about it. > > The possibility for you would be the aforementioned patch and default to > something more recent to XP but still allow to target it. That's the > moment you're welcome to do it and post it for review on the list. > Targeting XP will not be supported but that's actually the current > situation anyway since the majority of people here are not testing XP > anymore. > > -- > Adrien Nader > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
Hello, Could we keep XP for the 5.0 release and then drop it after? For VLC, we will keep XP compatibility for the next major release, in a few days, and then drop it totally. On Sun, 15 Oct 2017, at 11:21, Martell Malone wrote: > I figured this would be a good point to revive this discussion. > LLVM/Clang progress for mingw-w64 has come on quite a lot since I brought > this up. > > The last time we had an issue around libcxx needing 0x600 for c++ threads > without winpthreads. > Now libunwind is in the same situation. > > Martin has been working hard to get libunwind in shape for mingw-w64 but > the locks also require 0x600. > (This is the same api used in libc++) > https://reviews.llvm.org/D38704 > > I thought FF 52 was the last version but > https://support.mozilla.org/en-US/kb/end-support-windows-xp-and-vista > > Also it seems to be well past that time now anyway. > https://www.mozilla.org/media/img/firefox/organizations/release-overview-high-res.78cf477dd915.png > > > A little longer term > I think with this transition we should also be able to create a new > pthreads library using the same api's available after vista. > This should give us room to have c11 threads and just wrap pthreads > around > this much like musl libc does. > > > On Mon, Jun 12, 2017 at 7:18 PM, Adrien Nader wrote: > > > Hi, > > > > The implication of this change would be that you need a separate > > toolchain to target these OSes and 5.x is not going to be abandoned > > tomorrow, which gives you plenty of time. > > > > I've followed the support from browsers and FF 53 which is an ESR is the > > last browser to support XP. Since it's recent and ESR, support will last > > a few more months but that's about it. > > > > The possibility for you would be the aforementioned patch and default to > > something more recent to XP but still allow to target it. That's the > > moment you're welcome to do it and post it for review on the list. > > Targeting XP will not be supported but that's actually the current > > situation anyway since the majority of people here are not testing XP > > anymore. > > > > -- > > Adrien Nader > > > > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > Mingw-w64-public mailing list > > Mingw-w64-public@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public -- Jean-Baptiste Kempf - President +33 672 704 734 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?
The discussion is about master branch. 2017-10-16 4:53 GMT+02:00 Jean-Baptiste Kempf : > Hello, > > Could we keep XP for the 5.0 release and then drop it after? > > For VLC, we will keep XP compatibility for the next major release, in a > few days, and then drop it totally. > > On Sun, 15 Oct 2017, at 11:21, Martell Malone wrote: > > I figured this would be a good point to revive this discussion. > > LLVM/Clang progress for mingw-w64 has come on quite a lot since I brought > > this up. > > > > The last time we had an issue around libcxx needing 0x600 for c++ threads > > without winpthreads. > > Now libunwind is in the same situation. > > > > Martin has been working hard to get libunwind in shape for mingw-w64 but > > the locks also require 0x600. > > (This is the same api used in libc++) > > https://reviews.llvm.org/D38704 > > > > I thought FF 52 was the last version but > > https://support.mozilla.org/en-US/kb/end-support-windows-xp-and-vista > > > > Also it seems to be well past that time now anyway. > > https://www.mozilla.org/media/img/firefox/organizations/ > release-overview-high-res.78cf477dd915.png > > > > > > A little longer term > > I think with this transition we should also be able to create a new > > pthreads library using the same api's available after vista. > > This should give us room to have c11 threads and just wrap pthreads > > around > > this much like musl libc does. > > > > > > On Mon, Jun 12, 2017 at 7:18 PM, Adrien Nader wrote: > > > > > Hi, > > > > > > The implication of this change would be that you need a separate > > > toolchain to target these OSes and 5.x is not going to be abandoned > > > tomorrow, which gives you plenty of time. > > > > > > I've followed the support from browsers and FF 53 which is an ESR is > the > > > last browser to support XP. Since it's recent and ESR, support will > last > > > a few more months but that's about it. > > > > > > The possibility for you would be the aforementioned patch and default > to > > > something more recent to XP but still allow to target it. That's the > > > moment you're welcome to do it and post it for review on the list. > > > Targeting XP will not be supported but that's actually the current > > > situation anyway since the majority of people here are not testing XP > > > anymore. > > > > > > -- > > > Adrien Nader > > > > > > > > > -- > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > ___ > > > Mingw-w64-public mailing list > > > Mingw-w64-public@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ > > Mingw-w64-public mailing list > > Mingw-w64-public@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > -- > Jean-Baptiste Kempf - President > +33 672 704 734 > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
