Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On Mon, May 25, 2015 at 7:47 PM, İsmail Dönmez wrote: > Hi, > . > Noticed while trying to compile the application from > http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx . > > Patch attached. ping? -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On 05/28/15 11:06, İsmail Dönmez wrote: > On Mon, May 25, 2015 at 7:47 PM, İsmail Dönmez wrote: >> Hi, >> . >> Noticed while trying to compile the application from >> http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx . >> >> Patch attached. > ping? > Looks good to me. Thanks, Jacek -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On Thu, May 28, 2015 at 4:49 PM, Jacek Caban wrote: > On 05/28/15 11:06, İsmail Dönmez wrote: >> On Mon, May 25, 2015 at 7:47 PM, İsmail Dönmez wrote: >>> Hi, >>> . >>> Noticed while trying to compile the application from >>> http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx . >>> >>> Patch attached. >> ping? >> > > Looks good to me. Could you please apply it? Thanks! -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On 05/28/15 17:29, İsmail Dönmez wrote: > On Thu, May 28, 2015 at 4:49 PM, Jacek Caban wrote: >> On 05/28/15 11:06, İsmail Dönmez wrote: >>> On Mon, May 25, 2015 at 7:47 PM, İsmail Dönmez wrote: Hi, . Noticed while trying to compile the application from http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx . Patch attached. >>> ping? >>> >> Looks good to me. > Could you please apply it? Thanks! I committed the change, but I noticed that you modified winnt.h from widl directory. I removed that part because that's just an internal side effect of importing it from Wine. The one we care about is in mingw-w64-headers/include. Also, I can see that we already forked ddk fro ReactOS, but it would be nice to contribute the change to them. Cheers, Jacek -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On Thu, May 28, 2015 at 6:51 PM, Jacek Caban wrote: > On 05/28/15 17:29, İsmail Dönmez wrote: >> On Thu, May 28, 2015 at 4:49 PM, Jacek Caban wrote: >>> On 05/28/15 11:06, İsmail Dönmez wrote: On Mon, May 25, 2015 at 7:47 PM, İsmail Dönmez wrote: > Hi, > . > Noticed while trying to compile the application from > http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx . > > Patch attached. ping? >>> Looks good to me. >> Could you please apply it? Thanks! > > I committed the change, but I noticed that you modified winnt.h from > widl directory. I removed that part because that's just an internal side > effect of importing it from Wine. The one we care about is in > mingw-w64-headers/include. Thanks! > Also, I can see that we already forked ddk fro ReactOS, but it would be > nice to contribute the change to them. I'll send a patch to them too. ismail -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On Thu, May 28, 2015 at 6:51 PM, Jacek Caban wrote: > On 05/28/15 17:29, İsmail Dönmez wrote: >> On Thu, May 28, 2015 at 4:49 PM, Jacek Caban wrote: >>> On 05/28/15 11:06, İsmail Dönmez wrote: On Mon, May 25, 2015 at 7:47 PM, İsmail Dönmez wrote: > Hi, > . > Noticed while trying to compile the application from > http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx . > > Patch attached. ping? >>> Looks good to me. >> Could you please apply it? Thanks! > > I committed the change, but I noticed that you modified winnt.h from > widl directory. I removed that part because that's just an internal side > effect of importing it from Wine. The one we care about is in > mingw-w64-headers/include. Btw, without winnt.h change, I still cannot compile the example program from http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx so I think, it also should be applied. Regards, ismail -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On Thu, May 28, 2015 at 8:58 PM, İsmail Dönmez wrote: > On Thu, May 28, 2015 at 6:51 PM, Jacek Caban wrote: >> On 05/28/15 17:29, İsmail Dönmez wrote: >>> On Thu, May 28, 2015 at 4:49 PM, Jacek Caban wrote: On 05/28/15 11:06, İsmail Dönmez wrote: > On Mon, May 25, 2015 at 7:47 PM, İsmail Dönmez wrote: >> Hi, >> . >> Noticed while trying to compile the application from >> http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx . >> >> Patch attached. > ping? > Looks good to me. >>> Could you please apply it? Thanks! >> >> I committed the change, but I noticed that you modified winnt.h from >> widl directory. I removed that part because that's just an internal side >> effect of importing it from Wine. The one we care about is in >> mingw-w64-headers/include. > > Btw, without winnt.h change, I still cannot compile the example > program from > http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx > so I think, it also should be applied. Would you mind applying the winnt.h part too? I guess it wouldn't hurt to keep those definitions in sync. ismail -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
On 06/01/15 10:53, İsmail Dönmez wrote: > On Thu, May 28, 2015 at 8:58 PM, İsmail Dönmez wrote: >> On Thu, May 28, 2015 at 6:51 PM, Jacek Caban wrote: >>> >>> I committed the change, but I noticed that you modified winnt.h from >>> widl directory. I removed that part because that's just an internal side >>> effect of importing it from Wine. The one we care about is in >>> mingw-w64-headers/include. >> Btw, without winnt.h change, I still cannot compile the example >> program from >> http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx >> so I think, it also should be applied. > Would you mind applying the winnt.h part too? I guess it wouldn't hurt > to keep those definitions in sync. As I said, winnt.h from widl directory is not meant to be used to build anything with mingw-w64 except internal widl usage. Please prepare and test a patch for mingw-w64-header/include/winnt.h. Thanks, Jacek -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add some missing IMAGE_DLLCHARACTERISTICS_* constants
Hi, On Mon, Jun 1, 2015 at 12:25 PM, Jacek Caban wrote: > On 06/01/15 10:53, İsmail Dönmez wrote: >> On Thu, May 28, 2015 at 8:58 PM, İsmail Dönmez wrote: >>> On Thu, May 28, 2015 at 6:51 PM, Jacek Caban wrote: I committed the change, but I noticed that you modified winnt.h from widl directory. I removed that part because that's just an internal side effect of importing it from Wine. The one we care about is in mingw-w64-headers/include. >>> Btw, without winnt.h change, I still cannot compile the example >>> program from >>> http://blogs.msdn.com/b/oldnewthing/archive/2015/05/18/10615339.aspx >>> so I think, it also should be applied. >> Would you mind applying the winnt.h part too? I guess it wouldn't hurt >> to keep those definitions in sync. > > As I said, winnt.h from widl directory is not meant to be used to build > anything with mingw-w64 except internal widl usage. Please prepare and > test a patch for mingw-w64-header/include/winnt.h. Now I get it, please see the attached patch. diff --git a/mingw-w64-headers/include/winnt.h b/mingw-w64-headers/include/winnt.h index bfecb7b..8d8bd0d 100644 --- a/mingw-w64-headers/include/winnt.h +++ b/mingw-w64-headers/include/winnt.h @@ -5878,6 +5878,7 @@ __buildmemorybarrier() #define IMAGE_SUBSYSTEM_XBOX 14 #define IMAGE_SUBSYSTEM_WINDOWS_BOOT_APPLICATION 16 +#define IMAGE_DLLCHARACTERISTICS_HIGH_ENTROPY_VA 0x0020 #define IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE 0x0040 #define IMAGE_DLLCHARACTERISTICS_FORCE_INTEGRITY 0x0080 #define IMAGE_DLLCHARACTERISTICS_NX_COMPAT 0x0100 @@ -5886,6 +5887,7 @@ __buildmemorybarrier() #define IMAGE_DLLCHARACTERISTICS_NO_BIND 0x0800 #define IMAGE_DLLCHARACTERISTICS_APPCONTAINER 0x1000 #define IMAGE_DLLCHARACTERISTICS_WDM_DRIVER 0x2000 +#define IMAGE_DLLCHARACTERISTICS_GUARD_CF 0x4000 #define IMAGE_DLLCHARACTERISTICS_TERMINAL_SERVER_AWARE 0x8000 #define IMAGE_DIRECTORY_ENTRY_EXPORT 0 -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
