Re: [Mingw-w64-public] [PATCH] winpthreads: Check GetModuleHandle return value before calling GetProcAddress
On Thu, 9 Nov 2023, LIU Hao wrote: 在 2023-11-09 21:27, Martin Storsjö 写道: On Tue, 31 Oct 2023, Martin Storsjö wrote: In Windows Store builds with the winstorecompat library, GetModuleHandle returns null, and GetProcAddress is not documented to allow passing null. Signed-off-by: Martin Storsjö --- mingw-w64-libraries/winpthreads/src/clock.c | 8 +--- mingw-w64-libraries/winpthreads/src/misc.c | 4 +++- mingw-w64-libraries/winpthreads/src/thread.c | 6 -- 3 files changed, 12 insertions(+), 6 deletions(-) Ping This patch looks good to me. Sorry for overlooking. Thanks, pushed now, and no problem - there wasn't any rush about this. // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] winpthreads: Check GetModuleHandle return value before calling GetProcAddress
在 2023-11-09 21:27, Martin Storsjö 写道: On Tue, 31 Oct 2023, Martin Storsjö wrote: In Windows Store builds with the winstorecompat library, GetModuleHandle returns null, and GetProcAddress is not documented to allow passing null. Signed-off-by: Martin Storsjö --- mingw-w64-libraries/winpthreads/src/clock.c | 8 +--- mingw-w64-libraries/winpthreads/src/misc.c | 4 +++- mingw-w64-libraries/winpthreads/src/thread.c | 6 -- 3 files changed, 12 insertions(+), 6 deletions(-) Ping This patch looks good to me. Sorry for overlooking. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] winpthreads: Check GetModuleHandle return value before calling GetProcAddress
On Tue, 31 Oct 2023, Martin Storsjö wrote: In Windows Store builds with the winstorecompat library, GetModuleHandle returns null, and GetProcAddress is not documented to allow passing null. Signed-off-by: Martin Storsjö --- mingw-w64-libraries/winpthreads/src/clock.c | 8 +--- mingw-w64-libraries/winpthreads/src/misc.c | 4 +++- mingw-w64-libraries/winpthreads/src/thread.c | 6 -- 3 files changed, 12 insertions(+), 6 deletions(-) Ping // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public