Re: '[[' regression in R59

2020-05-07 Thread Martijn Dekker

Op 05-05-20 om 22:35 schreef Thorsten Glaser:

Martijn Dekker dixit:


As of mksh-R59 there is a regression in glob pattern matching with '[['.


Thanks, fixed.


Verified. :)


I’m too tired to release R59b tonight, so if you have got any other
bugs/regressions to go into it before I do so tomorrow or so… do tell.
You seem to have more weird-corner-case test coverage than I do.


Nope, all my other tests pass.

- M.

--
modernish -- harness the shell
https://github.com/modernish/modernish


Re: '[[' regression in R59

2020-05-05 Thread Thorsten Glaser
Martijn Dekker dixit:

> As of mksh-R59 there is a regression in glob pattern matching with '[['.

Thanks, fixed.

I’m too tired to release R59b tonight, so if you have got any other
bugs/regressions to go into it before I do so tomorrow or so… do tell.
You seem to have more weird-corner-case test coverage than I do.

Stay safe,
//mirabilos
-- 
21:49⎜ I have a question guys,
 ⎜Can I use my PC as SMTP server, I use Windows 7 .
 ⎜Already googled and Installed IIS
 ⎜but Still I can't send E-mail


'[[' regression in R59

2020-05-04 Thread Martijn Dekker
As of mksh-R59 there is a regression in glob pattern matching with '[['. 
Backslash-escaping of a * passed from a variable appears to be ignored.


$ mksh-R58 -c 'v=a\\*e; [[ abcde == $v ]]';echo $?
1
$ mksh-R59 -c 'v=a\\*e; [[ abcde == $v ]]';echo $?
0   <== bug

ksh93, bash, yash and zsh all behave like mksh R58 and earlier.

Testing the git repo revealed the regression was introduced by this commit:

| commit 24e61ee166cf50c7c1fcaf58d7393b2e6e557c93
| Author: tg 
| Date:   Tue Apr 7 23:14:44 2020 +
|
| implement full extglob pattern matching on [[ x = $y ]] RHS
|
| eliminates some eval and brings us closer to ksh93

--
modernish -- harness the shell
https://github.com/modernish/modernish