Re: my first patch

2023-11-04 Thread Chris Bennett
On Wed, Oct 25, 2023 at 10:10:32AM +0600, Maria Morisot wrote:
> 
> > that you're using correct lengths though, it is possible to get things
> > wrong and break programs.
> 
> I was careful to look at the buffer lengths being written and to match them 
> in strlcpy and snprintf. I peeked at the source for instances of strcpy and 
> found a lot in xenocara; less in the main source tree.
> 
> I'm willing to change these but I need to know how to submit the altered 
> files and since it's my first time contributing, I'd love if someone could 
> double check a bit of my work.
> 

I think that the explanation of what you are doing and trying to
accomplish was a little bit unclear from the responses you got.

Upstream means sending your work "up" to the programmers elsewhere who
are creating and developing the program.

This can allow, if they want to and it doesn't cause problems with other
OS's, your changes to be incorporated into the software. This doesn't
have anything to do with OpenBSD, except that it will make porting the
program into being usable with OpenBSD different. (See ports on the
website and the po...@openbsd.org mailing list).

So, there is a big difference between changing the original program to
work better with OpenBSD or porting it in.
Porting in a program means adapting it, possibly with patches that make
the changes *only* for OpenBSD.

So, Libreoffice isn't an OpenBSD program. Certain patches or changes
shouldn't be done locally unless upstream refuses your change.
Then, that program will be ported in officially, just marked as broken
or dropped as a program for OpenBSD.

A really good and simple example is an error in a man page. That sort of
change should always be sent upstream first. If they refuse to accept
that change, then patch it here.

If some flags for our compiler are different, then that is a local
adaptation *for OpenBSD*. Do that here and don't bother upstream unless
you have questions.

Updating programs that are ported in can sometimes be quite difficult
when the version changes. That is what Stuart meant about having a
nightmare when changing the local copy for us in the way you are doing
it.

Also, even if everything you have done is 100% perfect, don't be
disappointed if your work isn't accepted. Just learn from it and start a
new project. OpenBSD has extremely picky and overworked developers.
Which is probably why I sleep well at night knowing I have an excellent
and secure OS. They do amazingly good work!

So even if your first ten tries at different things fail, by the time of
your eleventh, you will probably be getting it right by then.

Enjoy!
-- 
Chris Bennett



Three more orphan packages

2023-11-04 Thread Daniele B.


Hello,

Just found these orphan packages:

fcitx-table-extra-5.0.9p0
monitoring-plugins-2.3.3p0
monitoring-plugins-mysql-2.3.3

all not uninstalled both by uninstalling their parent package
and by a 'pkg_delete -a'.


== Daniele Bonini



Re: The Book of PF: Physical copies to be available again soon

2023-11-04 Thread Peter N. M. Hansteen
On Sat, Nov 04, 2023 at 10:52:01AM -0400, Jay Hart wrote:
> 
> Peter,
> 
> Any plans to update it?

Questions of the type

"Are you working on a new edition of your book about ?"

or the more general

"Are you working on a book about ?"

or even

"When is your next book coming out?"

are never going to be answered truthfully, or at all, by any writer or
publisher unless a definite publication date has been set and they are
confident that all the myriad factors that determine the outcome of
the project are firmly under control.

If the real question is,

"Would it be safe for me to start writing a PF book?"

My answer is no. There is no guarantee that the effort you put in will
give satisfactory-to-you returns in any form or fashion. Writing is a
time sink and publishers may or may not be interested.

On the other hand if you are asking,

"Should I start writing a book on PF or a related subject?",

my take is, please do, if you feel that it is a thing worth doing.

But again, keep in mind that writing a book and getting it published
will eat up several significantly more than bite-sized chunks of your
time, but if you feel that your book needs to be written, please go
ahead.

The reason The Book of PF exists is that I had a general idea of what
kind of PF book I would like to see existing, and a work in progress
manuscript existed that I showed to anyone interested. Fortunately
enough people relevant to getting the book actually published (and
revised twice so far) agreed that this book needed to happen.

When I get to the point that a new edition of The Book of PF or any
other book relevant to OpenBSD that I am able to write is certain to
be published at a specific time, this mailing list will be one of the
first public forums that will receive notification.

That much I will promise.

All the best,
Peter

-- 
Peter N. M. Hansteen, member of the first RFC 1149 implementation team
https://bsdly.blogspot.com/ https://www.bsdly.net/ https://www.nuug.no/
"Remember to set the evil bit on all malicious network traffic"
delilah spamd[29949]: 85.152.224.147: disconnected after 42673 seconds.



Re: The Book of PF: Physical copies to be available again soon

2023-11-04 Thread Jay Hart


Peter,

Any plans to update it?

R/,

Jay

> For those interested in physical copies of The Book of PF 
> (https://nostarch.com/pf3)
> -- it has been out of print, only available in electronic formats for a while 
> --
> I just got word from No Starch Press (the publisher) that they are expecting 
> to
> have a fresh batch arriving at their warehouse within the next few weeks.
>
> I will share any details with those interested when I have them.
>
> All the best,
> Peter
>
> --
> Peter N. M. Hansteen, member of the first RFC 1149 implementation team
> https://bsdly.blogspot.com/ https://www.bsdly.net/ https://www.nuug.no/
> "Remember to set the evil bit on all malicious network traffic"
> delilah spamd[29949]: 85.152.224.147: disconnected after 42673 seconds.
>
>