Re: VMD linux/debian cdrom issue
Martijn van Duren wrote: > (…) > I worked around this by bootstrapping the disk via the qemu port and > booting the disk from vmm once it's finally done. Qemu is significantly > slower than vmm, so do get another cup of $BEVERAGE. > (…) Another option is to grab https://cdimage.debian.org/cdimage/openstack/current/debian-9.5.2-20180809-openstack-amd64.raw It does not have a premade account so you need to add your ssh public key where it belongs. Boot it via vmd, let the autosetup thing die from timeout. Connect via ssh, uninstall all software related to the autosetup thing (I do not remember the name, but if you watch the first boot, you will have some clue) Reboot the vm. To add a ssh key, I did not succeed in mounting the file via vnconfig, not sure whether it is doable or not so I used a Debian system I had access to. On the linux host: # losetup /dev/loop0 debian-9.5.2-20180809-openstack-amd64.raw # kpartx -a /dev/loop0 # mount /dev/mapper/loop0p1 /tmp/vmdisk/ ### the moment you add your ssh public key. # umount /dev/mapper/loop0p1 # kpartx -d /dev/loop0 # losetup -d /dev/loop0 Hope it helps as well.
Re: pf - NAT not working after systemboot
> But how can I address this ? > The system should come up by itself without any manual interaction. Just a workaround but adding pfctl -f /etc/pf.conf to /etc/rc.local might help.
xenodm-config.in cleanup
Hello As Xreset.in and Xstartup.in went in the Attic two days ago, I think the following makes sense as well: Index: xenocara/app/xenodm/config/xenodm-config.in === RCS file: /cvs/xenocara/app/xenodm/config/xenodm-config.in,v retrieving revision 1.4 diff -u -p -r1.4 xenodm-config.in --- xenocara/app/xenodm/config/xenodm-config.in 5 Sep 2017 17:48:07 - 1.4 +++ xenocara/app/xenodm/config/xenodm-config.in 14 Jul 2018 09:51:25 - @@ -10,9 +10,7 @@ DisplayManager*resources: @XENODMCONFIGD ! individual resource settings. DisplayManager*authorize: true ! -DisplayManager*startup:@XENODMSCRIPTDIR@/Xstartup DisplayManager*session:@XENODMSCRIPTDIR@/Xsession -DisplayManager*reset: @XENODMSCRIPTDIR@/Xreset DisplayManager*authComplain: true ! The following three resources set up display :0 as the console. DisplayManager._0.setup: @XENODMSCRIPTDIR@/Xsetup_0
Re: i915 witness log
Ingo Feinerer wrote: > with > > $ sysctl kern.version > kern.version=OpenBSD 6.3-current (GENERIC.MP) #88: Wed Jun 6 20:07:00 MDT > 2018 > dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP > > I observe following messages (…) Not exactly the same message but also somewhat i915 related with a snapshot one day older than yours : sysctl kern.version kern.version=OpenBSD 6.3-current (GENERIC.MP) #84: Tue Jun 5 19:22:09 MDT 2018 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP lock order reversal: 1st 0x81da5108 &sched_lock (&sched_lock) @ /usr/src/sys/kern/kern_synch.c:444 2nd 0x800ff9f0 &dev_priv->uncore.lock (&dev_priv->uncore.lock) @ /usr/src/sys/dev/pci/drm/i915/intel_uncore.c:811 lock order "&dev_priv->uncore.lock"(mutex) -> "&sched_lock"(sched_lock) first seen at: #0 witness_checkorder+0x4b4 #1 ___mp_lock+0x70 #2 schedclock+0x30 #3 hardclock+0xe3 #4 lapic_clockintr+0x3d #5 Xresume_lapic_ltimer+0x22 #6 gen6_write32+0x120 #7 ironlake_irq_handler+0x7e #8 intr_handler+0x74 #9 Xintr_ioapic_edge16_untramp+0x13d #10 acpicpu_idle+0x166 #11 cpu_idle_cycle+0x10 lock order "&sched_lock"(sched_lock) -> "&dev_priv->uncore.lock"(mutex) first seen at: #0 witness_checkorder+0x4b4 #1 _mtx_enter+0x31 #2 gen6_read32+0x8f #3 gen6_ring_get_seqno+0x3a #4 __i915_wait_request+0x232 #5 i915_gem_object_wait_rendering__nonblocking+0x1d6 #6 i915_gem_set_domain_ioctl+0xdb #7 drm_do_ioctl+0x221 #8 drmioctl+0xf9 #9 VOP_IOCTL+0x5a #10 vn_ioctl+0x6b #11 sys_ioctl+0x457 #12 syscall+0x32a #13 Xsyscall_untramp+0xc0 lock order reversal: 1st 0x81da5108 &sched_lock (&sched_lock) @ /usr/src/sys/kern/kern_synch.c:444 2nd 0x80106270 &dev_priv->irq_lock (&dev_priv->irq_lock) @ /usr/src/sys/dev/pci/drm/i915/intel_ringbuffer.c:1787 lock order "&dev_priv->irq_lock"(mutex) -> "&sched_lock"(sched_lock) first seen at: #0 witness_checkorder+0x4b4 #1 ___mp_lock+0x70 #2 wakeup_n+0x39 #3 task_add+0x93 #4 gen6_rps_boost+0x129 #5 __i915_wait_request+0x155 #6 i915_gem_object_wait_rendering__nonblocking+0x1d6 #7 i915_gem_set_domain_ioctl+0xdb #8 drm_do_ioctl+0x221 #9 drmioctl+0xf9 #10 VOP_IOCTL+0x5a #11 vn_ioctl+0x6b #12 sys_ioctl+0x457 #13 syscall+0x32a #14 Xsyscall_untramp+0xc0 lock order "&sched_lock"(sched_lock) -> "&dev_priv->irq_lock"(mutex) first seen at: #0 witness_checkorder+0x4b4 #1 _mtx_enter+0x31 #2 gen6_ring_put_irq+0x36 #3 __i915_wait_request+0x367 #4 i915_gem_object_wait_rendering__nonblocking+0x1d6 #5 i915_gem_set_domain_ioctl+0xdb #6 drm_do_ioctl+0x221 #7 drmioctl+0xf9 #8 VOP_IOCTL+0x5a #9 vn_ioctl+0x6b #10 sys_ioctl+0x457 #11 syscall+0x32a #12 Xsyscall_untramp+0xc0 on OpenBSD 6.3-current (GENERIC.MP) #84: Tue Jun 5 19:22:09 MDT 2018 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 8451125248 (8059MB) avail mem = 8117297152 (7741MB) mpath0 at root scsibus0 at mpath0: 256 targets mainbus0 at root bios0 at mainbus0: SMBIOS rev. 2.6 @ 0xdae9c000 (64 entries) bios0: vendor LENOVO version "8DET70WW (1.40 )" date 05/14/2015 bios0: LENOVO 42919Y5 acpi0 at bios0: rev 2 acpi0: sleep states S0 S3 S4 S5 acpi0: tables DSDT FACP SLIC SSDT SSDT SSDT HPET APIC MCFG ECDT ASF! TCPA SSDT SSDT DMAR UEFI UEFI UEFI acpi0: wakeup devices LID_(S3) SLPB(S3) IGBE(S4) EXP4(S4) EXP7(S4) EHC1(S3) EHC2(S3) HDEF(S4) acpitimer0 at acpi0: 3579545 Hz, 24 bits acpihpet0 at acpi0: 14318179 Hz acpimadt0 at acpi0 addr 0xfee0: PC-AT compat cpu0 at mainbus0: apid 0 (boot processor) cpu0: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 797.55 MHz cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN cpu0: 256KB 64b/line 8-way L2 cache cpu0: smt 0, core 0, package 0 mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges using xsaveopt cpu0: apic clock running at 99MHz cpu0: mwait min=64, max=64, C-substates=0.2.1.1.2, IBE cpu1 at mainbus0: apid 1 (application processor) cpu1: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 797.42 MHz cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN cpu1: 256KB 64b/line 8-way L2 cache cpu1: smt 1, core 0, package 0 cpu2 at mainbus0: apid 2 (application processor) cpu2: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 797.42 MHz cpu2: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEAD
Re: Lenovo T60p touchpad not working (6.2-stable/amd64)
Riccardo Mottola wrote: > If I may ask, does screen brightness work for you? I have a dim > setting and can't change it with the keyboard blue keys, but. > > I also tried xbacklight > > $ xbacklight > No outputs have backlight property > > > So... I'm stuck with something that is too dim with normal office > lightning and too bright for an evening hack :) Did you try to set wsconsctl display.brightness ? -- Regards, Julien
Re: [cwm] Can't move snaped window
Ve Telko wrote: > > Hello all, > Hello > window in cwm -current snapped to screen edge can not be moved using > keyboard shortcuts. Is this a feature or bug? :) What about a moveamount bigger than the snapdist ? -- Julien
Re: suckless st on OpenBSD62
Frederic Fichter wrote: > Hello all, > Hello > My $HOME/.profile has only one line in it: > export ENV=$HOME/.kshrc > > And I set some variables in my $HOME/.kshrc > > Now, everything's cool in xterm (i.e. variables are set) - but that's not the > case in st, when I launch st from dmenu. > If I launch st from xterm, variables are set as well. > > Where should I look for an explanation? I don't know your setup, here using Xenodm autologin I can reproduce that only if I don't source ~/.profile in ~/.xsession. Regards, Julien
[cwm] poponbell support
Hi, all the best for 2018 !
XTerm already has it but this duty IMO belongs to the WM.
To test, add "pop yes" to ~/.cwmrc and restart cwm.
Index: calmwm.h
===
RCS file: /cvs/xenocara/app/cwm/calmwm.h,v
retrieving revision 1.351
diff -u -p -r1.351 calmwm.h
--- calmwm.h29 Dec 2017 20:03:46 - 1.351
+++ calmwm.h1 Jan 2018 12:30:09 -
@@ -284,6 +284,7 @@ struct conf {
struct wm_q wmq;
int ngroups;
int stickygroups;
+ int poponbell;
int nameqlen;
int bwidth;
int mamount;
Index: client.c
===
RCS file: /cvs/xenocara/app/cwm/client.c,v
retrieving revision 1.244
diff -u -p -r1.244 client.c
--- client.c29 Dec 2017 18:50:43 - 1.244
+++ client.c1 Jan 2018 12:30:09 -
@@ -554,6 +554,8 @@ client_urgency(struct client_ctx *cc)
{
if (!(cc->flags & CLIENT_ACTIVE))
cc->flags |= CLIENT_URGENCY;
+ if (Conf.poponbell)
+ client_show(cc);
}
void
Index: conf.c
===
RCS file: /cvs/xenocara/app/cwm/conf.c,v
retrieving revision 1.237
diff -u -p -r1.237 conf.c
--- conf.c 29 Dec 2017 20:03:46 - 1.237
+++ conf.c 1 Jan 2018 12:30:09 -
@@ -288,6 +288,7 @@ conf_init(struct conf *c)
unsigned inti;
c->stickygroups = 0;
+ c->poponbell = 0;
c->bwidth = 1;
c->mamount = 1;
c->snapdist = 0;
Index: cwmrc.5
===
RCS file: /cvs/xenocara/app/cwm/cwmrc.5,v
retrieving revision 1.70
diff -u -p -r1.70 cwmrc.5
--- cwmrc.5 29 Dec 2017 20:03:46 - 1.70
+++ cwmrc.5 1 Jan 2018 12:30:09 -
@@ -217,6 +217,10 @@ Set a default size for the keyboard move
in pixels.
The default is 1.
.Pp
+.It Ic pop Ic yes Ns \&| Ns Ic no
+Toggle poponbell.
+When enabled, the window in which a bell rings is shown even if it was hidden.
+.Pp
.It Ic snapdist Ar pixels
Minimum distance to snap-to adjacent edge, in pixels.
The default is 0.
Index: parse.y
===
RCS file: /cvs/xenocara/app/cwm/parse.y,v
retrieving revision 1.69
diff -u -p -r1.69 parse.y
--- parse.y 29 Dec 2017 20:03:46 - 1.69
+++ parse.y 1 Jan 2018 12:30:09 -
@@ -69,7 +69,7 @@ typedef struct {
%}
%token BINDKEY UNBINDKEY BINDMOUSE UNBINDMOUSE
-%token FONTNAME STICKY GAP
+%token FONTNAME POP STICKY GAP
%token AUTOGROUP COMMAND IGNORE WM
%token YES NO BORDERWIDTH MOVEAMOUNT
%token COLOR SNAPDIST
@@ -112,6 +112,9 @@ main: FONTNAME STRING {
free(conf->font);
conf->font = $2;
}
+ | POP yesno {
+ conf->poponbell = $2;
+ }
| STICKY yesno {
conf->stickygroups = $2;
}
@@ -320,6 +323,7 @@ lookup(char *s)
{ "menufg", MENUFG},
{ "moveamount", MOVEAMOUNT},
{ "no", NO},
+ { "pop",POP},
{ "selfont",FONTSELCOLOR},
{ "snapdist", SNAPDIST},
{ "sticky", STICKY},
--
Regards,
Julien
Re: PATCH: cwm move window to {top,bottom}{left,right} corners
Okan Demirmen wrote: > A rough cut (no manpage bits yet) would be something like the below; it > allows one to "snap" to any edge or corner. Tested and approved, thanks. See a proposal for cwmrc.5 below. I don't have idea for default keybindings so I didn't touch cwm.1 > Incidentally, I dislike we used up/down/left/right from the beginning, > not sure of the trouble changing to all to cardinal directions or not... Well, it depends on how much you dislike it … It would break everyone's ~/.cwmrc all of a sudden. Index: cwmrc.5 === RCS file: /cvs/xenocara/app/cwm/cwmrc.5,v retrieving revision 1.68 diff -u -p -r1.68 cwmrc.5 --- cwmrc.5 6 Jul 2017 17:09:17 - 1.68 +++ cwmrc.5 4 Dec 2017 20:08:50 - @@ -334,6 +334,8 @@ Other windows in its group share remaini Move current window. .It window-resize Resize current window. +.It window-snap +Snap current window to edge or corner of the screen .It window-move-up Move window .Ar moveamount @@ -398,6 +400,22 @@ pixels right. Resize window 10 times .Ar moveamount pixels left. +.It window-snap-up +Snap window to top edge +.It window-snap-down +Snap window to bottom edge +.It window-snap-right +Snap window to right edge +.It window-snap-left +Snap window to left edge +.It window-snap-up-right +Snap window to top-right corner +.It window-snap-up-left +Snap window to top-left corner +.It window-snap-down-right +Snap window to bottom-right corner +.It window-snap-down-left +Snap window to bottom-left corner .It pointer-move-up Move pointer .Ar moveamount
Re: PATCH: cwm move window to {top,bottom}{left,right} corners
A long time ago sent Dimitris Papastamos a patch to misc which
let one send X clients to corners.[0]
I think it is useful so thank you Dimitris!
With some minor editing it still builds on current.
I have no use of window-move-{up,down,right,left}{,-big} but X client
corner warping is done on a regular basis.
At the time it did not receive the attention it (IMO) deserves.
Maybe was it because "feature" was written on the first line? ;)
I know featuritis is considered a disease around here and
I'm happy it is but here is an updated version anyway.
This version lacks the keybindings from the initial patch,
it also lacks for now a change in the man pages.
I use it with the following in ~/.cwmrc:
bind-key 4S-Leftwindow-movebottomleft
bind-key 4S-Right window-movebottomright
bind-key 4S-XF86Backwindow-movetopleft
bind-key 4S-XF86Forward window-movetopright
I know these are not standards keys found on every keyboard,
but Thinkpads are not exotic beasts in this land so it might
be an helpful start to some of you and every declinaison of h j k l
was already in use in the default config.
OK?
[0] https://marc.info/?l=openbsd-misc&m=140344759017419&w=2
Index: calmwm.h
===
RCS file: /cvs/xenocara/app/cwm/calmwm.h,v
retrieving revision 1.341
diff -u -p -r1.341 calmwm.h
--- calmwm.h14 Jul 2017 17:23:38 - 1.341
+++ calmwm.h22 Nov 2017 19:21:47 -
@@ -54,6 +54,10 @@
#define CWM_DOWN 0x0002
#define CWM_LEFT 0x0004
#define CWM_RIGHT 0x0008
+#define CWM_TOP_LEFT0x0100
+#define CWM_BOTTOM_LEFT 0x0200
+#define CWM_TOP_RIGHT 0x0400
+#define CWM_BOTTOM_RIGHT 0x0800
#define CWM_BIGAMOUNT 0x0010
#define DIRECTIONMASK (CWM_UP | CWM_DOWN | CWM_LEFT | CWM_RIGHT)
@@ -476,6 +480,7 @@ void
kbfunc_client_toggle_hmaximize(v
voidkbfunc_client_toggle_vmaximize(void *, struct cargs *);
voidkbfunc_client_htile(void *, struct cargs *);
voidkbfunc_client_vtile(void *, struct cargs *);
+voidkbfunc_client_move_edge(void *, struct cargs *);
voidkbfunc_client_cycle(void *, struct cargs *);
voidkbfunc_client_toggle_group(void *, struct cargs *);
voidkbfunc_client_movetogroup(void *, struct cargs *);
Index: conf.c
===
RCS file: /cvs/xenocara/app/cwm/conf.c,v
retrieving revision 1.233
diff -u -p -r1.233 conf.c
--- conf.c 14 Jul 2017 17:23:38 - 1.233
+++ conf.c 22 Nov 2017 19:21:48 -
@@ -67,6 +67,14 @@ static const struct {
{ "window-delete", kbfunc_client_delete, CWM_CONTEXT_CC, 0 },
{ "window-htile", kbfunc_client_htile, CWM_CONTEXT_CC, 0 },
{ "window-vtile", kbfunc_client_vtile, CWM_CONTEXT_CC, 0 },
+ { "window-movetopleft", kbfunc_client_move_edge, CWM_CONTEXT_CC,
+ (CWM_TOP_LEFT) },
+ { "window-movebottomleft", kbfunc_client_move_edge, CWM_CONTEXT_CC,
+ (CWM_BOTTOM_LEFT) },
+ { "window-movetopright", kbfunc_client_move_edge, CWM_CONTEXT_CC,
+ (CWM_TOP_RIGHT) },
+ { "window-movebottomright", kbfunc_client_move_edge, CWM_CONTEXT_CC,
+ (CWM_BOTTOM_RIGHT) },
{ "window-stick", kbfunc_client_toggle_sticky, CWM_CONTEXT_CC, 0 },
{ "window-fullscreen", kbfunc_client_toggle_fullscreen, CWM_CONTEXT_CC,
0 },
{ "window-maximize", kbfunc_client_toggle_maximize, CWM_CONTEXT_CC, 0 },
@@ -666,6 +674,51 @@ conf_grab_mouse(Window win)
BUTTONMASK, GrabModeAsync, GrabModeSync,
None, None);
}
+ }
+}
+
+void
+kbfunc_client_move_edge(void *ctx, struct cargs *cargs)
+{
+ struct client_ctx *cc = ctx;
+ struct screen_ctx *sc = cc->sc;
+ struct geom xine;
+ int flags;
+
+ /*
+* pick screen that the middle of the window is on.
+* that's probably more fair than if just the origin of
+* a window is poking over a boundary
+*/
+ xine = screen_area(sc,
+ cc->geom.x + cc->geom.w / 2,
+ cc->geom.y + cc->geom.h / 2, CWM_GAP);
+
+ flags = cargs->flag;
+
+ switch (flags) {
+ case CWM_TOP_LEFT:
+cc->geom.x = xine.x;
+cc->geom.y = xine.y;
+client_move(cc);
+break;
+ case CWM_BOTTOM_LEFT:
+cc->geom.x = xine.x;
+cc->geom.y = xine.y + xine.h - cc->geom.h - cc->bwidth * 2;
+client_move(cc);
+break;
+ case CWM_TOP_RIGHT:
+cc->geom.x = xine.x + xine.w - cc->geom.w - cc->bwidth * 2;
+cc->geom.y = xi
[www] fix a link
The link is leading to group.8, let it lead to group.5 Index: faq/faq10.html === RCS file: /cvs/www/faq/faq10.html,v retrieving revision 1.273 diff -u -p -r1.273 faq10.html --- faq/faq10.html 13 Oct 2017 23:21:43 - 1.273 +++ faq/faq10.html 20 Nov 2017 21:46:41 - @@ -650,7 +650,7 @@ The most common use cases include: For details on selective group inclusion, see -https://man.openbsd.org/group";>group(5). +https://man.openbsd.org/group.5";>group(5).
Re: [cwm] ability to autogroup kbfunc_menu_ssh clients
Please disregard previous mail: https://marc.info/?l=openbsd-misc&m=151000897902424&w=2 The patch in there would break any terminal emulator which does not use "-class" to set a class. Rereading the man page, I now see it is easy to achieve the same behaviour from ~/.cwmrc: command term"xterm -class Ssh" and override the binding with bind-key CM-Return xterm so that every single terminal emulator spawned via the default shortcut does not get a 'Ssh' class Sorry for the noise.
[cwm] ability to autogroup kbfunc_menu_ssh clients
Hello, I'm a heavy autogroup user and this is how I let clients
launched with kbfunc_menu_ssh comply with autogroup rules.
I'd love that or any other way to autogroup kbfunc_menu_ssh clients
to go mainline.
Regards,
Julien
Index: kbfunc.c
===
RCS file: /cvs/xenocara/app/cwm/kbfunc.c,v
retrieving revision 1.149
diff -u -p -r1.149 kbfunc.c
--- kbfunc.c14 Jul 2017 18:01:46 - 1.149
+++ kbfunc.c6 Nov 2017 20:05:49 -
@@ -646,7 +646,8 @@ menu:
search_match_text, search_print_text)) != NULL) {
if (mi->text[0] == '\0')
goto out;
- l = snprintf(path, sizeof(path), "%s -T '[ssh] %s' -e ssh %s",
+ l = snprintf(path, sizeof(path),
+ "%s -class 'Ssh' -T '[ssh] %s' -e ssh %s",
cmd->path, mi->text, mi->text);
if (l == -1 || l >= sizeof(path))
goto out;
[cwm] list all available items
Hello !
Using cwm and loving it, Thank you Okan and all devs before you
who got involved in the development. Just minor things
I'd change from the defaults. Here is one:
When using a menu, I much more often than not hit ^a to list
all available items, especially when calling kbfunc_menu_client
and I'm sure I'm not the only one.
The following patch inverts the default behavior, giving instant feedback
as soon a menu is launched, with all available items being listed.
On the first keystroke, the behavior is back to what it was
before this patch.
Regards,
Julien
Index: cwm.1
===
RCS file: /cvs/xenocara/app/cwm/cwm.1,v
retrieving revision 1.58
diff -u -p -r1.58 cwm.1
--- cwm.1 21 Jul 2017 15:55:37 - 1.58
+++ cwm.1 6 Nov 2017 20:17:14 -
@@ -179,8 +179,6 @@ Previous item.
Backspace.
.It Ic C-u
Clear input.
-.It Ic C-a
-List all available items.
.It Ic [Esc]
Cancel.
.El
Index: menu.c
===
RCS file: /cvs/xenocara/app/cwm/menu.c,v
retrieving revision 1.102
diff -u -p -r1.102 menu.c
--- menu.c 25 Apr 2017 12:08:05 - 1.102
+++ menu.c 6 Nov 2017 20:17:14 -
@@ -40,7 +40,7 @@
enum ctltype {
CTL_NONE = -1,
CTL_ERASEONE = 0, CTL_WIPE, CTL_UP, CTL_DOWN, CTL_RETURN,
- CTL_TAB, CTL_ABORT, CTL_ALL
+ CTL_TAB, CTL_ABORT
};
struct menu_ctx {
@@ -115,6 +115,7 @@ menu_filter(struct screen_ctx *sc, struc
evmask |= KEYMASK; /* accept keys as well */
(void)strlcpy(mc.promptstr, prompt, sizeof(mc.promptstr));
mc.hasprompt = 1;
+ mc.list = !mc.list; /* List all available items */
}
XSelectInput(X_Dpy, sc->menu.win, evmask);
@@ -294,9 +295,6 @@ menu_handle_key(XEvent *e, struct menu_c
mc->changed = 1;
}
break;
- case CTL_ALL:
- mc->list = !mc->list;
- break;
case CTL_ABORT:
mi = xmalloc(sizeof(*mi));
mi->text[0] = '\0';
@@ -565,10 +563,6 @@ menu_keycode(XKeyEvent *ev, enum ctltype
case XK_h:
case XK_H:
*ctl = CTL_ERASEONE;
- break;
- case XK_a:
- case XK_A:
- *ctl = CTL_ALL;
break;
case XK_bracketleft:
*ctl = CTL_ABORT;
