Re: KERNEL PANIC: HP 250 G5 Notebook PC (W4M67EA)

2017-01-01 Thread Kyoung Jae Seo
On Sun, Jan 01, 2017 at 02:00:44PM +0300, Özgür Kazancci wrote:
> Hello,
> 
> Mike, just wanted to ask if you've had any chance of committing anything
> regarding the issue? Few months have passed and I'm just curious about the
> issue:
> 
> http://marc.info/?l=openbsd-bugs&m=147626115403928&w=2
> 
> Thanks,
> Happy New Year OpenBSD!
> 

Hi

OpenBSD stock kernel might not be able to boot in most of newer HP
laptops. My pavilion also fails to boot because OpenBSD kernel does not
have ACPI CMOS RTC handler.

Can you try booting kernel with ec disabled? You don't have to disable
it in laptop's bios just configure kernel before booting.

To have better idea of what is actually causing the problem you can
compile kernel with #define ACPI_DEBUG and boot with it. If it's indeed
hp ACPI CMOS issue it will fail with message : Unsupported region space
5 when kernel crashes.

I have a wip patch based on linux's implementation but it's too
invasive and hacky right now for sharing. As soon as I get more time
I'll open up discussion in tech@ after tidying things up.

There was discussion on FreeBSD bugs lists of how to handle hp laptop's
acpi cmos some time ago but developers could not agree on resolution.

For those interested : 
https://lists.freebsd.org/pipermail/freebsd-amd64/2016-February/016620.html
https://wiki.freebsd.org/Laptops/HP_Envy_6Z-1100

Thanks.



Re: KERNEL PANIC: HP 250 G5 Notebook PC (W4M67EA)

2017-01-07 Thread Mike Larkin
On Mon, Jan 02, 2017 at 06:55:28AM +0900, Kyoung Jae Seo wrote:
> On Sun, Jan 01, 2017 at 02:00:44PM +0300, Özgür Kazancci wrote:
> > Hello,
> > 
> > Mike, just wanted to ask if you've had any chance of committing anything
> > regarding the issue? Few months have passed and I'm just curious about the
> > issue:
> > 
> > http://marc.info/?l=openbsd-bugs&m=147626115403928&w=2
> > 
> > Thanks,
> > Happy New Year OpenBSD!
> > 
> 
> Hi
> 
> OpenBSD stock kernel might not be able to boot in most of newer HP
> laptops. My pavilion also fails to boot because OpenBSD kernel does not
> have ACPI CMOS RTC handler.
> 
> Can you try booting kernel with ec disabled? You don't have to disable
> it in laptop's bios just configure kernel before booting.
> 
> To have better idea of what is actually causing the problem you can
> compile kernel with #define ACPI_DEBUG and boot with it. If it's indeed
> hp ACPI CMOS issue it will fail with message : Unsupported region space
> 5 when kernel crashes.
> 
> I have a wip patch based on linux's implementation but it's too
> invasive and hacky right now for sharing. As soon as I get more time
> I'll open up discussion in tech@ after tidying things up.
> 
> There was discussion on FreeBSD bugs lists of how to handle hp laptop's
> acpi cmos some time ago but developers could not agree on resolution.
> 
> For those interested : 
> https://lists.freebsd.org/pipermail/freebsd-amd64/2016-February/016620.html
> https://wiki.freebsd.org/Laptops/HP_Envy_6Z-1100
> 
> Thanks.
> 

Looks like we do need something like what Kyoung Jae Seo says. I'm happy
to look at a diff but at the moment I don't have the hardware to look into
this (or much free time). Even if the diff is rough, it's probably better
to see what you have earlier rather than later.

-ml



Re: KERNEL PANIC: HP 250 G5 Notebook PC (W4M67EA)

2017-01-07 Thread Mike Larkin
On Sat, Jan 07, 2017 at 03:32:22PM -0800, Mike Larkin wrote:
> On Mon, Jan 02, 2017 at 06:55:28AM +0900, Kyoung Jae Seo wrote:
> > On Sun, Jan 01, 2017 at 02:00:44PM +0300, Özgür Kazancci wrote:
> > > Hello,
> > > 
> > > Mike, just wanted to ask if you've had any chance of committing anything
> > > regarding the issue? Few months have passed and I'm just curious about the
> > > issue:
> > > 
> > > http://marc.info/?l=openbsd-bugs&m=147626115403928&w=2
> > > 
> > > Thanks,
> > > Happy New Year OpenBSD!
> > > 
> > 
> > Hi
> > 
> > OpenBSD stock kernel might not be able to boot in most of newer HP
> > laptops. My pavilion also fails to boot because OpenBSD kernel does not
> > have ACPI CMOS RTC handler.
> > 
> > Can you try booting kernel with ec disabled? You don't have to disable
> > it in laptop's bios just configure kernel before booting.
> > 
> > To have better idea of what is actually causing the problem you can
> > compile kernel with #define ACPI_DEBUG and boot with it. If it's indeed
> > hp ACPI CMOS issue it will fail with message : Unsupported region space
> > 5 when kernel crashes.
> > 
> > I have a wip patch based on linux's implementation but it's too
> > invasive and hacky right now for sharing. As soon as I get more time
> > I'll open up discussion in tech@ after tidying things up.
> > 
> > There was discussion on FreeBSD bugs lists of how to handle hp laptop's
> > acpi cmos some time ago but developers could not agree on resolution.
> > 
> > For those interested : 
> > https://lists.freebsd.org/pipermail/freebsd-amd64/2016-February/016620.html
> > https://wiki.freebsd.org/Laptops/HP_Envy_6Z-1100
> > 
> > Thanks.
> > 
> 
> Looks like we do need something like what Kyoung Jae Seo says. I'm happy
> to look at a diff but at the moment I don't have the hardware to look into
> this (or much free time). Even if the diff is rough, it's probably better
> to see what you have earlier rather than later.
> 
> -ml
> 

Also, this is the third time (that I recall) that HP has thrown us a curveball
in their ACPI implementation (although at least this time they seem to be
spec-compliant and it's us missing stuff). Toshiba is another vendor that
tends to do bizarre things.

-ml



Re: KERNEL PANIC: HP 250 G5 Notebook PC (W4M67EA)

2017-01-08 Thread James Hastings
On Sat, Jan 07, 2017 at 03:32:22PM -0800, Mike Larkin wrote:
> Also, this is the third time (that I recall) that HP has thrown us a curveball
> in their ACPI implementation (although at least this time they seem to be
> spec-compliant and it's us missing stuff). Toshiba is another vendor that
> tends to do bizarre things.
>
> -ml
>

I own many buggy HP machines; This is a starting point / placeholder.

Index: dev/acpi/acpi.c
===
RCS file: /cvs/src/sys/dev/acpi/acpi.c,v
retrieving revision 1.317
diff -u -p -r1.317 acpi.c
--- dev/acpi/acpi.c 25 Oct 2016 06:48:58 -  1.317
+++ dev/acpi/acpi.c 8 Jan 2017 18:10:22 -
@@ -419,6 +419,10 @@ acpi_gasio(struct acpi_softc *sc, int io
else
acpiec_write(sc->sc_ec, (u_int8_t)address, len, buffer);
break;
+
+   case GAS_CMOS:
+   printf("Unsupported RegionSpace CMOS\n");
+   break;
}
return (0);
 }
Index: dev/acpi/acpireg.h
===
RCS file: /cvs/src/sys/dev/acpi/acpireg.h,v
retrieving revision 1.36
diff -u -p -r1.36 acpireg.h
--- dev/acpi/acpireg.h  10 Jul 2016 20:36:41 -  1.36
+++ dev/acpi/acpireg.h  8 Jan 2017 18:10:23 -
@@ -86,6 +86,7 @@ struct acpi_gas {
 #define GAS_PCI_CFG_SPACE  2
 #define GAS_EMBEDDED   3
 #define GAS_SMBUS  4
+#define GAS_CMOS   5
 #define GAS_FUNCTIONAL_FIXED   127
u_int8_tregister_bit_width;
u_int8_tregister_bit_offset;
Index: dev/acpi/dsdt.c
===
RCS file: /cvs/src/sys/dev/acpi/dsdt.c,v
retrieving revision 1.228
diff -u -p -r1.228 dsdt.c
--- dev/acpi/dsdt.c 18 Dec 2016 15:59:22 -  1.228
+++ dev/acpi/dsdt.c 8 Jan 2017 18:10:25 -
@@ -2470,6 +2470,7 @@ aml_rwfield(struct aml_value *fld, int b
case ACPI_OPREG_SYSIO:
case ACPI_OPREG_PCICFG:
case ACPI_OPREG_EC:
+   case ACPI_OPREG_CMOS:
aml_rwgas(ref1, fld->v_field.bitpos + bpos, blen,
val, mode, fld->v_field.flags);
break;