Re: ath AR5424 support
Brynet schrieb: Luis Henriques wrote: Hi! I finally got tired of not using my wireless card on my laptop and decided to take a look at the code. I compared the ath OpenBSD code with similar drivers on NetBSD and Linux kernels, start adding/correcting the ath code and finally got it to work. I am currently able to use my AR5424 wireless card! I think you may have just duplicated some existing work, Damien commited a new Atheros driver in -CURRENT.. it was named athn(4). http://marc.info/?l=openbsd-cvsm=125821878008903w=2 You might have been able to adapt this new driver, instead of pulling in code from Linux (..even if it may be ISC licenced). 1) Most of the code I'm using is from Linux driver which is AFAIK GPL'ed code. Is this a problem? If it is GPL code, it's very unlikely to be commited. -Bryan. If I remember correctly the AR5424 is the AzureWave assembled into some EEE Models amongst others. I don't think it is supported by athn http://www.openbsd.org/cgi-bin/man.cgi?query=athnapropos=0sektion=0manpath=OpenBSD+Currentarch=i386format=html Regards, Dorian
Re: ath AR5424 support
On Fri, Jan 22, 2010 at 10:55:22PM -0500, Daniel Dickman wrote: 1) Most of the code I'm using is from Linux driver which is AFAIK GPL'ed code. Is this a problem? Why do you think the code is GPL'ed? What driver did you look at? Some of the atheros code in the linux kernel comes from OpenBSD. For example: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/net/wireless/ath/ath5k/ath5k.h;h=6a2a967621cc1523aadbad93a22e9edc4382;hb=HEAD Note the copyright at the top: Copyright (c) 2004-2007 Reyk Floeter r...@openbsd.org Not to mention the non-GPL license that follows... I used as reference the ath5k Linux device driver and the atheros_hal from NetBSD. My question is just: can I do this and publish a patch? I am using the code for myself at the moment and, of course, I would like to share it. I just don't want to get into troubles. 2) I know nothing about wireless cards and my code is probably doing very stupid things. This means that I will not be able to provide any kind of support to it. I'd imagine a dmesg with and without your patch would no doubt be helpful to start... Here's a dmesg with my patch applied. Note that it adds nothing to the output so there's not point in publishing the dmesg without the patch. OpenBSD 4.6-current (GENERIC.MP) #32: Fri Jan 22 22:38:21 WET 2010 mig...@hades.my.domain:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 2144796672 (2045MB) avail mem = 2078343168 (1982MB) mainbus0 at root bios0 at mainbus0: SMBIOS rev. 2.4 @ 0xf0170 (26 entries) bios0: vendor TOSHIBA version V2.00 date 06/10/2008 bios0: TOSHIBA Satellite A210 acpi0 at bios0: rev 2 acpi0: tables DSDT FACP TCPA SLIC SSDT APIC MCFG HPET ASF! acpi0: wakeup devices PB2_(S4) PB3_(S4) PB4_(S4) PB5_(S3) PB6_(S0) BB4_(S4) BB5_(S4) OHC1(S4) OHC2(S4) OHC3(S4) OHC4(S4) OHC5(S4) EHCI(S4) P2P_(S5) AUDO(S4) MODM(S4) AZLA(S3) acpitimer0 at acpi0: 3579545 Hz, 32 bits acpimadt0 at acpi0 addr 0xfee0: PC-AT compat cpu0 at mainbus0: apid 0 (boot processor) cpu0: AMD Turion(tm) 64 X2 Mobile Technology TL-60, 1995.25 MHz cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,CX16,NXE,MMXX,FFXSR,LONG,3DNOW2,3DNOW cpu0: 64KB 64b/line 2-way I-cache, 64KB 64b/line 2-way D-cache, 512KB 64b/line 16-way L2 cache cpu0: ITLB 32 4KB entries fully associative, 8 4MB entries fully associative cpu0: DTLB 32 4KB entries fully associative, 8 4MB entries fully associative cpu0: apic clock running at 199MHz cpu1 at mainbus0: apid 1 (application processor) cpu1: AMD Turion(tm) 64 X2 Mobile Technology TL-60, 1995.00 MHz cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,CX16,NXE,MMXX,FFXSR,LONG,3DNOW2,3DNOW cpu1: 64KB 64b/line 2-way I-cache, 64KB 64b/line 2-way D-cache, 512KB 64b/line 16-way L2 cache cpu1: ITLB 32 4KB entries fully associative, 8 4MB entries fully associative cpu1: DTLB 32 4KB entries fully associative, 8 4MB entries fully associative ioapic0 at mainbus0: apid 2 pa 0xfec0, version 21, 24 pins acpihpet0 at acpi0: 14318180 Hz acpiprt0 at acpi0: bus 0 (PCI0) acpiprt1 at acpi0: bus 1 (PB2_) acpiprt2 at acpi0: bus -1 (PB3_) acpiprt3 at acpi0: bus -1 (PB4_) acpiprt4 at acpi0: bus 8 (PB5_) acpiprt5 at acpi0: bus 14 (PB6_) acpiprt6 at acpi0: bus 20 (PB7_) acpiprt7 at acpi0: bus -1 (BB4_) acpiprt8 at acpi0: bus 8 (BB5_) acpiprt9 at acpi0: bus 26 (P2P_) acpiprt10 at acpi0: bus -1 (AGP_) acpiec0 at acpi0 acpicpu0 at acpi0: PSS acpicpu1 at acpi0: PSS acpibtn0 at acpi0: LID_ acpibtn1 at acpi0: PWRB acpiac0 at acpi0: AC unit online acpibat0 at acpi0: BAT1 model PA3457U serial 3658Q type Li-Ion oem TOSHIBA acpivideo0 at acpi0: VGA_ acpivout0 at acpivideo0: CRT_ acpivout1 at acpivideo0: LCD_ acpivout2 at acpivideo0: TV__ acpivout3 at acpivideo0: DVI_ acpivideo1 at acpi0: VGA_ acpivout4 at acpivideo1: CRT_ acpivout5 at acpivideo1: LCD_ acpivout6 at acpivideo1: TV__ cpu0: PowerNow! K8 1995 MHz: speeds: 2000 1800 1600 800 MHz pci0 at mainbus0 bus 0 pchb0 at pci0 dev 0 function 0 ATI RS690 Host rev 0x00 ppb0 at pci0 dev 2 function 0 ATI RS690M PCIE rev 0x00 pci1 at ppb0 bus 1 vga1 at pci1 dev 0 function 0 ATI Mobility Radeon HD 2400 rev 0x00 wsdisplay0 at vga1 mux 1: console (80x25, vt100 emulation) wsdisplay0: screen 1-5 added (80x25, vt100 emulation) azalia0 at pci1 dev 0 function 1 ATI RS690M HD Audio rev 0x00: apic 2 int 19 (irq 11) azalia0: no supported codecs azalia0: initialization failure, detaching ppb1 at pci0 dev 5 function 0 ATI RS690 PCIE rev 0x00 pci2 at ppb1 bus 8 ppb2 at pci0 dev 6 function 0 ATI RS690 PCIE rev 0x00 pci3 at ppb2 bus 14 re0 at pci3 dev 0 function 0 Realtek 8101E rev 0x01: RTL8101E (0x3400), apic 2 int 18 (irq 3), address 00:1e:ec:3a:48:9f rlphy0 at re0 phy 7: RTL8201L 10/100 PHY, rev. 1 ppb3 at pci0 dev 7 function 0 ATI RS690 PCIE rev 0x00 pci4 at ppb3 bus 20 ath0 at pci4 dev 0 function 0 Atheros AR5424
Re: ath AR5424 support
On Sat, Jan 23, 2010 at 10:23:36AM +0100, Dorian B?ttner wrote: Brynet schrieb: Luis Henriques wrote: Hi! I finally got tired of not using my wireless card on my laptop and decided to take a look at the code. I compared the ath OpenBSD code with similar drivers on NetBSD and Linux kernels, start adding/correcting the ath code and finally got it to work. I am currently able to use my AR5424 wireless card! I think you may have just duplicated some existing work, Damien commited a new Atheros driver in -CURRENT.. it was named athn(4). http://marc.info/?l=openbsd-cvsm=125821878008903w=2 You might have been able to adapt this new driver, instead of pulling in code from Linux (..even if it may be ISC licenced). 1) Most of the code I'm using is from Linux driver which is AFAIK GPL'ed code. Is this a problem? If it is GPL code, it's very unlikely to be commited. -Bryan. If I remember correctly the AR5424 is the AzureWave assembled into some EEE Models amongst others. I don't think it is supported by athn http://www.openbsd.org/cgi-bin/man.cgi?query=athnapropos=0sektion=0manpath=OpenBSD+Currentarch=i386format=html Not sure about this, but I'm have been using -current and the driver that actually is being attached to my card is ath, not athn. The default behaviour (without my mods to the driver) is to crash my system (i.e., the system stops responding and I need to do a hard reboot on the laptop) as soon as I do something like ifconfig ath0 scan or ifconfig ath0 192.168.0.1. Luis
Re: ath AR5424 support
On 2010 Jan 23 (Sat) at 16:17:29 + (+), Luis Henriques wrote: :On Fri, Jan 22, 2010 at 10:55:22PM -0500, Daniel Dickman wrote: : 1) Most of the code I'm using is from Linux driver which is AFAIK GPL'ed code. : Is this a problem? : : Why do you think the code is GPL'ed? What driver did you look at? Some : of the atheros code in the linux kernel comes from OpenBSD. For : example: : : http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/net/wireless/ath/ath5k/ath5k.h;h=6a2a967621cc1523aadbad93a22e9edc4382;hb=HEAD : : Note the copyright at the top: : Copyright (c) 2004-2007 Reyk Floeter r...@openbsd.org : : Not to mention the non-GPL license that follows... : :I used as reference the ath5k Linux device driver and the atheros_hal from :NetBSD. My question is just: can I do this and publish a patch? I am using :the code for myself at the moment and, of course, I would like to share it. :I just don't want to get into troubles. : If the code that you used is based on ISC and/or BSD licenses, then it should be safe. The top of the file normally contians the actual license that it is under. -- Schlattwhapper, n.: The window shade that allows itself to be pulled down, hesitates for a second, then snaps up in your face. -- Rich Hall, Sniglets
Re: ath AR5424 support
On Sat, Jan 23, 2010 at 04:22:19PM +, Luis Henriques wrote: On Sat, Jan 23, 2010 at 10:23:36AM +0100, Dorian B?ttner wrote: Brynet schrieb: Luis Henriques wrote: Hi! I finally got tired of not using my wireless card on my laptop and decided to take a look at the code. I compared the ath OpenBSD code with similar drivers on NetBSD and Linux kernels, start adding/correcting the ath code and finally got it to work. I am currently able to use my AR5424 wireless card! I think you may have just duplicated some existing work, Damien commited a new Atheros driver in -CURRENT.. it was named athn(4). http://marc.info/?l=openbsd-cvsm=125821878008903w=2 You might have been able to adapt this new driver, instead of pulling in code from Linux (..even if it may be ISC licenced). 1) Most of the code I'm using is from Linux driver which is AFAIK GPL'ed code. Is this a problem? If it is GPL code, it's very unlikely to be commited. -Bryan. If I remember correctly the AR5424 is the AzureWave assembled into some EEE Models amongst others. I don't think it is supported by athn http://www.openbsd.org/cgi-bin/man.cgi?query=athnapropos=0sektion=0manpath=OpenBSD+Currentarch=i386format=html Not sure about this, but I'm have been using -current and the driver that actually is being attached to my card is ath, not athn. The default behaviour (without my mods to the driver) is to crash my system (i.e., the system stops responding and I need to do a hard reboot on the laptop) as soon as I do something like ifconfig ath0 scan or ifconfig ath0 192.168.0.1. Luis Not to be rude, but shit or get off the pot; either you copied the code from GPL'ed sources or you didn't. If you did, it won't go in. If you didn't, then make sure that it's considered compatible with the BSD license. If it comes from a BSD-like license, the only way you'll know if anybody cares is by showing it, not talking about it. Patches traditionally have been sent to tech@, so that's the place for it, if it's not GPL'ed. Goddamn.
Re: ath AR5424 support
1) Most of the code I'm using is from Linux driver which is AFAIK GPL'ed code. Is this a problem? Why do you think the code is GPL'ed? What driver did you look at? Some of the atheros code in the linux kernel comes from OpenBSD. For example: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/net/wireless/ath/ath5k/ath5k.h;h=6a2a967621cc1523aadbad93a22e9edc4382;hb=HEAD Note the copyright at the top: Copyright (c) 2004-2007 Reyk Floeter r...@openbsd.org Not to mention the non-GPL license that follows... 2) I know nothing about wireless cards and my code is probably doing very stupid things. This means that I will not be able to provide any kind of support to it. I'd imagine a dmesg with and without your patch would no doubt be helpful to start...
Re: ath AR5424 support
Luis Henriques wrote: Hi! I finally got tired of not using my wireless card on my laptop and decided to take a look at the code. I compared the ath OpenBSD code with similar drivers on NetBSD and Linux kernels, start adding/correcting the ath code and finally got it to work. I am currently able to use my AR5424 wireless card! I think you may have just duplicated some existing work, Damien commited a new Atheros driver in -CURRENT.. it was named athn(4). http://marc.info/?l=openbsd-cvsm=125821878008903w=2 You might have been able to adapt this new driver, instead of pulling in code from Linux (..even if it may be ISC licenced). 1) Most of the code I'm using is from Linux driver which is AFAIK GPL'ed code. Is this a problem? If it is GPL code, it's very unlikely to be commited. -Bryan.
