Re: Remove outdated /etc/examples/unwind.conf?

2021-07-26 Thread Stuart Henderson
On 2021-07-24, David Higgs  wrote:
> I wonder if there would be any benefit to a sysclean-like tool as part of a
> standard upgrade/sysmerge that automatically deletes everything older than
> the (supported) current and prior release?

I think it's not possible, sometimes config files move from being
installed in /etc by default to not having a default but still used,
such a tool would remove those.

sysclean is great, and for files in "system owned" directories like
/usr/lib, /usr/include, /usr/share and the various bin directories, in
almost all cases the list of files can be removed directly. But for
"user owned" directories like /etc that's very much not the case.




Re: Remove outdated /etc/examples/unwind.conf?

2021-07-24 Thread Sebastian Benoit
David Higgs(hig...@gmail.com) on 2021.07.24 14:05:04 -0400:
> I wonder if there would be any benefit to a sysclean-like tool as part of a
> standard upgrade/sysmerge that automatically deletes everything older than
> the (supported) current and prior release?  It would remove the need to
> curate removal lists in upgrade.html.  Just an idle thought... pay me no
> mind.

At this time we believe it is enough to provide the list in upgrade.html.
If the removal of a file is needed because leaving it around can cause
problems (for example include files), it will be mentioned in current.html.

Sometimes less is more, for example more time for developers to do important
things.

Also note that any automatically generated list should be reviewed, you may
have valid reasons to keep a file around.



Re: Remove outdated /etc/examples/unwind.conf?

2021-07-24 Thread David Higgs
On Fri, Jul 23, 2021 at 5:33 AM Stuart Henderson 
wrote:

> On 2021-07-21, David Higgs  wrote:
> > I was looking into how to configure unwind for my needs, and found
> > significant discrepancies between /etc/examples/unwind.conf and the
> > unwind.conf(5) manual.  Namely, the example file had lots of captive
> portal
> > info, while the manual made no mention of it.
> >
> > After browsing source history, I learned that when captive portal support
> > was removed, the example config was removed.
> >
> > I'm going to compare the contents of etc.tgz versus my /etc/examples
> > directory to avoid confusion in the future, but should sysmerge(8) have
> > removed example files such as this?
>
> sysmerge doesn't deal with files in /etc/examples, they aren't expected
> to be modified in-place so they are just overwritten as part of
> extracting the base set. As with other files in the base there's nothing
> to remove old ones no longer present, but you can use "sysclean" (in
> packages) to identify files in system directories that aren't present
> in base - either local additions or obsolete files - if you'd like to
> remove them.
>

Oh, that makes more sense.  I use sysclean on my -stable systems, but not
on this VM running -current.  I had somehow gotten the idea in my head that
sysmerge ingested files from /etc/examples to perform updates - and thus
they were treated differently - but clearly I was very wrong.

I wonder if there would be any benefit to a sysclean-like tool as part of a
standard upgrade/sysmerge that automatically deletes everything older than
the (supported) current and prior release?  It would remove the need to
curate removal lists in upgrade.html.  Just an idle thought... pay me no
mind.

Apologies for the noise.

--david


Re: Remove outdated /etc/examples/unwind.conf?

2021-07-23 Thread Stuart Henderson
On 2021-07-21, David Higgs  wrote:
> I was looking into how to configure unwind for my needs, and found
> significant discrepancies between /etc/examples/unwind.conf and the
> unwind.conf(5) manual.  Namely, the example file had lots of captive portal
> info, while the manual made no mention of it.
>
> After browsing source history, I learned that when captive portal support
> was removed, the example config was removed.
>
> I'm going to compare the contents of etc.tgz versus my /etc/examples
> directory to avoid confusion in the future, but should sysmerge(8) have
> removed example files such as this?

sysmerge doesn't deal with files in /etc/examples, they aren't expected
to be modified in-place so they are just overwritten as part of
extracting the base set. As with other files in the base there's nothing
to remove old ones no longer present, but you can use "sysclean" (in
packages) to identify files in system directories that aren't present
in base - either local additions or obsolete files - if you'd like to
remove them.



Remove outdated /etc/examples/unwind.conf?

2021-07-21 Thread David Higgs
I was looking into how to configure unwind for my needs, and found
significant discrepancies between /etc/examples/unwind.conf and the
unwind.conf(5) manual.  Namely, the example file had lots of captive portal
info, while the manual made no mention of it.

After browsing source history, I learned that when captive portal support
was removed, the example config was removed.

I'm going to compare the contents of etc.tgz versus my /etc/examples
directory to avoid confusion in the future, but should sysmerge(8) have
removed example files such as this?

Thanks.

--david