Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-13 Thread Harald Dunkel

Hi Omar,

On 2023-11-09 18:22:41, Omar Polo wrote:

I've committed the update and backported to -STABLE so the fixed package
should appear in the next days.

Thanks for the report and sorry for the breakage



I highly appreciate your fast response and the fix you have
provided.


Regards
Harri



Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-09 Thread Omar Polo
I've committed the update and backported to -STABLE so the fixed package
should appear in the next days.

Thanks for the report and sorry for the breakage



Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-08 Thread Omar Polo
On 2023/11/07 22:44:56 +0100, Giovanni Bechis  wrote:
> On 11/7/23 20:16, Omar Polo wrote:
> > On 2023/11/07 19:30:43 +0100, Harald Dunkel  wrote:
> >> Hi Omar,
> >>
> >> sorry for the delay, but I have good news: The patch seems to
> >> work. Of course I will continue to watch it.
> > Thanks for verifying!
> >
> > Before bumping the smtp-filter protocol version I took at look at what
> > we had in the port tree to know what would break, but this slipped.
> > apologize.
> >
> > If it's OK for Giovanni and Joerg I'd like to commit this and backport
> > to 7.4-stable (same diff tested by Harald, reattaching for convenience.)
> [...]
> > +Index: filter-spamassassin.go
> > +--- filter-spamassassin.go.orig
> >  filter-spamassassin.go
> > +@@ -211,7 +211,7 @@ func run() {
> > +   for in.Scan() {
> > +   f := strings.Split(in.Text(), "|")
> > +   t, ver, ev, sid := f[0], f[1], f[4], f[5]
> > +-  if (t != "filter" && t != "report") || ver != "0.6" {
> > ++  if (t != "filter" && t != "report") || ver != "0.7" {
> > +   l3.Err(fmt.Sprintln(sid, "protocol", t, ver))
> does this still works with previous protocol versions ?

The only difference between 0.6 and 0.7 is the order of the link-auth
fields (`result' and `username' were swapped.)  As far as I can see,
filter-spamassassin doesn't use it, so it should work as usual on both
0.6 and 0.7 versions.

> ok giovanni@ in any case for current and 7.4 since it will be a no-op on 
> OpenBSD.

Thanks :)



Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-07 Thread Giovanni Bechis

On 11/7/23 20:16, Omar Polo wrote:

On 2023/11/07 19:30:43 +0100, Harald Dunkel  wrote:

Hi Omar,

sorry for the delay, but I have good news: The patch seems to
work. Of course I will continue to watch it.

Thanks for verifying!

Before bumping the smtp-filter protocol version I took at look at what
we had in the port tree to know what would break, but this slipped.
apologize.

If it's OK for Giovanni and Joerg I'd like to commit this and backport
to 7.4-stable (same diff tested by Harald, reattaching for convenience.)

[...]

+Index: filter-spamassassin.go
+--- filter-spamassassin.go.orig
 filter-spamassassin.go
+@@ -211,7 +211,7 @@ func run() {
+   for in.Scan() {
+   f := strings.Split(in.Text(), "|")
+   t, ver, ev, sid := f[0], f[1], f[4], f[5]
+-  if (t != "filter" && t != "report") || ver != "0.6" {
++  if (t != "filter" && t != "report") || ver != "0.7" {
+   l3.Err(fmt.Sprintln(sid, "protocol", t, ver))

does this still works with previous protocol versions ?

ok giovanni@ in any case for current and 7.4 since it will be a no-op on 
OpenBSD.
 Cheers
   Giovanni


Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-07 Thread Omar Polo
On 2023/11/07 19:30:43 +0100, Harald Dunkel  wrote:
> Hi Omar,
> 
> sorry for the delay, but I have good news: The patch seems to
> work. Of course I will continue to watch it.

Thanks for verifying!

Before bumping the smtp-filter protocol version I took at look at what
we had in the port tree to know what would break, but this slipped.
apologize.

If it's OK for Giovanni and Joerg I'd like to commit this and backport
to 7.4-stable (same diff tested by Harald, reattaching for convenience.)

Index: Makefile
===
RCS file: /home/cvs/ports/mail/opensmtpd-filters/spamassassin/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile26 Sep 2023 12:28:14 -  1.8
+++ Makefile5 Nov 2023 09:20:27 -
@@ -4,7 +4,7 @@ V = 0.7
 FILTER_NAME =  spamassassin
 DISTNAME = filter-spamassassin-${V}
 HOMEPAGE = https://www.umaxx.net/
-REVISION = 0
+REVISION = 1
 
 CATEGORIES =   mail
 
Index: patches/patch-filter-spamassassin_go
===
RCS file: patches/patch-filter-spamassassin_go
diff -N patches/patch-filter-spamassassin_go
--- /dev/null   1 Jan 1970 00:00:00 -
+++ patches/patch-filter-spamassassin_go7 Nov 2023 19:14:58 -
@@ -0,0 +1,14 @@
+handle the smtpd filter-protocol version 0.7
+
+Index: filter-spamassassin.go
+--- filter-spamassassin.go.orig
 filter-spamassassin.go
+@@ -211,7 +211,7 @@ func run() {
+   for in.Scan() {
+   f := strings.Split(in.Text(), "|")
+   t, ver, ev, sid := f[0], f[1], f[4], f[5]
+-  if (t != "filter" && t != "report") || ver != "0.6" {
++  if (t != "filter" && t != "report") || ver != "0.7" {
+   l3.Err(fmt.Sprintln(sid, "protocol", t, ver))
+   return
+   }



Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-07 Thread Harald Dunkel

Hi Omar,

sorry for the delay, but I have good news: The patch seems to
work. Of course I will continue to watch it.

Thank you very much

Harri



Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-06 Thread Harald Dunkel

On 2023-11-05 10:21:10, Omar Polo wrote:


Can you try the following diff to see if it helps?



I will try this evening after work, stay tuned. Its been a while
since I used CVS.

Regards

Harri



smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-05 Thread Harald Dunkel

Hi folks,

since OpenBSD 7.4 the spamassassin filter seems to be broken. On
the first EMail opensmtpd dies with a message in maillog saying

Nov  5 08:59:23 mhost smtpd[60460]: bcc4f33a095bb28e smtp connected 
address=xx.xx.xx.xx host=mail.example.com
Nov  5 08:59:23 mhost filter-spamassassin[7782]: bcc4f33a095bb28e protocol 
report 0.7
Nov  5 08:59:23 mhost filter-spamassassin[7782]: exit
Nov  5 08:59:23 mhost smtpd[68513]: warn: lost processor: spamassassin exited 
abnormally
Nov  5 08:59:23 mhost smtpd[68513]: Exiting


smtpd is configured according to /usr/local/share/doc/pkg-readmes/\
opensmtpd-filter-spamassassin (except for the tls option):

xname = "mailhost.example.de"
pki $xname cert "/etc/ssl/example.de/fullchain.pem"
pki $xname key  "/etc/ssl/example.de/privkey.pem"
pki $xname dhe  auto

filter "spamassassin" proc-exec "filter-spamassassin"

listen on all tls pki $xname filter "spamassassin"
listen on socket filter "spamassassin"
:
:

If I kick out the tls stuff, it is still broken.

Can anybody reproduce this? Every helpful hint is highly
appreciated.


Harri



Re: smtpd[68513]: warn: lost processor: spamassassin exited abnormally

2023-11-05 Thread Omar Polo
On 2023/11/05 09:59:14 +0100, Harald Dunkel  wrote:
> Hi folks,
> 
> since OpenBSD 7.4 the spamassassin filter seems to be broken. On
> the first EMail opensmtpd dies with a message in maillog saying
> 
> Nov  5 08:59:23 mhost smtpd[60460]: bcc4f33a095bb28e smtp connected 
> address=xx.xx.xx.xx host=mail.example.com
> Nov  5 08:59:23 mhost filter-spamassassin[7782]: bcc4f33a095bb28e protocol 
> report 0.7
> Nov  5 08:59:23 mhost filter-spamassassin[7782]: exit

This seems to suggest that it's due the filter-protocol version bump.

(+cc filter-spamassassin maintainers)

I don't use filter-spamassassin and can't test, but since it doesn't
seem to use link-auth it shouldn't care about this protocol change, so
just bumping the version should be enough.

Can you try the following diff to see if it helps?

Index: Makefile
===
RCS file: /home/cvs/ports/mail/opensmtpd-filters/spamassassin/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile26 Sep 2023 12:28:14 -  1.8
+++ Makefile5 Nov 2023 09:20:27 -
@@ -4,7 +4,7 @@ V = 0.7
 FILTER_NAME =  spamassassin
 DISTNAME = filter-spamassassin-${V}
 HOMEPAGE = https://www.umaxx.net/
-REVISION = 0
+REVISION = 1
 
 CATEGORIES =   mail
 
Index: patches/patch-filter-spamassassin_go
===
RCS file: patches/patch-filter-spamassassin_go
diff -N patches/patch-filter-spamassassin_go
--- /dev/null   1 Jan 1970 00:00:00 -
+++ patches/patch-filter-spamassassin_go5 Nov 2023 09:20:36 -
@@ -0,0 +1,14 @@
+handle the smtpd filter-protocol version 0.7
+
+Index: filter-spamassassin.go
+--- filter-spamassassin.go.orig
 filter-spamassassin.go
+@@ -211,7 +211,7 @@ func run() {
+   for in.Scan() {
+   f := strings.Split(in.Text(), "|")
+   t, ver, ev, sid := f[0], f[1], f[4], f[5]
+-  if (t != "filter" && t != "report") || ver != "0.6" {
++  if (t != "filter" && t != "report") || ver != "0.7" {
+   l3.Err(fmt.Sprintln(sid, "protocol", t, ver))
+   return
+   }