Re: [Mixxx-devel] Track analysis progress bar
On Mon, Jun 27, 2011 at 7:51 PM, Jonas Ådahl wrote:
> Hi,
>
> When loading a track to a deck, one thing I missed from a UI feedback
> perspective was knowing how the analysis went and how long I had to
> wait. I missed it enough so that I downloaded the source code for
> mixxx (the default branch "trunk") and started to hack on adding a
> progress bar.
>
> Result is available as the attached patch. I also attached a
> screenshot illustrating the results. The darker orange background of
> the right wave form overview widget will be filled completely when the
> track has been analysed, like a progress bar. The color used is the
> same as the wave form color, but with alpha value 60 out of 255.
>
> Comments?
>
> Jonas
>
Hi,
There was a bug in the previous version causing it only to work on one
of the skins (the one I was testing on, surprisingly). Attaching an
updated patch, also increasing the alpha value to 80/255.
Jonas
=== modified file 'mixxx/src/basetrackplayer.cpp'
--- mixxx/src/basetrackplayer.cpp 2011-05-06 02:34:38 +
+++ mixxx/src/basetrackplayer.cpp 2011-06-27 06:18:19 +
@@ -20,8 +20,10 @@
ConfigObject *pConfig,
EngineMaster* pMixingEngine,
EngineChannel::ChannelOrientation defaultOrientation,
+ AnalyserQueue* pAnalyserQueue,
QString group)
: BasePlayer(pParent, group),
+ m_pAnalyserQueue(pAnalyserQueue),
m_pConfig(pConfig),
m_pLoadedTrack() {
@@ -236,6 +238,10 @@
emit(newTrackLoaded(m_pLoadedTrack));
}
+AnalyserQueue* BaseTrackPlayer::getAnalyserQueue() const {
+return m_pAnalyserQueue;
+}
+
WaveformRenderer* BaseTrackPlayer::getWaveformRenderer() const {
return m_pWaveformRenderer;
}
=== modified file 'mixxx/src/basetrackplayer.h'
--- mixxx/src/basetrackplayer.h 2010-11-15 16:11:56 +
+++ mixxx/src/basetrackplayer.h 2011-06-26 15:01:39 +
@@ -4,6 +4,7 @@
#include "configobject.h"
#include "trackinfoobject.h"
#include "baseplayer.h"
+#include "analyserqueue.h"
#include "engine/enginechannel.h"
class EngineMaster;
@@ -18,9 +19,11 @@
ConfigObject* pConfig,
EngineMaster* pMixingEngine,
EngineChannel::ChannelOrientation defaultOrientation,
+AnalyserQueue* pAnalyserQueue,
QString group);
virtual ~BaseTrackPlayer();
+AnalyserQueue* getAnalyserQueue() const;
WaveformRenderer* getWaveformRenderer() const;
TrackPointer getLoadedTrack() const;
@@ -38,6 +41,7 @@
private:
ConfigObject* m_pConfig;
TrackPointer m_pLoadedTrack;
+AnalyserQueue* m_pAnalyserQueue;
ControlObjectThreadMain* m_pCuePoint;
ControlObjectThreadMain* m_pLoopInPoint;
=== modified file 'mixxx/src/deck.cpp'
--- mixxx/src/deck.cpp 2010-10-24 09:50:11 +
+++ mixxx/src/deck.cpp 2011-06-26 14:37:19 +
@@ -4,8 +4,9 @@
ConfigObject* pConfig,
EngineMaster* pMixingEngine,
EngineChannel::ChannelOrientation defaultOrientation,
+ AnalyserQueue* pAnalyserQueue,
QString group)
-: BaseTrackPlayer(pParent, pConfig, pMixingEngine, defaultOrientation, group) {
+: BaseTrackPlayer(pParent, pConfig, pMixingEngine, defaultOrientation, pAnalyserQueue, group) {
}
=== modified file 'mixxx/src/deck.h'
--- mixxx/src/deck.h 2010-10-24 09:50:11 +
+++ mixxx/src/deck.h 2011-06-26 14:36:37 +
@@ -10,6 +10,7 @@
ConfigObject *pConfig,
EngineMaster* pMixingEngine,
EngineChannel::ChannelOrientation defaultOrientation,
+ AnalyserQueue* pAnalyserQueue,
QString group);
virtual ~Deck();
};
=== modified file 'mixxx/src/playermanager.cpp'
--- mixxx/src/playermanager.cpp 2011-04-03 20:51:18 +
+++ mixxx/src/playermanager.cpp 2011-06-26 14:36:44 +
@@ -68,7 +68,7 @@
if (number % 2 == 0)
orientation = EngineChannel::RIGHT;
-pDeck = new Deck(this, m_pConfig, m_pEngine, orientation, group);
+pDeck = new Deck(this, m_pConfig, m_pEngine, orientation, m_pAnalyserQueue, group);
// Connect the player to the analyser queue so that loaded tracks are
// analysed.
=== modified file 'mixxx/src/sampler.cpp'
--- mixxx/src/sampler.cpp 2010-10-24 09:50:11 +
+++ mixxx/src/sampler.cpp 2011-06-26 15:13:14 +
@@ -5,7 +5,7 @@
EngineMaster* pMixingEngine,
EngineChannel::ChannelOrientation defaultOrientation,
QString group)
-: BaseTrackPlayer(pParent, pConfig, pMixingEngine, defaultOrientation, group) {
+: BaseTrackPlayer(pParent, pConfig, pMixingEngine, defaultOrientation, NULL, group) {
}
=== modified file 'mixxx/src/skin/legacyskinparser.cpp'
--- mixxx/src/skin/legacyskinparser.cpp 2011-05-05 21:29:33 +
+++ mixxx/src/skin/legacy
Re: [Mixxx-devel] Track analysis progress bar
This is a useful feature. Is it attached to a bug ticket or a bzr branch? That way we won't forget about it and it can eventually get merged. thanks, Owen On Wed, 2011-06-29 at 22:44 +0200, Jonas Ådahl wrote: > On Mon, Jun 27, 2011 at 7:51 PM, Jonas Ådahl wrote: > > Hi, > > > > When loading a track to a deck, one thing I missed from a UI feedback > > perspective was knowing how the analysis went and how long I had to > > wait. I missed it enough so that I downloaded the source code for > > mixxx (the default branch "trunk") and started to hack on adding a > > progress bar. > > > > Result is available as the attached patch. I also attached a > > screenshot illustrating the results. The darker orange background of > > the right wave form overview widget will be filled completely when the > > track has been analysed, like a progress bar. The color used is the > > same as the wave form color, but with alpha value 60 out of 255. > > > > Comments? > > > > Jonas > > > > Hi, > > There was a bug in the previous version causing it only to work on one > of the skins (the one I was testing on, surprisingly). Attaching an > updated patch, also increasing the alpha value to 80/255. > > Jonas > -- > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2d-c2 > ___ Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Track analysis progress bar
Thanks for the suggestion; I'll create a bug and attach it there. The instructions for submitting patches on the wiki is to send them to the mailing list. If this is outdated information, I could update it to suggest creating a ticket for possible contributions. Is it? Jonas On Wed, Jun 29, 2011 at 11:00 PM, Owen Williams wrote: > This is a useful feature. Is it attached to a bug ticket or a bzr > branch? That way we won't forget about it and it can eventually get > merged. > > thanks, > Owen > > On Wed, 2011-06-29 at 22:44 +0200, Jonas Ådahl wrote: >> On Mon, Jun 27, 2011 at 7:51 PM, Jonas Ådahl wrote: >> > Hi, >> > >> > When loading a track to a deck, one thing I missed from a UI feedback >> > perspective was knowing how the analysis went and how long I had to >> > wait. I missed it enough so that I downloaded the source code for >> > mixxx (the default branch "trunk") and started to hack on adding a >> > progress bar. >> > >> > Result is available as the attached patch. I also attached a >> > screenshot illustrating the results. The darker orange background of >> > the right wave form overview widget will be filled completely when the >> > track has been analysed, like a progress bar. The color used is the >> > same as the wave form color, but with alpha value 60 out of 255. >> > >> > Comments? >> > >> > Jonas >> > >> >> Hi, >> >> There was a bug in the previous version causing it only to work on one >> of the skins (the one I was testing on, surprisingly). Attaching an >> updated patch, also increasing the alpha value to 80/255. >> >> Jonas >> -- >> All of the data generated in your IT infrastructure is seriously valuable. >> Why? It contains a definitive record of application performance, security >> threats, fraudulent activity, and more. Splunk takes this data and makes >> sense of it. IT sense. And common sense. >> http://p.sf.net/sfu/splunk-d2d-c2 >> ___ Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > > -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Track analysis progress bar
For reference, the new bug is https://bugs.launchpad.net/mixxx/+bug/803740 . Jonas On Wed, Jun 29, 2011 at 11:04 PM, Jonas Ådahl wrote: > Thanks for the suggestion; I'll create a bug and attach it there. > > The instructions for submitting patches on the wiki is to send them to > the mailing list. If this is outdated information, I could update it > to suggest creating a ticket for possible contributions. Is it? > > Jonas > > On Wed, Jun 29, 2011 at 11:00 PM, Owen Williams wrote: >> This is a useful feature. Is it attached to a bug ticket or a bzr >> branch? That way we won't forget about it and it can eventually get >> merged. >> >> thanks, >> Owen >> >> On Wed, 2011-06-29 at 22:44 +0200, Jonas Ådahl wrote: >>> On Mon, Jun 27, 2011 at 7:51 PM, Jonas Ådahl wrote: >>> > Hi, >>> > >>> > When loading a track to a deck, one thing I missed from a UI feedback >>> > perspective was knowing how the analysis went and how long I had to >>> > wait. I missed it enough so that I downloaded the source code for >>> > mixxx (the default branch "trunk") and started to hack on adding a >>> > progress bar. >>> > >>> > Result is available as the attached patch. I also attached a >>> > screenshot illustrating the results. The darker orange background of >>> > the right wave form overview widget will be filled completely when the >>> > track has been analysed, like a progress bar. The color used is the >>> > same as the wave form color, but with alpha value 60 out of 255. >>> > >>> > Comments? >>> > >>> > Jonas >>> > >>> >>> Hi, >>> >>> There was a bug in the previous version causing it only to work on one >>> of the skins (the one I was testing on, surprisingly). Attaching an >>> updated patch, also increasing the alpha value to 80/255. >>> >>> Jonas >>> -- >>> All of the data generated in your IT infrastructure is seriously valuable. >>> Why? It contains a definitive record of application performance, security >>> threats, fraudulent activity, and more. Splunk takes this data and makes >>> sense of it. IT sense. And common sense. >>> http://p.sf.net/sfu/splunk-d2d-c2 >>> ___ Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> >> >> > -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] Track analysis progress bar
On Wednesday, June 29, 2011 16:04:29 Jonas Ådahl wrote: > Thanks for the suggestion; I'll create a bug and attach it there. > > The instructions for submitting patches on the wiki is to send them to > the mailing list. If this is outdated information, I could update it > to suggest creating a ticket for possible contributions. Is it? > > Jonas > fyi -- I just updated the wiki with instructions on submitting patches to lp bugs, not the mixxx-devel. Thanks for the heads up. Bill -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
