Re: [Mixxx-devel] 1.12 windows build fixing
Hi all, Windows build is now ok on x86 and x64 But there was a network error when transferring the builded x86 installer from the build server to downloads.mixxx.org see end of log in : http://builds.mixxx.org:8081/jenkins/job/1.12-release/architecture=i386,platform=windows/lastBuild/consoleFull [6] the result is an incomplete package at http://downloads.mixxx.org/builds/1.12/release/mixxx-1.12.0-beta1-1.12-git5575-release-x86.exe [7] can someone drop this file on the download server as it is incorrect (it's only 7MB instead of 20+MB) ? Just to avoid someone downloading it and trying to install. I don't know what can be the side effect of this. Thanks, -- Sébastien Blaisot Le 16/10/2015 00:35, Sébastien Blaisot a écrit : > I finally got it compile on my machine. > > I sent a PR with all the changes I made : > > https://github.com/mixxxdj/mixxx/pull/743 [1] > > sb > > Le 16/10/2015 00:31, Sébastien Blaisot a écrit : in fact, both of them need > to be replaced with > TAGLIB_FILENAME_FROM_QSTRING(getFilename()) > > sb > > Le 16/10/2015 00:24, Sébastien Blaisot a écrit : sorry, wrong line. > > I meant > https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396 > [2] > > sb > > Le 16/10/2015 00:09, Sébastien Blaisot a écrit : Probably you also need to > patch this : > https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105 > [3] > > I have a link-time error (unresolved external symbol) for > soundsourcemediafoundation > > sb > > Le 15/10/2015 23:59, Daniel Schürmann a écrit : Nice! Then I will prepare a > commit, using this. > > Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot: I have no idea. > It is available in Visual Studio 2010, 2012, 2013 and 2015 > https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist [4] > but I don't know if it is dependant of an option at compile time. > > I know it works perfectly for me, out of the box (no special > configuration for VC) using scons and mixxx 1.12 config ;) > > sb > > Le 15/10/2015 23:50, Daniel Schürmann a écrit : Is this available on VC > without c++11 support? > > Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: As we are in a #ifdef > _WIN32, why not using native static_assert ? > https://msdn.microsoft.com/fr-fr/library/dd293588.aspx [5] > > sb -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org [8] Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel [9] -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org [8] Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel [9] -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org [8] Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel [9] -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org [8] Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel [9] Links: -- [1] https://github.com/mixxxdj/mixxx/pull/743 [2] https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396 [3] https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105 [4] https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist [5] https://msdn.microsoft.com/fr-fr/library/dd293588.aspx [6] http://builds.mixxx.org:8081/jenkins/job/1.12-release/architecture=i386,platform=windows/lastBuild/consoleFull [7] http://downloads.mixxx.org/builds/1.12/release/mixxx-1.12.0-beta1-1.12-git5575-release-x86.exe [8] http://mixxx.org [9] https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
As we are in a #ifdef _WIN32, why not using native static_assert ? https://msdn.microsoft.com/fr-fr/library/dd293588.aspx sb Le 15/10/2015 22:05, Daniel Schürmann a écrit : > Thank you. > > I have fixed the issue and have a working STATIC_ASSERT > just build local, will commit next. > > > Am 15.10.2015 um 22:00 schrieb Owen Williams: >> Still failing: >> >> >> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' >> soundsourcemediafoundation.cpp >> >> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : >> warning C4005: 'NOMINMAX' : macro redefinition >> command-line arguments : see previous definition of 'NOMINMAX' >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : >> error C2614: 'SoundSourceMediaFoundation' : illegal member >> initialization: 'm_wcFilename' is not a base or member >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : >> error C2065: 'm_wcFilename' : undeclared identifier >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >> error C2065: 'm_wcFilename' : undeclared identifier >> >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >> error C2541: 'delete' : cannot delete objects that are not pointers >> scons: *** [win64_build\plugins\win64_build\mediafoundation >> \soundsourcemediafoundation.obj] Error 2 >> scons: building terminated because of errors. >> >> Build step 'Execute Windows batch command' marked build as failure >> Recording test results >> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports >> were found but none of them are new. Did tests run? >> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform >> \windows\test_results.xml is 14 days old >> >> SSH: Current build result is [FAILURE], not going to run. >> >> Finished: FAILURE >> >> >> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote: >>> NULL), >>> >>> You're missing a closing parenthesis >>> >>> — >>> Reply to this email directly or view it on GitHub. >>> >>> >> >> -- >> ___ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
Still failing: cl : Ligne de commande warning D9002 : option '/arch:SSE2' inconnue ignorée audiotagger.cpp d:\mixxx-buildserver64\include\taglib\trefcounter.h(36) : warning C4005: 'NOMINMAX' : redéfinition de macro arguments de ligne de commande : voir la définition précédente de 'NOMINMAX' src\audiotagger.cpp(25) : error C4430: spécificateur de type manquant - int est pris en compte par défaut. Remarque : C++ ne prend pas en charge int par défaut scons: *** [win64_build\audiotagger.obj] Error 2 scons: building terminated because of errors. Le 15/10/2015 22:16, Daniel Schürmann a écrit : > New version is up: > https://github.com/mixxxdj/mixxx/commit/316e7e9900e03a7c331db6ebdf03d5c16c323651 > > Am 15.10.2015 um 22:00 schrieb Owen Williams: >> Still failing: >> >> >> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' >> soundsourcemediafoundation.cpp >> >> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : >> warning C4005: 'NOMINMAX' : macro redefinition >> command-line arguments : see previous definition of 'NOMINMAX' >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : >> error C2614: 'SoundSourceMediaFoundation' : illegal member >> initialization: 'm_wcFilename' is not a base or member >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : >> error C2065: 'm_wcFilename' : undeclared identifier >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >> error C2065: 'm_wcFilename' : undeclared identifier >> >> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >> error C2541: 'delete' : cannot delete objects that are not pointers >> scons: *** [win64_build\plugins\win64_build\mediafoundation >> \soundsourcemediafoundation.obj] Error 2 >> scons: building terminated because of errors. >> >> Build step 'Execute Windows batch command' marked build as failure >> Recording test results >> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports >> were found but none of them are new. Did tests run? >> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform >> \windows\test_results.xml is 14 days old >> >> SSH: Current build result is [FAILURE], not going to run. >> >> Finished: FAILURE >> >> >> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote: >>> NULL), >>> >>> You're missing a closing parenthesis >>> >>> — >>> Reply to this email directly or view it on GitHub. >>> >>> >> >> -- >> ___ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
in fact, both of them need to be replaced with TAGLIB_FILENAME_FROM_QSTRING(getFilename()) sb Le 16/10/2015 00:24, Sébastien Blaisot a écrit : > sorry, wrong line. > > I meant > https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396 > > sb > > Le 16/10/2015 00:09, Sébastien Blaisot a écrit : >> Probably you also need to patch this : >> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105 >> >> I have a link-time error (unresolved external symbol) for >> soundsourcemediafoundation >> >> sb >> >> Le 15/10/2015 23:59, Daniel Schürmann a écrit : >>> Nice! Then I will prepare a commit, using this. >>> >>> Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot: I have no idea. It is available in Visual Studio 2010, 2012, 2013 and 2015 https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist but I don't know if it is dependant of an option at compile time. I know it works perfectly for me, out of the box (no special configuration for VC) using scons and mixxx 1.12 config ;) sb Le 15/10/2015 23:50, Daniel Schürmann a écrit : > Is this available on VC without c++11 support? > > Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: >> As we are in a #ifdef _WIN32, why not using native static_assert ? >> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx >> >> sb >> >> -- >> ___ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
New version is up: https://github.com/mixxxdj/mixxx/commit/316e7e9900e03a7c331db6ebdf03d5c16c323651 Am 15.10.2015 um 22:00 schrieb Owen Williams: > Still failing: > > > cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' > soundsourcemediafoundation.cpp > > c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : > warning C4005: 'NOMINMAX' : macro redefinition > command-line arguments : see previous definition of 'NOMINMAX' > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : > error C2614: 'SoundSourceMediaFoundation' : illegal member > initialization: 'm_wcFilename' is not a base or member > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : > error C2065: 'm_wcFilename' : undeclared identifier > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : > error C2065: 'm_wcFilename' : undeclared identifier > > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : > error C2541: 'delete' : cannot delete objects that are not pointers > scons: *** [win64_build\plugins\win64_build\mediafoundation > \soundsourcemediafoundation.obj] Error 2 > scons: building terminated because of errors. > > Build step 'Execute Windows batch command' marked build as failure > Recording test results > ERROR: Publisher 'Publish JUnit test result report' failed: Test reports > were found but none of them are new. Did tests run? > For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform > \windows\test_results.xml is 14 days old > > SSH: Current build result is [FAILURE], not going to run. > > Finished: FAILURE > > > On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote: >> NULL), >> >> You're missing a closing parenthesis >> >> — >> Reply to this email directly or view it on GitHub. >> >> > > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
Is this available on VC without c++11 support? Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: > As we are in a #ifdef _WIN32, why not using native static_assert ? > https://msdn.microsoft.com/fr-fr/library/dd293588.aspx > > sb > > Le 15/10/2015 22:05, Daniel Schürmann a écrit : >> Thank you. >> >> I have fixed the issue and have a working STATIC_ASSERT >> just build local, will commit next. >> >> >> Am 15.10.2015 um 22:00 schrieb Owen Williams: >>> Still failing: >>> >>> >>> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' >>> soundsourcemediafoundation.cpp >>> >>> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : >>> warning C4005: 'NOMINMAX' : macro redefinition >>>command-line arguments : see previous definition of 'NOMINMAX' >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : >>> error C2614: 'SoundSourceMediaFoundation' : illegal member >>> initialization: 'm_wcFilename' is not a base or member >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : >>> error C2065: 'm_wcFilename' : undeclared identifier >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >>> error C2065: 'm_wcFilename' : undeclared identifier >>> >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >>> error C2541: 'delete' : cannot delete objects that are not pointers >>> scons: *** [win64_build\plugins\win64_build\mediafoundation >>> \soundsourcemediafoundation.obj] Error 2 >>> scons: building terminated because of errors. >>> >>> Build step 'Execute Windows batch command' marked build as failure >>> Recording test results >>> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports >>> were found but none of them are new. Did tests run? >>> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform >>> \windows\test_results.xml is 14 days old >>> >>> SSH: Current build result is [FAILURE], not going to run. >>> >>> Finished: FAILURE >>> >>> >>> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote: NULL), You're missing a closing parenthesis — Reply to this email directly or view it on GitHub. >>> -- >>> ___ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> -- >> ___ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
I finally got it compile on my machine. I sent a PR with all the changes I made : https://github.com/mixxxdj/mixxx/pull/743 sb Le 16/10/2015 00:31, Sébastien Blaisot a écrit : > in fact, both of them need to be replaced with > TAGLIB_FILENAME_FROM_QSTRING(getFilename()) > > sb > > Le 16/10/2015 00:24, Sébastien Blaisot a écrit : >> sorry, wrong line. >> >> I meant >> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396 >> >> sb >> >> Le 16/10/2015 00:09, Sébastien Blaisot a écrit : >>> Probably you also need to patch this : >>> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105 >>> >>> I have a link-time error (unresolved external symbol) for >>> soundsourcemediafoundation >>> >>> sb >>> >>> Le 15/10/2015 23:59, Daniel Schürmann a écrit : Nice! Then I will prepare a commit, using this. Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot: > I have no idea. > It is available in Visual Studio 2010, 2012, 2013 and 2015 > https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist > but I don't know if it is dependant of an option at compile time. > > I know it works perfectly for me, out of the box (no special > configuration for VC) using scons and mixxx 1.12 config ;) > > sb > > Le 15/10/2015 23:50, Daniel Schürmann a écrit : >> Is this available on VC without c++11 support? >> >> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: >>> As we are in a #ifdef _WIN32, why not using native static_assert ? >>> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx >>> >>> sb >>> -- >>> ___ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> -- >> ___ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
Thank you. I have fixed the issue and have a working STATIC_ASSERT just build local, will commit next. Am 15.10.2015 um 22:00 schrieb Owen Williams: > Still failing: > > > cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' > soundsourcemediafoundation.cpp > > c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : > warning C4005: 'NOMINMAX' : macro redefinition > command-line arguments : see previous definition of 'NOMINMAX' > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : > error C2614: 'SoundSourceMediaFoundation' : illegal member > initialization: 'm_wcFilename' is not a base or member > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : > error C2065: 'm_wcFilename' : undeclared identifier > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : > error C2065: 'm_wcFilename' : undeclared identifier > > plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : > error C2541: 'delete' : cannot delete objects that are not pointers > scons: *** [win64_build\plugins\win64_build\mediafoundation > \soundsourcemediafoundation.obj] Error 2 > scons: building terminated because of errors. > > Build step 'Execute Windows batch command' marked build as failure > Recording test results > ERROR: Publisher 'Publish JUnit test result report' failed: Test reports > were found but none of them are new. Did tests run? > For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform > \windows\test_results.xml is 14 days old > > SSH: Current build result is [FAILURE], not going to run. > > Finished: FAILURE > > > On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote: >> NULL), >> >> You're missing a closing parenthesis >> >> — >> Reply to this email directly or view it on GitHub. >> >> > > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
Probably you also need to patch this : https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105 I have a link-time error (unresolved external symbol) for soundsourcemediafoundation sb Le 15/10/2015 23:59, Daniel Schürmann a écrit : > Nice! Then I will prepare a commit, using this. > > Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot: >> I have no idea. >> It is available in Visual Studio 2010, 2012, 2013 and 2015 >> https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist >> but I don't know if it is dependant of an option at compile time. >> >> I know it works perfectly for me, out of the box (no special >> configuration for VC) using scons and mixxx 1.12 config ;) >> >> sb >> >> Le 15/10/2015 23:50, Daniel Schürmann a écrit : >>> Is this available on VC without c++11 support? >>> >>> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: As we are in a #ifdef _WIN32, why not using native static_assert ? https://msdn.microsoft.com/fr-fr/library/dd293588.aspx sb -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
I have no idea. It is available in Visual Studio 2010, 2012, 2013 and 2015 https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist but I don't know if it is dependant of an option at compile time. I know it works perfectly for me, out of the box (no special configuration for VC) using scons and mixxx 1.12 config ;) sb Le 15/10/2015 23:50, Daniel Schürmann a écrit : > Is this available on VC without c++11 support? > > Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: >> As we are in a #ifdef _WIN32, why not using native static_assert ? >> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx >> >> sb >> >> Le 15/10/2015 22:05, Daniel Schürmann a écrit : >>> Thank you. >>> >>> I have fixed the issue and have a working STATIC_ASSERT >>> just build local, will commit next. >>> >>> >>> Am 15.10.2015 um 22:00 schrieb Owen Williams: Still failing: cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' soundsourcemediafoundation.cpp c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : warning C4005: 'NOMINMAX' : macro redefinition command-line arguments : see previous definition of 'NOMINMAX' plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : error C2614: 'SoundSourceMediaFoundation' : illegal member initialization: 'm_wcFilename' is not a base or member plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : error C2065: 'm_wcFilename' : undeclared identifier plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : error C2065: 'm_wcFilename' : undeclared identifier plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : error C2541: 'delete' : cannot delete objects that are not pointers scons: *** [win64_build\plugins\win64_build\mediafoundation \soundsourcemediafoundation.obj] Error 2 scons: building terminated because of errors. Build step 'Execute Windows batch command' marked build as failure Recording test results ERROR: Publisher 'Publish JUnit test result report' failed: Test reports were found but none of them are new. Did tests run? For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform \windows\test_results.xml is 14 days old SSH: Current build result is [FAILURE], not going to run. Finished: FAILURE On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote: > NULL), > > You're missing a closing parenthesis > > — > Reply to this email directly or view it on GitHub. > > -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> -- >>> ___ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> -- >> ___ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] 1.12 windows build fixing
It seems to be compiling fine if you replace STATIC_ASSERT(sizeof(wchar_t) == sizeof(QChar)); with static_assert(sizeof(wchar_t) == sizeof(QChar), "wchar_t is not the same size than QChar"); and remove STATIC_ASSERT definition in src/util/assert.h sb Le 15/10/2015 23:41, Sébastien Blaisot a écrit : > As we are in a #ifdef _WIN32, why not using native static_assert ? > https://msdn.microsoft.com/fr-fr/library/dd293588.aspx > > sb > > Le 15/10/2015 22:05, Daniel Schürmann a écrit : >> Thank you. >> >> I have fixed the issue and have a working STATIC_ASSERT >> just build local, will commit next. >> >> >> Am 15.10.2015 um 22:00 schrieb Owen Williams: >>> Still failing: >>> >>> >>> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' >>> soundsourcemediafoundation.cpp >>> >>> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : >>> warning C4005: 'NOMINMAX' : macro redefinition >>>command-line arguments : see previous definition of 'NOMINMAX' >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : >>> error C2614: 'SoundSourceMediaFoundation' : illegal member >>> initialization: 'm_wcFilename' is not a base or member >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : >>> error C2065: 'm_wcFilename' : undeclared identifier >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >>> error C2065: 'm_wcFilename' : undeclared identifier >>> >>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : >>> error C2541: 'delete' : cannot delete objects that are not pointers >>> scons: *** [win64_build\plugins\win64_build\mediafoundation >>> \soundsourcemediafoundation.obj] Error 2 >>> scons: building terminated because of errors. >>> >>> Build step 'Execute Windows batch command' marked build as failure >>> Recording test results >>> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports >>> were found but none of them are new. Did tests run? >>> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform >>> \windows\test_results.xml is 14 days old >>> >>> SSH: Current build result is [FAILURE], not going to run. >>> >>> Finished: FAILURE >>> >>> >>> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote: NULL), You're missing a closing parenthesis — Reply to this email directly or view it on GitHub. >>> -- >>> ___ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> -- >> ___ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- > ___ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel