Re: [mkgmap-dev] NOD127 branch ready to merge?

2014-03-13 Thread Minko
+1

Excellent Gerd, I can finally make some paths routable again, with the trunk 
version it was not possible to get a good routing for cyclists and pedestrians 
(foot=no, bicycle=no didnt work in Basecamp) and now it makes a difference!


 the work on this branch is finished.
 We think it is ready for merge to trunk.
 
 If I hear no complains, I'll merge on
 friday.
 
 Gerd
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] NOD127 branch ready to merge?

2014-03-13 Thread Gerd Petermann
Hi Minko,

thanks for the feedback. I tried routing with your style but I was not 
sure that I found the right options for Basecamp, MapSource and the device.
Do you think that these hints are still correct?
http://mijndev.openstreetmap.nl/~ligfietser/openfietsmap/full/readme.html

Gerd

 Date: Thu, 13 Mar 2014 08:46:02 +0100
 From: ligfiet...@online.nl
 To: mkgmap-dev@lists.mkgmap.org.uk
 Subject: Re: [mkgmap-dev] NOD127 branch ready to merge?
 
 +1
 
 Excellent Gerd, I can finally make some paths routable again, with the trunk 
 version it was not possible to get a good routing for cyclists and 
 pedestrians (foot=no, bicycle=no didnt work in Basecamp) and now it makes a 
 difference!
 
 
  the work on this branch is finished.
  We think it is ready for merge to trunk.
  
  If I hear no complains, I'll merge on
  friday.
  
  Gerd
 ___
 mkgmap-dev mailing list
 mkgmap-dev@lists.mkgmap.org.uk
 http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] Commit: r3109: correct SeaGenerator and some Boundary tools

2014-03-13 Thread svn commit

Version mkgmap-r3109 was committed by gerd on Thu, 13 Mar 2014

correct SeaGenerator and some Boundary tools

use high precision in Way.clockwise() and Way.containsPointsOf()
This reduces the number of messages like
 Converting anti-island starting at ... into an island as it is surrounded by 
water

The routines are not used to calculate precompiled sea data or precompiled 
boundary data, but they are used in tools like
BoundaryCoverageUtil, BoundaryDiff, BoundaryFile2Gpx
and to debug boundary data, so there is no need to 
create new precompiled data because of this change.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] default style and underground pipelines

2014-03-13 Thread Gerd Petermann
Hi Marko,

thanks for reporting this. I did not change
two routines to use high precision coordinates.

See 
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmaprev=3109
for details.

Gerd

 Date: Tue, 18 Feb 2014 11:04:59 +0200
 From: marko.mak...@iki.fi
 To: mkgmap-dev@lists.mkgmap.org.uk
 Subject: Re: [mkgmap-dev] default style and underground pipelines
 
 Hi Gerd,
 
 is it intended that these ways are placed in the map?
 sample:
 http://www.openstreetmap.org/way/60575011
 
 man_made=pipeline
 type=water
 location=underground
 
 This rule in lines fires:
 
 man_made=cable|(man_made=*  man_made ~ '.*pipe.*')
 {name '${name} (${operator})' | '${name}' | '${operator}' }
 [0x28 resolution 23]
 
 I wrote this rule with visible features in mind, such as oil or gas 
 pipelines in rural areas. In well-mapped urban areas, this can cause 
 unnecessary clutter, just like subways and tunnels with access=private, 
 which are being omitted by the default style.
 
 Maybe there should be a way to limit the visibility of some objects 
 based on the map density or nearby map features. If a cycleway or 
 highway is parallel to a pipeline, then the pipeline should be hidden 
 except maybe in resolution=24. Likewise, if a cycleway is parallel to a 
 highway, it should be hidden at lower zoom levels. If there are two 
 antiparallel oneways for a highway=*, only one should be generated at 
 lower zoom levels.
 
 Best regards,
 
   Marko
 ___
 mkgmap-dev mailing list
 mkgmap-dev@lists.mkgmap.org.uk
 http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] NOD127 branch ready to merge?

2014-03-13 Thread Minko
Well, you are right, last weeks upload was by mistake made with mkgmap-r3081, 
the trunk version.
So those maps still have the old behaviour, although the description in the 
readme file was supposed for the branch version ;-)
Now the NOD branch is ready, I can now optimize my styles further to make more 
paths accessible for bicycles or foot and unaccesible for car routing (=racing 
bike).

 
 thanks for the feedback. I tried routing with your style but I was not
 sure that I found the right options for Basecamp, MapSource and the
 device.
 Do you think that these hints are still correct?
 http://mijndev.openstreetmap.nl/~ligfietser/openfietsmap/full/readme.html
 
 Gerd

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] default style and underground pipelines

2014-03-13 Thread Gerd Petermann
Sorry, replied to the wrong post.

It was meant to be this:
http://gis.19327.n5.nabble.com/Bogus-anti-island-warnings-for-tiny-natural-coastline-tp5799271.html

Gerd

From: gpetermann_muenc...@hotmail.com
To: mkgmap-dev@lists.mkgmap.org.uk
Date: Thu, 13 Mar 2014 09:28:39 +0100
Subject: Re: [mkgmap-dev] default style and underground pipelines




Hi Marko,

thanks for reporting this. I did not change
two routines to use high precision coordinates.

See 
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmaprev=3109
for details.

Gerd

 Date: Tue, 18 Feb 2014 11:04:59 +0200
 From: marko.mak...@iki.fi
 To: mkgmap-dev@lists.mkgmap.org.uk
 Subject: Re: [mkgmap-dev] default style and underground pipelines
 
 Hi Gerd,
 
 is it intended that these ways are placed in the map?
 sample:
 http://www.openstreetmap.org/way/60575011
 
 man_made=pipeline
 type=water
 location=underground
 
 This rule in lines fires:
 
 man_made=cable|(man_made=*  man_made ~ '.*pipe.*')
 {name '${name} (${operator})' | '${name}' | '${operator}' }
 [0x28 resolution 23]
 
 I wrote this rule with visible features in mind, such as oil or gas 
 pipelines in rural areas. In well-mapped urban areas, this can cause 
 unnecessary clutter, just like subways and tunnels with access=private, 
 which are being omitted by the default style.
 
 Maybe there should be a way to limit the visibility of some objects 
 based on the map density or nearby map features. If a cycleway or 
 highway is parallel to a pipeline, then the pipeline should be hidden 
 except maybe in resolution=24. Likewise, if a cycleway is parallel to a 
 highway, it should be hidden at lower zoom levels. If there are two 
 antiparallel oneways for a highway=*, only one should be generated at 
 lower zoom levels.
 
 Best regards,
 
   Marko
 ___
 mkgmap-dev mailing list
 mkgmap-dev@lists.mkgmap.org.uk
 http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] default style and underground pipelines

2014-03-13 Thread chris66
Am 18.02.2014 10:04, schrieb Marko Mäkelä:

 man_made=pipeline
 type=water
 location=underground

 This rule in lines fires:

 man_made=cable|(man_made=*  man_made ~ '.*pipe.*')
 {name '${name} (${operator})' | '${name}' | '${operator}' }
 [0x28 resolution 23]
 
 I wrote this rule with visible features in mind, such as oil or gas
 pipelines in rural areas. In well-mapped urban areas, this can cause
 unnecessary clutter, just like subways and tunnels with access=private,
 which are being omitted by the default style.

I think underground pipelines should not be displayed, so a filter
for location=underground should be added IMHO.

Chris



___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] NOD127 branch ready to merge?

2014-03-13 Thread Gerd Petermann
Hi ,

I think all map creators should check theirs hints regarding the
use of MapSource, Basecamp and firmware versions on devices
when they use the branch.

I'd expect to see good routing results with the latest versions of 
Garmin software, but I am not sure regarding the so called 
activity routing.

I'm investigating one problem reported by WanMil now.

Gerd

 Date: Thu, 13 Mar 2014 09:29:11 +0100
 From: ligfiet...@online.nl
 To: mkgmap-dev@lists.mkgmap.org.uk
 Subject: Re: [mkgmap-dev] NOD127 branch ready to merge?
 
 Well, you are right, last weeks upload was by mistake made with mkgmap-r3081, 
 the trunk version.
 So those maps still have the old behaviour, although the description in the 
 readme file was supposed for the branch version ;-)
 Now the NOD branch is ready, I can now optimize my styles further to make 
 more paths accessible for bicycles or foot and unaccesible for car routing 
 (=racing bike).
 
  
  thanks for the feedback. I tried routing with your style but I was not
  sure that I found the right options for Basecamp, MapSource and the
  device.
  Do you think that these hints are still correct?
  http://mijndev.openstreetmap.nl/~ligfietser/openfietsmap/full/readme.html
  
  Gerd
 
 ___
 mkgmap-dev mailing list
 mkgmap-dev@lists.mkgmap.org.uk
 http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] default style and underground pipelines

2014-03-13 Thread Gerd Petermann
Hi Chris,

I agree, but I am not an expert reg. style rules.
Please send a proposal.

Gerd

 To: mkgmap-dev@lists.mkgmap.org.uk
 From: chris66...@gmx.de
 Date: Thu, 13 Mar 2014 09:36:57 +0100
 Subject: Re: [mkgmap-dev] default style and underground pipelines
 
 Am 18.02.2014 10:04, schrieb Marko Mäkelä:
 
  man_made=pipeline
  type=water
  location=underground
 
  This rule in lines fires:
 
  man_made=cable|(man_made=*  man_made ~ '.*pipe.*')
  {name '${name} (${operator})' | '${name}' | '${operator}' }
  [0x28 resolution 23]
  
  I wrote this rule with visible features in mind, such as oil or gas
  pipelines in rural areas. In well-mapped urban areas, this can cause
  unnecessary clutter, just like subways and tunnels with access=private,
  which are being omitted by the default style.
 
 I think underground pipelines should not be displayed, so a filter
 for location=underground should be added IMHO.
 
 Chris
 
 
 
 ___
 mkgmap-dev mailing list
 mkgmap-dev@lists.mkgmap.org.uk
 http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] default style and underground pipelines

2014-03-13 Thread chris66
Am 13.03.2014 09:39, schrieb Gerd Petermann:
 Hi Chris,
 
 I agree, but I am not an expert reg. style rules.
 Please send a proposal.
 
 Gerd


Something like:

man_made=*  location=underground {delete man_made}

in front of the main rule.

Chris




___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] default style and underground pipelines

2014-03-13 Thread Marko Mäkelä

On Thu, Mar 13, 2014 at 09:46:26AM +0100, chris66 wrote:

Something like:

man_made=*  location=underground {delete man_made}

in front of the main rule.


Yes, and maybe others, such as:

man_made=*  tunnel=yes {delete man_made}

But, there could be a caveat. What is the scope of delete? If a 
polygon rule uses delete, will the tag be visible in a line rule? Or 
vice versa?


By the way, the man_made=* rule at the bottom could accidentally catch 
some man_made that were skipped because of area=yes earlier. I think 
that we should do one of:


man_made=*  area=yes {delete man_made}

or add area!=yes to the cable/pipe rule.

If the delete action could interfere with rules in other files, I guess 
we should change the bottom rule from


man_made=cable|(man_made=*  man_made ~ '.*pipe.*')

to something like this:

(man_made=cable|(man_made=*  man_made ~ '.*pipe.*'))  area!=yes  
tunnel!=yes  location!=underground


Marko
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] default style and underground pipelines

2014-03-13 Thread Gerd Petermann
Hi Marko,
 But, there could be a caveat. What is the scope of delete? If a 
 polygon rule uses delete, will the tag be visible in a line rule? Or 
 vice versa?

If the way is not closed, only the rules in the lines file are used.
If the way is closed, the rules in the lines file are used before the rules
in the polygons file. In this case the rules are combined are
if they were placed in one file.
So yes, if you delete a tag in the lines file, the tag is not visible in
the rules of the polygons file.

A special case: Some ways are only passed to the polygon rules
or only to the lines rules, this happens for ways that are members
of mp relations or created by mp-processing.

Gerd
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] adjust-turn-headings

2014-03-13 Thread Gerd Petermann
Hi programmers,

I think this option is not working in all cases.
I already mentioned that it has problems since
we have mergeroads, but there is also another 
problem:
It will only make angles larger when they are too small,
but it will not make angles smaller when they should
be small. 
Connections between class 4 roads do typically not
have sharp angles, so this method should
also modify angles so that they are close to straight lines.

I don't have time to look at this during the next days.

Gerd


  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] NOD127 branch ready to merge?

2014-03-13 Thread Steve Ratcliffe

Hi

Its been a long time since any significant improvement has been
made to the routing code, so many thanks for all the time that
Gerd has put into this.

The latest trunk already has a few of the changes so the best point
of comparison is with r3072 or earlier.

The other thing to note is that over the years, workarounds may have 
been developed that are no longer necessary or even counter-productive.

So you may need to check a custom style, particularly if it is heavily
modified to target cycling etc rather than cars.

..Steve

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] problem with address search and --code-page

2014-03-13 Thread Steve Ratcliffe

Hi

 Did you have time to look for the cause of this bug?

Sorry I've been distracted by all the routing excitement :)
I shall take a look later today.

..Steve

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] Bogus anti-island warnings for tiny natural=coastline

2014-03-13 Thread Marko Mäkelä

On Tue, Mar 11, 2014 at 08:33:34AM +0100, Gerd Petermann wrote:
I guess we can change that, but I'd first like to finish the 
NOD127 branch.


Thanks, now I only see very small shape warnings, with no OSM tags.  
The tags might be useful for collecting some statistics, but little 
else.


Marko
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


[mkgmap-dev] Turn restrictions with role=via ways

2014-03-13 Thread Marko Mäkelä
Now, with all these routing improvements, I wonder if it would be 
possible to extend our support for turn restrictions.


Some mapper seems to prefer via ways to via nodes in this crossing:

http://www.openstreetmap.org/way/30692839

This 2-node way is a role=via member of a no_u_turn restriction that has 
4 ways as members: from,via,via,to. It is also a role=via member of a 
no_left_turn restriction.


The no_u_turn restriction could have been mapped with three ways as 
from,via,to and the no_left_turn could have been mapped with having this 
way as role=from, and a node as role=via. Even if I changed the map like 
that, mkgmap would still ignore the no_u_turn, because the role=via 
member would be a way.


So, I wonder if we could start supporting this style of mapping? There 
are lots of dual carriageways in city areas where such turn restrictions 
are common, at least for no_u_turn.


Marko
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


[mkgmap-dev] Commit: r3110: Hide underground pipelines and cables in the default style.

2014-03-13 Thread svn commit

Version mkgmap-r3110 was committed by marko on Thu, 13 Mar 2014

Hide underground pipelines and cables in the default style.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev