Re: [mkgmap-dev] NPE with r3183 & r3185
Hi Henning, when all errors are fixed, mkgmap will evaluate the tags described in the wiki: http://wiki.openstreetmap.org/wiki/Relation:restriction If your style abuses e.g. car routing for racing bikes, you may have to add rules in the relations file. See 1st http://gis.19327.n5.nabble.com/r3165-in-via-ways-branch-tp5802056.html and then http://gis.19327.n5.nabble.com/vehicles-in-restriction-relations-tp5801618p5802487.html Gerd Henning Scholland wrote > Hi Gerd, > so the exeptions are handled with the normal access-rules? > > Henning > > Am 13.04.2014 18:28, schrieb Gerd Petermann: >> Hi Henning, >> >> I think you should remove or comment them. >> They were ignored in older versions of mkgmap, and they are obsolete in >> the current version, as mkgmap evaluates the tags itself. >> >> I am still working on a bigger patch to fix some other issues >> regarding restriction relations, >> maybe I'll post a first version today. >> >> Gerd > > ___ > mkgmap-dev mailing list > mkgmap-dev@.org > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- View this message in context: http://gis.19327.n5.nabble.com/NPE-with-r3183-r3185-tp5803133p5803144.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] NPE with r3183 & r3185
Hi Gerd, so the exeptions are handled with the normal access-rules? Henning Am 13.04.2014 18:28, schrieb Gerd Petermann: Hi Henning, I think you should remove or comment them. They were ignored in older versions of mkgmap, and they are obsolete in the current version, as mkgmap evaluates the tags itself. I am still working on a bigger patch to fix some other issues regarding restriction relations, maybe I'll post a first version today. Gerd ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Commit: r3189: now really fix NPE that occurs when relations style file removes the restriction tag
Version mkgmap-r3189 was committed by gerd on Sun, 13 Apr 2014 now really fix NPE that occurs when relations style file removes the restriction tag (r3188 ignored all restriction relations) ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] NPE with r3183 & r3185
Hi Henning,
I think you should remove or comment them.
They were ignored in older versions of mkgmap, and they are obsolete in
the current version, as mkgmap evaluates the tags itself.
I am still working on a bigger patch to fix some other issues regarding
restriction relations,
maybe I'll post a first version today.
Gerd
Date: Sun, 13 Apr 2014 18:20:02 +0200
From: o...@aighes.de
To: mkgmap-dev@lists.mkgmap.org.uk
Subject: Re: [mkgmap-dev] NPE with r3183 & r3185
Hi Gerd,
so how I have to change my style to get the same effect as I got
before?
Henning
Am 13.04.2014 17:39, schrieb Gerd Petermann:
Hi Henning,
yes, these two lines are problematic:
type=restriction & except ~ '.*bicycle*.' { delete type ; delete
restriction }type=restriction:bicycle { set restriction =
'${restriction:bicycle}' }
mkgmap ignored them up to release r3169, now they have an
effect. I'll add checks to detect that.
Gerd
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] NPE with r3183 & r3185
Hi Gerd,
so how I have to change my style to get the same effect as I got before?
Henning
Am 13.04.2014 17:39, schrieb Gerd Petermann:
Hi Henning,
yes, these two lines are problematic:
type=restriction & except ~ '.*bicycle*.' { delete type ; delete
restriction }
type=restriction:bicycle { set restriction = '${restriction:bicycle}' }
mkgmap ignored them up to release r3169, now they have an effect. I'll
add checks to detect that.
Gerd
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Commit: r3188: fix NPE that occurs when relations style file removes the restriction tag
Version mkgmap-r3188 was committed by gerd on Sun, 13 Apr 2014 fix NPE that occurs when relations style file removes the restriction tag ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] NPE with r3183 & r3185
Hi Henning,
yes, these two lines are problematic:
type=restriction & except ~ '.*bicycle*.' { delete type ; delete restriction
}type=restriction:bicycle { set restriction = '${restriction:bicycle}' }
mkgmap ignored them up to release r3169, now they have an effect. I'll add
checks to detect that.
Gerd
> Date: Sun, 13 Apr 2014 17:09:43 +0200
> From: o...@aighes.de
> To: mkgmap-dev@lists.mkgmap.org.uk
> Subject: [mkgmap-dev] NPE with r3183 & r3185
>
> Hi everybody,
>
> since updating to r3183 I get the following NPE. Also Updating to r3185
> doesn't solve the issue to me. The NPE doesn't occur in all my maps, but
> in several ones, mainly in maps with higher density of mapping.
>
> Henning
>
> java.lang.NullPointerException
> at
> uk.me.parabola.mkgmap.reader.osm.RestrictionRelation.eval(RestrictionRelation.java:106)
> at
> uk.me.parabola.mkgmap.reader.osm.RelationStyleHook.end(RelationStyleHook.java:56)
> at
> uk.me.parabola.mkgmap.reader.osm.OsmReadingHooksChain.end(OsmReadingHooksChain.java:79)
> at
> uk.me.parabola.mkgmap.reader.osm.o5m.O5mBinMapDataSource.load(O5mBinMapDataSource.java:49)
> at
> uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127)
> at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167)
> at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63)
> at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:220)
> at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:216)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] NPE with r3183 & r3185
Hi Henning, looks like your relations style file is removing the tag restriction=* or one that starts with "restriction:" Is that intended? Gerd > Date: Sun, 13 Apr 2014 17:09:43 +0200 > From: o...@aighes.de > To: mkgmap-dev@lists.mkgmap.org.uk > Subject: [mkgmap-dev] NPE with r3183 & r3185 > > Hi everybody, > > since updating to r3183 I get the following NPE. Also Updating to r3185 > doesn't solve the issue to me. The NPE doesn't occur in all my maps, but > in several ones, mainly in maps with higher density of mapping. > > Henning > > java.lang.NullPointerException > at > uk.me.parabola.mkgmap.reader.osm.RestrictionRelation.eval(RestrictionRelation.java:106) > at > uk.me.parabola.mkgmap.reader.osm.RelationStyleHook.end(RelationStyleHook.java:56) > at > uk.me.parabola.mkgmap.reader.osm.OsmReadingHooksChain.end(OsmReadingHooksChain.java:79) > at > uk.me.parabola.mkgmap.reader.osm.o5m.O5mBinMapDataSource.load(O5mBinMapDataSource.java:49) > at > uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127) > at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) > at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) > at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:220) > at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:216) > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:744) > > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] NPE with r3183 & r3185
Hi everybody, since updating to r3183 I get the following NPE. Also Updating to r3185 doesn't solve the issue to me. The NPE doesn't occur in all my maps, but in several ones, mainly in maps with higher density of mapping. Henning java.lang.NullPointerException at uk.me.parabola.mkgmap.reader.osm.RestrictionRelation.eval(RestrictionRelation.java:106) at uk.me.parabola.mkgmap.reader.osm.RelationStyleHook.end(RelationStyleHook.java:56) at uk.me.parabola.mkgmap.reader.osm.OsmReadingHooksChain.end(OsmReadingHooksChain.java:79) at uk.me.parabola.mkgmap.reader.osm.o5m.O5mBinMapDataSource.load(O5mBinMapDataSource.java:49) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:220) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:216) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] restriction relations with wrong restriction text
Hi , the current wiki http://wiki.openstreetmap.org/wiki/Relation:restriction#Tags documents these restriction texts: no_right_turn / no_left_turn / no_u_turn / no_straight_on / only_right_turn / only_left_turn / only_straight_on / no_entry / no_exit current mkgmap allows typos like no_turn_right , no_turn_xyz (anything that starts with no_turn) as well as all strings that start with only_turn It prints a warning for them, but doesn't ignore them. I found 14 no_turn_on_red restrictions like this: http://www.openstreetmap.org/relation/204 which probably should not be interpreted like normal restrictions, so I think mkgmap should not accept generics. OK? Gerd > Date: Sun, 13 Apr 2014 13:23:35 +0200 > From: ku...@suse.de > To: mkgmap-dev@lists.mkgmap.org.uk > Subject: Re: [mkgmap-dev] restriction relations with wrong restriction text > > On Sun, Apr 13, Gerd Petermann wrote: > > > Hi all, > > > > should mkgmap ignore if a no_left_turn restriction doesn't describe a > > no_left_turn? > > > > For example, look at this > > http://www.openstreetmap.org/relation/3414378 > > That's around the corner of my old flat, I know the area very well. > The text is correct, the to way is wrong. I will fix that. > I think in such cases you should ignore the restriction and > print a warning, so that people can fix it. > > > In short: the restriction should be ignored after printing a warning. > > Correct. > > Thorsten > > -- > Thorsten Kukuk, Senior Architect SLES & Common Code Base > SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Commit: r3187: make-cycleways-v1.patch:
Version mkgmap-r3187 was committed by gerd on Sun, 13 Apr 2014 make-cycleways-v1.patch: - fix error: evaluate oneway:bicycle=no and bicycle:oneway=no also if no cycleway=* tag is found - document options --make-all-cycleways and --make-cycleways as deprecated, ignore make-cycleways and print request to use make-opposite-cycleways if make-all-cycleways is used - evaluate also tags cycleway:left=opposite_track, cycleway:left=opposite_lane, cycleway:right=opposite_track, cycleway:right=opposite_lane as triggers to create the additional cycleway in oneways. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Commit: r3186: improvements by Minko:
Version mkgmap-r3186 was committed by gerd on Sun, 13 Apr 2014 improvements by Minko: - don't open a new window for uninstall process - if map was already installed, use the existing past instead of the default c:\garmin\maps ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] restriction relations with wrong restriction text
On Sun, Apr 13, Gerd Petermann wrote: > Hi all, > > should mkgmap ignore if a no_left_turn restriction doesn't describe a > no_left_turn? > > For example, look at this > http://www.openstreetmap.org/relation/3414378 That's around the corner of my old flat, I know the area very well. The text is correct, the to way is wrong. I will fix that. I think in such cases you should ignore the restriction and print a warning, so that people can fix it. > In short: the restriction should be ignored after printing a warning. Correct. Thorsten -- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] restriction relations with wrong restriction text
Hi all, should mkgmap ignore if a no_left_turn restriction doesn't describe a no_left_turn? For example, look at this http://www.openstreetmap.org/relation/3414378 >From and to way build a straight line, but tag says restriction=no_left_turn. I think it is not clear what is meant, this might be an "only_straight_on" or the to way is wrong or the from way is wrong. In short: the restriction should be ignored after printing a warning. I've coded this check to be very tolerant , so this one is accepted: http://www.openstreetmap.org/relation/1394386 although the difference to a straight line is only 10 degrees. My test would complain if the difference would be less than 3 degrees. OK? Better ideas? Ciao, Gerd ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
