[mkgmap-dev] Commit: r3230: partly revert r3228 & r3229

[svn commit]

Version mkgmap-r3230 was committed by gerd on Fri, 25 Apr 2014

partly revert r3228 & r3229 

Don't combine routable and non-routable lines in WrongAngleFixer.
This causes more distorted lines at crossings with railways (tram)
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] Problem with this restriction?

[Gerd Petermann]

Hi Bernd,

okay, r3230 looks better now, and it still fixes the problem reported
be Enrico.

I think we may still improve the railway=tram lines somehow. 
They are often pairs of parallel lines, sharp angles 
are for sure not correct, and they also build a network.
Current code doesn't use this knowledge.
I'll think about this again later.

Gerd

> Date: Fri, 25 Apr 2014 06:17:52 +0200
> From: weigelt.be...@web.de
> To: mkgmap-dev@lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] Problem with this restriction?
> 
> Thank you , Gerd
> 
> Hier sollte eigentlich eine Signatur stehen.
> 
> 
> 
> -Original Message-
> From: Gerd Petermann 
> To: "mkgmap-dev@lists.mkgmap.org.uk" 
> Sent: Do., 24 Apr. 2014 23:06
> Subject: Re: [mkgmap-dev] Problem with this restriction?
> 
> Hi Bernd,
> 
> the error is fixed with r3229. 
> I am also checking why the restriction 2254003 is ignored.
> The angle doesn't look that bad, but 
> mkgmap calculates an angle which seems to say right turn.
> 
> Gerd
> 
> > From: weigelt.be...@web.de
> > To: mkgmap-dev@lists.mkgmap.org.uk
> > Date: Thu, 24 Apr 2014 21:00:47 +0200
> > Subject: [mkgmap-dev] Problem with this restriction?
> > 
> > 
> > Hi
> > 
> > I got this error if i build a map around DE-Starnberg
> > 
> > Time started: Thu Apr 24 20:50:22 CEST 2014
> > java.lang.AssertionError
> > at 
> > uk.me.parabola.imgfmt.app.net.RouteRestriction.(RouteRestriction.java:88)
> > at 
> > uk.me.parabola.imgfmt.app.net.RoadNetwork.addRestriction(RoadNetwork.java:536)
> > at 
> > uk.me.parabola.mkgmap.general.MapDetails.addRestriction(MapDetails.java:131)
> > at 
> > uk.me.parabola.mkgmap.reader.osm.RestrictionRelation.addRestriction(RestrictionRelation.java:535)
> > at 
> > uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:495)
> > at 
> > uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:248)
> > at 
> > uk.me.parabola.mkgmap.reader.osm.o5m.O5mBinMapDataSource.load(O5mBinMapDataSource.java:53)
> > at 
> > uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127)
> > at 
> > uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167)
> > at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63)
> > at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:220)
> > at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:216)
> > at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> > at 
> > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> > at 
> > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> > at java.lang.Thread.run(Thread.java:744)
> > Time finished: Thu Apr 24 20:50:54 CEST 2014
> > Total time taken: 31241ms
> > 
> > 
> > last entry in mkgmap.log.0
> > 2014/04/24 20:50:53 Warnung (RoadNetwork): 
> > /home/bernd/map_build/tiles/65020018.o5m: Turn restriction (no_u_turn) 
> > http://www.openstreetmap.org/browse/relation/2254003 (at 
> > http://www.openstreetmap.org/?mlat=48.119082&mlon=11.583557&zoom=17) the 
> > angle 
> > of the from and to way don't match the restriction
> > 
> > http://www.openstreetmap.org/relation/2254003
> > 
> > link to mapdata
> > http://files.mkgmap.org.uk/download/204/65020018.o5m
> > 
> > Bernd
> > 
> > ___
> > mkgmap-dev mailing list
> > mkgmap-dev@lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] delete name not working

[franco_bez]

Hi all,

I'm facing a very strange problem with the style function delete.

in the points file I have the following rule



In the past this removed unwanted labels on post boxes in the map.

Since quite some time, I assume since the change to the new style rules a
few month ago, the labels re-appeared in the map.

I tried many different things to get rid of them but I always failed.

Any Idea what's going wrong here ?

I composed a testcase for the bug, sample osm data and style is included:

happens everywhere but my testcase is located here

  

Download Testcase
  

here's a screenshot of a "points only" map from the testcase

 



--
View this message in context: 
http://gis.19327.n5.nabble.com/delete-name-not-working-tp5804145.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] Problem with this restriction?

[Bernd Weigelt]

Am Freitag, 25. April 2014, 10:00:42 schrieb Gerd Petermann:
> okay, r3230 looks better now, and it still fixes the problem reported
> be Enrico.
> 
> I think we may still improve the railway=tram lines somehow. 
> They are often pairs of parallel lines, sharp angles 
> are for sure not correct, and they also build a network.
> Current code doesn't use this knowledge.
> I'll think about this again later.

Thanks Gerd

I'm back home now and will test r3230 or later to create a new mapset.

Bernd
 
-- 
amarok2 now playing:




___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] delete name not working

[Bernd Weigelt]

Am Freitag, 25. April 2014, 05:34:32 schrieb franco_bez:

Hi Franco

I think this is a problem in our style, so we should fix it there ;-)

Bernd
-- 
amarok2 now playing:




___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] delete name not working

[GerdP]

Hi Franco,

your points file contains 
include 'inc/name';
which contains the name function.
This is before the delete, so mkgmap:label:1 is already filled.

I did not try, but I think you just have to move the include 'inc/name';
line
after the changes of the name tag.

Gerd


franco_bez wrote
> Hi all,
> 
> I'm facing a very strange problem with the style function delete.
> 
> in the points file I have the following rule

> 
> In the past this removed unwanted labels on post boxes in the map.
> 
> Since quite some time, I assume since the change to the new style rules a
> few month ago, the labels re-appeared in the map.
> 
> I tried many different things to get rid of them but I always failed.
> 
> Any Idea what's going wrong here ?
> 
> I composed a testcase for the bug, sample osm data and style is included:
> happens everywhere but my testcase is located here
> 
>   
> 
> Download Testcase
>   
> 
> here's a screenshot of a "points only" map from the testcase
 




--
View this message in context: 
http://gis.19327.n5.nabble.com/delete-name-not-working-tp5804145p5804156.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] delete name not working

[Bernd Weigelt]

Am Freitag, 25. April 2014, 07:10:29 schrieb GerdP:
 
Hi Gerd

> I did not try, but I think you just have to move the include 'inc/name';
> line
> after the changes of the name tag.


That was my first thoughts, too, but i will also test our changes at the start 
of inc/name.

Bernd

-- 
amarok2 now playing:




___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] delete name not working

[franco_bez]

Just a question for my understanding of the problem:

This rule not only sets the "name" but also mkgmap:label:1 ?



I thought that calling -  delete name - would erase the name, no matter what
it was assigned before.

would it make any difference having a rule with the set command instead ?



would - delete name - then work as expected ?



--
View this message in context: 
http://gis.19327.n5.nabble.com/delete-name-not-working-tp5804145p5804164.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] delete name not working

[GerdP]

Hi Franco,

the style manual says about Action block name:
This sets the first label of the element but only if it is not already set.
This is a helper action. The same
effect can be produced with different notations as it is shown in the
following example where all three
lines have the same effect.
{name '${name} (${ref})' | '${ref}' | '${name}'}
{add mkgmap:label:1='${name} (${ref})' | '${ref}' | '${name}'}
mkgmap:label:1!=* {set mkgmap:label:1='${name} (${ref})' | '${ref}' |
'${name}'}

So, if you delete the name tag after using the name action, it has no effect
on the tag mkgmap:label:1.

Gerd


franco_bez wrote
> Just a question for my understanding of the problem:
> 
> This rule not only sets the "name" but also mkgmap:label:1 ?

> 
> I thought that calling -  delete name - would erase the name, no matter
> what it was assigned before.
> 
> would it make any difference having a rule with the set command instead ?

> 
> would - delete name - then work as expected ?





--
View this message in context: 
http://gis.19327.n5.nabble.com/delete-name-not-working-tp5804145p5804172.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[Henning Scholland]

Hi @ all,

while thinking about creation of simple maps with less features I 
thought about an better parameter for splitter then just the number of 
OSM-nodes. Actually splitter writes density-files (but also based on 
OSM-nodes). You can imagine that the number of OSM-nodes may differ a 
lot in detailed mapped areas if you just want to generate a map of 
highways. Maybe it would be a great feature, that mkgmap can write a 
density-file (as splitter did) but also considering the used style file.


Henning

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[GerdP]

Hi Henning,

I don't understand. What would be the content of that file? 
What would you do with it?

Gerd


Henning Scholland wrote
> Hi @ all,
> 
> while thinking about creation of simple maps with less features I 
> thought about an better parameter for splitter then just the number of 
> OSM-nodes. Actually splitter writes density-files (but also based on 
> OSM-nodes). You can imagine that the number of OSM-nodes may differ a 
> lot in detailed mapped areas if you just want to generate a map of 
> highways. Maybe it would be a great feature, that mkgmap can write a 
> density-file (as splitter did) but also considering the used style file.
> 
> Henning
> 
> ___
> mkgmap-dev mailing list

> mkgmap-dev@.org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev





--
View this message in context: 
http://gis.19327.n5.nabble.com/mkgmap-ToDo-list-tp5803388p5804174.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[Henning Scholland]

Hi Gerd,
splitter is able to write a density file, which stores the density of 
OSM-nodes in the specific area. Afterwards the file is splitted and 
processed by mkgmap. mkgmap will use only the objects, which are 
addressed in style-file.


Example: In a rectangle of 100x100m are 5 nodes belonging to a highway 
and 10 nodes belonging to POI, and polygones and style-file only 
contains highways, mkgmap writes only 5 nodes (and one line) to img-file.


For an more effictive splitting of tiles I would imagine, that a 
density-file created by mkgmap based on the written data will be much 
better then the file written by splitter.


Henning

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[Gerd Petermann]

Hi Henning,

well, I don't know how well the number of nodes
in a tile correlates with the size of the img file,
but it seems to work for most users.
My understanding is that this should work as well for
a style which only processes a few details,
only the ratio between number of nodes and tile size
will be different, in other words, you have to find
out how much higher the max-nodes value can be.

Gerd



> Date: Fri, 25 Apr 2014 19:27:09 +0200
> From: o...@aighes.de
> To: mkgmap-dev@lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] mkgmap ToDo list
> 
> Hi Gerd,
> splitter is able to write a density file, which stores the density of 
> OSM-nodes in the specific area. Afterwards the file is splitted and 
> processed by mkgmap. mkgmap will use only the objects, which are 
> addressed in style-file.
> 
> Example: In a rectangle of 100x100m are 5 nodes belonging to a highway 
> and 10 nodes belonging to POI, and polygones and style-file only 
> contains highways, mkgmap writes only 5 nodes (and one line) to img-file.
> 
> For an more effictive splitting of tiles I would imagine, that a 
> density-file created by mkgmap based on the written data will be much 
> better then the file written by splitter.
> 
> Henning
> 
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
  ___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[Henning Scholland]

Hi Gerd,

finding a proper max-nodes value wont solve the problem globaly. Eg. 
then you compare the needed value from europe/north america to the value 
needed in the rest of the world.


Henning

Am 25.04.2014 19:35, schrieb Gerd Petermann:

Hi Henning,

well, I don't know how well the number of nodes
in a tile correlates with the size of the img file,
but it seems to work for most users.
My understanding is that this should work as well for
a style which only processes a few details,
only the ratio between number of nodes and tile size
will be different, in other words, you have to find
out how much higher the max-nodes value can be.

Gerd



> Date: Fri, 25 Apr 2014 19:27:09 +0200
> From: o...@aighes.de
> To: mkgmap-dev@lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] mkgmap ToDo list
>
> Hi Gerd,
> splitter is able to write a density file, which stores the density of
> OSM-nodes in the specific area. Afterwards the file is splitted and
> processed by mkgmap. mkgmap will use only the objects, which are
> addressed in style-file.
>
> Example: In a rectangle of 100x100m are 5 nodes belonging to a highway
> and 10 nodes belonging to POI, and polygones and style-file only
> contains highways, mkgmap writes only 5 nodes (and one line) to 
img-file.

>
> For an more effictive splitting of tiles I would imagine, that a
> density-file created by mkgmap based on the written data will be much
> better then the file written by splitter.
>
> Henning
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[GerdP]

Hi Henning,

it seems I still don't understand. 
The max-nodes values influences the number of tiles created. 
I don't see a big difference between a map for US consisting of 100 
or 250 tiles, esp. if the map doesn't contain routing info.

I would try to find a value that allows to utilize all CPUs
without reaching heap limits or img limits.

Why do you think that you have to find an optimal value?

Gerd


Henning Scholland wrote
> Hi Gerd,
> 
> finding a proper max-nodes value wont solve the problem globaly. Eg. 
> then you compare the needed value from europe/north america to the value 
> needed in the rest of the world.
> 
> Henning
> 
> Am 25.04.2014 19:35, schrieb Gerd Petermann:
>> Hi Henning,
>>
>> well, I don't know how well the number of nodes
>> in a tile correlates with the size of the img file,
>> but it seems to work for most users.
>> My understanding is that this should work as well for
>> a style which only processes a few details,
>> only the ratio between number of nodes and tile size
>> will be different, in other words, you have to find
>> out how much higher the max-nodes value can be.
>>
>> Gerd
>>
>>
>>
>> > Date: Fri, 25 Apr 2014 19:27:09 +0200
>> > From: 

> osm@

>> > To: 

> mkgmap-dev@.org

>> > Subject: Re: [mkgmap-dev] mkgmap ToDo list
>> >
>> > Hi Gerd,
>> > splitter is able to write a density file, which stores the density of
>> > OSM-nodes in the specific area. Afterwards the file is splitted and
>> > processed by mkgmap. mkgmap will use only the objects, which are
>> > addressed in style-file.
>> >
>> > Example: In a rectangle of 100x100m are 5 nodes belonging to a highway
>> > and 10 nodes belonging to POI, and polygones and style-file only
>> > contains highways, mkgmap writes only 5 nodes (and one line) to 
>> img-file.
>> >
>> > For an more effictive splitting of tiles I would imagine, that a
>> > density-file created by mkgmap based on the written data will be much
>> > better then the file written by splitter.
>> >
>> > Henning
>> >
>> > ___
>> > mkgmap-dev mailing list
>> > 

> mkgmap-dev@.org

>> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>>
>> ___
>> mkgmap-dev mailing list
>> 

> mkgmap-dev@.org

>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> 
> ___
> mkgmap-dev mailing list

> mkgmap-dev@.org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev





--
View this message in context: 
http://gis.19327.n5.nabble.com/mkgmap-ToDo-list-tp5803388p5804188.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[Henning Scholland]

Hi Gerd,

I would like to have img-tiles which have globally nearly the same 
filesize, so that they use the space of devices like eTrex 10.


With my actual map I use globally the same value for max-nodes. But the 
size of the img-tiles differ more then factor 2. Eg. a tile in Germany 
is between 2 and 5 mb where a tile in China is about 10 mb. If I remove 
details, this difference will increase, because in Germany more objects 
will be removed from the img-tile then in China.


Henning

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap ToDo list

[GerdP]

Hi Henning,

okay, got it. 
You mentioned the density file written by splitter. I have no idea how,
but you may find a way to manipulate the values in that file.

DensityMap.readMap() contains the code to read that file
which simply represents the content of the density map 
(x and y index and number of nodes in each line)
If splitter finds a file density.txt in its working directory, it will read
that file
instead of the input file(s) to calculate the areas.list.

What you need now is a routine that calculates a weight factor for each
field
in the density map based on the number of bytes in the corresponding img
file,
which you can use to lower the number of nodes.

The problem is: You have only one factor for many elements in the grid
of the density map, and I see no way to calculate something more detailed
in mkgmap.

Does that help you somehow?

Gerd




Henning Scholland wrote
> Hi Gerd,
> 
> I would like to have img-tiles which have globally nearly the same 
> filesize, so that they use the space of devices like eTrex 10.
> 
> With my actual map I use globally the same value for max-nodes. But the 
> size of the img-tiles differ more then factor 2. Eg. a tile in Germany 
> is between 2 and 5 mb where a tile in China is about 10 mb. If I remove 
> details, this difference will increase, because in Germany more objects 
> will be removed from the img-tile then in China.
> 
> Henning
> 
> ___
> mkgmap-dev mailing list

> mkgmap-dev@.org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev





--
View this message in context: 
http://gis.19327.n5.nabble.com/mkgmap-ToDo-list-tp5803388p5804194.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] delete name not working

[franco_bez]

Hi Gerd,
thank you very much for the clarification. 



--
View this message in context: 
http://gis.19327.n5.nabble.com/delete-name-not-working-tp5804145p5804196.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev