Re: [mkgmap-dev] [Patch] "Area too small to split at " ... followed by "Too many POIs at location " error message

2017-01-16 Thread Gerd Petermann 
Hi Ticker,

(see 3756)
the useNormalSplit code is still needed, maybe because the rules for the 
largeObjectAreas are not okay.
So if you find a better solution please let me know. I am also no longer 
convinced that the code in MapSplitter
which sets wantSplit to true is a good idea, esp. in combination with 
--order-by-decreasing-area I guess
it would be better to avoid unnessary splits. Am i right?

Gerd


Von: mkgmap-dev  im Auftrag von Gerd 
Petermann 
Gesendet: Sonntag, 15. Januar 2017 15:10:48
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [Patch] "Area too small to split at " ... followed by 
"Too many POIs at location " error message

Hi Ticker,

the original intention of the useNormalSplit code  was to solve a problem with 
two huge polygons having the same center point.
At that time I tried to minimize the possibility that this code is executed in 
other cases.
However, it seems that this is dead code since r3351 because of the handling 
with largeObjectAreas.
I think I should remove it.

Gerd






Von: mkgmap-dev  im Auftrag von Ticker 
Berkin 
Gesendet: Sonntag, 15. Januar 2017 14:41:27
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] [Patch] "Area too small to split at " ... followed by 
"Too many POIs at location " error message

Hi Gerd

Yes; however, regardless of useNormalSplit, with --order-by... the
shapes need to be split into their correct area.

This bit of code has always troubled me. I wasn't sure if its objective
was to lessen the chance of empty subdivisions or to lessen the chance
of exceeding maximum data sizes in the subdivision.

Maybe splitIntoAreas (and, for that matter, points) shouldn't set
used[area] to true so that lines can be distributed between the two
areas.

Also the test ... && (this.lines.size() > 1 || this.shapes.size() > 1))
should take ((lines.size + shapes.size) > 1). But not including shapes
if --order-by...

Another possibility is that the caller of MapArea.split, with accurate
information on the number/size of subdivision data items, knowing that
this is more that will fit into a subDivision and further splits by
area are not possible, passes a flag that make it send excess items
into other subdivisions - very much like the way it handles
largeObjectAreas

Ticker


On Sun, 2017-01-15 at 10:00 +, Gerd Petermann wrote:
> Hi all,
>
> attached is a patch to solve this problem.
>
> A binary is here:
> http://files.mkgmap.org.uk/download/327/mkgmap.jar
>
> @Ticker: Please review.
> I've noticed that with --order-by-decreasing-area
> the code in MapArea to set useNormalSplit may not be used because
> the condition used[0] != used[1] is never true when there is a shape
> in that area. I think this can cause problems if we also have some
> complex
> lines with (nearly) the same center point in the same area.
>
> Gerd
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message

2017-01-16 Thread svn commit 
Version mkgmap-r3756 was committed by gerd on Mon, 16 Jan 2017

improve MapSplitter: avoid "Too many POIs at location" error message 

http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap=3756
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] Commit r3755: remove unused import, no functional change

2017-01-16 Thread svn commit 
Version mkgmap-r3755 was committed by gerd on Mon, 16 Jan 2017

remove unused import, no functional change

http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap=3755
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] crash reading style file

2017-01-16 Thread Mike Baggaley 
Hi, the following (erroneous) line in my points file crashes mkgmap

bridge:name~'[Bb]ridge' bridge_name~'[Bb]ridge' {echotags 'bridge as name'}

Time started: Mon Jan 16 12:57:37 GMT 2017
java.lang.UnsupportedOperationException
at
uk.me.parabola.mkgmap.osmstyle.eval.AbstractOp.getKeyValue(AbstractOp.java:1
34)
at
uk.me.parabola.mkgmap.osmstyle.eval.RegexOp.setSecond(RegexOp.java:51)
at
uk.me.parabola.mkgmap.osmstyle.eval.ExpressionReader.runOp(ExpressionReader.
java:180)
at
uk.me.parabola.mkgmap.osmstyle.eval.ExpressionReader.readConditions(Expressi
onReader.java:85)
at
uk.me.parabola.mkgmap.osmstyle.RuleFileReader.loadFile(RuleFileReader.java:1
15)
at
uk.me.parabola.mkgmap.osmstyle.RuleFileReader.load(RuleFileReader.java:86)
at
uk.me.parabola.mkgmap.osmstyle.StyleImpl.readRules(StyleImpl.java:302)
at
uk.me.parabola.mkgmap.osmstyle.StyleImpl.(StyleImpl.java:160)
at
uk.me.parabola.mkgmap.osmstyle.StyleImpl.readStyle(StyleImpl.java:554)
at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.createConverter(OsmMapData
Source.java:289)
at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.setupHandler(OsmMapDataSou
rce.java:187)
at
uk.me.parabola.mkgmap.reader.osm.xml.Osm5MapDataSource.load(Osm5MapDataSourc
e.java:59)
at
uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java
:138)
at
uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154)
at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52)
at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:265)
at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:1)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
Source)
at java.lang.Thread.run(Unknown Source)
Exiting - if you want to carry on regardless, use the --keep-going option
Number of ExitExceptions: 1
Time finished: Mon Jan 16 12:57:37 GMT 2017
Total time taken: 420ms

It has a missing | between the two test conditions, but crashes mkgmap
instead of reporting the mistake. Is anyone an expert in this bit of code?

Regards,
Mike

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] Copyright & License file reader improvements

2017-01-16 Thread Mike Baggaley 
Hi Gerd, I tried that, and BaseCamp does indeed show the license file info
when installed using NSIS.

Regards,
Mike

-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] 
Sent: 16 January 2017 09:48
To: Mike Baggaley 
Subject: AW: [mkgmap-dev] Copyright & License file reader improvements

Hi Mike,

I compile the map with the --nsis option and use the nsis compiler to create
an "OSM map.exe". Finally I install the map with it.

Gerd


Von: Mike Baggaley 
Gesendet: Montag, 16. Januar 2017 10:43:51
An: 'Gerd Petermann'
Betreff: RE: [mkgmap-dev] Copyright & License file reader improvements

Hi Gerd, Do you use a single gmapsupp in basecamp or the separate tiles? I
use a gmapsupp file and put it on a memory card (I don't register the map).

Regards,
Mike

-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 15 January 2017 09:06
To: Development list for mkgmap 
Subject: Re: [mkgmap-dev] Copyright & License file reader improvements

Hi Mike,

I do not specify a licence info or copyright in my options file. So, I see
the default settings. Maybe
that is a hint that something is wrong?

Gerd


Von: mkgmap-dev  im Auftrag von Mike
Baggaley 
Gesendet: Sonntag, 15. Januar 2017 10:02:54
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements

HI Gerd,

I only see the copyright info when I click on it! Bizarre!

Cheers,
Mike

-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 15 January 2017 08:14
To: Development list for mkgmap 
Subject: Re: [mkgmap-dev] Copyright & License file reader improvements

Hi Mike,

today I noticed that MapSource and Basecamp display the licence together
with the copyright info
when you click on the Copyright button in the "Map Product Manager".

Gerd


Von: mkgmap-dev  im Auftrag von Mike
Baggaley 
Gesendet: Freitag, 6. Januar 2017 18:07:37
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements

Hi Gerd, I seem to have forgotten how to display the license info in
Basecamp or the on the device (I know how to display the copyright info).
Can you point me in the right direction? BTW I do not have MapSource - is
this still available for download or is it now outdated?

Cheers,
Mike

-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 06 January 2017 13:09
To: Development list for mkgmap 
Subject: Re: [mkgmap-dev] Copyright & License file reader improvements

Hi Steve,

that rang a bell. I found this thread:
http://gis.19327.n8.nabble.com/Copyright-text-scrambled-td5764455.html#a5764
487
and esp. my reply here:
http://gis.19327.n8.nabble.com/Copyright-text-scrambled-tp5764455p5764513.ht
ml

which also has a patch which that introduced the special handling of empty
lines.

@Mike: Please check how your patch handles this.

Gerd


Von: mkgmap-dev  im Auftrag von
Steve Ratcliffe 
Gesendet: Freitag, 6. Januar 2017 11:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements

On 06/01/17 09:04, Gerd Petermann wrote:
> @Steve: Do you remember a reason for the removal of empty lines?

I don't remember.  It would have been for devices and not for mapsource,
I vaguely remember something about it not displaying after the blank, or
a strange character, but this is probably
I should have proper internet again later today I may be able to find
out more.

..Steve
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev



___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] route calculation error

2017-01-16 Thread Gerd Petermann 
That's impossible if we are talking abou the normal releases.
Maybe you tried a patched version ?

Gerd


Von: mkgmap-dev  im Auftrag von Steve 
Sgalowski 
Gesendet: Montag, 16. Januar 2017 10:41:40
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] route calculation error

I used the same style and same typ files for both
and 3754 failed 3753 all is ok

Stephen


On Mon, Jan 16, 2017 at 7:35 PM, Gerd Petermann 
> wrote:
Hi Steve,

r3754 works fine for me. Compared to r3753 the only change was in the default 
style, so if you use your own style
the problem must be somewhere else.

Gerd


Von: mkgmap-dev 
>
 im Auftrag von Steve Sgalowski 
>
Gesendet: Montag, 16. Januar 2017 10:18:46
An: Development list for mkgmap
Betreff: [mkgmap-dev] route calculation error

ok I have just checked  mkgmap 3753,able to route 4 k .

mkgmap 3754 Failed to make routeable maps .

garmin montana advises no routable roads on this map .

Again , all is OK on mkgmap 3753 with  spliter 574 .

Stephen

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] route calculation error

2017-01-16 Thread Steve Sgalowski 
I used the same style and same typ files for both
and 3754 failed 3753 all is ok

Stephen


On Mon, Jan 16, 2017 at 7:35 PM, Gerd Petermann <
gpetermann_muenc...@hotmail.com> wrote:

> Hi Steve,
>
> r3754 works fine for me. Compared to r3753 the only change was in the
> default style, so if you use your own style
> the problem must be somewhere else.
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von
> Steve Sgalowski 
> Gesendet: Montag, 16. Januar 2017 10:18:46
> An: Development list for mkgmap
> Betreff: [mkgmap-dev] route calculation error
>
> ok I have just checked  mkgmap 3753,able to route 4 k .
>
> mkgmap 3754 Failed to make routeable maps .
>
> garmin montana advises no routable roads on this map .
>
> Again , all is OK on mkgmap 3753 with  spliter 574 .
>
> Stephen
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] route calculation error

2017-01-16 Thread Gerd Petermann 
Hi Steve,

r3754 works fine for me. Compared to r3753 the only change was in the default 
style, so if you use your own style
the problem must be somewhere else.

Gerd


Von: mkgmap-dev  im Auftrag von Steve 
Sgalowski 
Gesendet: Montag, 16. Januar 2017 10:18:46
An: Development list for mkgmap
Betreff: [mkgmap-dev] route calculation error

ok I have just checked  mkgmap 3753,able to route 4 k .

mkgmap 3754 Failed to make routeable maps .

garmin montana advises no routable roads on this map .

Again , all is OK on mkgmap 3753 with  spliter 574 .

Stephen

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] route calculation error

2017-01-16 Thread Steve Sgalowski 
ok I have just checked  mkgmap 3753,able to route 4 k .

mkgmap 3754 Failed to make routeable maps .

garmin montana advises no routable roads on this map .

Again , all is OK on mkgmap 3753 with  spliter 574 .

Stephen
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev