Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread osm@pinns

Hi Gerd

Just noticed your crash.gdb , which indeed causes a crash

However, if I take a different starting point  but still join the a39 
where your route joins it , I don't get a crash,


Very odd that the end sames ok but the beginning.

Anyway, will do some more checking tomorrow

Nick
On 08/02/2018 21:04, osm@pinns wrote:

Hi Gerd

I can see that , but again no probs here when I used your map

For my final trial i used some pbf files of the UK which were split 
last year without the align for dem option


This still worked !, ie no crashes ;

good point - have to check if the dem poly includes empty hgt files.

Will do some more checking tomorrow.

Again, congratulations on a major achievement!

Nick


On 08/02/2018 20:36, Gerd Petermann wrote:

Hi Nick,

okay, sounds good. Do you also use -dem-poly or hgt files with voids?
I tested a rather small polygon [1] divided into 10 parts, maybe that 
created more stress

for MapSource.

Maybe we can find other --align-for-dem values or -even better -
a field in TRE or DEM  or TDB that can be changed to allow more or 
all values.


Gerd

[1] http://files.mkgmap.org.uk/download/412/baddem6b.7z


Von: mkgmap-dev  im Auftrag 
von osm@pinns 

Gesendet: Donnerstag, 8. Februar 2018 21:22
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd,

Having difficulty creating long distances without stopovers ikn
Mapsource, but that seems have been the case anyway before dem, at least
in my case using default style

Have created a long distance one in Basecamp, exported it in Mapsource
and absolutely no problem with creating profiles! Excellent work !

If I invert the route , ie in Basecamp, and export it in mapsource, same
: no issues at all

At one stage, I cannot reproduce it ,I just got a black profile, but
that could be when I a dem was missing.


On 08/02/2018 19:11, Gerd Petermann wrote:

Hi Nick,

great! In my test cases I found problems with long distance routes 
without any stopover.

Please try that as well, maybe also the inverse routes.

Gerd


Von: mkgmap-dev  im Auftrag 
von osm@pinns 

Gesendet: Donnerstag, 8. Februar 2018 19:01
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

Brilliant ! have done a really spaghetti route with lots of ups and 
downs left and right and


seems to be working with align-for-dem=360  and even

--dem-dists=2484,3312,9942,16560

r

Nick

On 08/02/2018 17:40, Gerd Petermann wrote:

Hi all,

I've created patches for splitter and mkgmap.
The binaries are here:
   http://files.mkgmap.org.uk/download/417/splitter.jar
http://files.mkgmap.org.uk/detail/416

Please try splitter with align-for-dem=360. I found no more crashes 
as long

as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936

Maybe you find a combination of  align-for-dem and dem-dists with 
more than one value

that still works, I'll try again tomorrow.

Gerd


Von: mkgmap-dev 
 
im Auftrag von Gerd Petermann 


Gesendet: Donnerstag, 8. Februar 2018 13:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi all,

the patch contained a stupid bug, but there is more to this:
1) the effect of the patch depends on the dem-dists value (I assume 
only the one
that gives the highest resolution). The higher the resolution the 
better it works.

2) it probably also depends on the boundaries (areas.list)

I assume now that the tile boundary from areas.list should be a 
certain multiples of degrees,
probably different multiples for lat and lon and that the overlap 
simply makes

sure that this boundary is within the overlapped area.
Maybe the preferred multiples also depend on the dem-dist.

I'll try to find out more ...

Gerd


Von: mkgmap-dev 
 
im Auftrag von osm@pinns 

Gesendet: Donnerstag, 8. Februar 2018 10:33
An: 
mkgmap-dev@lists.mkgmap.org.uk

Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route
turns south 20miles then up again

r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:


Hi all,

okay, thanks for testing. I'll try to find a better patch.
Please check: I think the patch works fine for routes which cross 
tile borders in horizontal direction
direction but I still see problems with vertical crossing. Can you 
confirm that?


Gerd


Von: mkgmap-dev 
 
im Auftrag von Henning Scholland 


Gesendet: Donnerstag, 8. Februar 2018 09:59
An: Development list

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread osm@pinns

Hi Gerd

I can see that , but again no probs here when I used your map

For my final trial i used some pbf files of the UK which were split last 
year without the align for dem option


This still worked !, ie no crashes ;

good point - have to check if the dem poly includes empty hgt files.

Will do some more checking tomorrow.

Again, congratulations on a major achievement!

Nick


On 08/02/2018 20:36, Gerd Petermann wrote:

Hi Nick,

okay, sounds good. Do you also use -dem-poly or hgt files with voids?
I tested a rather small polygon [1] divided into 10 parts, maybe that created 
more stress
for MapSource.

Maybe we can find other --align-for-dem values or -even better -
a field in TRE or DEM  or TDB that can be changed to allow more or all values.

Gerd

[1] http://files.mkgmap.org.uk/download/412/baddem6b.7z


Von: mkgmap-dev  im Auftrag von osm@pinns 

Gesendet: Donnerstag, 8. Februar 2018 21:22
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd,

Having difficulty creating long distances without stopovers ikn
Mapsource, but that seems have been the case anyway before dem, at least
in my case using default style

Have created a long distance one in Basecamp, exported it in Mapsource
and absolutely no problem with creating profiles! Excellent work !

If I invert the route , ie in Basecamp, and export it in mapsource, same
: no issues at all

At one stage, I cannot reproduce it ,I just got a black profile, but
that could be when I a dem was missing.


On 08/02/2018 19:11, Gerd Petermann wrote:

Hi Nick,

great! In my test cases I found problems with long distance routes without any 
stopover.
Please try that as well, maybe also the inverse routes.

Gerd


Von: mkgmap-dev  im Auftrag von osm@pinns 

Gesendet: Donnerstag, 8. Februar 2018 19:01
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

Brilliant ! have done a really spaghetti route with lots of ups and downs left 
and right and

seems to be working with align-for-dem=360  and even

--dem-dists=2484,3312,9942,16560

r

Nick

On 08/02/2018 17:40, Gerd Petermann wrote:

Hi all,

I've created patches for splitter and mkgmap.
The binaries are here:
   http://files.mkgmap.org.uk/download/417/splitter.jar
http://files.mkgmap.org.uk/detail/416

Please try splitter with align-for-dem=360. I found no more crashes as long
as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936

Maybe you find a combination of  align-for-dem and dem-dists with more than one 
value
that still works, I'll try again tomorrow.

Gerd


Von: mkgmap-dev 
 im 
Auftrag von Gerd Petermann 

Gesendet: Donnerstag, 8. Februar 2018 13:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi all,

the patch contained a stupid bug, but there is more to this:
1) the effect of the patch depends on the dem-dists value (I assume only the one
that gives the highest resolution). The higher the resolution the better it 
works.
2) it probably also depends on the boundaries (areas.list)

I assume now that the tile boundary from areas.list should be a certain 
multiples of degrees,
probably different multiples for lat and lon and that the overlap simply makes
sure that this boundary is within the overlapped area.
Maybe the preferred multiples also depend on the dem-dist.

I'll try to find out more ...

Gerd


Von: mkgmap-dev 
 im 
Auftrag von osm@pinns 
Gesendet: Donnerstag, 8. Februar 2018 10:33
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route
turns south 20miles then up again

r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:


Hi all,

okay, thanks for testing. I'll try to find a better patch.
Please check: I think the patch works fine for routes which cross tile borders 
in horizontal direction
direction but I still see problems with vertical crossing. Can you confirm that?

Gerd


Von: mkgmap-dev 
 im 
Auftrag von Henning Scholland 
Gesendet: Donnerstag, 8. Februar 2018 09:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Same for me, but just did quick test. Will try on the weekend more detailed
Henning
On 8 Feb 2018, at 16:57, lig fietser 
mailto:ligfiet...@hotmail.com>>
 wrote:

Hi Gerd,

I tested your patch but I still see frequent cras

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Gerd Petermann
Hi Nick,

okay, sounds good. Do you also use -dem-poly or hgt files with voids?
I tested a rather small polygon [1] divided into 10 parts, maybe that created 
more stress
for MapSource.

Maybe we can find other --align-for-dem values or -even better -
a field in TRE or DEM  or TDB that can be changed to allow more or all values.

Gerd

[1] http://files.mkgmap.org.uk/download/412/baddem6b.7z


Von: mkgmap-dev  im Auftrag von 
osm@pinns 
Gesendet: Donnerstag, 8. Februar 2018 21:22
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd,

Having difficulty creating long distances without stopovers ikn
Mapsource, but that seems have been the case anyway before dem, at least
in my case using default style

Have created a long distance one in Basecamp, exported it in Mapsource
and absolutely no problem with creating profiles! Excellent work !

If I invert the route , ie in Basecamp, and export it in mapsource, same
: no issues at all

At one stage, I cannot reproduce it ,I just got a black profile, but
that could be when I a dem was missing.


On 08/02/2018 19:11, Gerd Petermann wrote:
> Hi Nick,
>
> great! In my test cases I found problems with long distance routes without 
> any stopover.
> Please try that as well, maybe also the inverse routes.
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von 
> osm@pinns 
> Gesendet: Donnerstag, 8. Februar 2018 19:01
> An: mkgmap-dev@lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi Gerd
>
> Brilliant ! have done a really spaghetti route with lots of ups and downs 
> left and right and
>
> seems to be working with align-for-dem=360  and even
>
> --dem-dists=2484,3312,9942,16560
>
> r
>
> Nick
>
> On 08/02/2018 17:40, Gerd Petermann wrote:
>
> Hi all,
>
> I've created patches for splitter and mkgmap.
> The binaries are here:
>   http://files.mkgmap.org.uk/download/417/splitter.jar
> http://files.mkgmap.org.uk/detail/416
>
> Please try splitter with align-for-dem=360. I found no more crashes as long
> as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936
>
> Maybe you find a combination of  align-for-dem and dem-dists with more than 
> one value
> that still works, I'll try again tomorrow.
>
> Gerd
>
> 
> Von: mkgmap-dev 
> 
>  im Auftrag von Gerd Petermann 
> 
> Gesendet: Donnerstag, 8. Februar 2018 13:16
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi all,
>
> the patch contained a stupid bug, but there is more to this:
> 1) the effect of the patch depends on the dem-dists value (I assume only the 
> one
> that gives the highest resolution). The higher the resolution the better it 
> works.
> 2) it probably also depends on the boundaries (areas.list)
>
> I assume now that the tile boundary from areas.list should be a certain 
> multiples of degrees,
> probably different multiples for lat and lon and that the overlap simply makes
> sure that this boundary is within the overlapped area.
> Maybe the preferred multiples also depend on the dem-dist.
>
> I'll try to find out more ...
>
> Gerd
>
> 
> Von: mkgmap-dev 
> 
>  im Auftrag von osm@pinns 
> Gesendet: Donnerstag, 8. Februar 2018 10:33
> An: mkgmap-dev@lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi Gerd
>
> I think you are right ,ie
>
> start and finishing point  at same level seems OK eventhough the route
> turns south 20miles then up again
>
> r
>
> Nick
>
>
> On 08/02/2018 09:27, Gerd Petermann wrote:
>
>
> Hi all,
>
> okay, thanks for testing. I'll try to find a better patch.
> Please check: I think the patch works fine for routes which cross tile 
> borders in horizontal direction
> direction but I still see problems with vertical crossing. Can you confirm 
> that?
>
> Gerd
>
> 
> Von: mkgmap-dev 
> 
>  im Auftrag von Henning Scholland 
> 
> Gesendet: Donnerstag, 8. Februar 2018 09:59
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Same for me, but just did quick test. Will try on the weekend more detailed
> Henning
> On 8 Feb 2018, at 16:57, lig fietser 
> mailto:ligfiet...@hotmail.com>>
>  wrote:
>
> Hi Gerd,
>
> I tested your patch but I still see frequent crashes near tile borders.
>
>
> 
> Van: mkgmap-dev 
> 
>  namens Gerd Petermann 
> 
> Verzonden: woens

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread osm@pinns

Hi Gerd,

Having difficulty creating long distances without stopovers ikn 
Mapsource, but that seems have been the case anyway before dem, at least 
in my case using default style


Have created a long distance one in Basecamp, exported it in Mapsource 
and absolutely no problem with creating profiles! Excellent work !


If I invert the route , ie in Basecamp, and export it in mapsource, same 
: no issues at all


At one stage, I cannot reproduce it ,I just got a black profile, but 
that could be when I a dem was missing.



On 08/02/2018 19:11, Gerd Petermann wrote:

Hi Nick,

great! In my test cases I found problems with long distance routes without any 
stopover.
Please try that as well, maybe also the inverse routes.

Gerd


Von: mkgmap-dev  im Auftrag von osm@pinns 

Gesendet: Donnerstag, 8. Februar 2018 19:01
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

Brilliant ! have done a really spaghetti route with lots of ups and downs left 
and right and

seems to be working with align-for-dem=360  and even

--dem-dists=2484,3312,9942,16560

r

Nick

On 08/02/2018 17:40, Gerd Petermann wrote:

Hi all,

I've created patches for splitter and mkgmap.
The binaries are here:
  http://files.mkgmap.org.uk/download/417/splitter.jar
http://files.mkgmap.org.uk/detail/416

Please try splitter with align-for-dem=360. I found no more crashes as long
as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936

Maybe you find a combination of  align-for-dem and dem-dists with more than one 
value
that still works, I'll try again tomorrow.

Gerd


Von: mkgmap-dev 
 im 
Auftrag von Gerd Petermann 

Gesendet: Donnerstag, 8. Februar 2018 13:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi all,

the patch contained a stupid bug, but there is more to this:
1) the effect of the patch depends on the dem-dists value (I assume only the one
that gives the highest resolution). The higher the resolution the better it 
works.
2) it probably also depends on the boundaries (areas.list)

I assume now that the tile boundary from areas.list should be a certain 
multiples of degrees,
probably different multiples for lat and lon and that the overlap simply makes
sure that this boundary is within the overlapped area.
Maybe the preferred multiples also depend on the dem-dist.

I'll try to find out more ...

Gerd


Von: mkgmap-dev 
 im 
Auftrag von osm@pinns 
Gesendet: Donnerstag, 8. Februar 2018 10:33
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route
turns south 20miles then up again

r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:


Hi all,

okay, thanks for testing. I'll try to find a better patch.
Please check: I think the patch works fine for routes which cross tile borders 
in horizontal direction
direction but I still see problems with vertical crossing. Can you confirm that?

Gerd


Von: mkgmap-dev 
 im 
Auftrag von Henning Scholland 
Gesendet: Donnerstag, 8. Februar 2018 09:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Same for me, but just did quick test. Will try on the weekend more detailed
Henning
On 8 Feb 2018, at 16:57, lig fietser 
mailto:ligfiet...@hotmail.com>>
 wrote:

Hi Gerd,

I tested your patch but I still see frequent crashes near tile borders.



Van: mkgmap-dev 
 
namens Gerd Petermann 

Verzonden: woensdag 7 februari 2018 02:45:27
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: [mkgmap-dev] patch for crash in MapSource

Hi all,

attached is a patch that seems to help in many cases where --dem-poly causes crashes in 
MapSource "Show Profile..."
A binary is here:
http://files.mkgmap.org.uk/download/414/mkgmap.jar

It changes the TRE file and the *.tdb file.
I still see a few crashes but maybe those are caused by other problems.

Please try and let me know your results. I found no bad impact so far,
long distance routing still seems to work, but I've not tested much.

@Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
In this case this patch is not yet okay.

Gerd



mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Thomas Morgenstern
Hi, sorry forgot my posting. i have solved this problem. But: in 
mkgmap-r4107\examples\styles\default\inc\compat_lines  Line 124 is the old 
error existing, diskused at 3.feb.2018. Quote # > mkgmap:carpool_compat=yes  { 
set access=no; set mkgmap:bus=yes; set mkgmap:emergency=yes; set 
mkgmap:carpool=yes } Ha.. yes it could be either.  My guess would be that
it should be 'setaccess no' as it is followed by some
of the access flags.#end quote

following command gives no error :
mkgmap:carpool_compat=yes  { setaccess no; set mkgmap:bus=yes; set 
mkgmap:emergency=yes; set mkgmap:carpool=yes ;}  
the Equal sign after setaccess must bee replaced with space.
thomas


Von: Thomas Morgenstern 
Datum: Donnerstag, 8. Februar 2018 18:49
An: Development list for mkgmap 
Betreff: Re: [mkgmap-dev] patch for crash in MapSource


This version has a problem reading stylefile. It gives me the following error 
:Error in style:Error: (points:240): quoted word found where command expected. 
Could not open style. 
Line 240 is : 
amenity=guidepost | amenity=signpost | (tourism=information & 
information=guidepost) {add name=('$(name:de')|'$(name)'|'Wegweiser')} [0x4c01 
resolution 24]

this error never occured with older versions. like  mkgmap- r3997.  what is 
wrong ?

thomas
--
Von: "Gerd Petermann" 
Datum: Donnerstag, 8. Februar 2018 17:40
An: "Development list for mkgmap" 
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

> Hi all,
> 
> I've created patches for splitter and mkgmap.
> The binaries are here:
> http://files.mkgmap.org.uk/download/417/splitter.jar
> http://files.mkgmap.org.uk/detail/416
> 
> Please try splitter with align-for-dem=360. I found no more crashes as long
> as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936
> 
> Maybe you find a combination of  align-for-dem and dem-dists with more than 
> one value
> that still works, I'll try again tomorrow.
> 
> Gerd
> 
> 
> Von: mkgmap-dev  im Auftrag von Gerd 
> Petermann 
> Gesendet: Donnerstag, 8. Februar 2018 13:16
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
> 
> Hi all,
> 
> the patch contained a stupid bug, but there is more to this:
> 1) the effect of the patch depends on the dem-dists value (I assume only the 
> one
> that gives the highest resolution). The higher the resolution the better it 
> works.
> 2) it probably also depends on the boundaries (areas.list)
> 
> I assume now that the tile boundary from areas.list should be a certain 
> multiples of degrees,
> probably different multiples for lat and lon and that the overlap simply makes
> sure that this boundary is within the overlapped area.
> Maybe the preferred multiples also depend on the dem-dist.
> 
> I'll try to find out more ...
> 
> Gerd
> 
> 
> Von: mkgmap-dev  im Auftrag von 
> osm@pinns 
> Gesendet: Donnerstag, 8. Februar 2018 10:33
> An: mkgmap-dev@lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
> 
> Hi Gerd
> 
> I think you are right ,ie
> 
> start and finishing point  at same level seems OK eventhough the route
> turns south 20miles then up again
> 
> r
> 
> Nick
> 
> 
> On 08/02/2018 09:27, Gerd Petermann wrote:
>> Hi all,
>>
>> okay, thanks for testing. I'll try to find a better patch.
>> Please check: I think the patch works fine for routes which cross tile 
>> borders in horizontal direction
>> direction but I still see problems with vertical crossing. Can you confirm 
>> that?
>>
>> Gerd
>>
>> 
>> Von: mkgmap-dev  im Auftrag von 
>> Henning Scholland 
>> Gesendet: Donnerstag, 8. Februar 2018 09:59
>> An: Development list for mkgmap
>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>
>> Same for me, but just did quick test. Will try on the weekend more detailed
>> Henning
>> On 8 Feb 2018, at 16:57, lig fietser 
>> mailto:ligfiet...@hotmail.com>> wrote:
>>
>> Hi Gerd,
>>
>> I tested your patch but I still see frequent crashes near tile borders.
>>
>>
>> 
>> Van: mkgmap-dev  namens Gerd 
>> Petermann 
>> Verzonden: woensdag 7 februari 2018 02:45:27
>> Aan: mkgmap-dev@lists.mkgmap.org.uk
>> Onderwerp: [mkgmap-dev] patch for crash in MapSource
>>
>> Hi all,
>>
>> attached is a patch that seems to help in many cases where --dem-poly causes 
>> crashes in MapSource "Show Profile..."
>> A binary is here:
>> http://files.mkgmap.org.uk/download/414/mkgmap.jar
>>
>> It changes the TRE file and the *.tdb file.
>> I still see a few crashes but maybe those are caused by other problems.
>>
>> Please try and let me know your results. I found no bad impact so far,
>> long distance routing still seems to work, but I've not tested much.
>>
>> @Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
>> In this case this patch is not yet okay.
>>
>> Gerd
>>
>> __

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Gerd Petermann
Hi Nick,

great! In my test cases I found problems with long distance routes without any 
stopover.
Please try that as well, maybe also the inverse routes.

Gerd


Von: mkgmap-dev  im Auftrag von 
osm@pinns 
Gesendet: Donnerstag, 8. Februar 2018 19:01
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

Brilliant ! have done a really spaghetti route with lots of ups and downs left 
and right and

seems to be working with align-for-dem=360  and even

--dem-dists=2484,3312,9942,16560

r

Nick

On 08/02/2018 17:40, Gerd Petermann wrote:

Hi all,

I've created patches for splitter and mkgmap.
The binaries are here:
 http://files.mkgmap.org.uk/download/417/splitter.jar
http://files.mkgmap.org.uk/detail/416

Please try splitter with align-for-dem=360. I found no more crashes as long
as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936

Maybe you find a combination of  align-for-dem and dem-dists with more than one 
value
that still works, I'll try again tomorrow.

Gerd


Von: mkgmap-dev 

 im Auftrag von Gerd Petermann 

Gesendet: Donnerstag, 8. Februar 2018 13:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi all,

the patch contained a stupid bug, but there is more to this:
1) the effect of the patch depends on the dem-dists value (I assume only the one
that gives the highest resolution). The higher the resolution the better it 
works.
2) it probably also depends on the boundaries (areas.list)

I assume now that the tile boundary from areas.list should be a certain 
multiples of degrees,
probably different multiples for lat and lon and that the overlap simply makes
sure that this boundary is within the overlapped area.
Maybe the preferred multiples also depend on the dem-dist.

I'll try to find out more ...

Gerd


Von: mkgmap-dev 

 im Auftrag von osm@pinns 
Gesendet: Donnerstag, 8. Februar 2018 10:33
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route
turns south 20miles then up again

r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:


Hi all,

okay, thanks for testing. I'll try to find a better patch.
Please check: I think the patch works fine for routes which cross tile borders 
in horizontal direction
direction but I still see problems with vertical crossing. Can you confirm that?

Gerd


Von: mkgmap-dev 

 im Auftrag von Henning Scholland 

Gesendet: Donnerstag, 8. Februar 2018 09:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Same for me, but just did quick test. Will try on the weekend more detailed
Henning
On 8 Feb 2018, at 16:57, lig fietser 
mailto:ligfiet...@hotmail.com>>
 wrote:

Hi Gerd,

I tested your patch but I still see frequent crashes near tile borders.



Van: mkgmap-dev 

 namens Gerd Petermann 

Verzonden: woensdag 7 februari 2018 02:45:27
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: [mkgmap-dev] patch for crash in MapSource

Hi all,

attached is a patch that seems to help in many cases where --dem-poly causes 
crashes in MapSource "Show Profile..."
A binary is here:
http://files.mkgmap.org.uk/download/414/mkgmap.jar

It changes the TRE file and the *.tdb file.
I still see a few crashes but maybe those are caused by other problems.

Please try and let me know your results. I found no bad impact so far,
long distance routing still seems to work, but I've not tested much.

@Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
In this case this patch is not yet okay.

Gerd



mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev



___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.u

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Gerd Petermann
Hi Thomas,

the patch is based in r4107, this contains a change from Steve.

I am  not sure if your syntax is wrong or not. Please try this:
amenity=guidepost | amenity=signpost | (tourism=information & 
information=guidepost) {add name='$(name:de')|'$(name)'|'Wegweiser'} [0x4c01 
resolution 24]

I've removed a pair of () .

Gerd


Von: mkgmap-dev  im Auftrag von Thomas 
Morgenstern 
Gesendet: Donnerstag, 8. Februar 2018 19:49
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

This version has a problem reading stylefile. It gives me the following error 
:Error in style:Error: (points:240): quoted word found where command expected. 
Could not open style.
Line 240 is :
amenity=guidepost | amenity=signpost | (tourism=information & 
information=guidepost) {add name=('$(name:de')|'$(name)'|'Wegweiser')} [0x4c01 
resolution 24]

this error never occured with older versions. like  mkgmap- r3997.  what is 
wrong ?

thomas
--
Von: "Gerd Petermann" 
Datum: Donnerstag, 8. Februar 2018 17:40
An: "Development list for mkgmap" 
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

> Hi all,
>
> I've created patches for splitter and mkgmap.
> The binaries are here:
> http://files.mkgmap.org.uk/download/417/splitter.jar
> http://files.mkgmap.org.uk/detail/416
>
> Please try splitter with align-for-dem=360. I found no more crashes as long
> as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936
>
> Maybe you find a combination of  align-for-dem and dem-dists with more than 
> one value
> that still works, I'll try again tomorrow.
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von Gerd 
> Petermann 
> Gesendet: Donnerstag, 8. Februar 2018 13:16
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi all,
>
> the patch contained a stupid bug, but there is more to this:
> 1) the effect of the patch depends on the dem-dists value (I assume only the 
> one
> that gives the highest resolution). The higher the resolution the better it 
> works.
> 2) it probably also depends on the boundaries (areas.list)
>
> I assume now that the tile boundary from areas.list should be a certain 
> multiples of degrees,
> probably different multiples for lat and lon and that the overlap simply makes
> sure that this boundary is within the overlapped area.
> Maybe the preferred multiples also depend on the dem-dist.
>
> I'll try to find out more ...
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von 
> osm@pinns 
> Gesendet: Donnerstag, 8. Februar 2018 10:33
> An: mkgmap-dev@lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Hi Gerd
>
> I think you are right ,ie
>
> start and finishing point  at same level seems OK eventhough the route
> turns south 20miles then up again
>
> r
>
> Nick
>
>
> On 08/02/2018 09:27, Gerd Petermann wrote:
>> Hi all,
>>
>> okay, thanks for testing. I'll try to find a better patch.
>> Please check: I think the patch works fine for routes which cross tile 
>> borders in horizontal direction
>> direction but I still see problems with vertical crossing. Can you confirm 
>> that?
>>
>> Gerd
>>
>> 
>> Von: mkgmap-dev  im Auftrag von 
>> Henning Scholland 
>> Gesendet: Donnerstag, 8. Februar 2018 09:59
>> An: Development list for mkgmap
>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>
>> Same for me, but just did quick test. Will try on the weekend more detailed
>> Henning
>> On 8 Feb 2018, at 16:57, lig fietser 
>> mailto:ligfiet...@hotmail.com>> wrote:
>>
>> Hi Gerd,
>>
>> I tested your patch but I still see frequent crashes near tile borders.
>>
>>
>> 
>> Van: mkgmap-dev  namens Gerd 
>> Petermann 
>> Verzonden: woensdag 7 februari 2018 02:45:27
>> Aan: mkgmap-dev@lists.mkgmap.org.uk
>> Onderwerp: [mkgmap-dev] patch for crash in MapSource
>>
>> Hi all,
>>
>> attached is a patch that seems to help in many cases where --dem-poly causes 
>> crashes in MapSource "Show Profile..."
>> A binary is here:
>> http://files.mkgmap.org.uk/download/414/mkgmap.jar
>>
>> It changes the TRE file and the *.tdb file.
>> I still see a few crashes but maybe those are caused by other problems.
>>
>> Please try and let me know your results. I found no bad impact so far,
>> long distance routing still seems to work, but I've not tested much.
>>
>> @Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
>> In this case this patch is not yet okay.
>>
>> Gerd
>>
>> 
>>
>> mkgmap-dev mailing list
>> mkgmap-dev@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> ___
>> mkgmap-dev mailing list
>> mkgmap-dev@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Thomas Morgenstern
This version has a problem reading stylefile. It gives me the following error 
:Error in style:Error: (points:240): quoted word found where command expected. 
Could not open style. 
Line 240 is : 
amenity=guidepost | amenity=signpost | (tourism=information & 
information=guidepost) {add name=('$(name:de')|'$(name)'|'Wegweiser')} [0x4c01 
resolution 24]

this error never occured with older versions. like  mkgmap- r3997.  what is 
wrong ?

thomas
--
Von: "Gerd Petermann" 
Datum: Donnerstag, 8. Februar 2018 17:40
An: "Development list for mkgmap" 
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

> Hi all,
> 
> I've created patches for splitter and mkgmap.
> The binaries are here:
> http://files.mkgmap.org.uk/download/417/splitter.jar
> http://files.mkgmap.org.uk/detail/416
> 
> Please try splitter with align-for-dem=360. I found no more crashes as long
> as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936
> 
> Maybe you find a combination of  align-for-dem and dem-dists with more than 
> one value
> that still works, I'll try again tomorrow.
> 
> Gerd
> 
> 
> Von: mkgmap-dev  im Auftrag von Gerd 
> Petermann 
> Gesendet: Donnerstag, 8. Februar 2018 13:16
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
> 
> Hi all,
> 
> the patch contained a stupid bug, but there is more to this:
> 1) the effect of the patch depends on the dem-dists value (I assume only the 
> one
> that gives the highest resolution). The higher the resolution the better it 
> works.
> 2) it probably also depends on the boundaries (areas.list)
> 
> I assume now that the tile boundary from areas.list should be a certain 
> multiples of degrees,
> probably different multiples for lat and lon and that the overlap simply makes
> sure that this boundary is within the overlapped area.
> Maybe the preferred multiples also depend on the dem-dist.
> 
> I'll try to find out more ...
> 
> Gerd
> 
> 
> Von: mkgmap-dev  im Auftrag von 
> osm@pinns 
> Gesendet: Donnerstag, 8. Februar 2018 10:33
> An: mkgmap-dev@lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
> 
> Hi Gerd
> 
> I think you are right ,ie
> 
> start and finishing point  at same level seems OK eventhough the route
> turns south 20miles then up again
> 
> r
> 
> Nick
> 
> 
> On 08/02/2018 09:27, Gerd Petermann wrote:
>> Hi all,
>>
>> okay, thanks for testing. I'll try to find a better patch.
>> Please check: I think the patch works fine for routes which cross tile 
>> borders in horizontal direction
>> direction but I still see problems with vertical crossing. Can you confirm 
>> that?
>>
>> Gerd
>>
>> 
>> Von: mkgmap-dev  im Auftrag von 
>> Henning Scholland 
>> Gesendet: Donnerstag, 8. Februar 2018 09:59
>> An: Development list for mkgmap
>> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>>
>> Same for me, but just did quick test. Will try on the weekend more detailed
>> Henning
>> On 8 Feb 2018, at 16:57, lig fietser 
>> mailto:ligfiet...@hotmail.com>> wrote:
>>
>> Hi Gerd,
>>
>> I tested your patch but I still see frequent crashes near tile borders.
>>
>>
>> 
>> Van: mkgmap-dev  namens Gerd 
>> Petermann 
>> Verzonden: woensdag 7 februari 2018 02:45:27
>> Aan: mkgmap-dev@lists.mkgmap.org.uk
>> Onderwerp: [mkgmap-dev] patch for crash in MapSource
>>
>> Hi all,
>>
>> attached is a patch that seems to help in many cases where --dem-poly causes 
>> crashes in MapSource "Show Profile..."
>> A binary is here:
>> http://files.mkgmap.org.uk/download/414/mkgmap.jar
>>
>> It changes the TRE file and the *.tdb file.
>> I still see a few crashes but maybe those are caused by other problems.
>>
>> Please try and let me know your results. I found no bad impact so far,
>> long distance routing still seems to work, but I've not tested much.
>>
>> @Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
>> In this case this patch is not yet okay.
>>
>> Gerd
>>
>> 
>>
>> mkgmap-dev mailing list
>> mkgmap-dev@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> ___
>> mkgmap-dev mailing list
>> mkgmap-dev@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>



> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev_

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread osm@pinns

Hi Gerd

Brilliant ! have done a really spaghetti route with lots of ups and 
downs left and right and


seems to be working with align-for-dem=360  and even

--dem-dists=2484,3312,9942,16560

r

Nick


On 08/02/2018 17:40, Gerd Petermann wrote:

Hi all,

I've created patches for splitter and mkgmap.
The binaries are here:
  http://files.mkgmap.org.uk/download/417/splitter.jar
http://files.mkgmap.org.uk/detail/416

Please try splitter with align-for-dem=360. I found no more crashes as long
as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936

Maybe you find a combination of  align-for-dem and dem-dists with more than one 
value
that still works, I'll try again tomorrow.

Gerd


Von: mkgmap-dev  im Auftrag von Gerd 
Petermann 
Gesendet: Donnerstag, 8. Februar 2018 13:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi all,

the patch contained a stupid bug, but there is more to this:
1) the effect of the patch depends on the dem-dists value (I assume only the one
that gives the highest resolution). The higher the resolution the better it 
works.
2) it probably also depends on the boundaries (areas.list)

I assume now that the tile boundary from areas.list should be a certain 
multiples of degrees,
probably different multiples for lat and lon and that the overlap simply makes
sure that this boundary is within the overlapped area.
Maybe the preferred multiples also depend on the dem-dist.

I'll try to find out more ...

Gerd


Von: mkgmap-dev  im Auftrag von osm@pinns 

Gesendet: Donnerstag, 8. Februar 2018 10:33
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route
turns south 20miles then up again

r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:

Hi all,

okay, thanks for testing. I'll try to find a better patch.
Please check: I think the patch works fine for routes which cross tile borders 
in horizontal direction
direction but I still see problems with vertical crossing. Can you confirm that?

Gerd


Von: mkgmap-dev  im Auftrag von Henning 
Scholland 
Gesendet: Donnerstag, 8. Februar 2018 09:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Same for me, but just did quick test. Will try on the weekend more detailed
Henning
On 8 Feb 2018, at 16:57, lig fietser 
mailto:ligfiet...@hotmail.com>> wrote:

Hi Gerd,

I tested your patch but I still see frequent crashes near tile borders.



Van: mkgmap-dev  namens Gerd Petermann 

Verzonden: woensdag 7 februari 2018 02:45:27
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: [mkgmap-dev] patch for crash in MapSource

Hi all,

attached is a patch that seems to help in many cases where --dem-poly causes crashes in 
MapSource "Show Profile..."
A binary is here:
http://files.mkgmap.org.uk/download/414/mkgmap.jar

It changes the TRE file and the *.tdb file.
I still see a few crashes but maybe those are caused by other problems.

Please try and let me know your results. I found no bad impact so far,
long distance routing still seems to work, but I've not tested much.

@Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
In this case this patch is not yet okay.

Gerd



mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Gerd Petermann
Hi all,

I've created patches for splitter and mkgmap.
The binaries are here:
 http://files.mkgmap.org.uk/download/417/splitter.jar
http://files.mkgmap.org.uk/detail/416

Please try splitter with align-for-dem=360. I found no more crashes as long
as used only one dem level, e.g. dem-dists=3312 or dem-dists=9936

Maybe you find a combination of  align-for-dem and dem-dists with more than one 
value
that still works, I'll try again tomorrow.

Gerd


Von: mkgmap-dev  im Auftrag von Gerd 
Petermann 
Gesendet: Donnerstag, 8. Februar 2018 13:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi all,

the patch contained a stupid bug, but there is more to this:
1) the effect of the patch depends on the dem-dists value (I assume only the one
that gives the highest resolution). The higher the resolution the better it 
works.
2) it probably also depends on the boundaries (areas.list)

I assume now that the tile boundary from areas.list should be a certain 
multiples of degrees,
probably different multiples for lat and lon and that the overlap simply makes
sure that this boundary is within the overlapped area.
Maybe the preferred multiples also depend on the dem-dist.

I'll try to find out more ...

Gerd


Von: mkgmap-dev  im Auftrag von 
osm@pinns 
Gesendet: Donnerstag, 8. Februar 2018 10:33
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route
turns south 20miles then up again

r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:
> Hi all,
>
> okay, thanks for testing. I'll try to find a better patch.
> Please check: I think the patch works fine for routes which cross tile 
> borders in horizontal direction
> direction but I still see problems with vertical crossing. Can you confirm 
> that?
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von 
> Henning Scholland 
> Gesendet: Donnerstag, 8. Februar 2018 09:59
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Same for me, but just did quick test. Will try on the weekend more detailed
> Henning
> On 8 Feb 2018, at 16:57, lig fietser 
> mailto:ligfiet...@hotmail.com>> wrote:
>
> Hi Gerd,
>
> I tested your patch but I still see frequent crashes near tile borders.
>
>
> 
> Van: mkgmap-dev  namens Gerd 
> Petermann 
> Verzonden: woensdag 7 februari 2018 02:45:27
> Aan: mkgmap-dev@lists.mkgmap.org.uk
> Onderwerp: [mkgmap-dev] patch for crash in MapSource
>
> Hi all,
>
> attached is a patch that seems to help in many cases where --dem-poly causes 
> crashes in MapSource "Show Profile..."
> A binary is here:
> http://files.mkgmap.org.uk/download/414/mkgmap.jar
>
> It changes the TRE file and the *.tdb file.
> I still see a few crashes but maybe those are caused by other problems.
>
> Please try and let me know your results. I found no bad impact so far,
> long distance routing still seems to work, but I've not tested much.
>
> @Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
> In this case this patch is not yet okay.
>
> Gerd
>
> 
>
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


profile-crash-v2.patch
Description: profile-crash-v2.patch


align-for-dem.patch
Description: align-for-dem.patch
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] max-jobs patch

2018-02-08 Thread Gerd Petermann
Hi Henning,

maybe you see those high heap values with DEM? How do measure it?
I think the monitor function of VisualVM shows quite well if Garbage Collection 
is under stress or not.

binary is here:
http://files.mkgmap.org.uk/download/415/mkgmap.jar

For those users who already used --max-jobs with or without a paramter before 
there should be no difference.

Gerd


Von: mkgmap-dev  im Auftrag von Henning 
Scholland 
Gesendet: Donnerstag, 8. Februar 2018 09:56
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] max-jobs patch

Hi Gerd,
Maybe my map is somehow special, but mkgmap definitely need more than 1gb heap 
per job. I will check on the weekend. Can you please post a patched mkgmap.jar?

How about doing it the other way round and suggest the user to use max-job 
option if mkgmap think it is useful?

Henning
On 8 Feb 2018, at 16:38, Gerd Petermann 
mailto:gpetermann_muenc...@hotmail.com>> wrote:

Hi Manfred,

thanks for testing. Just to make this clear: I always use --max-jobs, because I 
also
always use -Xmx whenever I compile many tiles.

In this case a large tile is one that results in a large *.img
(one with many MB). Typically this depends on the --max-nodes option for 
splitter
and the style and the mkgmap options (routable or not, without or without DEM 
etc).

The max-jobs option allows to specify the number of parallel jobs,
e.g. --max-jobs=5 would start 5 parallel jobs (threads). Whenever one input 
file is done,
the next one is started until all are finished. The patch only changes the 
default from 1
to "number of cores". You can also use max-jobs=10 on a 2-core cpu, but this 
will slow down
the run time.

What I tried to point out is that a user who doesn't know about the --max--jobs 
option
might as well not know about the meaning of the -Xmx JRE option.

What happens if you start mkgmap on an 8-core machine with max-jobs=8 and
without -Xmx option? I think it will crash, and with the 2nd version of the 
patch it will tell
the user to look at the -Xmx option. So far so good.
What happens on a 4 core machine with max-jobs=4 and no -Xmx option?
What if the OS is 32 bit only? This would not allow much more than -Xmx1700m.
What if the option is used but set to a rather low value, e.g. -Xmx=1000m?

My current thinking is this:
If --max-jobs is not specified mkgmap should check the number of cores and the 
available heap
and assume that one thread needs ~500M.

So, I would use something like num = Math.min(Runtime.getRuntime().maxMemory() 
/ (512 * 1024 * 1024),
 Runtime.getRuntime().availableProcessors()) as default, maybe also for the 
case that one
specifies --max-jobs .

How does that sound?

Gerd








Von: mkgmap-dev  im Auftrag von Manfred 
Haiduk 
Gesendet: Mittwoch, 7. Februar 2018 22:28
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] max-jobs patch

I don't know, if Nordrhein-Westfalen is that kind of large tiles you
meant. Splitter ended up with 43 files and i tried to make mapsource
maps with and without --max-jobs option and mkgmap r4000. My computer
does the job with 43 files about 12minutes faster than without this
option. My laptop is a core i5 with 8Gb of memory. The command i use is
like this line :

java -Xmx7500m -XX:-UseGCOverheadLimit -ea -jar
-Dlog.config=logging.properties
C:\PROGRA~2\KartenTools\mkgmap\mkgmap.jar
--location-autofill=is_in,nearest --mapname=70060001 --family-id=7006
.\styles\mystyle.txt --series-name="STYLE TEST"
--family-name="OpenStreetmap" --country-name=STYLETEST
--country-abbr=STY --area-name=STY --overview-mapname="overview"
--latin1 --style-file=.\styles --style=myland --max-jobs --keep-going
--check-roundabouts --drive-on=detect,right --output-dir=.\out\MYSTYLE
--index --bounds=mybounds --route
--name-tag-list=name,place_name,loc_name --housenumbers
--x-split-name-index --add-pois-to-areas --precomp-sea=.\input\sea.zip
--tdbfile --draw-priority=10 --gmapsupp -c .\data\MYSTYLE\template.args
--description=MYSTYLE --remove-ovm-work-files=true

Hope this gave you some useful hints


Am 07.02.2018 um 20:06 schrieb Gerd Petermann:
 Hi Mike,

 I did not yet try it. My understanding is that the Garbage Collection will try 
hard
 to avoid an out of heap exception. In other words: A user might see better 
throughput
 with fewer parallel jobs. What are your experiences? Did you try with
 large maps, say > 40 large tiles ?

 Gerd



 Von: mkgmap-dev  im Auftrag von Mike 
Baggaley 
 Gesendet: Mittwoch, 7. Februar 2018 01:58
 An: 'Development list for mkgmap'
 Betreff: Re: [mkgmap-dev] max-jobs patch

 Hi Gerd, please find attached v2 of the max-jobs patch.

 This version additionally catches out of heap memory exceptions and displays
 a message suggesting either the use of the Java -Xmx option to increase the
 available heap memory or the mkgmap --max-jobs option with a smaller value
 to reduce the memory re

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Gerd Petermann
Hi all,

the patch contained a stupid bug, but there is more to this:
1) the effect of the patch depends on the dem-dists value (I assume only the one
that gives the highest resolution). The higher the resolution the better it 
works.
2) it probably also depends on the boundaries (areas.list)

I assume now that the tile boundary from areas.list should be a certain 
multiples of degrees,
probably different multiples for lat and lon and that the overlap simply makes
sure that this boundary is within the overlapped area.
Maybe the preferred multiples also depend on the dem-dist.

I'll try to find out more ...

Gerd


Von: mkgmap-dev  im Auftrag von 
osm@pinns 
Gesendet: Donnerstag, 8. Februar 2018 10:33
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route
turns south 20miles then up again

r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:
> Hi all,
>
> okay, thanks for testing. I'll try to find a better patch.
> Please check: I think the patch works fine for routes which cross tile 
> borders in horizontal direction
> direction but I still see problems with vertical crossing. Can you confirm 
> that?
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von 
> Henning Scholland 
> Gesendet: Donnerstag, 8. Februar 2018 09:59
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] patch for crash in MapSource
>
> Same for me, but just did quick test. Will try on the weekend more detailed
> Henning
> On 8 Feb 2018, at 16:57, lig fietser 
> mailto:ligfiet...@hotmail.com>> wrote:
>
> Hi Gerd,
>
> I tested your patch but I still see frequent crashes near tile borders.
>
>
> 
> Van: mkgmap-dev  namens Gerd 
> Petermann 
> Verzonden: woensdag 7 februari 2018 02:45:27
> Aan: mkgmap-dev@lists.mkgmap.org.uk
> Onderwerp: [mkgmap-dev] patch for crash in MapSource
>
> Hi all,
>
> attached is a patch that seems to help in many cases where --dem-poly causes 
> crashes in MapSource "Show Profile..."
> A binary is here:
> http://files.mkgmap.org.uk/download/414/mkgmap.jar
>
> It changes the TRE file and the *.tdb file.
> I still see a few crashes but maybe those are caused by other problems.
>
> Please try and let me know your results. I found no bad impact so far,
> long distance routing still seems to work, but I've not tested much.
>
> @Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
> In this case this patch is not yet okay.
>
> Gerd
>
> 
>
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] Commit r4106: Better detect errors in action command lists.

2018-02-08 Thread Steve Ratcliffe

Hi Gerd


you changed the lines file in the default style (removed lots of now obsolete 
semicolons)


I did, I've reverted that part of the change.

..Steve


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


[mkgmap-dev] Commit r4107: Revert removal of semi-colons from lines file.

2018-02-08 Thread svn commit
Version mkgmap-r4107 was committed by steve on Thu, 08 Feb 2018

Revert removal of semi-colons from lines file.

They are note required, but it is probably clearer with them
present.


http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4107
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread osm@pinns

Hi Gerd

I think you are right ,ie

start and finishing point  at same level seems OK eventhough the route 
turns south 20miles then up again


r

Nick


On 08/02/2018 09:27, Gerd Petermann wrote:

Hi all,

okay, thanks for testing. I'll try to find a better patch.
Please check: I think the patch works fine for routes which cross tile borders 
in horizontal direction
direction but I still see problems with vertical crossing. Can you confirm that?

Gerd


Von: mkgmap-dev  im Auftrag von Henning 
Scholland 
Gesendet: Donnerstag, 8. Februar 2018 09:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Same for me, but just did quick test. Will try on the weekend more detailed
Henning
On 8 Feb 2018, at 16:57, lig fietser 
mailto:ligfiet...@hotmail.com>> wrote:

Hi Gerd,

I tested your patch but I still see frequent crashes near tile borders.



Van: mkgmap-dev  namens Gerd Petermann 

Verzonden: woensdag 7 februari 2018 02:45:27
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: [mkgmap-dev] patch for crash in MapSource

Hi all,

attached is a patch that seems to help in many cases where --dem-poly causes crashes in 
MapSource "Show Profile..."
A binary is here:
http://files.mkgmap.org.uk/download/414/mkgmap.jar

It changes the TRE file and the *.tdb file.
I still see a few crashes but maybe those are caused by other problems.

Please try and let me know your results. I found no bad impact so far,
long distance routing still seems to work, but I've not tested much.

@Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
In this case this patch is not yet okay.

Gerd



mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Gerd Petermann
Hi all,

okay, thanks for testing. I'll try to find a better patch.
Please check: I think the patch works fine for routes which cross tile borders 
in horizontal direction
direction but I still see problems with vertical crossing. Can you confirm that?

Gerd


Von: mkgmap-dev  im Auftrag von Henning 
Scholland 
Gesendet: Donnerstag, 8. Februar 2018 09:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] patch for crash in MapSource

Same for me, but just did quick test. Will try on the weekend more detailed
Henning
On 8 Feb 2018, at 16:57, lig fietser 
mailto:ligfiet...@hotmail.com>> wrote:

Hi Gerd,

I tested your patch but I still see frequent crashes near tile borders.



Van: mkgmap-dev  namens Gerd Petermann 

Verzonden: woensdag 7 februari 2018 02:45:27
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: [mkgmap-dev] patch for crash in MapSource

Hi all,

attached is a patch that seems to help in many cases where --dem-poly causes 
crashes in MapSource "Show Profile..."
A binary is here:
http://files.mkgmap.org.uk/download/414/mkgmap.jar

It changes the TRE file and the *.tdb file.
I still see a few crashes but maybe those are caused by other problems.

Please try and let me know your results. I found no bad impact so far,
long distance routing still seems to work, but I've not tested much.

@Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
In this case this patch is not yet okay.

Gerd



mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread Henning Scholland
Same for me, but just did quick test. Will try on the weekend more detailed
Henning

On 8 Feb 2018, 16:57, at 16:57, lig fietser  wrote:
>Hi Gerd,
>
>I tested your patch but I still see frequent crashes near tile borders.
>
>
>
>Van: mkgmap-dev  namens Gerd
>Petermann 
>Verzonden: woensdag 7 februari 2018 02:45:27
>Aan: mkgmap-dev@lists.mkgmap.org.uk
>Onderwerp: [mkgmap-dev] patch for crash in MapSource
>
>Hi all,
>
>attached is a patch that seems to help in many cases where --dem-poly
>causes crashes in MapSource "Show Profile..."
>A binary is here:
>http://files.mkgmap.org.uk/download/414/mkgmap.jar
>
>It changes the TRE file and the *.tdb file.
>I still see a few crashes but maybe those are caused by other problems.
>
>Please try and let me know your results. I found no bad impact so far,
>long distance routing still seems to work, but I've not tested much.
>
>@Steve: Maybe we have to make sure that the areas in *.tdb do not
>overlap.
>In this case this patch is not yet okay.
>
>Gerd
>
>
>
>
>___
>mkgmap-dev mailing list
>mkgmap-dev@lists.mkgmap.org.uk
>http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread osm@pinns

Hi Gerd

Same here testing the UK

Nick


On 08/02/2018 08:57, lig fietser wrote:


Hi Gerd,

I tested your patch but I still see frequent crashes near tile borders.



*Van:* mkgmap-dev  namens Gerd 
Petermann 

*Verzonden:* woensdag 7 februari 2018 02:45:27
*Aan:* mkgmap-dev@lists.mkgmap.org.uk
*Onderwerp:* [mkgmap-dev] patch for crash in MapSource
Hi all,

attached is a patch that seems to help in many cases where --dem-poly 
causes crashes in MapSource "Show Profile..."

A binary is here:
http://files.mkgmap.org.uk/download/414/mkgmap.jar

It changes the TRE file and the *.tdb file.
I still see a few crashes but maybe those are caused by other problems.

Please try and let me know your results. I found no bad impact so far,
long distance routing still seems to work, but I've not tested much.

@Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
In this case this patch is not yet okay.

Gerd


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] max-jobs patch

2018-02-08 Thread Henning Scholland
Hi Gerd,
Maybe my map is somehow special, but mkgmap definitely need more than 1gb heap 
per job. I will check on the weekend. Can you please post a patched mkgmap.jar?

How about doing it the other way round and suggest the user to use max-job 
option if mkgmap think it is useful?

Henning

On 8 Feb 2018, 16:38, at 16:38, Gerd Petermann 
 wrote:
>Hi Manfred,
>
>thanks for testing. Just to make this clear: I always use --max-jobs,
>because I also
>always use -Xmx whenever I compile many tiles.
>
>In this case a large tile is one that results in a large *.img
>(one with many MB). Typically this depends on the --max-nodes option
>for splitter
>and the style and the mkgmap options (routable or not, without or
>without DEM etc).
>
>The max-jobs option allows to specify the number of parallel jobs,
>e.g. --max-jobs=5 would start 5 parallel jobs (threads). Whenever one
>input file is done,
>the next one is started until all are finished. The patch only changes
>the default from 1
>to "number of cores". You can also use max-jobs=10 on a 2-core cpu, but
>this will slow down
>the run time.
>
>What I tried to point out is that a user who doesn't know about the
>--max--jobs option
>might as well not know about the meaning of the -Xmx JRE option.
>
>What happens if you start mkgmap on an 8-core machine with max-jobs=8
>and
>without -Xmx option? I think it will crash, and with the 2nd version of
>the patch it will tell
>the user to look at the -Xmx option. So far so good.
>What happens on a 4 core machine with max-jobs=4 and no -Xmx option?
>What if the OS is 32 bit only? This would not allow much more than
>-Xmx1700m.
>What if the option is used but set to a rather low value, e.g.
>-Xmx=1000m?
>
>My current thinking is this:
>If --max-jobs is not specified mkgmap should check the number of cores
>and the available heap
>and assume that one thread needs ~500M.
>
>So, I would use something like num =
>Math.min(Runtime.getRuntime().maxMemory() / (512 * 1024 * 1024),
>Runtime.getRuntime().availableProcessors()) as default, maybe also for
>the case that one
>specifies --max-jobs .
>
>How does that sound?
>
>Gerd
>
>
>
>
>
>
>
>Von: mkgmap-dev  im Auftrag von
>Manfred Haiduk 
>Gesendet: Mittwoch, 7. Februar 2018 22:28
>An: mkgmap-dev@lists.mkgmap.org.uk
>Betreff: Re: [mkgmap-dev] max-jobs patch
>
>I don't know, if Nordrhein-Westfalen is that kind of large tiles you
>meant. Splitter ended up with 43 files and i tried to make mapsource
>maps with and without --max-jobs option and mkgmap r4000. My computer
>does the job with 43 files about 12minutes faster than without this
>option. My laptop is a core i5 with 8Gb of memory. The command i use is
>like this line :
>
>java -Xmx7500m -XX:-UseGCOverheadLimit -ea -jar
>-Dlog.config=logging.properties
>C:\PROGRA~2\KartenTools\mkgmap\mkgmap.jar
>--location-autofill=is_in,nearest --mapname=70060001 --family-id=7006
>.\styles\mystyle.txt --series-name="STYLE TEST"
>--family-name="OpenStreetmap" --country-name=STYLETEST
>--country-abbr=STY --area-name=STY --overview-mapname="overview"
>--latin1 --style-file=.\styles --style=myland --max-jobs --keep-going
>--check-roundabouts --drive-on=detect,right --output-dir=.\out\MYSTYLE
>--index --bounds=mybounds --route
>--name-tag-list=name,place_name,loc_name --housenumbers
>--x-split-name-index --add-pois-to-areas --precomp-sea=.\input\sea.zip
>--tdbfile --draw-priority=10 --gmapsupp -c .\data\MYSTYLE\template.args
>--description=MYSTYLE --remove-ovm-work-files=true
>
>Hope this gave you some useful hints
>
>
>Am 07.02.2018 um 20:06 schrieb Gerd Petermann:
>> Hi Mike,
>>
>> I did not yet try it. My understanding is that the Garbage Collection
>will try hard
>> to avoid an out of heap exception. In other words: A user might see
>better throughput
>> with fewer parallel jobs. What are your experiences? Did you try with
>> large maps, say > 40 large tiles ?
>>
>> Gerd
>>
>> 
>> Von: mkgmap-dev  im Auftrag
>von Mike Baggaley 
>> Gesendet: Mittwoch, 7. Februar 2018 01:58
>> An: 'Development list for mkgmap'
>> Betreff: Re: [mkgmap-dev] max-jobs patch
>>
>> Hi Gerd, please find attached v2 of the max-jobs patch.
>>
>> This version additionally catches out of heap memory exceptions and
>displays
>> a message suggesting either the use of the Java -Xmx option to
>increase the
>> available heap memory or the mkgmap --max-jobs option with a smaller
>value
>> to reduce the memory requirement (the latter is suggested only if
>using more
>> than one thread).
>>
>> How does that seem?
>> Regards,
>> Mike
>>
>> -Original Message-
>> From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
>> Sent: 05 February 2018 07:28
>> To: Mike Baggaley ; 'Development list for mkgmap'
>> 
>> Subject: Re: [mkgmap-dev] max-jobs patch
>>
>> Hi Mike,
>>
>> thought about this again. Maybe this change is too simple. With
>multiple
>> jobs one also
>> needs more heap (-Xmx JRE option). If

Re: [mkgmap-dev] patch for crash in MapSource

2018-02-08 Thread lig fietser
Hi Gerd,

I tested your patch but I still see frequent crashes near tile borders.



Van: mkgmap-dev  namens Gerd Petermann 

Verzonden: woensdag 7 februari 2018 02:45:27
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: [mkgmap-dev] patch for crash in MapSource

Hi all,

attached is a patch that seems to help in many cases where --dem-poly causes 
crashes in MapSource "Show Profile..."
A binary is here:
http://files.mkgmap.org.uk/download/414/mkgmap.jar

It changes the TRE file and the *.tdb file.
I still see a few crashes but maybe those are caused by other problems.

Please try and let me know your results. I found no bad impact so far,
long distance routing still seems to work, but I've not tested much.

@Steve: Maybe we have to make sure that the areas in *.tdb do not overlap.
In this case this patch is not yet okay.

Gerd
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] Commit r4106: Better detect errors in action command lists.

2018-02-08 Thread Gerd Petermann
Hi Steve,

you changed the lines file in the default style (removed lots of now obsolete 
semicolons)
This seems unintented as I still see the semicolons in the other files.

Gerd


Von: mkgmap-dev  im Auftrag von svn 
commit 
Gesendet: Mittwoch, 7. Februar 2018 23:02
An: mkgmap-...@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk
Betreff: [mkgmap-dev] Commit r4106: Better detect errors in action command  
lists.

Version mkgmap-r4106 was committed by steve on Wed, 07 Feb 2018

Better detect errors in action command lists.

It is no longer required to end set, add, setaccess and addaccess
commands with a semicolon.

http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4106
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] max-jobs patch

2018-02-08 Thread Gerd Petermann
Hi Manfred,

thanks for testing. Just to make this clear: I always use --max-jobs, because I 
also
always use -Xmx whenever I compile many tiles.

In this case a large tile is one that results in a large *.img
(one with many MB). Typically this depends on the --max-nodes option for 
splitter
and the style and the mkgmap options (routable or not, without or without DEM 
etc).

The max-jobs option allows to specify the number of parallel jobs,
e.g. --max-jobs=5 would start 5 parallel jobs (threads). Whenever one input 
file is done,
the next one is started until all are finished. The patch only changes the 
default from 1
to "number of cores". You can also use max-jobs=10 on a 2-core cpu, but this 
will slow down
the run time.

What I tried to point out is that a user who doesn't know about the --max--jobs 
option
might as well not know about the meaning of the -Xmx JRE option.

What happens if you start mkgmap on an 8-core machine with max-jobs=8 and
without -Xmx option? I think it will crash, and with the 2nd version of the 
patch it will tell
the user to look at the -Xmx option. So far so good.
What happens on a 4 core machine with max-jobs=4 and no -Xmx option?
What if the OS is 32 bit only? This would not allow much more than -Xmx1700m.
What if the option is used but set to a rather low value, e.g. -Xmx=1000m?

My current thinking is this:
If --max-jobs is not specified mkgmap should check the number of cores and the 
available heap
and assume that one thread needs ~500M. 

So, I would use something like num = Math.min(Runtime.getRuntime().maxMemory() 
/ (512 * 1024 * 1024),
 Runtime.getRuntime().availableProcessors()) as default, maybe also for the 
case that one
specifies --max-jobs .

How does that sound?

Gerd







Von: mkgmap-dev  im Auftrag von Manfred 
Haiduk 
Gesendet: Mittwoch, 7. Februar 2018 22:28
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] max-jobs patch

I don't know, if Nordrhein-Westfalen is that kind of large tiles you
meant. Splitter ended up with 43 files and i tried to make mapsource
maps with and without --max-jobs option and mkgmap r4000. My computer
does the job with 43 files about 12minutes faster than without this
option. My laptop is a core i5 with 8Gb of memory. The command i use is
like this line :

java -Xmx7500m -XX:-UseGCOverheadLimit -ea -jar
-Dlog.config=logging.properties
C:\PROGRA~2\KartenTools\mkgmap\mkgmap.jar
--location-autofill=is_in,nearest --mapname=70060001 --family-id=7006
.\styles\mystyle.txt --series-name="STYLE TEST"
--family-name="OpenStreetmap" --country-name=STYLETEST
--country-abbr=STY --area-name=STY --overview-mapname="overview"
--latin1 --style-file=.\styles --style=myland --max-jobs --keep-going
--check-roundabouts --drive-on=detect,right --output-dir=.\out\MYSTYLE
--index --bounds=mybounds --route
--name-tag-list=name,place_name,loc_name --housenumbers
--x-split-name-index --add-pois-to-areas --precomp-sea=.\input\sea.zip
--tdbfile --draw-priority=10 --gmapsupp -c .\data\MYSTYLE\template.args
--description=MYSTYLE --remove-ovm-work-files=true

Hope this gave you some useful hints


Am 07.02.2018 um 20:06 schrieb Gerd Petermann:
> Hi Mike,
>
> I did not yet try it. My understanding is that the Garbage Collection will 
> try hard
> to avoid an out of heap exception. In other words: A user might see better 
> throughput
> with fewer parallel jobs. What are your experiences? Did you try with
> large maps, say > 40 large tiles ?
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von Mike 
> Baggaley 
> Gesendet: Mittwoch, 7. Februar 2018 01:58
> An: 'Development list for mkgmap'
> Betreff: Re: [mkgmap-dev] max-jobs patch
>
> Hi Gerd, please find attached v2 of the max-jobs patch.
>
> This version additionally catches out of heap memory exceptions and displays
> a message suggesting either the use of the Java -Xmx option to increase the
> available heap memory or the mkgmap --max-jobs option with a smaller value
> to reduce the memory requirement (the latter is suggested only if using more
> than one thread).
>
> How does that seem?
> Regards,
> Mike
>
> -Original Message-
> From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
> Sent: 05 February 2018 07:28
> To: Mike Baggaley ; 'Development list for mkgmap'
> 
> Subject: Re: [mkgmap-dev] max-jobs patch
>
> Hi Mike,
>
> thought about this again. Maybe this change is too simple. With multiple
> jobs one also
> needs more heap (-Xmx JRE option). If you create rather large tiles with
> splitter (max-nodes=160)
> you need 0.5 - 1 GB for each job. Not sure what happens when a user creates
> a map with
> 10 tiles on an 8-core machine without any -Xmx option.
>
> I fear this will result in OutOfMemory exception, so better check the
> available heap as well.
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von Mike
> Baggaley 
> Gesendet: Sonntag, 4. Februar 2018 15:14