Re: [mkgmap-dev] default style improvements
Hi Gerd
Here is another patch. I've made the changes as you suggested and the
following changes:
When highway=path is converted into a cycleway or bridleway, add
foot=yes in case the inc/access[_country] rules don't allow foot on the
resultant highway type
Restrict which historic= are shown as polygons. The original patch
widened this too much.
Regards
Ticker
On Thu, 2019-01-03 at 14:56 +, Gerd Petermann wrote:
> Hi Ticker,
>
> yes please, my understanding was that the patch was not accepted.
>
> Gerd
>
>
> Von: mkgmap-dev im Auftrag
> von Ticker Berkin
> Gesendet: Donnerstag, 3. Januar 2019 11:59
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] default style improvements
>
> Hi Gerd
>
> Do you want me to do another version of this patch before you commit
> it?
>
> I'd like to get on with the next set of changes; minor things like
> removing horse= can be done with these.
>
> Regards
> Ticker
>
> On Thu, 2018-12-13 at 10:54 +, Ticker Berkin wrote:
> > Hi Gerd
> >
> > My rationale was to see what highway= tags from various european
> > countries the default style didn't handle and hence generated:
> >
> > [0x07 road_class=0 road_speed=0 resolution 23]
> >
> > and then decide to:
> >
> > a) explicitly ignore.
> > b) handle as if they were a well defined highway type,
> >with appropriate access control.
> > c) generate a new line type, with routing as appropriate.
> > d) allow mop-up as above.
> >
> > I removed escape/emergency_bay because I didn't think they added
> > anything useful to routing or the resultant map.
> >
> > footpath/foot looked like they should be footway or path, but if
> > you
> > think they should be ignored, I have no problem with that.
> >
> > What remained after this exercise was a few rubbish tags and lots
> > of
> > highway={real name of street} and I'd rather have these on my map
> >
> > The {add horse=xxx} I just changed a bit to be in keeping with what
> > was
> > there already but happy to delete it.
> >
> > Ticker
> >
> > On Thu, 2018-12-13 at 09:18 +, Gerd Petermann wrote:
> > > Hi Ticker,
> > >
> > > I think it is not a good idea to remove highway=escape or
> > > highway=emergency_bay. The last time I looked at them most where
> > > correctly mapped.
> > > I'd also remove horse=yes or horse=no unless you want evaluate
> > > that
> > > somewhere in the style. Don't know why it is in the current
> > > default
> > > style.
> > > There is no code in mkgmap to evaluate it.
> > >
> > > Reg. rules like
> > > highway=footpath | highway=foot {set highway=footway} # fix
> > > common
> > > bad tagging
> > > I think we don't need them. Most of those ways are mapped by HOT
> > > projects, it is very likely that they are not connected or self
> > > intersecting etc.
> > > I'd rather remove the mop up rule instead of adding a lot of "try
> > > to
> > > guess better" rules.
> > >
> > > Gerd
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-devIndex: resources/styles/default/inc/access_country
===
--- resources/styles/default/inc/access_country (revision 4258)
+++ resources/styles/default/inc/access_country (working copy)
@@ -4,19 +4,26 @@
# Belgium (BEL)
-highway=trunk & mkgmap:country=BEL { add bicycle=no; add foot=no }
-highway=cycleway & mkgmap:country=BEL { add foot=yes }
-highway=bridleway & mkgmap:country=BEL { add foot=yes }
+highway=trunk & mkgmap:country=BEL {add bicycle=no; add foot=no}
+highway=cycleway & mkgmap:country=BEL {add foot=yes}
+highway=bridleway & mkgmap:country=BEL {add foot=yes}
# The Netherlands (NLD)
-highway=trunk & mkgmap:country=NLD { add bicycle=no; add foot=no }
-highway=cycleway & mkgmap:country=NLD { add foot=yes }
-highway=bridleway & mkgmap:country=NLD { add foot=yes }
+highway=trunk & mkgmap:country=NLD {add bicycle=no; add foot=no}
+highway=cycleway & mkgmap:country=NLD {add foot=yes}
+highway=bridleway & mkgmap:country=NLD {add foot=yes}
# Spain (ESP)
-highway=trunk & mkgmap:country=ESP { add bicycle=yes; add foot=yes }
-highway=bridleway & mkgmap:country=ESP { add bicycle=yes; add foot=yes }
+highway=trunk & mkgmap:country=ESP {add bicycle=yes; add foot=yes}
+highway=bridleway & mkgmap:country=ESP {add bicycle=yes; add foot=yes}
+# United Kingdom (GBR)
+highway=cycleway & mkgmap:country=GBR {add foot=yes}
+highway=bridleway & mkgmap:country=GBR {
+add bicycle=yes;
+add foot=yes;
+add motor_vehicle=private
+}
Index: resources/styles/default/lines
===
--- resources/styles/default/lines (revision 4258)
+++ resou
Re: [mkgmap-dev] default style improvements
Hi Ticker,
yes please, my understanding was that the patch was not accepted.
Gerd
Von: mkgmap-dev im Auftrag von Ticker
Berkin
Gesendet: Donnerstag, 3. Januar 2019 11:59
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] default style improvements
Hi Gerd
Do you want me to do another version of this patch before you commit
it?
I'd like to get on with the next set of changes; minor things like
removing horse= can be done with these.
Regards
Ticker
On Thu, 2018-12-13 at 10:54 +, Ticker Berkin wrote:
> Hi Gerd
>
> My rationale was to see what highway= tags from various european
> countries the default style didn't handle and hence generated:
>
> [0x07 road_class=0 road_speed=0 resolution 23]
>
> and then decide to:
>
> a) explicitly ignore.
> b) handle as if they were a well defined highway type,
>with appropriate access control.
> c) generate a new line type, with routing as appropriate.
> d) allow mop-up as above.
>
> I removed escape/emergency_bay because I didn't think they added
> anything useful to routing or the resultant map.
>
> footpath/foot looked like they should be footway or path, but if you
> think they should be ignored, I have no problem with that.
>
> What remained after this exercise was a few rubbish tags and lots of
> highway={real name of street} and I'd rather have these on my map
>
> The {add horse=xxx} I just changed a bit to be in keeping with what
> was
> there already but happy to delete it.
>
> Ticker
>
> On Thu, 2018-12-13 at 09:18 +, Gerd Petermann wrote:
> > Hi Ticker,
> >
> > I think it is not a good idea to remove highway=escape or
> > highway=emergency_bay. The last time I looked at them most where
> > correctly mapped.
> > I'd also remove horse=yes or horse=no unless you want evaluate that
> > somewhere in the style. Don't know why it is in the current default
> > style.
> > There is no code in mkgmap to evaluate it.
> >
> > Reg. rules like
> > highway=footpath | highway=foot {set highway=footway} # fix common
> > bad tagging
> > I think we don't need them. Most of those ways are mapped by HOT
> > projects, it is very likely that they are not connected or self
> > intersecting etc.
> > I'd rather remove the mop up rule instead of adding a lot of "try
> > to
> > guess better" rules.
> >
> > Gerd
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] splitter, mapid
Hi Gerd, we can use any formula to assign mapid. If this formula would be widely accepted, there wouldn't be much conflicts between maps created by different developers. If we use the original Garmin's formula, then we would avoid conflicts with many existing Garmin's maps too. The only requirement would be to avoid FIDs already used by Garmin. As for my other divagation, it was about how to implement Garmin's formula. For full implementation, we would need some changes to mkgmap too. Without changes to mkgmap, we can implement forumla only for FIDs up to some limit. I have suggested, how this partial implementation could look like. -- Best regards, Andrzej ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Not-equal compare bug?
See this note in the style manual:
There used to be some restrictions on the kind of expression you could
use. Now the only
restriction is you must have at least one test that depends on a tag
existing. So you cannot
match on everything, regardless of tags, or test for an object that
does not have a tag.
Lorenzo
Il giorno gio, 03/01/2019 alle 15.05 +0200, Harri Suomalainen ha
scritto:
> Also this line seems to give the same error:
> !(highway=* & oneway=*) { deletealltags }
>
> Error in style: Error: (lines:12): Invalid rule expression:
> $highway!=*
> > $oneway!=*
>
> Hope this helps, as this is a different syntax at least and the same
> result is still complained of.
>
>
>
> On 1/3/19 2:35 PM, Harri Suomalainen wrote:
> > Using mkgmap-r4260 I tried several variations to make a rule match
> > when
> > some tag does not exist:
> >
> > Line: ( highway!=* | oneway!=*) { deletealltags }
> > Error in style: Error: (lines:12): Invalid rule expression:
> > $highway!=*|
> > $oneway!=*
> >
> > Similar error is given when comparing expression with this line:
> > oneway!=* { deletealltags }
> >
> > Tt seems != works fine but only if there is an equal comparision
> > first
> > like in this line that gives no error:
> >highway=* & oneway !=* { deletealltags }
> >
> > Do I missunderstand something or is this a bug?
> >
> > I think I tried some other use case while back and I got similar
> > errors
> > when it started with != comparision first. This may not be a very
> > new
> > issue.
> >
> > Chears, Harri
> > ___
> > mkgmap-dev mailing list
> > mkgmap-dev@lists.mkgmap.org.uk
> >
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
>
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Not-equal compare bug?
Also this line seems to give the same error:
!(highway=* & oneway=*) { deletealltags }
Error in style: Error: (lines:12): Invalid rule expression: $highway!=*
| $oneway!=*
Hope this helps, as this is a different syntax at least and the same
result is still complained of.
On 1/3/19 2:35 PM, Harri Suomalainen wrote:
Using mkgmap-r4260 I tried several variations to make a rule match when
some tag does not exist:
Line: ( highway!=* | oneway!=*) { deletealltags }
Error in style: Error: (lines:12): Invalid rule expression: $highway!=*|
$oneway!=*
Similar error is given when comparing expression with this line:
oneway!=* { deletealltags }
Tt seems != works fine but only if there is an equal comparision first
like in this line that gives no error:
highway=* & oneway !=* { deletealltags }
Do I missunderstand something or is this a bug?
I think I tried some other use case while back and I got similar errors
when it started with != comparision first. This may not be a very new
issue.
Chears, Harri
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Not-equal compare bug?
Using mkgmap-r4260 I tried several variations to make a rule match when
some tag does not exist:
Line: ( highway!=* | oneway!=*) { deletealltags }
Error in style: Error: (lines:12): Invalid rule expression: $highway!=*|
$oneway!=*
Similar error is given when comparing expression with this line:
oneway!=* { deletealltags }
Tt seems != works fine but only if there is an equal comparision first
like in this line that gives no error:
highway=* & oneway !=* { deletealltags }
Do I missunderstand something or is this a bug?
I think I tried some other use case while back and I got similar errors
when it started with != comparision first. This may not be a very new issue.
Chears, Harri
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] default style improvements
Hi Gerd
Do you want me to do another version of this patch before you commit
it?
I'd like to get on with the next set of changes; minor things like
removing horse= can be done with these.
Regards
Ticker
On Thu, 2018-12-13 at 10:54 +, Ticker Berkin wrote:
> Hi Gerd
>
> My rationale was to see what highway= tags from various european
> countries the default style didn't handle and hence generated:
>
> [0x07 road_class=0 road_speed=0 resolution 23]
>
> and then decide to:
>
> a) explicitly ignore.
> b) handle as if they were a well defined highway type,
>with appropriate access control.
> c) generate a new line type, with routing as appropriate.
> d) allow mop-up as above.
>
> I removed escape/emergency_bay because I didn't think they added
> anything useful to routing or the resultant map.
>
> footpath/foot looked like they should be footway or path, but if you
> think they should be ignored, I have no problem with that.
>
> What remained after this exercise was a few rubbish tags and lots of
> highway={real name of street} and I'd rather have these on my map
>
> The {add horse=xxx} I just changed a bit to be in keeping with what
> was
> there already but happy to delete it.
>
> Ticker
>
> On Thu, 2018-12-13 at 09:18 +, Gerd Petermann wrote:
> > Hi Ticker,
> >
> > I think it is not a good idea to remove highway=escape or
> > highway=emergency_bay. The last time I looked at them most where
> > correctly mapped.
> > I'd also remove horse=yes or horse=no unless you want evaluate that
> > somewhere in the style. Don't know why it is in the current default
> > style.
> > There is no code in mkgmap to evaluate it.
> >
> > Reg. rules like
> > highway=footpath | highway=foot {set highway=footway} # fix common
> > bad tagging
> > I think we don't need them. Most of those ways are mapped by HOT
> > projects, it is very likely that they are not connected or self
> > intersecting etc.
> > I'd rather remove the mop up rule instead of adding a lot of "try
> > to
> > guess better" rules.
> >
> > Gerd
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
