Re: [mkgmap-dev] Performance with --bounds option
Hi Ticker, some more details: I didn't think of boundary relations like r1959008 which contains > 700 outer rings. For each node close to that boundary mkgmap called Java2DConverter.areaToSingularAreas() which calculated all the areas again and again. In Germany, boundary relations typically have only one ring ;) I think I should look into the code which compiles bounds.zip, somehow I expected that those complex areas are split to singular areas, might improve performance. Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 19:46 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Performance with --bounds option Hi Ticker, I forgot to remove some experimental code for is-in branch in BoundaryQuadTree. Fixed with r4469. I'll probably also remove the methods pointInsideArea() and pointInsideSingularArea() in BoundaryUtil. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 18. März 2020 18:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Performance with --bounds option Have done: http://files.mkgmap.org.uk/download/462/74220001.osm.pbf Ticker On Wed, 2020-03-18 at 16:26 +, Gerd Petermann wrote: > Hi Ticker, > > will look at it tomorrow. Maybe you can upload the file to > http://files.mkgmap.org.uk/ > > Gerd > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Mittwoch, 18. März 2020 11:56 > An: Development list for mkgmap > Betreff: Re: [mkgmap-dev] Performance with --bounds option > > Hi Gerd > > It's > > 74220001: 2674688,-700416 to 2811904,-233472 > # : 57.392578,-15.029297 to 60.336914,-5.009766 > > Ticker > > On Wed, 2020-03-18 at 10:46 +, Gerd Petermann wrote: > > Hi Ticker, > > > > please tell me the tile boundaries > > > > Gerd > > > > > > > > Von: mkgmap-dev im Auftrag > > von Ticker Berkin > > Gesendet: Mittwoch, 18. März 2020 11:43 > > An: mkgmap development > > Betreff: [mkgmap-dev] Performance with --bounds option > > > > Hi Gerd > > > > With the current version I have a tile that takes 3.5 hours to > > build. > > With an old version (r4295) it took about 3 minutes. Without - > > -bounds > > it takes 1 minute 15 secs. > > > > Relevant options are: > > --bounds=bounds.zip --location-autofill=is_in,nearest > > > > > > From the mkgmap.log files: > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Checking bounds dir took 66 ms > > ... > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Starting with location hook > > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_265_ > > -75.bnd > > ... about 40 similar messages ... > > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_280_ > > -25.bnd > > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > > ../mapGB/74220001.osm.pbf: no precompiled boundary information > > available for raster tile 275_-40 > > ... 16 similar messages ... > > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > > ../mapGB/74220001.osm.pbf: no precompiled boundary information > > available for raster tile 280_-25 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: QuadTree searches: 97834 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Location hook finished in 12747318 ms > > > > The old version had similar lines, but the stats at the end are: > > > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: QuadTree searches: 95639 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Location hook finished in 113704 ms > > > > Ticker > > > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@
[mkgmap-dev] Commit r4472: Make sure that getKeystring() doesn't return something like null=way for a rule which cannot be indexed, e.g.
Version mkgmap-r4472 was committed by gerd on Thu, 19 Mar 2020
Make sure that getKeystring() doesn't return something like null=way for a rule
which cannot be indexed, e.g.
type()=way [0x02]
or
type()=way & highway!=* {add blabla}
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4472
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] problem with reading style file
Hi Mike,
"Previous versions are happy with this."
Yes, somehow, because they ignored the error and also the rule.
What's the expected effect of this rule?
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Mittwoch, 18. März 2020 21:54
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] problem with reading style file
Hi Gerd,
it looks like the merge of the is-in branch has introduced a bug in the
style file reader. I now get the following error:
Error in style: Error: (inc/address:19): Cannot start rule with tag!=*
Could not open style style
The offending line is:
type()=way & highway!=* {delete mkgmap:country; delete mkgmap:region; delete
mkgmap:city; delete mkgmap:is_in; set mkgmap:add-to-index='no'}
Previous versions are happy with this.
Regards,
Mike
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Commit r4471: remove dead code
Version mkgmap-r4471 was committed by gerd on Thu, 19 Mar 2020 remove dead code http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4471 ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] problem with reading style file
Hi Gerd,
it looks like the merge of the is-in branch has introduced a bug in the
style file reader. I now get the following error:
Error in style: Error: (inc/address:19): Cannot start rule with tag!=*
Could not open style style
The offending line is:
type()=way & highway!=* {delete mkgmap:country; delete mkgmap:region; delete
mkgmap:city; delete mkgmap:is_in; set mkgmap:add-to-index='no'}
Previous versions are happy with this.
Regards,
Mike
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Performance with --bounds option
Hi Ticker, I forgot to remove some experimental code for is-in branch in BoundaryQuadTree. Fixed with r4469. I'll probably also remove the methods pointInsideArea() and pointInsideSingularArea() in BoundaryUtil. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 18. März 2020 18:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Performance with --bounds option Have done: http://files.mkgmap.org.uk/download/462/74220001.osm.pbf Ticker On Wed, 2020-03-18 at 16:26 +, Gerd Petermann wrote: > Hi Ticker, > > will look at it tomorrow. Maybe you can upload the file to > http://files.mkgmap.org.uk/ > > Gerd > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Mittwoch, 18. März 2020 11:56 > An: Development list for mkgmap > Betreff: Re: [mkgmap-dev] Performance with --bounds option > > Hi Gerd > > It's > > 74220001: 2674688,-700416 to 2811904,-233472 > # : 57.392578,-15.029297 to 60.336914,-5.009766 > > Ticker > > On Wed, 2020-03-18 at 10:46 +, Gerd Petermann wrote: > > Hi Ticker, > > > > please tell me the tile boundaries > > > > Gerd > > > > > > > > Von: mkgmap-dev im Auftrag > > von Ticker Berkin > > Gesendet: Mittwoch, 18. März 2020 11:43 > > An: mkgmap development > > Betreff: [mkgmap-dev] Performance with --bounds option > > > > Hi Gerd > > > > With the current version I have a tile that takes 3.5 hours to > > build. > > With an old version (r4295) it took about 3 minutes. Without - > > -bounds > > it takes 1 minute 15 secs. > > > > Relevant options are: > > --bounds=bounds.zip --location-autofill=is_in,nearest > > > > > > From the mkgmap.log files: > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Checking bounds dir took 66 ms > > ... > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Starting with location hook > > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_265_ > > -75.bnd > > ... about 40 similar messages ... > > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_280_ > > -25.bnd > > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > > ../mapGB/74220001.osm.pbf: no precompiled boundary information > > available for raster tile 275_-40 > > ... 16 similar messages ... > > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > > ../mapGB/74220001.osm.pbf: no precompiled boundary information > > available for raster tile 280_-25 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: QuadTree searches: 97834 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Location hook finished in 12747318 ms > > > > The old version had similar lines, but the stats at the end are: > > > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: QuadTree searches: 95639 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Location hook finished in 113704 ms > > > > Ticker > > > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-
[mkgmap-dev] Commit r4470: genSea.patch by Ticker Berkin
Version mkgmap-r4470 was committed by gerd on Wed, 18 Mar 2020 genSea.patch by Ticker Berkin fixes flooded areas caused by changes in r4392 and other issues with unclosed coastlines http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4470 ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Commit r4469: fix performance issue introduced with merge from is-in branch:
Version mkgmap-r4469 was committed by gerd on Wed, 18 Mar 2020 fix performance issue introduced with merge from is-in branch: Use again Area.contains() instead of BoundaryUtil.pointInsideArea() http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4469 ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Performance with --bounds option
Have done: http://files.mkgmap.org.uk/download/462/74220001.osm.pbf Ticker On Wed, 2020-03-18 at 16:26 +, Gerd Petermann wrote: > Hi Ticker, > > will look at it tomorrow. Maybe you can upload the file to > http://files.mkgmap.org.uk/ > > Gerd > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Mittwoch, 18. März 2020 11:56 > An: Development list for mkgmap > Betreff: Re: [mkgmap-dev] Performance with --bounds option > > Hi Gerd > > It's > > 74220001: 2674688,-700416 to 2811904,-233472 > # : 57.392578,-15.029297 to 60.336914,-5.009766 > > Ticker > > On Wed, 2020-03-18 at 10:46 +, Gerd Petermann wrote: > > Hi Ticker, > > > > please tell me the tile boundaries > > > > Gerd > > > > > > > > Von: mkgmap-dev im Auftrag > > von Ticker Berkin > > Gesendet: Mittwoch, 18. März 2020 11:43 > > An: mkgmap development > > Betreff: [mkgmap-dev] Performance with --bounds option > > > > Hi Gerd > > > > With the current version I have a tile that takes 3.5 hours to > > build. > > With an old version (r4295) it took about 3 minutes. Without - > > -bounds > > it takes 1 minute 15 secs. > > > > Relevant options are: > > --bounds=bounds.zip --location-autofill=is_in,nearest > > > > > > From the mkgmap.log files: > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Checking bounds dir took 66 ms > > ... > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Starting with location hook > > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_265_ > > -75.bnd > > ... about 40 similar messages ... > > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_280_ > > -25.bnd > > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > > ../mapGB/74220001.osm.pbf: no precompiled boundary information > > available for raster tile 275_-40 > > ... 16 similar messages ... > > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > > ../mapGB/74220001.osm.pbf: no precompiled boundary information > > available for raster tile 280_-25 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: QuadTree searches: 97834 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Location hook finished in 12747318 ms > > > > The old version had similar lines, but the stats at the end are: > > > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: QuadTree searches: 95639 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > > ../mapGB/74220001.osm.pbf: Location hook finished in 113704 ms > > > > Ticker > > > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Performance with --bounds option
Hi Ticker, will look at it tomorrow. Maybe you can upload the file to http://files.mkgmap.org.uk/ Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 18. März 2020 11:56 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Performance with --bounds option Hi Gerd It's 74220001: 2674688,-700416 to 2811904,-233472 # : 57.392578,-15.029297 to 60.336914,-5.009766 Ticker On Wed, 2020-03-18 at 10:46 +, Gerd Petermann wrote: > Hi Ticker, > > please tell me the tile boundaries > > Gerd > > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Mittwoch, 18. März 2020 11:43 > An: mkgmap development > Betreff: [mkgmap-dev] Performance with --bounds option > > Hi Gerd > > With the current version I have a tile that takes 3.5 hours to build. > With an old version (r4295) it took about 3 minutes. Without --bounds > it takes 1 minute 15 secs. > > Relevant options are: > --bounds=bounds.zip --location-autofill=is_in,nearest > > > From the mkgmap.log files: > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Checking bounds dir took 66 ms > ... > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Starting with location hook > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_265_ > -75.bnd > ... about 40 similar messages ... > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_280_ > -25.bnd > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > ../mapGB/74220001.osm.pbf: no precompiled boundary information > available for raster tile 275_-40 > ... 16 similar messages ... > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > ../mapGB/74220001.osm.pbf: no precompiled boundary information > available for raster tile 280_-25 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: QuadTree searches: 97834 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Location hook finished in 12747318 ms > > The old version had similar lines, but the stats at the end are: > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: QuadTree searches: 95639 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Location hook finished in 113704 ms > > Ticker > > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] precompiled sea
Hi David, yes, sounds like noise unless you did not change anything else. If you think that a newer version of mkgmap solved the problem please double check with the older mkgmap version so that you can be sure that this is the reason. Gerd Von: mkgmap-dev im Auftrag von David Gesendet: Mittwoch, 18. März 2020 13:21 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] precompiled sea Hello Ticker and Gerd, I may introduce some noise in your search. I had a problem with sea generation for Ireland and I wrote about that few weeks ago. Gerd or Ticker suggested to me to update my precompiled sea files. I did it but it did not solve the problem of flooded areas (even with OSM latest data). Then I tried options with generate-sea instead of precompiled sea files, without more success. I decided to wait for few days to see if an update would solve my problem. And it worked. All versions (I did not test later than 4466) after the merge of is_in filter, and few ones before produce, a correct result for Ireland. David ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] precompiled sea
Hello Ticker and Gerd, I may introduce some noise in your search. I had a problem with sea generation for Ireland and I wrote about that few weeks ago. Gerd or Ticker suggested to me to update my precompiled sea files. I did it but it did not solve the problem of flooded areas (even with OSM latest data). Then I tried options with generate-sea instead of precompiled sea files, without more success. I decided to wait for few days to see if an update would solve my problem. And it worked. All versions (I did not test later than 4466) after the merge of is_in filter, and few ones before produce, a correct result for Ireland. David ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Performance with --bounds option
Hi Gerd It's 74220001: 2674688,-700416 to 2811904,-233472 # : 57.392578,-15.029297 to 60.336914,-5.009766 Ticker On Wed, 2020-03-18 at 10:46 +, Gerd Petermann wrote: > Hi Ticker, > > please tell me the tile boundaries > > Gerd > > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Mittwoch, 18. März 2020 11:43 > An: mkgmap development > Betreff: [mkgmap-dev] Performance with --bounds option > > Hi Gerd > > With the current version I have a tile that takes 3.5 hours to build. > With an old version (r4295) it took about 3 minutes. Without --bounds > it takes 1 minute 15 secs. > > Relevant options are: > --bounds=bounds.zip --location-autofill=is_in,nearest > > > From the mkgmap.log files: > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Checking bounds dir took 66 ms > ... > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Starting with location hook > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_265_ > -75.bnd > ... about 40 similar messages ... > INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil > ../mapGB/74220001.osm.pbf: loading boundary file: bounds_280_ > -25.bnd > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > ../mapGB/74220001.osm.pbf: no precompiled boundary information > available for raster tile 275_-40 > ... 16 similar messages ... > WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid > ../mapGB/74220001.osm.pbf: no precompiled boundary information > available for raster tile 280_-25 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: QuadTree searches: 97834 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Location hook finished in 12747318 ms > > The old version had similar lines, but the stats at the end are: > > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: === LocationHook Stats = > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: QuadTree searches: 95639 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull : 20 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 > INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook > ../mapGB/74220001.osm.pbf: Location hook finished in 113704 ms > > Ticker > > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Performance with --bounds option
Hi Ticker, please tell me the tile boundaries Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 18. März 2020 11:43 An: mkgmap development Betreff: [mkgmap-dev] Performance with --bounds option Hi Gerd With the current version I have a tile that takes 3.5 hours to build. With an old version (r4295) it took about 3 minutes. Without --bounds it takes 1 minute 15 secs. Relevant options are: --bounds=bounds.zip --location-autofill=is_in,nearest >From the mkgmap.log files: INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Checking bounds dir took 66 ms ... INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Starting with location hook INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil ../mapGB/74220001.osm.pbf: loading boundary file: bounds_265_ -75.bnd ... about 40 similar messages ... INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil ../mapGB/74220001.osm.pbf: loading boundary file: bounds_280_ -25.bnd WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid ../mapGB/74220001.osm.pbf: no precompiled boundary information available for raster tile 275_-40 ... 16 similar messages ... WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid ../mapGB/74220001.osm.pbf: no precompiled boundary information available for raster tile 280_-25 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: === LocationHook Stats = INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: QuadTree searches: 97834 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull : 20 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Location hook finished in 12747318 ms The old version had similar lines, but the stats at the end are: INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: === LocationHook Stats = INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: QuadTree searches: 95639 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull : 20 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Location hook finished in 113704 ms Ticker ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Processing of mp source
Hi Mike, > I think that if a copyright file is provided, this should override any > existing copyright messages from any input files It looks like current processing of copyright-file is to override any previously defined copyright. This is acceptable, only needs a clear explanation in documentation. -- Best regards, Andrzej ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Performance with --bounds option
Hi Gerd With the current version I have a tile that takes 3.5 hours to build. With an old version (r4295) it took about 3 minutes. Without --bounds it takes 1 minute 15 secs. Relevant options are: --bounds=bounds.zip --location-autofill=is_in,nearest >From the mkgmap.log files: INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Checking bounds dir took 66 ms ... INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Starting with location hook INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil ../mapGB/74220001.osm.pbf: loading boundary file: bounds_265_ -75.bnd ... about 40 similar messages ... INFO: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil ../mapGB/74220001.osm.pbf: loading boundary file: bounds_280_ -25.bnd WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid ../mapGB/74220001.osm.pbf: no precompiled boundary information available for raster tile 275_-40 ... 16 similar messages ... WARN: uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryGrid ../mapGB/74220001.osm.pbf: no precompiled boundary information available for raster tile 280_-25 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: === LocationHook Stats = INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: QuadTree searches: 97834 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull : 20 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Location hook finished in 12747318 ms The old version had similar lines, but the stats at the end are: INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: === LocationHook Stats = INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: QuadTree searches: 95639 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull : 20 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: unsuccesfull for ways: 9 INFO: uk.me.parabola.mkgmap.reader.osm.LocationHook ../mapGB/74220001.osm.pbf: Location hook finished in 113704 ms Ticker ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] precompiled sea
Hi Gerd The version in my patch is simpler and works for both createLandPolygons and createSeaPolygons (both contain a subtle "+= 4") Ticker On Wed, 2020-03-18 at 10:26 +, Gerd Petermann wrote: > Hi Ticker, > > I finally understood what was wrong in the addCorners() method, so > this patch shows the minimal change to make it work. > > Gerd ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] precompiled sea
Hi Gerd I was just going through the code and this is what I had so far: The significant changes are in createInnerWays/createLandPolygons r4389 createInnerWays extracts land/anticlockwise/islands from the hitMap. It has some logical mistakes like a 50% chance of putting an erroneous start/end point on an earlier edge from where the real land is cut by the tile bounds; this is like a spike, but possibly going round 3 corners and back! Then, unless the only shoreline is an enclosed sea (Caspian/Black/Dead/...?) or there are sea-sectors, it will generated a sea background and MP.cutout all the land. Otherwise it generates a land background with this as the MP relation inner but probably no outers unless there are sea-sectors. r4392 has similar behaviour and I was just getting to the bit that you've found where addCorners needed fixing. My version simplifies and fixes createLandPolygons and addCorners. It also has other improvements: If the tile doesn't have any real islands, make it land based and have any encroaching sea as sea polygons. If using option sea-sectors: - Put the triangles on the correct side of the coastline rather than the 50% chance it had before. - Don't force the background to land as an "inner" of the triangles "outer" - rather, if tile is land, show sea-triangle on the sea-side, if the background is sea, show a land-triangle on the land-side. There are a few other minor fixes and tidy-ups Ticker On Wed, 2020-03-18 at 10:05 +, Gerd Petermann wrote: > Hi Ticker, > > OK, my results: > The refactoring in r4382 introduced two bugs. > With the partial revert in r4391 both bugs were fixed. > With r4392 one bug was re-introduced. :( > I've attached a small patch for that. > > Now I wonder if your longer patch fixes any other issues? > > Gerd ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] precompiled sea
Hi Ticker, I finally understood what was wrong in the addCorners() method, so this patch shows the minimal change to make it work. Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 11:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Ticker, OK, my results: The refactoring in r4382 introduced two bugs. With the partial revert in r4391 both bugs were fixed. With r4392 one bug was re-introduced. :( I've attached a small patch for that. Now I wonder if your longer patch fixes any other issues? Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 08:14 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Ticker, forget it. Found an older extract of Ireland which shows the error with r4382, but not with r4380 or with your patch. I just want to understand how the changes in 4381 changed this before committing your patch... Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 07:41 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Ticker, thanks for the patch. Do you have an example file that shows how 4381 introduced new problems which are now solved? Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 17. März 2020 17:40 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Gerd, Mike Considering --generate-sea=... and SeaGenerator.java. Following changes around r4381, many more tiles have land/sea flipped, and, looking at the log files, MultiPolygonRelation gives errors for the sea relation, complaining about inner polygons being in inner polygons etc. The code relating to extracting polygons from the coastline doesn't seem to understand what it is doing regarding the change in behaviour between land polygons on a sea tile and vice-versa and I have little confidence in its ability to handle complex coastlines. So, I've re-written the guts of it to fix these shortcomings. I haven't touched the "floodblocker" code, which I think should be decommissioned. Patch attached. There are a few other aspects that to this code that I think could be improved. Ticker On Thu, 2020-01-30 at 11:35 +, Ticker Berkin wrote: > Hi > > Having just generated full britain-and-ireland with current trunk > (r4432), I'm also now seeing some tiles (5 out of 101) with sea/land > flipped when using option: > --generate-sea="multipolygon,extend-sea-sectors,close-gaps=350" > but when I process some of the same tiles with r4295 they are OK. > > It's not a problem for me at the moment, I've simply replaced above > with > --precomp-sea=sea-latest.zip > > However I prefer to use --generate-sea for various reasons: > - saves downloading sea.zip every now and again. > - island cut-outs match land features exactly, whereas there were > slight differences with sea.zip. > - not had these problems before. > - no noticeable performance problems. > > Sometime I'll try and pin down when the change happened. I hadn't > noticed before because the tiles in the small map I use day-to-day > don't show the problem. > > Ticker > > On Wed, 2020-01-29 at 22:50 +, Mike Baggaley wrote: > > Hi Gerd, up to now I have built my UK map with the sea and land in > > a > > single > > pass using --generate-sea. However, some tiles are getting the sea > > and land > > inverted, typically where a very small amount of sea is in the > > tile. > > I was > > trying to see whether if I precompiled the sea, the problem would > > go > > away - > > I was assuming the tiles of precompiled sea would be bigger because > > they > > contained no other data, so the probability of inversion would be > > reduced. I > > was therefore first trying to generate precompiled sea, then use it > > to build > > my UK map. It may be that my assumption is incorrect and that it > > won't make > > any difference anyway. > > > > Regards, > > Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev fix-r4392-v2.patch Description: fix-r4392-v2.patch ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] precompiled sea
Hi Ticker, OK, my results: The refactoring in r4382 introduced two bugs. With the partial revert in r4391 both bugs were fixed. With r4392 one bug was re-introduced. :( I've attached a small patch for that. Now I wonder if your longer patch fixes any other issues? Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 08:14 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Ticker, forget it. Found an older extract of Ireland which shows the error with r4382, but not with r4380 or with your patch. I just want to understand how the changes in 4381 changed this before committing your patch... Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 07:41 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Ticker, thanks for the patch. Do you have an example file that shows how 4381 introduced new problems which are now solved? Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 17. März 2020 17:40 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Gerd, Mike Considering --generate-sea=... and SeaGenerator.java. Following changes around r4381, many more tiles have land/sea flipped, and, looking at the log files, MultiPolygonRelation gives errors for the sea relation, complaining about inner polygons being in inner polygons etc. The code relating to extracting polygons from the coastline doesn't seem to understand what it is doing regarding the change in behaviour between land polygons on a sea tile and vice-versa and I have little confidence in its ability to handle complex coastlines. So, I've re-written the guts of it to fix these shortcomings. I haven't touched the "floodblocker" code, which I think should be decommissioned. Patch attached. There are a few other aspects that to this code that I think could be improved. Ticker On Thu, 2020-01-30 at 11:35 +, Ticker Berkin wrote: > Hi > > Having just generated full britain-and-ireland with current trunk > (r4432), I'm also now seeing some tiles (5 out of 101) with sea/land > flipped when using option: > --generate-sea="multipolygon,extend-sea-sectors,close-gaps=350" > but when I process some of the same tiles with r4295 they are OK. > > It's not a problem for me at the moment, I've simply replaced above > with > --precomp-sea=sea-latest.zip > > However I prefer to use --generate-sea for various reasons: > - saves downloading sea.zip every now and again. > - island cut-outs match land features exactly, whereas there were > slight differences with sea.zip. > - not had these problems before. > - no noticeable performance problems. > > Sometime I'll try and pin down when the change happened. I hadn't > noticed before because the tiles in the small map I use day-to-day > don't show the problem. > > Ticker > > On Wed, 2020-01-29 at 22:50 +, Mike Baggaley wrote: > > Hi Gerd, up to now I have built my UK map with the sea and land in > > a > > single > > pass using --generate-sea. However, some tiles are getting the sea > > and land > > inverted, typically where a very small amount of sea is in the > > tile. > > I was > > trying to see whether if I precompiled the sea, the problem would > > go > > away - > > I was assuming the tiles of precompiled sea would be bigger because > > they > > contained no other data, so the probability of inversion would be > > reduced. I > > was therefore first trying to generate precompiled sea, then use it > > to build > > my UK map. It may be that my assumption is incorrect and that it > > won't make > > any difference anyway. > > > > Regards, > > Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev fix-r4392.patch Description: fix-r4392.patch ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] precompiled sea
Hi Ticker, forget it. Found an older extract of Ireland which shows the error with r4382, but not with r4380 or with your patch. I just want to understand how the changes in 4381 changed this before committing your patch... Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 07:41 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Ticker, thanks for the patch. Do you have an example file that shows how 4381 introduced new problems which are now solved? Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 17. März 2020 17:40 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] precompiled sea Hi Gerd, Mike Considering --generate-sea=... and SeaGenerator.java. Following changes around r4381, many more tiles have land/sea flipped, and, looking at the log files, MultiPolygonRelation gives errors for the sea relation, complaining about inner polygons being in inner polygons etc. The code relating to extracting polygons from the coastline doesn't seem to understand what it is doing regarding the change in behaviour between land polygons on a sea tile and vice-versa and I have little confidence in its ability to handle complex coastlines. So, I've re-written the guts of it to fix these shortcomings. I haven't touched the "floodblocker" code, which I think should be decommissioned. Patch attached. There are a few other aspects that to this code that I think could be improved. Ticker On Thu, 2020-01-30 at 11:35 +, Ticker Berkin wrote: > Hi > > Having just generated full britain-and-ireland with current trunk > (r4432), I'm also now seeing some tiles (5 out of 101) with sea/land > flipped when using option: > --generate-sea="multipolygon,extend-sea-sectors,close-gaps=350" > but when I process some of the same tiles with r4295 they are OK. > > It's not a problem for me at the moment, I've simply replaced above > with > --precomp-sea=sea-latest.zip > > However I prefer to use --generate-sea for various reasons: > - saves downloading sea.zip every now and again. > - island cut-outs match land features exactly, whereas there were > slight differences with sea.zip. > - not had these problems before. > - no noticeable performance problems. > > Sometime I'll try and pin down when the change happened. I hadn't > noticed before because the tiles in the small map I use day-to-day > don't show the problem. > > Ticker > > On Wed, 2020-01-29 at 22:50 +, Mike Baggaley wrote: > > Hi Gerd, up to now I have built my UK map with the sea and land in > > a > > single > > pass using --generate-sea. However, some tiles are getting the sea > > and land > > inverted, typically where a very small amount of sea is in the > > tile. > > I was > > trying to see whether if I precompiled the sea, the problem would > > go > > away - > > I was assuming the tiles of precompiled sea would be bigger because > > they > > contained no other data, so the probability of inversion would be > > reduced. I > > was therefore first trying to generate precompiled sea, then use it > > to build > > my UK map. It may be that my assumption is incorrect and that it > > won't make > > any difference anyway. > > > > Regards, > > Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
