Re: [mkgmap-dev] highway=unclassified & area=yes

2020-09-12 Thread Dave Swarthout
Those mappers might have used this new proposal for highway=junction
incorrectly.
https://wiki.openstreetmap.org/wiki/Proposed_features/highway%3Djunction

I'm not sure about their motives or reasoning but clearly a changeset
comment or an email to those people is in order.

Dave


On Sun, Sep 13, 2020 at 12:02 AM Gerd Petermann <
gpetermann_muenc...@hotmail.com> wrote:

> Yes, look like mapping errors (mapping for the renderer?). Maybe
> area:highway=* was meant. I would not change the style for them.
>
> Gerd
>
> 
> Von: mkgmap-dev  im Auftrag von
> ael 
> Gesendet: Samstag, 12. September 2020 18:52
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] highway=unclassified & area=yes
>
> On Sat, Sep 12, 2020 at 05:27:03PM +0100, Ticker Berkin wrote:
> > Hi all
> >
> > Diagnosing what seemed like superfluous navigation pop-up, eg "Turn
> > left on A1", while driving on the A1, I discover quite a few junctions
> > are surrounded by a closed way with tags [highway=unclassified,
> > area=yes]
> >
> > https://www.openstreetmap.org/way/239371846
> > https://www.openstreetmap.org/way/239371836
> > https://www.openstreetmap.org/way/239754207
> >
> > I haven't found any references to this being something that is
> > acceptable or is wrong, so I don't know if these should be deleted from
> > OSM and/or ignored by the mkgmap style.
>
> They look clearly wrong to me, but then I don't have any local
> knowledge.
>
> ael
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>


-- 
Dave Swarthout
Homer, Alaska
Chiang Mai, Thailand
Travel Blog at http://dswarthout.blogspot.com
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap skips multipolygon with no nodes in map area

2020-09-12 Thread Ranko Jaksic

Hi Gerd,

Great! Thanks for the fast fix!
No missing multipolygon with release 4574.

I was afraid you would say that this is such a rare situation that the check was 
"intentionally left out because of performance issues"  :)

Ranko


On 12.09.2020. 8:09, Gerd Petermann wrote:

Hi Ranko,

thanks for reporting. Strange that such an obvious error did not show up before!
Problem is in the method MultiPolygonRelation.removeWaysOutsideBbox(). I am 
working on a fix.

Gerd


Von: mkgmap-dev  im Auftrag von Ranko Jaksic 

Gesendet: Donnerstag, 10. September 2020 15:19
An: mkgmap-dev
Betreff: [mkgmap-dev] mkgmap skips multipolygon with no nodes in map area

Hi Gerd,

Recently I discovered a missing forest "triangle" on my map (see attached 
screenshots).
I am using the same mkgmap/splitter (4551/597) versions as before, but 
obviously OSM data changed so splitter generated a slightly different areas.list

The forest in question consists of two very large multipolygons:

https://www.openstreetmap.org/relation/1431438
https://www.openstreetmap.org/relation/4433469

Both relations cover the map-tile area, but mkgmap creates no polygon for the 
second one.
It supose it doesn't get detected in mkgmap because it has no nodes in the area
(splitter has no such problem: it detects the multipolygon and includes it in 
the output file).

I am including my test data:
- forest.osm.pbf  - contains only these two relations (or use 
croatia-latest.osm.pbf extract from Geofabrik :)
- areas-test.list - area in question
- forest-typ.txt  - simple typ file to display forest (not really needed)

test code:

java -jar splitter.jar --split-file=areas-test.list forest.osm.pbf
java -jar mkgmap.jar -c template.args forest-typ.txt --gmapi 
--remove-ovm-work-files

Splitter includes both relations in the 88010024.osm.pbf, but mkgmap includes 
only the first one in the generated 88010024.img file.

regards,
Ranko

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev



___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] highway=unclassified & area=yes

2020-09-12 Thread Gerd Petermann
Yes, look like mapping errors (mapping for the renderer?). Maybe area:highway=* 
was meant. I would not change the style for them.

Gerd


Von: mkgmap-dev  im Auftrag von ael 

Gesendet: Samstag, 12. September 2020 18:52
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] highway=unclassified & area=yes

On Sat, Sep 12, 2020 at 05:27:03PM +0100, Ticker Berkin wrote:
> Hi all
>
> Diagnosing what seemed like superfluous navigation pop-up, eg "Turn
> left on A1", while driving on the A1, I discover quite a few junctions
> are surrounded by a closed way with tags [highway=unclassified,
> area=yes]
>
> https://www.openstreetmap.org/way/239371846
> https://www.openstreetmap.org/way/239371836
> https://www.openstreetmap.org/way/239754207
>
> I haven't found any references to this being something that is
> acceptable or is wrong, so I don't know if these should be deleted from
> OSM and/or ignored by the mkgmap style.

They look clearly wrong to me, but then I don't have any local
knowledge.

ael

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] highway=unclassified & area=yes

2020-09-12 Thread ael
On Sat, Sep 12, 2020 at 05:27:03PM +0100, Ticker Berkin wrote:
> Hi all
> 
> Diagnosing what seemed like superfluous navigation pop-up, eg "Turn
> left on A1", while driving on the A1, I discover quite a few junctions
> are surrounded by a closed way with tags [highway=unclassified,
> area=yes]
> 
> https://www.openstreetmap.org/way/239371846
> https://www.openstreetmap.org/way/239371836
> https://www.openstreetmap.org/way/239754207
> 
> I haven't found any references to this being something that is
> acceptable or is wrong, so I don't know if these should be deleted from
> OSM and/or ignored by the mkgmap style.

They look clearly wrong to me, but then I don't have any local
knowledge.

ael

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


[mkgmap-dev] highway=unclassified & area=yes

2020-09-12 Thread Ticker Berkin
Hi all

Diagnosing what seemed like superfluous navigation pop-up, eg "Turn
left on A1", while driving on the A1, I discover quite a few junctions
are surrounded by a closed way with tags [highway=unclassified,
area=yes]

https://www.openstreetmap.org/way/239371846
https://www.openstreetmap.org/way/239371836
https://www.openstreetmap.org/way/239754207

and these "way"s, with the default style (and all other styles I've
ever looked at) will generated a road that probably shares many routing
points with the real roads in the junction.
 
These seem to be used for documentation of changes and are possibly
being create automatically by some OSM editing tool.

I haven't found any references to this being something that is
acceptable or is wrong, so I don't know if these should be deleted from
OSM and/or ignored by the mkgmap style.

Thoughts anyone -

Ticker

___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] precomp sea test environment

2020-09-12 Thread Gerd Petermann
Hi all,

it seems the correctness of the input files provided at [1] is not as good as 
Wanmil and I thought. Wrong data like a single closed way tagged 
natural=coastline near the center of Africa was not removed. I've corrected it 
a few minutes ago, see version 1 of https://www.openstreetmap.org/way/845273583.

Still working on a simple check ...

ciao,
Gerd
[1] https://osmdata.openstreetmap.de/data/land-polygons.html



Von: mkgmap-dev  im Auftrag von Gerd 
Petermann 
Gesendet: Donnerstag, 10. September 2020 20:20
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] precomp sea test environment

Hi all,

OK, I'll try to find a good solution. For hgt files we have the file 
resources/known-hgt.bin  which tells mkgmap which *.hgt files it should be able 
to find. I think the same can be done for those rectangles which will always be 
"land" in the index.txt file. I just have to filter those which are close to 
the coast so that they might change.

Gerd


Von: mkgmap-dev  im Auftrag von Carlos 
Dávila 
Gesendet: Donnerstag, 10. September 2020 18:49
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] precomp sea test environment

I also face wrong sea from time to time. I agree a pre-check would be
much useful. Also your sea-check style+empty tiles, thanks Gerd.

El 10/9/20 a las 11:27, Joris Bo escribió:
> Hi Gerd
>
> I recently (24-8-2020) had the same problem. The bad sea.zip was about 14Mb 
> smaller then usual.
> A pre-check and warning would be great.
>
> Kind Regards
> Joris
>
> -Oorspronkelijk bericht-
> Van: mkgmap-dev  Namens Gerd Petermann
> Verzonden: donderdag 10 september 2020 11:16
> Aan: mkgmap-dev@lists.mkgmap.org.uk
> Onderwerp: [mkgmap-dev] precomp sea test environment
>
> Hi all,
>
> today I stumbled over a bad sea.zip file that was created in 2019-11-08. Most 
> of the two Americas was flooded.
> I wondered if I should add some code to mkgmap to detect this case?  Eg. 
> mkgmap could check some points which are clearly inside continents.
>
> Besides that it is rather simple to produce a test style for the sea which 
> just creates an overview map. I've created some empty tiles which cover full 
> planet and used them to create an overview map containing only sea polygons. 
> This compilation takes ~1 minute. A quick glance at osmmap.img should show 
> the familiar shapes of the continents, if not something is wrong and that 
> probably means that the precomp-sea data is bad.
> I've attached this, maybe it is of some help.
>
> Gerd
>
>
>
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


[mkgmap-dev] Commit r4574: correction: In rare cases a multipolygon was ignored.

2020-09-12 Thread svn commit
Version mkgmap-r4574 was committed by gerd on Sat, 12 Sep 2020

correction: In rare cases a multipolygon was ignored.
This happened when none of the polygon points was inside the tile and an edge 
of the MP crossed the tile bounds.

Thanks to Ranko Jaksic for reporting this very old bug.


http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4574
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev