Re: [mkgmap-dev] OT: Style to help mapping?

2021-02-07 Thread Joao Almeida

Apologies for the confusion,

What  I meant is something like a map legend (key)
An OSM file that generates a line or a polygon and a point and the 
key/tag for that element so that mkgmap can draw it on the output map 
from the Style and TYP.


Something like this attached file a bit like an artificial country, that 
has one of each ( most important tags, not the 8 ones ;-)


Cheers
Joao




On 3/02/2021 6:01 pm, Gerd Petermann wrote:

Hi Joao,

I also don't understand what you want. My first idea was that you want to test the TYP, 
not the style, so maybe try the fake input file "test-map:all-elements" like 
this:
java -jar mgmap.jar test-map:all-elements xyz.typ

One problem: test-map:all-elements doesn't generate extended types (yet)

Gerd




Von: mkgmap-dev  im Auftrag von Joris Bo 

Gesendet: Mittwoch, 3. Februar 2021 07:20
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] OT: Style to help mapping?

Hi Joao,

Could you be more precise in what you have in mind?
What test would you like to run?

What I understand now is that you would like a style which has an entry for 
every highway,waterway, railway... line in osm.
But today there are 80209 unique tags and only the highway tag alone has 
731unique values.
Tomorrow that could be some more or less, not very simple to maintain
https://taginfo.openstreetmap.org/keys


Met vriendelijke groeten,

Joris Bo
jori...@hotmail.com

-Oorspronkelijk bericht-
Van: mkgmap-dev  Namens Joao Almeida
Verzonden: woensdag 3 februari 2021 03:22
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: Re: [mkgmap-dev] OT: Style to help mapping?

On 25/01/2021 9:14 pm, Gerd Petermann wrote:

Hi Joris,

not sure if others also have this problem but for me the mapnik TYP is not 
usable on my Oregon. The difference between the magenta for a route and the red 
colors for major roads is too small, I've problems to distinguish them, esp. 
when the light is not optimal.
I probably need something different. Ill try a modified version of
Minkos OpenFietsMap style with interesting things rendered bright blue
or green)

Gerd



Von: mkgmap-dev  im Auftrag
von Joris Bo 
Gesendet: Donnerstag, 21. Januar 2021 09:09
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] OT: Style to help mapping?

Hi Gerd,

My style is a copy of www.openstreetmap.org

Culvert, track(type), meadow and farmland  are distinguishable.
Because of usage osm colors I agree not specifically good readable on smaller 
gps, but on my Oregon 650, its fine.

You can make more contrast colors in de typ-file  yourself off course
https://github.com/Jorisbo/Mkgmap-Mapnik-Style-Garmin


Met vriendelijke groeten,

Joris Bo
jori...@hotmail.com

-Oorspronkelijk bericht-
Van: mkgmap-dev  Namens Gerd
Petermann
Verzonden: donderdag 21 januari 2021 08:05
Aan: mkgmap-dev@lists.mkgmap.org.uk
Onderwerp: [mkgmap-dev] OT: Style to help mapping?

Hi all,

with new Bing areal images I started mapping the area around my home town. This 
has an effect on my cycling activities as well, I am now much more interested 
in details reg. e.g. highway=track without tracktype or highways crossing small 
waterways  (bridge or tunnel=culvert?) as well as different landuses like 
meadow and farmland.

Does anybody know a public map style  that hilites those details?

Gerd
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev



It would be great to have an OSM file with 1 of each of the Lines, Points and 
Polygons so that we could run a test style with a very small file to verify the 
outputs.

Has anyone come across this or has an idea on how to do it?

Thanks
Joao
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev



___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] Fix Sea Patch

2021-02-07 Thread Gerd Petermann
Hi Mike and Ticker,

do you expect an impact on the PrecompSeaGenerator?

Gerd


Von: mkgmap-dev  im Auftrag von Ticker 
Berkin 
Gesendet: Sonntag, 7. Februar 2021 18:16
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Fix Sea Patch

Hi Mike / Gerd

This patch seems fine to me.

Ticker


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] Fix Sea Patch

2021-02-07 Thread Ticker Berkin
Hi Mike / Gerd

This patch seems fine to me.

Ticker


___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev


Re: [mkgmap-dev] Fix Sea Patch

2021-02-07 Thread Mike Baggaley
Hi Gerd/Ticker,

Please find attached an updated patch that adds the --generate-sea=check option 
and fixes the other typo.

Cheers,
Mike

-Original Message-
From: Mike Baggaley [mailto:m...@tvage.co.uk] 
Sent: 31 January 2021 17:31
To: 'Development list for mkgmap' 
Subject: RE: [mkgmap-dev] Fix Sea Patch

Hi Ticker,

The third case (water areas) will be because they are ordered in the wrong 
direction, so they are being picked up as land rather than water - hence the 
error message of land within land. There is no sea showing on the standard OSM 
renderer for way 255902449. This one is presumably seawater that gets refilled 
at extra high tide. My own generated map does show seawater at this point. I 
haven't checked the others.

I'll look at adding an option for checking the sea data (--generate-sea=check) 
and fix the typo you mentioned.

Cheers,
Mike

-Original Message-
From: Ticker Berkin [mailto:rwb-mkg...@jagit.co.uk] 
Sent: 30 January 2021 17:05
To: Development list for mkgmap 
Subject: Re: [mkgmap-dev] Fix Sea Patch

Hi Mike & Gerd

I've just tried running with this on britain-and-ireland.osm.pbf using:
 --generate-sea=multipolygon,extend-sea-sectors,close-gaps=750

I got a few messages from it that I don't get normally - attached.

Looking at some of these, I found:
1/ islands, tagged with coastline, within lakes.
2/ strange inland coastline triangles (didn't check which way round the
coastline went) Source "OS_Opendata_Vectormap_District"
3/ water areas,
close to the sea - maybe salt-water lagoons, tagged with coastline -
I'm not sure why these are flagged if inland seas are allowed.

Some of these could be fixed in OSM.

The run-time has increases from about 35 mins to 44 mins (would need to
run again in a clean environment to be sure of this). I suggest having
an option to enable the extra checking.

I don't have any problem with more detailed logging.

Good to fix the spelling mistake (but should fix loadLandAndSee as
well)

Ticker

On Fri, 2021-01-29 at 11:18 +, Mike Baggaley wrote:
> Hi Gerd, attached is a slightly updated patch, with test data and the
> results from r4600 and the patch. The existing code does not identify
> all
> the problems in the test data and does not provide sufficiently
> detailed
> information on those it does find to enable investigation/correction.
> 
> The test data contains 4 test scenarios:
> land within sea within land, no errors - the existing code is ok here
> sea within land within sea, the outer sea should produce an error -
> the
> existing code is ok here
> land within land within land, the two inner lands should produce an
> error -
> these are not found by the existing code
> sea within sea within sea, all three seas should produce an error -
> the
> existing code finds the errors but does not identify the surrounding
> way for
> the inner two
> 
> Cheers,
> Mike
> 
> -Original Message-
> From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] 
> Sent: 18 January 2021 11:54
> To: Development list for mkgmap 
> Subject: Re: [mkgmap-dev] Fix Sea Patch
> 
> Hi Mike,
> 
> it would be great  to have some unit tests or at least a sample file
> containing the problem cases which are treated by your patch.
> 
> Gerd
> 
> 
> Von: mkgmap-dev  im Auftrag
> von Mike
> Baggaley 
> Gesendet: Montag, 18. Januar 2021 10:06
> An: 'Development list for mkgmap'
> Betreff: Re: [mkgmap-dev] Fix Sea Patch
> 
> Hi Gerd,
> 
> I had too little logging information in the version I sent
> previously. The
> attached remedies that.
> 
> Cheers,
> Mike
> 
> -Original Message-
> From: Mike Baggaley [mailto:m...@tvage.co.uk]
> Sent: 18 January 2021 00:28
> To: 'Development list for mkgmap' 
> Subject: RE: [mkgmap-dev] Fix Sea Patch
> 
> Hi Gerd,
> 
> I'm not sure that mkgmap should be prescriptive about where the input
> data
> comes from. However, I have produced an updated patch that reports on
> errors
> in the input data without providing any functionality to fix the
> problems.
> Please see the attached patch that is able to identify most problems
> in sea
> data.
> 
> Cheers,
> Mike
> 
> -Original Message-
> From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
> Sent: 05 January 2021 08:40
> To: Development list for mkgmap 
> Subject: Re: [mkgmap-dev] Fix Sea Patch
> 
> Hi Mike & Ticker,
> 
> I would not want to add code to mkgmap to fix problems which only
> occur in
> data that is produced by a 3rd party software. My understanding is
> that the
> "fixing" should happen in that 3rd party software, not in mkgmap.
> 
> Gerd
> 
> 
> Von: mkgmap-dev  im Auftrag
> von Mike
> Baggaley 
> Gesendet: Montag, 4. Januar 2021 20:40
> An: 'Development list for mkgmap'
> Betreff: Re: [mkgmap-dev] Fix Sea Patch
> 
> Hi Ticker,
> 
> I use coastline data that is generated from just line data and the
> algorithm
> used is not able to properly determine whet