[mkgmap-dev] Commit r4603: Improve documentation (docsections2.patch by Mike Baggaley)
Version mkgmap-r4603 was committed by gerd on Thu, 25 Feb 2021 Improve documentation (docsections2.patch by Mike Baggaley) - Add new sections "Diagnostic options" and "POI options" http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap=4603 ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Overview Too Big
Hi Gerd, I'll have a look at that. The patch catches the low level error and re-throws in at a higher level in the case of the overview map. It will need to do the same for the main map. I notice that when the map is too big, processing does not stop, even though I have not got --keep-going set. Looking at the code, it seems that the keep going check is in the Throwable catcher, rather than the MapFailedException catcher. Is this intended or a mistake? It seems to me that you'd be unlikely to want to continue from some random error, but might want to if the problem was known to be related to just one map. Cheers, Mike -Original Message- From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] Sent: 24 February 2021 09:30 To: Development list for mkgmap Subject: Re: [mkgmap-dev] Overview Too Big Hi Mike, I agree that the message should be improved. In fact I am always unsure what kind of limit this is. I've just created a working single tile map of Berlin including NOD which has a filesize of > 21MB. Your patch reports a number which probably counts bytes (I miss that info), but I think it is not about tile/map size. I assume it is about max. sub file size. So, maybe show that sub file name also? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Mittwoch, 24. Februar 2021 00:16 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Overview Too Big Hi Gerd, The error message that mkgmap outputs when the overview map is too big is not helpful. Please find attached a patch that improves this. Cheers, Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] minor documentation improvement
Oops, attached the wrong patch. Here's the correct one... -Original Message- From: Mike Baggaley [mailto:m...@tvage.co.uk] Sent: 24 February 2021 13:43 To: 'Gerd Petermann' ; 'Development list for mkgmap' Subject: RE: [mkgmap-dev] minor documentation improvement Hi Gerd, >I think "Error checking options" is too strong. My understanding is that the options enable additional plausibility checks which may help to explain >unexpected results in routing. So, maybe "Diagnostic options" is better? Sounds reasonable - please find an updated patch. >reg. "POI options": >I think the option name --link-pois-to-ways is very misleading. I think it is much more about routing then about "points of interest" like shops or >restaurants. Good point, I've moved it back to the miscellaneous options. Do you think the option should be deprecated with a better named option replacing it? Cheers, Mike docsections2.patch Description: Binary data ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] minor documentation improvement
Hi Gerd, >I think "Error checking options" is too strong. My understanding is that the options enable additional plausibility checks which may help to explain >unexpected results in routing. So, maybe "Diagnostic options" is better? Sounds reasonable - please find an updated patch. >reg. "POI options": >I think the option name --link-pois-to-ways is very misleading. I think it is much more about routing then about "points of interest" like shops or >restaurants. Good point, I've moved it back to the miscellaneous options. Do you think the option should be deprecated with a better named option replacing it? Cheers, Mike docsections2.patch Description: Binary data ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] minor documentation improvement
Hi Mike, I think "Error checking options" is too strong. My understanding is that the options enable additional plausibility checks which may help to explain unexpected results in routing. So, maybe "Diagnostic options" is better? reg. "POI options": I think the option name --link-pois-to-ways is very misleading. I think it is much more about routing then about "points of interest" like shops or restaurants. Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Mittwoch, 24. Februar 2021 08:55 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] minor documentation improvement Hi Gerd, Please find attached a patch to move some of the miscellaneous options into new sections Error checking options and POI options. There is no change to any of the actual wording. Cheers, Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Overview Too Big
Hi Mike, I agree that the message should be improved. In fact I am always unsure what kind of limit this is. I've just created a working single tile map of Berlin including NOD which has a filesize of > 21MB. Your patch reports a number which probably counts bytes (I miss that info), but I think it is not about tile/map size. I assume it is about max. sub file size. So, maybe show that sub file name also? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Mittwoch, 24. Februar 2021 00:16 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Overview Too Big Hi Gerd, The error message that mkgmap outputs when the overview map is too big is not helpful. Please find attached a patch that improves this. Cheers, Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
