Re: [mkgmap-dev] special case where splitting fails without a log message
Hi Ticker, just to make sure: The triangle was connected to the outside. My algo to find holes also failed with that. I also tried a completely different approach using java path with WindingRule.WIND_EVEN_ODD (this is also used in JOSM). Works quite well but is much slower.. I'm back to the idea suggested in TODO: Keep the MP as is and do the splitting once for each level. I've implemented part of this but it only makes sense when the splitting is 100% reliable, else it is possible that huge areas are wrong. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Montag, 31. Mai 2021 18:12 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] special case where splitting fails without a log message Hi Gerd shapeSplitter will have problems (ie get it wrong some of the time) where there are in/out lines to a hole that share the same cut point as a line that is the boundary between a shape and hole; could be many holes (or shapes) and many lines. The simple sort/dedupe I was doing isn't adequate. I'll come up with something better tomorrow. Ticker ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] special case where splitting fails without a log message
Hi Gerd shapeSplitter will have problems (ie get it wrong some of the time) where there are in/out lines to a hole that share the same cut point as a line that is the boundary between a shape and hole; could be many holes (or shapes) and many lines. The simple sort/dedupe I was doing isn't adequate. I'll come up with something better tomorrow. Ticker ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [mkgmap-svn] Commit r4749: remove/disable code to merge shapes to the max for now:
Hi Ticker, sorry, I didn't keep that specific case. If you cannot reproduce I'll try to find it again. Both the triangle and the rest was visited in clockwise order and the start/end was somewhere else on the rest. I think the cut did not go through the triangle but I'm not sure. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Montag, 31. Mai 2021 11:18 An: mkgmap-dev@lists.mkgmap.org.uk; mkgmap-...@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] [mkgmap-svn] Commit r4749: remove/disable code to merge shapes to the max for now: Hi Gerd Do you have an example of this triangle / concave shape? Are you sure there isn't a rotation through the connection point, resulting in something like a figure-of-8. Ticker On Mon, 2021-05-31 at 07:41 +0100, svn commit wrote: > Version mkgmap-r4749 was committed by gerd on Mon, 31 May 2021 > BRANCH: low-res-opt > remove/disable code to merge shapes to the max for now: > - hole detection was too simple, sometimes removed outer parts of > shapes > - ShapeSplitter doesn't handle some degenarated shapes well where > parts are connected in a single point, like a triangle connected to a > concave shape. > > Will try again with a different approach once ShapeSplitter is able > to handle these cases. > > http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4749 > ___ > mkgmap-svn mailing list > To unsubscribe send an mail to mkgmap-svn-le...@lists.mkgmap.org.uk > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-svn ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [mkgmap-svn] Commit r4749: remove/disable code to merge shapes to the max for now:
Hi Gerd Do you have an example of this triangle / concave shape? Are you sure there isn't a rotation through the connection point, resulting in something like a figure-of-8. Ticker On Mon, 2021-05-31 at 07:41 +0100, svn commit wrote: > Version mkgmap-r4749 was committed by gerd on Mon, 31 May 2021 > BRANCH: low-res-opt > remove/disable code to merge shapes to the max for now: > - hole detection was too simple, sometimes removed outer parts of > shapes > - ShapeSplitter doesn't handle some degenarated shapes well where > parts are connected in a single point, like a triangle connected to a > concave shape. > > Will try again with a different approach once ShapeSplitter is able > to handle these cases. > > http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4749 > ___ > mkgmap-svn mailing list > To unsubscribe send an mail to mkgmap-svn-le...@lists.mkgmap.org.uk > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-svn ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev