Re: [mkgmap-dev] [PATCH v1] Merge similar lines and ways
Hi Thilo, I will modify the code that the merging is applied even earlier. Shouldn't be too hard to do. Did you do that? I would be keen to try a version because I notice on my first few trips with the Nuvi that sometimes it says keep right/left when it should say turn right/left. I think that is because the way looks like this: AAABBB C C C C When it should look like this: AA C C C C i.e. A and B are really the same road as far as routing is concerned. It would be good to have an option to merge those ways. Cheers, Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v1] Merge similar lines and ways
Mark Burton escribió: Hi Thilo, I will modify the code that the merging is applied even earlier. Shouldn't be too hard to do. Did you do that? I would be keen to try a version because I notice on my first few trips with the Nuvi that sometimes it says keep right/left when it should say turn right/left. I think that is because the way looks like this: AAABBB C C C C When it should look like this: AA C C C C i.e. A and B are really the same road as far as routing is concerned. It would be good to have an option to merge those ways. I think in many cases it depends on the angle between the from road and the to one. Changing the to way type to XXX_link gives a turn instruction instead of keep, but can only be done in some cases. Regards Carlos Cheers, Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v1] Merge similar lines and ways
Hi Thilo, The attached will merge lines that are similar* after styling. It is activated by the switch --merge-lines. As there are less way fragments, the Douglas-Peucker filter will work better and the routing should improve somewhat, because the ways will be longer and the routing algorithm won't give up too soon. The size of the resulting map is reduced a little bit as well. The patch is based on code published by Johann Gail on this mailing list. Will this cause a problem with ways that have been split on purpose because they are longer than the maximum allowed arc length? Cheers, Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v1] Merge similar lines and ways
Thilo Hannemann schrieb: Please test and complain ;). Note that the argument --merge-lines is needed for the merging to take place. Are there patches in the latest? Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v1] Merge similar lines and ways
Please test and complain ;). Note that the argument --merge-lines is needed for the merging to take place. Are there patches in the latest? What I meant: Are all these patches which are announced on the list as [PATCH vx] included in the mkgmap-latest? If not - where can I download the patched versions? Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v1] Merge similar lines and ways
Hi Mark, Am 15.08.2009 um 13:45 schrieb Mark Burton: However, looking at the code it seems to me that the merging happens after StyledConverter.addRoad() is called and that is where the way lengths are limited. So you either have to do the merging earlier, or you need to add a constraint to limit the length of the merged way. I see what you mean. Damn. I assumed that the length limiting would only occur in the filters later on. Thank you for pointing this out. I will modify the code that the merging is applied even earlier. Shouldn't be too hard to do. @Chris: If not - where can I download the patched versions? You can download a version of mkgmap with all the patches that I do apply from http://wiki.openstreetmap.org/wiki/User:Radfahrer/Radkarte (it's in German though, it's the second link in the section Entwicklung: Ausserdem sind die Stil-Dateien, die TYP-Datei und das gepatchte mkgmap auch -hier- verfügbar. The current version has the patch in it, but as discussed above this patch is buggy. Also beware that this is no official version of mkgmap, so please don't ask for support for it on this mailing list. The mkgmap I use is heavily patched and by asking about problems with it on the mailing list you will only tie up resources for bugs that the official version of mkgmap doesn't have (and with that therefore nobody can help you). The better approach is to wait until the patch makes it to trunk, which it will or will not, depending on whether the maintainers deem it beneficial or not. Regards Thilo ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
