Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
On 11/23/2010 05:20 AM, maning sambale wrote: FYI, I already moved the tags to the multipolygon relation but the 2 poi icons still exist: http://www.openstreetmap.org/browse/relation/452620 I would expect them to, seeing as this is an unwanted outcome of combining the multipolygon and add-pois-to-areas code. WanMil posted a couple of days ago saying that it was going to be harder than he initially thought to fix, as the --add-pois-to-areas works on Garmin objects, rather than OSM objects. -- Charlie ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
I am sorry. The promised patch is more complicated than I thought. The POI generation source code has no access to original tags because it is placed after the transformation from an OSM object to a garmin object. It will take some time to change this. I won't do this before I finished the revision of the sea generation code. WanMil The mp is tagged wrong. http://wiki.openstreetmap.org/wiki/Multipolygon#Tagging points out that the tags are taken from the relation if it has at least one tag beside type=multipolygon. mkgmap follows this rule strictly since r1711. The relation is tagged with name=Manila City Hall so the resulting polygons of the multipolygon are tagged only with name=Manila City Hall. Please follow the single and easy rule: Put all tags of the multipolygon to the relation and not to the outer ways. The bug that multiple POIs are created multipolygons could be easily fixed. I wasn't aware of this problem. I will post a patch within the next days. Have fun! WanMil This way is tagged as a amenity=townhall and a multipolygon relation: http://www.openstreetmap.org/browse/way/24159829 http://www.openstreetmap.org/browse/relation/452620 In my style: polygons: building=* | man_made=* | amenity=* | tourism=* [0x13 resolution 24] and in the points: amenity=townhall [0x3003 resolution 21] building=* [0x6402 resolution 24] I have the add-pois-areas switch enabled This resulted to two POI icons (the little PH flag) in garmin http://farm2.static.flickr.com/1290/5184379090_bbeeeaffc8_b.jpg ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
The mp is tagged wrong. http://wiki.openstreetmap.org/wiki/Multipolygon#Tagging points out that the tags are taken from the relation if it has at least one tag beside type=multipolygon. mkgmap follows this rule strictly since r1711. The relation is tagged with name=Manila City Hall so the resulting polygons of the multipolygon are tagged only with name=Manila City Hall. Please follow the single and easy rule: Put all tags of the multipolygon to the relation and not to the outer ways. The bug that multiple POIs are created multipolygons could be easily fixed. I wasn't aware of this problem. I will post a patch within the next days. Have fun! WanMil This way is tagged as a amenity=townhall and a multipolygon relation: http://www.openstreetmap.org/browse/way/24159829 http://www.openstreetmap.org/browse/relation/452620 In my style: polygons: building=* | man_made=* | amenity=* | tourism=* [0x13 resolution 24] and in the points: amenity=townhall [0x3003 resolution 21] building=* [0x6402 resolution 24] I have the add-pois-areas switch enabled This resulted to two POI icons (the little PH flag) in garmin http://farm2.static.flickr.com/1290/5184379090_bbeeeaffc8_b.jpg ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] 2 pois for a single polygon/multipolygon
This way is tagged as a amenity=townhall and a multipolygon relation: http://www.openstreetmap.org/browse/way/24159829 http://www.openstreetmap.org/browse/relation/452620 In my style: polygons: building=* | man_made=* | amenity=* | tourism=* [0x13 resolution 24] and in the points: amenity=townhall [0x3003 resolution 21] building=* [0x6402 resolution 24] I have the add-pois-areas switch enabled This resulted to two POI icons (the little PH flag) in garmin http://farm2.static.flickr.com/1290/5184379090_bbeeeaffc8_b.jpg -- cheers, maning -- Freedom is still the most radical idea of all -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ -- ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
Am 17.11.2010 13:34, schrieb Greg Troxel: So I think that the relation inherits tags from the outer way, and thus both the multipolygon and the way get a poi point generated. I don't think this is a mkgmap bug. Another possible reason: The MP Code splits the MP to several normal polygons (without holes), each getting a POI. But this is just a guess. Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
AFAIK, the correct way of tagging is: way 1 - amenity=townhall way 2 - no tag relation type=multipolygon way 1 = outer way 2 = inner I'll check other data to verify. On Wed, Nov 17, 2010 at 8:34 PM, Greg Troxel g...@ir.bbn.com wrote: maning sambale emmanuel.samb...@gmail.com writes: This way is tagged as a amenity=townhall and a multipolygon relation: http://www.openstreetmap.org/browse/way/24159829 http://www.openstreetmap.org/browse/relation/452620 In my style: polygons: building=* | man_made=* | amenity=* | tourism=* [0x13 resolution 24] and in the points: amenity=townhall [0x3003 resolution 21] building=* [0x6402 resolution 24] I have the add-pois-areas switch enabled This resulted to two POI icons (the little PH flag) in garmin http://farm2.static.flickr.com/1290/5184379090_bbeeeaffc8_b.jpg So I think that the relation inherits tags from the outer way, and thus both the multipolygon and the way get a poi point generated. I don't think this is a mkgmap bug. What if you take the amenity/buiding/name tags off the outer way and put them on the relation? I am coming to the tenative conclusion that the map data is wrong. Or can you point to the rules for multipolygons and buildings that say putting the data on an outer way is correct? -- cheers, maning -- Freedom is still the most radical idea of all -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ -- ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
Can anyone confirm this? (I don't read code sorry) On Wed, Nov 17, 2010 at 8:44 PM, Chris66 chris66...@gmx.de wrote: Am 17.11.2010 13:34, schrieb Greg Troxel: So I think that the relation inherits tags from the outer way, and thus both the multipolygon and the way get a poi point generated. I don't think this is a mkgmap bug. Another possible reason: The MP Code splits the MP to several normal polygons (without holes), each getting a POI. But this is just a guess. Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- cheers, maning -- Freedom is still the most radical idea of all -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ -- ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
On Wed, Nov 17, 2010 at 09:37:17PM +0800, maning sambale wrote: Can anyone confirm this? (I don't read code sorry) If moving all tags from the role=outer way to the multipolygon relation fixes the problem, then Greg Troxel is right. If not, then Chris is right. I may have observed similar behaviour to what Chris mentioned, but that was months ago, and the code has been changed since then. Marko On Wed, Nov 17, 2010 at 8:44 PM, Chris66 chris66...@gmx.de wrote: Am 17.11.2010 13:34, schrieb Greg Troxel: So I think that the relation inherits tags from the outer way, and thus both the multipolygon and the way get a poi point generated. I don't think this is a mkgmap bug. Another possible reason: The MP Code splits the MP to several normal polygons (without holes), each getting a POI. But this is just a guess. Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- cheers, maning -- Freedom is still the most radical idea of all -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ -- ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
maning sambale schrieb am 17.11.2010 14:36: AFAIK, the correct way of tagging is: way 1 - amenity=townhall way 2 - no tag relation type=multipolygon way 1 = outer way 2 = inner I'll check other data to verify. This one of the possible solutions. Also ok would be way 1 - no tag way 2 - no tag relation type=multipolygon amenity=townhall way 1 = outer way 2 = inner In the beginning of multipolygon usage also the following scheme was used, but is considered faulty now. way 1 - amenity=townhall way 2 - amenity=townhall relation type=multipolygon way 1 = outer way 2 = inner Such an outdated tagging would result in two icons and should be considered as a tagging fault. If one of the first two solutions results in two icons, than the add-pois-to-areas function of mkgmap does not work correctly in combination with multipolygons. (In my point of view the add-pois-to-areas function should be reworked anyway, to give more control via the style file about which areas should generated which POIs.) Gruss Torsten ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
Another possible reason: The MP Code splits the MP to several normal polygons (without holes), each getting a POI. But this is just a guess. Can anyone confirm this? (I don't read code sorry) Hi, I created a test file with one park and one golf_course. Number of POIs seems to match the number of holes: http://up.picr.de/5665803.jpg So if my theory is correct, a possible solution: MP code marks all generated normal polygons except one with a flag. add-pois-to-areas ignores flagged polygons. Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
Number of POIs seems to match the number of holes: http://up.picr.de/5665803.jpg Result is the same if tagging the relation and not the outer way. Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
Marko Mäkelä marko.mak...@iki.fi writes: On Wed, Nov 17, 2010 at 09:37:17PM +0800, maning sambale wrote: Can anyone confirm this? (I don't read code sorry) If moving all tags from the role=outer way to the multipolygon relation fixes the problem, then Greg Troxel is right. If not, then Chris is right. I may have observed similar behaviour to what Chris mentioned, but that was months ago, and the code has been changed since then. I think we first need to be very sure about the correct tagging rules and then make mkgmap follow them. It seems odd for me if tags belong on the outer way member of a relation, but if so then relations shouldn't use inherited tags for creating POIs. pgpBqLwtjSkm4.pgp Description: PGP signature ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon
As far as I remember it, It should to be tagged in the outer way. But the wiki says otherwise, http://wiki.openstreetmap.org/wiki/Multipolygon#Usage On Thu, Nov 18, 2010 at 9:03 AM, Greg Troxel g...@ir.bbn.com wrote: Marko Mäkelä marko.mak...@iki.fi writes: On Wed, Nov 17, 2010 at 09:37:17PM +0800, maning sambale wrote: Can anyone confirm this? (I don't read code sorry) If moving all tags from the role=outer way to the multipolygon relation fixes the problem, then Greg Troxel is right. If not, then Chris is right. I may have observed similar behaviour to what Chris mentioned, but that was months ago, and the code has been changed since then. I think we first need to be very sure about the correct tagging rules and then make mkgmap follow them. It seems odd for me if tags belong on the outer way member of a relation, but if so then relations shouldn't use inherited tags for creating POIs. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- cheers, maning -- Freedom is still the most radical idea of all -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ -- ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
