Re: [mkgmap-dev] [PATCH v5] - Code around highway shield crap when sorting labels
On Mar 21, 2010, at 23:36, Mark Burton wrote: > So, those people who are tracking this patch series, please test and if > it doesn't bite your arse, I will commit it soonish I've applied the patch and will report on the results in due course. Cheers. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v5] - Code around highway shield crap when sorting labels
On 21.03.2010 23:36, Mark Burton wrote: > Also, for those of you wondering why the display names and other refs > are not showing up in the mapsource address search - it's because the > MDR building code only reads the first label for a road and ignores any > others. Shame that. I don't think there's a good reason why it couldn't > read the other labels, it's just doesn't do that at the moment. BTW - > the basic address search on the etrex and Nuvi still sees those > alternative road labels. > Your right, it would really be needed that all of the three combinations of name and ref are searchable independently. "name" "ref name" "ref" > So, those people who are tracking this patch series, please test and if > it doesn't bite your arse, I will commit it soonish > > I'll do tomorrow evening. Feel free to commit before however. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v5] - Code around highway shield crap when sorting labels
Felix, > Your right, it would really be needed that all of the three combinations > of name and ref are searchable independently. > "name" > "ref name" > "ref" All it requires is that all of the labels that are attached to a road are read in by the MDR generating code. Where those labels got their values from initially (name, ref, display_name, int_ref, ...) is irrelevant as far as the MDR is concerned. Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v5] - Code around highway shield crap when sorting labels
On Mar 21, 2010, at 23:36, Mark Burton wrote: > So, those people who are tracking this patch series, please test and if > it doesn't bite your arse, I will commit it soonish I tested v5 today. It seems to be OK. I'll try again with v6 tomorrow. Cheers ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v5] - Code around highway shield crap when sorting labels
Hi Clinton, > I tested v5 today. It seems to be OK. I'll try again with v6 tomorrow. Thanks. Actually, I think that v6 is OK (as far as fixing Felix's routing directions issue is concerned) and would like to commit it. However, I am holding off committing the patches until Felix says some more about the incompatibility issue with an MP patch. Any news Felix? Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v5] - Code around highway shield crap when sorting labels
On 22.03.2010 21:55, Mark Burton wrote: > Hi Clinton, > > >> I tested v5 today. It seems to be OK. I'll try again with v6 tomorrow. >> > Thanks. > > Actually, I think that v6 is OK (as far as fixing Felix's routing > directions issue is concerned) and would like to commit it. > > However, I am holding off committing the patches until Felix says some > more about the incompatibility issue with an MP patch. Any news Felix? > > Mark > Well as the mp_lesscuts_v4 patch is already commited, the breakage must be expected as I tried to add a patch that is already included (well probably slightly different though). Could you nevertheless also commit the sizeFilter.patch? It comes very handy and I know that besides me, also Thilo (User:Radfahrer) is using it. A value of 8 is quite good for default right now. (Polygons smaller than 8 pixels except for resolution 24 are not worthwhile anyhow and only slow down the map redraw). It is pretty straightforward and I don't think it could break anything. Also the mp_rolehandling_v3.patch should be committed too IMHO, because it really improves the maps. P.S.: This is an updated patch to r1602. > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v5] - Code around highway shield crap when sorting labels
Felix, Thanks for the update. > Well as the mp_lesscuts_v4 patch is already commited, the breakage must > be expected as I tried to add a patch that is already included (well > probably slightly different though). OK. > Could you nevertheless also commit the sizeFilter.patch? > It comes very handy and I know that besides me, also Thilo > (User:Radfahrer) is using it. A value of 8 is quite good for default > right now. (Polygons smaller than 8 pixels except for resolution 24 are > not worthwhile anyhow and only slow down the map redraw). It is pretty > straightforward and I don't think it could break anything. I will look at that - at this time I don't have any objection to it and if no one raises any objections I will commit it in a day or so. > Also the mp_rolehandling_v3.patch should be committed too IMHO, because > it really improves the maps. Steve's been handling the MP patches, hopefully he will look at incorporating that patch. Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
