Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Gerd, I'm using v2 of your patch. areas.list: 1605: 2320384,-153600 to 2369536,-55296 1645: 2320384,-55296 to 2381824,26624 problematic way:67416703 This way has only nodes in 1645 and is crossing 1605. He isn't displayed with josm, if split the both tiles out of a planet.pbf but it is in the file (opened with texteditor). Also mkgmap doesn't render it. Similar problem: way:29911983 and way:150505423 have one node in 1645 and are in the file but aren't shown in josm and mkgmap-generated map. Bu there are not all nodes of the ways in the tiles. Maybe this is problematic? Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Henning, thanks, I can reproduce the problem and I am able to fix it. Splitter skips some nodes because they are not written to any tile using the normal algorithm. It has to check first whether the nodes belongs to a problem way or relation. Wait for a new version in the problem-list branch (r207 still contains this error) ciao, Gerd Date: Thu, 25 Oct 2012 15:54:49 +0200 From: o...@aighes.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes Hi Gerd, I'm using v2 of your patch. areas.list: 1605: 2320384,-153600 to 2369536,-55296 1645: 2320384,-55296 to 2381824,26624 problematic way:67416703 This way has only nodes in 1645 and is crossing 1605. He isn't displayed with josm, if split the both tiles out of a planet.pbf but it is in the file (opened with texteditor). Also mkgmap doesn't render it. Similar problem: way:29911983 and way:150505423 have one node in 1645 and are in the file but aren't shown in josm and mkgmap-generated map. Bu there are not all nodes of the ways in the tiles. Maybe this is problematic? Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Gerd, I found another problem. If a long way has no nodes in a tile but is crossing the tile, then this long way isn't copied into the crossing tile. Is it possible to fix this? Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Henning, do you use the 2nd version of the patch? This should already work as you expect it. If yes, please let me know how to reproduce the error. By the way: I think I found a way to generate the problem list without too many false candidates. Ciao, Gerd Date: Wed, 24 Oct 2012 16:07:45 +0200 From: o...@aighes.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes Hi Gerd, I found another problem. If a long way has no nodes in a tile but is crossing the tile, then this long way isn't copied into the crossing tile. Is it possible to fix this? Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
The patch works for my sweden map (vänern): Before: http://gis.19327.n5.nabble.com/file/n5732113/Bildschirmfoto_2012-10-20_um_21.13.01.png After: http://gis.19327.n5.nabble.com/file/n5732113/Bildschirmfoto_2012-10-20_um_21.33.49.png Grand ... Klaus -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5732113.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
On Sun, Oct 21, toc-rox wrote: The patch works for my sweden map (vänern): Before: http://gis.19327.n5.nabble.com/file/n5732113/Bildschirmfoto_2012-10-20_um_21.13.01.png After: http://gis.19327.n5.nabble.com/file/n5732113/Bildschirmfoto_2012-10-20_um_21.33.49.png On both pictures you see some lines, where you see the background and not the polygon. Is this an artefact of the rounding issues discussed the last days here? Thorsten -- Thorsten Kukuk, Project Manager/Release Manager SLES SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Gerd, before adding severals boundarys and many ferry-ways in baltic sea just a question. Would it be possible to add wildcards like all ways and relation with ferry=* or all ways and relations with admin_level=2 ? How do others thing about it? Are there more ways which have typical a larger distance between nodes? Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Henning, I don't want to make the parser for this list too complex, but maybe I can copy some code from mkgmap. If you like, you can code some rules in the MultiTileProcessor, it contains a deactivated code in processRelation(), search for experimental code:. The more heap you can offer to splitter, and the less big your input file is, the more likely splitter can handle more (or all) relations without running out of memory. Reg. admin_level=2: That's funny, I thought it might be useful to delete all boundary=administrative relations completely and only use the precompiled bounds. Gerd Date: Sun, 21 Oct 2012 13:08:47 +0200 From: o...@aighes.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes Hi Gerd, before adding severals boundarys and many ferry-ways in baltic sea just a question. Would it be possible to add wildcards like all ways and relation with ferry=* or all ways and relations with admin_level=2 ? How do others thing about it? Are there more ways which have typical a larger distance between nodes? Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
I have tested the patch but the southern half of Lake Geneva is still dry, Multipolygon: http://www.openstreetmap.org/browse/relation/332617 areas.list: 0094: 2162688,278528 to 2183168,339968 # : 46.406250,5.976563 to 46.845703,7.294922 0554: 2142208,290816 to 2162688,339968 # : 45.966797,6.240234 to 46.406250,7.294922 1046: 2146304,258048 to 2162688,290816 # : 46.054688,5.537109 to 46.406250,6.240234 Tested on today's extract from http://download.geofabrik.de/openstreetmap/europe/alps.osm.pbf java -Xmx1400m -jar splitter-r200\splitter_patched.jar --write-kml=areas.kml --split-file=areas.list --no-trim --output=pbf --problem-file=problem_polygons.txt alps.osm.pbf ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Minko, Minko-2 wrote I have tested the patch but the southern half of Lake Geneva is still dry, Okay, I try to find out wether it is splitter that still writes incomplete data or is it mkgmap. Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5732180.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Minko-2 wrote I have tested the patch but the southern half of Lake Geneva is still dry, ... java -Xmx1400m -jar splitter-r200\splitter_patched.jar --write-kml=areas.kml --split-file=areas.list --no-trim --output=pbf --problem-file=problem_polygons.txt alps.osm.pbf ... Hi Minko, you haven't specified a problem file ? E.g. something like this: java -Xmx6000M -jar /home/kto/Freizeitkarte-Entwicklung/tools/splitter/splitter-poly.jar --geonames-file=/home/kto/Freizeitkarte-Entwicklung/cities/cities15000.zip --problem-file=/home/kto/Freizeitkarte-Entwicklung/*problem_polygons.txt* --mixed --no-trim --overlap=1 --mapid=58440001 --max-nodes=60 --output=xml --output-dir=/home/kto/Freizeitkarte-Entwicklung/work/Freizeitkarte_Schweden /home/kto/Freizeitkarte-Entwicklung/source/Freizeitkarte_Schweden.o5m Regards Klaus -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5732194.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
I did, Klaus: --problem-file=problem_polygons.txt I only didnt convert it to 05m format, but that shouldnt matter or does it? java -Xmx1400m -jar splitter-r200\splitter_patched.jar --write-kml=areas.kml --split-file=areas.list --no-trim --output=pbf --problem-file=problem_polygons.txt alps.osm.pbf ... Hi Minko, you haven't specified a problem file ? ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Minko-2 wrote I did, Klaus: --problem-file=problem_polygons.txt Oops - sorry - it seems I'm blind today. Regards Klaus -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5732199.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Thorsten, well, believe it or not, I did never create a map to use it, I am just trying to solve the problems ;-) Your are probably right, afaik the precompiled bounds are only used to set the admin level tags, the data cannot be accessed to draw an object. Ciao, Gerd Date: Sun, 21 Oct 2012 19:13:57 +0200 From: ku...@suse.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes On Sun, Oct 21, Gerd Petermann wrote: Reg. admin_level=2: That's funny, I thought it might be useful to delete all boundary=administrative relations completely and only use the precompiled bounds. You cannot use precompiled bounds to draw borders on your map, can you? -- Thorsten Kukuk, Project Manager/Release Manager SLES SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Minko, Minko-2 wrote If this patch will be implemented, will there be a list somewhere (wiki?) where we can add problematic multipolygons? This is probably the biggest problem with this solution. Therefore I consider any user written list of problem cases as a work-around. On the other hand, we may find out that most users find the same problem cases, which in turn would allow to distribute one list for all. Minko-2 wrote Or maybe some script can detect those large mps automatically from the OSM database? This would be great. As I've already written, I failed to produce the list within splitter. The algorithm that I've implemented calculates the bounding box of a way or relation to find out the tiles that should know the polygon. If this turns out to be good enough, and OSM api allows it, someone could provide a file that contains the info for each OSM way and relation (just the Id and the bbox info). Given that list (ordered by Id), splitter would not require much additional heap to write complete info to each tile, because we could simply merge the information while reading the normal input files. Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5731942.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Am 18.10.2012 11:44, schrieb Minko: If this patch will be implemented, will there be a list somewhere (wiki?) where we can add problematic multipolygons? I started a list here: http://wiki.openstreetmap.org/wiki/Mkgmap/help/problematic_polygons ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Thanks Henning, I added a few more. I started a list here: http://wiki.openstreetmap.org/wiki/Mkgmap/help/problematic_polygons ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Od: Minko ligfiet...@online.nl Thanks Henning, I added a few more. me too ;) m. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Klaus, attached is r200 with my patch applied (the binary) splitter.jar http://gis.19327.n5.nabble.com/file/n5731709/splitter.jar Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5731709.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Thanks for providing the patch ! I would like to verify the patch with a map of sweden (vänern sea). But I'm not familiar with pachtes ... how to apply the patch ? Or is it possible to provide a ready-to-run patched splitter ? Regards Klaus -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5731380.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hello Henning, no, it is not (yet). I plan to add o5m support to mkgmap soon. With my patch you can use splitter with o5m, if you do not specify the problem-file parm, it should produce the same results as r200. Gerd Date: Wed, 17 Oct 2012 22:58:48 +0200 From: o...@aighes.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes Hi Gerd, is it possible to use a normal splitter r200 with o5m input-data? What about mkgmap? Henning Am 17.10.2012 16:36, schrieb GerdP: Hi, here is a first try to fix this issue. splitter_problem_list.patch http://gis.19327.n5.nabble.com/file/n5731258/splitter_problem_list.patch A sample list of problem polygons: problem_polygons.txt http://gis.19327.n5.nabble.com/file/n5731258/problem_polygons.txt Specify it in the new parameter problem-file, e.g. --problem-file=./problem_polygons.txt It is recommended to use o5m format as input. To convert an existing osm.pbf file to o5m use e.g. osmconvert --drop-version --out-o5m europe.osm.pbf europe.o5m Sorry, the new code is not well commented yet, but I think it works quite well now. Any feedback is welcome. Ciao, GerdP ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hello Gerd no, it is not (yet). I plan to add o5m support to mkgmap soon. With my patch you can use splitter As an aside, what do you think it is about the o5m format that makes it quicker than pbf? ..Steve ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
+1 -Ursprüngliche Nachricht- Von: mkgmap-dev-boun...@lists.mkgmap.org.uk [mailto:mkgmap-dev- boun...@lists.mkgmap.org.uk] Im Auftrag von toc-rox Gesendet: Donnerstag, 18. Oktober 2012 10:09 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes Thanks for providing the patch ! I would like to verify the patch with a map of sweden (vänern sea). But I'm not familiar with pachtes ... how to apply the patch ? Or is it possible to provide a ready-to-run patched splitter ? Regards Klaus -- View this message in context: http://gis.19327.n5.nabble.com/Still- problems-with-lakes-tp5725668p5731380.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Klaus wrote: Or is it possible to provide a ready-to-run patched splitter ? +1 If this patch will be implemented, will there be a list somewhere (wiki?) where we can add problematic multipolygons? Or maybe some script can detect those large mps automatically from the OSM database? ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Steve, Steve Ratcliffe wrote Hello Gerd no, it is not (yet). I plan to add o5m support to mkgmap soon. With my patch you can use splitter As an aside, what do you think it is about the o5m format that makes it quicker than pbf? Well, not easy to say. I think it's a combination of many small points: 1) pbf uses (by default) compressied blocks, so you have to unzip a complete block before you can use any information in the block. 2) pbf read routines create a lot of temporary objects, this seems to stress GC 3) pbf doesn't allow to skip processing of node tags or way tags, but splitters' read passes often don't need them. So, with pbf we create lists of tags and return them to GC, with o5m we can simply skip them. To be fair, using the --drop-version parm in osmconvert removes a lot of info which is ignored by splitter and mkgmap. I did never try what effect is has to use pbf input that was created with this parm. When writing, o5m is probably only faster because it doesn't zip the data. As long as mkgmap doesn't understand o5m I see no benefit in using this. Maybe other computers show different results, esp. if the CPU is much faster than mine and the Disk access is slower. By the way: my patch also speeds up pbf reading a little bit. Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Still-problems-with-lakes-tp5725668p5731418.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Od: GerdP gpetermann_muenc...@hotmail.com Hi Gerd, here is a first try to fix this issue. splitter_problem_list.patch http://gis.19327.n5.nabble.com/file/n5731258/splitter_problem_list.patch I would like to try your patch as I have problem with glacier polygon when I build map of Greenland. I patched r200 splitter directory ... how to build splitter.jar file now? A sample list of problem polygons: problem_polygons.txt http://gis.19327.n5.nabble.com/file/n5731258/problem_polygons.txt Specify it in the new parameter problem-file, e.g. --problem-file=./problem_polygons.txt It is recommended to use o5m format as input. To convert an existing osm.pbf file to o5m use e.g. osmconvert --drop-version --out-o5m europe.osm.pbf europe.o5m Why not osm.pbf format? Thanks for your work mira ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Od: Gerd Petermann gpetermann_muenc...@hotmail.com Hi Gerd, why o5m: o5m is much faster to read compared to pbf, and the new algorithm requires a few more reads As Greenland map hasn't too much data I stayed with pbf ... not really longer splitting. Specify it in the new parameter problem-file, e.g. --problem-file=./problem_polygons.txt I added rel:1279614 # Greenland glacier to my problem_polygons.txt Now I nearly whole glacier! Amazing improvement! I still missing southern tip of glacier. I will try add some way values to fix it. Many thanks mira ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [Patch V1]Re: Still problems with lakes
Hi Gerd, is it possible to use a normal splitter r200 with o5m input-data? What about mkgmap? Henning Am 17.10.2012 16:36, schrieb GerdP: Hi, here is a first try to fix this issue. splitter_problem_list.patch http://gis.19327.n5.nabble.com/file/n5731258/splitter_problem_list.patch A sample list of problem polygons: problem_polygons.txt http://gis.19327.n5.nabble.com/file/n5731258/problem_polygons.txt Specify it in the new parameter problem-file, e.g. --problem-file=./problem_polygons.txt It is recommended to use o5m format as input. To convert an existing osm.pbf file to o5m use e.g. osmconvert --drop-version --out-o5m europe.osm.pbf europe.o5m Sorry, the new code is not well commented yet, but I think it works quite well now. Any feedback is welcome. Ciao, GerdP ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
