Re: [mkgmap-dev] Lake Garda... is empty
thanks, I never noticed the duplicate rules :O @ all :If I hear no complains I plan to commit this patch next monday. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Freitag, 21. September 2018 20:11 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Lake Garda... is empty Hi Gerd This patch moves the contents of inc/ landuse_points, landuse_polygons, water_lines, water_points and water_polygons inline and deletes rules if they have already occurred in the main file. IE there shouldn't be any change in meaning. After applying, you need to svn delete the above inc/ files Regards Ticker On Fri, 2018-09-21 at 15:49 +, Gerd Petermann wrote: > Hi Ticker, > > please post a patch with your suggested improvements. > > Gerd > > > Von: mkgmap-dev im Auftrag > von Steve Ratcliffe > Gesendet: Freitag, 21. September 2018 16:07 > An: mkgmap-dev@lists.mkgmap.org.uk > Betreff: Re: [mkgmap-dev] Lake Garda... is empty > > Hi Gerd > > > @Steve: I don't know why you created these includes. I also think > > it would be easier to have the rules within the polygons file. > > No problem - if it is easier to have them within the file, then move > them. > > Steve > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Hi Gerd
This patch moves the contents of inc/ landuse_points, landuse_polygons,
water_lines, water_points and water_polygons inline and deletes rules
if they have already occurred in the main file. IE there shouldn't be
any change in meaning.
After applying, you need to svn delete the above inc/ files
Regards
Ticker
On Fri, 2018-09-21 at 15:49 +, Gerd Petermann wrote:
> Hi Ticker,
>
> please post a patch with your suggested improvements.
>
> Gerd
>
>
> Von: mkgmap-dev im Auftrag
> von Steve Ratcliffe
> Gesendet: Freitag, 21. September 2018 16:07
> An: mkgmap-dev@lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] Lake Garda... is empty
>
> Hi Gerd
>
> > @Steve: I don't know why you created these includes. I also think
> > it would be easier to have the rules within the polygons file.
>
> No problem - if it is easier to have them within the file, then move
> them.
>
> Steve
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-devIndex: resources/styles/default/lines
===
--- resources/styles/default/lines (revision 4243)
+++ resources/styles/default/lines (working copy)
@@ -221,7 +221,18 @@
boundary=national [0x1e resolution 17]
boundary=political [0x1c resolution 19]
-include 'inc/water_lines';
+route=ferry {set mkgmap:numbers = false }
+route=ferry & (motorcar=no | motor_vehicle=no) {add mkgmap:ferry=1} [0x1b road_class=0 road_speed=0 resolution 23]
+route=ferry {add mkgmap:ferry=1} [0x1b road_class=3 road_speed=0 resolution 19]
+
+(waterway=river | waterway=canal) & intermittent=yes [0x26 resolution 20]
+(waterway=stream | waterway=drain) & intermittent=yes [0x10A02 resolution 22]
+
+waterway=canal [0x1f resolution 21]
+waterway=river [0x1f resolution 18]
+waterway=rapids|waterway=waterfall [0x1f resolution 22]
+waterway=stream | waterway=drain [0x18 resolution 22]
+
include 'inc/contour_lines';
Index: resources/styles/default/points
===
--- resources/styles/default/points (revision 4243)
+++ resources/styles/default/points (working copy)
@@ -294,10 +294,20 @@
barrier=bollard | barrier=bus_trap | barrier=gate [0x660f resolution 24]
barrier=block | barrier=cycle_barrier | barrier=stile | barrier=kissing_gate [0x660f resolution 24]
-include 'inc/water_points';
-include 'inc/landuse_points';
+landuse=basin|landuse=reservoir [0x650f resolution 24]
+natural=beach [0x6604 resolution 24]
+natural=glacier [0x650a resolution 24]
+natural=spring [0x6511 resolution 24]
+natural=stream [0x6512 resolution 24]
+natural=water & name=* [0x6603 resolution 24]
+natural=waterfall | waterway=waterfall [0x6508 resolution 24]
+natural=wetland & name=* [0x6513 resolution 24]
+
+landuse=cemetery|landuse=cemetary|amenity=grave_yard [0x6403 resolution 24]
+(landuse=wood|landuse=forest|natural=wood) & name=* [0x6618 resolution 24]
+
# The finalizer section is executed for each element when a rule with an element type matches
name=* { name '${name}' }
-include 'inc/address';
\ No newline at end of file
+include 'inc/address';
Index: resources/styles/default/polygons
===
--- resources/styles/default/polygons (revision 4243)
+++ resources/styles/default/polygons (working copy)
@@ -63,9 +63,48 @@
historic=museum | historic=memorial [0x1e resolution 21]
historic=archaeological_site | historic=ruins [0x1e resolution 21]
-include 'inc/water_polygons';
-include 'inc/landuse_polygons';
+landuse=basin [0x3f resolution 20]
+(landuse=reservoir | (natural=water & water=reservoir)) [0x3f resolution 20]
+natural=bay [0x3d resolution 18]
+natural=glacier [0x4d resolution 18]
+natural=marsh [0x51 resolution 20]
+natural=mud [0x51 resolution 20]
+natural=wetland [0x51 resolution 20]
+natural=water [0x3c resolution 18]
+natural=waterfall | waterway=waterfall [0x47 resolution 21]
+natural=sea { add mkgmap:skipSizeFilter=true; set mkgmap:drawLevel=2 } [0x32 resolution 10]
+
+waterway=riverbank [0x46 resolution 20]
+
+landuse=allotments [0x4e resolution 21]
+landuse=cemetery|landuse=cemetary|amenity=grave_yard [0x1a resolution 21]
+landuse=commercial [0x0c resolution 19]
+landuse=construction [0x0c resolution 21]
+landuse=farm |landuse=farmland [0x4e resolution 20]
+landuse=farmyard [0x10 resolution 22]
+landuse=forest|landuse=wood [0x50 resolution 20]
+landuse=greenfield [0x17 resolution 20]
+lan
Re: [mkgmap-dev] Lake Garda... is empty
Hi Ticker, please post a patch with your suggested improvements. Gerd Von: mkgmap-dev im Auftrag von Steve Ratcliffe Gesendet: Freitag, 21. September 2018 16:07 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Lake Garda... is empty Hi Gerd > @Steve: I don't know why you created these includes. I also think it would be > easier to have the rules within the polygons file. No problem - if it is easier to have them within the file, then move them. Steve ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Hi Gerd @Steve: I don't know why you created these includes. I also think it would be easier to have the rules within the polygons file. No problem - if it is easier to have them within the file, then move them. Steve ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Hi all,
sorry for the late response, I was cycling for a few weeks ;-)
I've now moved the two includes as I suggested in the post cited by Ticker.
@Steve: I don't know why you created these includes. I also think it would be
easier to have the rules within the polygons file.
Gerd
Von: mkgmap-dev im Auftrag von Ticker
Berkin
Gesendet: Mittwoch, 12. September 2018 11:06
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] Lake Garda... is empty
Maybe this should become a new thread on style/default:
I find the includes of inc/{landuse,water}_{points,lines,polygons}
pointless and unhelpful for various reasons:
1/ Each file is only included once so there is no advantage in avoiding
repetition.
2/ Checking the files to determine the behaviour for a tag is more
difficult - you can't just to a search from the top of 1 file.
3/ The contents of some of the files is not quite as the name suggests,
eg landuse_polygons tests for other tags.
4/ Some of the cases that you'd expect to be in the include file based
on its name have been moved out or duplicated into the parent file,
with intervening logic before the include, eg points and
landuse=military/village_green
5/ I suspect there are other cases where the contents of an include
file need to be scattered more intelligently into the parent file
Ticker
On Tue, 2018-09-11 at 21:42 +0200, Enrico Liboni wrote:
> Ticker, Lig - many thanks the lake is back now! I moved
> 'inc/*_polygons' as suggested.
>
> I'll test further to see if any adverse impact, but it does not seems
> the case so far. Guess this change should be made in the default
> style in next release, since we may have other lakes or bays that are
> labelled as tourist=yes - which may not be wrong for scenic touristic
> areas.
>
> Thanks!
> Enrico
>
> On Tue, Sep 11, 2018 at 7:20 PM Ticker Berkin > wrote:
> > Hi
> >
> > I seem to remember there was a suggestion a while ago (before may
> > 2017)
> > to reorder the styles/default/polygons to move the include
> > 'inc/*_polygons' up in the file to before "# building tag should be
> > last". I did this and had no problem with Lake Garda when I
> > generated
> > italy-latest in July this year.
> >
> > Ticker
> >
> > Just found the thread:
> > http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2017q2/026788.html
> >
> > On Tue, 2018-09-11 at 12:30 +, lig fietser wrote:
> > > Hi,
> > > I can reproduce your findings with the default style. With the
> > > generic new or my Openfietsmap style it renders fine so it seems
> > > style dependend.
> > > I found out the tourism=yes tag from the multipoly relation is
> > the
> > > cause. Once removed, it renders. Can this be fixed in mkgmap
> > (natural
> > > before tourism?) or should this tag be removed from osm?
> > > ___
> > > mkgmap-dev mailing list
> > > mkgmap-dev@lists.mkgmap.org.uk
> > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> > ___
> > mkgmap-dev mailing list
> > mkgmap-dev@lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Maybe this should become a new thread on style/default:
I find the includes of inc/{landuse,water}_{points,lines,polygons}
pointless and unhelpful for various reasons:
1/ Each file is only included once so there is no advantage in avoiding
repetition.
2/ Checking the files to determine the behaviour for a tag is more
difficult - you can't just to a search from the top of 1 file.
3/ The contents of some of the files is not quite as the name suggests,
eg landuse_polygons tests for other tags.
4/ Some of the cases that you'd expect to be in the include file based
on its name have been moved out or duplicated into the parent file,
with intervening logic before the include, eg points and
landuse=military/village_green
5/ I suspect there are other cases where the contents of an include
file need to be scattered more intelligently into the parent file
Ticker
On Tue, 2018-09-11 at 21:42 +0200, Enrico Liboni wrote:
> Ticker, Lig - many thanks the lake is back now! I moved
> 'inc/*_polygons' as suggested.
>
> I'll test further to see if any adverse impact, but it does not seems
> the case so far. Guess this change should be made in the default
> style in next release, since we may have other lakes or bays that are
> labelled as tourist=yes - which may not be wrong for scenic touristic
> areas.
>
> Thanks!
> Enrico
>
> On Tue, Sep 11, 2018 at 7:20 PM Ticker Berkin > wrote:
> > Hi
> >
> > I seem to remember there was a suggestion a while ago (before may
> > 2017)
> > to reorder the styles/default/polygons to move the include
> > 'inc/*_polygons' up in the file to before "# building tag should be
> > last". I did this and had no problem with Lake Garda when I
> > generated
> > italy-latest in July this year.
> >
> > Ticker
> >
> > Just found the thread:
> > http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2017q2/026788.html
> >
> > On Tue, 2018-09-11 at 12:30 +, lig fietser wrote:
> > > Hi,
> > > I can reproduce your findings with the default style. With the
> > > generic new or my Openfietsmap style it renders fine so it seems
> > > style dependend.
> > > I found out the tourism=yes tag from the multipoly relation is
> > the
> > > cause. Once removed, it renders. Can this be fixed in mkgmap
> > (natural
> > > before tourism?) or should this tag be removed from osm?
> > > ___
> > > mkgmap-dev mailing list
> > > mkgmap-dev@lists.mkgmap.org.uk
> > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> > ___
> > mkgmap-dev mailing list
> > mkgmap-dev@lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Ticker, Lig - many thanks the lake is back now! I moved 'inc/*_polygons' as suggested. I'll test further to see if any adverse impact, but it does not seems the case so far. Guess this change should be made in the default style in next release, since we may have other lakes or bays that are labelled as tourist=yes - which may not be wrong for scenic touristic areas. Thanks! Enrico On Tue, Sep 11, 2018 at 7:20 PM Ticker Berkin wrote: > Hi > > I seem to remember there was a suggestion a while ago (before may 2017) > to reorder the styles/default/polygons to move the include > 'inc/*_polygons' up in the file to before "# building tag should be > last". I did this and had no problem with Lake Garda when I generated > italy-latest in July this year. > > Ticker > > Just found the thread: > http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2017q2/026788.html > > On Tue, 2018-09-11 at 12:30 +, lig fietser wrote: > > Hi, > > I can reproduce your findings with the default style. With the > > generic new or my Openfietsmap style it renders fine so it seems > > style dependend. > > I found out the tourism=yes tag from the multipoly relation is the > > cause. Once removed, it renders. Can this be fixed in mkgmap (natural > > before tourism?) or should this tag be removed from osm? > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Hi I seem to remember there was a suggestion a while ago (before may 2017) to reorder the styles/default/polygons to move the include 'inc/*_polygons' up in the file to before "# building tag should be last". I did this and had no problem with Lake Garda when I generated italy-latest in July this year. Ticker Just found the thread: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2017q2/026788.html On Tue, 2018-09-11 at 12:30 +, lig fietser wrote: > Hi, > I can reproduce your findings with the default style. With the > generic new or my Openfietsmap style it renders fine so it seems > style dependend. > I found out the tourism=yes tag from the multipoly relation is the > cause. Once removed, it renders. Can this be fixed in mkgmap (natural > before tourism?) or should this tag be removed from osm? > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Hi, I can reproduce your findings with the default style. With the generic new or my Openfietsmap style it renders fine so it seems style dependend. I found out the tourism=yes tag from the multipoly relation is the cause. Once removed, it renders. Can this be fixed in mkgmap (natural before tourism?) or should this tag be removed from osm? ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
Thanks - yep I'm using --precomp-sea with latest sea.zip. Thomas I'll check the typ file but I suspect if there was an issue with water bodies level that would affect all lakes, not just one. Thanks Enrico Il Mar 11 Set 2018, 07:06 Thomas Morgenstern ha scritto: > At first look in your stylefile polygons and see how natural=water is > converted to garmintyp, I prefer 0x3c, resolution 18. Second look in your > typfile, if 0x3c is renderd and if the DrawPriority in typfile is high > enouf. Maybee 0x3c exist, but in a low layer, which is overwriting with > the other layers. > thomas > > Am 10.09.2018 um 23:18 schrieb Enrico Liboni: > > Folks, since sometime Lake Garda in Italy is not rendered correctly. I did > not report this a few months ago since I was using an old version of mkgmap > but I'm now using very latest one and fresh geofabrik pbf but the problem > remains. At a first glance OSM data seems fine: > https://www.openstreetmap.org/relation/8569 > > Any idea? Attached screenshot from my Garmin device, the lake should be > inside the ugly black line - note other smaller lakes are rendered > correctly. Lake name is also missed. I am using a custom style but I don't > think that can be the cause- > > Thanks, > Enrico > > [image: lakeGarda-black.jpg] > > > ___ > mkgmap-dev mailing > listmkgmap-...@lists.mkgmap.org.ukhttp://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > > ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Lake Garda... is empty
are you using the pre rendered sea data? Try fetching a new copy of it if yes - if not yet - then start using it. On 10 September 2018 at 23:18, Enrico Liboni wrote: > Folks, since sometime Lake Garda in Italy is not rendered correctly. I did > not report this a few months ago since I was using an old version of mkgmap > but I'm now using very latest one and fresh geofabrik pbf but the problem > remains. At a first glance OSM data seems fine: > https://www.openstreetmap.org/relation/8569 > > Any idea? Attached screenshot from my Garmin device, the lake should be > inside the ugly black line - note other smaller lakes are rendered > correctly. Lake name is also missed. I am using a custom style but I don't > think that can be the cause- > > Thanks, > Enrico > > [image: lakeGarda-black.jpg] > > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
