Re: [mkgmap-dev] Minor documentation patch
Hi Gerd, Please find an updated patch that I think captures the way the option works. I've tried to rewrite it as what it does rather than how it is implemented. I've also included an update to the top level help that removes the link to the OSM wiki as a provider of further information (it doesn't provide any) and adds a link to the geofabrik website as a source for input data. Let me know if you think the change still doesn't quite represent what happens. By the way, I'm not sure it is particularly logical to only remove words from the end of the label. There is also an error in the mkgmap home page, but the source doesn't seem to be included in the mkgmap distribution so I can't send a patch. The last sentence ends "and copy it to the cards in the Garmin directory" and I think it should say "and copy it to the card's /Garmin directory". Cheers, Mike -Original Message- From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] Sent: 09 January 2022 08:12 To: Development list for mkgmap Subject: Re: [mkgmap-dev] Minor documentation patch Hi Mike, thanks for the patch. I fear the original text was really wrong. Your suggestion is better but it still doesn't catch the case that all(!) words might be removed. Assume option --mdr7-del=PTH,TRK,UNP,PAV and label is "PTH UNP" or just "PTH" In both cases the processing of --mdr7-del would end up in an empty label and thus nothing is added to MDR7 section. With a label "SCHILLERSTRASSE UNP" the part " UNP" is removed. With a label "UNP SCHILLERSTRASSE" nothing is removed. The code actually splits the label at every blank (space) into an array of words. Then it removes from right to left if the last word appears in the list. A label that doesn't contain a blank is an array with one element. I have no idea how well this works with languages that are read from right to left, but that's a different story. Maybe you find better wording? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Samstag, 8. Januar 2022 16:24 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch Hi Gerd, Please find attached a minor documentation patch. Cheers, Mike options2.patch Description: Binary data ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Minor documentation patch
Hi Mike, thanks for the patch. I fear the original text was really wrong. Your suggestion is better but it still doesn't catch the case that all(!) words might be removed. Assume option --mdr7-del=PTH,TRK,UNP,PAV and label is "PTH UNP" or just "PTH" In both cases the processing of --mdr7-del would end up in an empty label and thus nothing is added to MDR7 section. With a label "SCHILLERSTRASSE UNP" the part " UNP" is removed. With a label "UNP SCHILLERSTRASSE" nothing is removed. The code actually splits the label at every blank (space) into an array of words. Then it removes from right to left if the last word appears in the list. A label that doesn't contain a blank is an array with one element. I have no idea how well this works with languages that are read from right to left, but that's a different story. Maybe you find better wording? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Samstag, 8. Januar 2022 16:24 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch Hi Gerd, Please find attached a minor documentation patch. Cheers, Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Minor documentation patch
Hi Gerd I think it is simplest to do that. Then later some of the sea options texts can be reworded if any of us feel strongly about it. Ticker On Mon, 2021-01-04 at 15:30 +, Gerd Petermann wrote: > Hi Ticker, > > not sure what to do now. Do you think i should commit Mikes patch > without changes? > > Gerd ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Minor documentation patch
Hi Ticker, not sure what to do now. Do you think i should commit Mikes patch without changes? Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Montag, 4. Januar 2021 15:52 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Minor documentation patch Hi Parts of what I said is not quite correct (I was looking at my modified version of SeaGenerator). The suggested wording for doc/options.txt is ok. However the trunk SeaGenerator.java does manipulate the coastline way but it is still available for rendering by the style. With option --coastlinefile, no manipulation takes place. Ticker On Sat, 2021-01-02 at 18:09 +, Ticker Berkin wrote: > Hi Mike & Gerd > > I'd suggest something like: > ... > When this option is specified the land and sea polygons are derived > from the given precompiled data rather than the natural=coastline > ways > from the input OSM files. > ... > > The coastline ways not removed or modified, leaving it up the style > to > decide to render then as lines. > > However --coastlinefile is different and doesn't pass them on > > Ticker > On Sat, 2021-01-02 at 17:43 +, Mike Baggaley wrote: > > HI Gerd, > > > > Thanks for the quick response. My issue with the existing wording > > is > > that it > > reads as if the input files are actually being modified. I'd be > > happy > > with > > "filtered out" or "are not loaded from the input OSM files". (Just > > noticed > > it actually says OSM tiles rather than OSM files in the first > > mention, so I > > think that needs changing as well.) Do either of the two > > suggestions > > seem > > better to you? > > > > Cheers, > > Mike > > > > -Original Message- > > From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] > > Sent: 02 January 2021 09:53 > > To: Development list for mkgmap > > Subject: Re: [mkgmap-dev] Minor documentation patch > > > > Hi Mike, > > > > thanks for the patch. I am not sure if I like the part for > > coastlines. I'm > > not 100% sure but I think the tag natural=coastline is really just > > removed > > before the OSM way is processed by the style rules. A way with > > more > > than a > > natural=coastline tag is still processed. That's very different to > > being > > "ignored", isn't it? > > > > Gerd > > > > > > Von: mkgmap-dev im Auftrag > > von Mike > > Baggaley > > Gesendet: Donnerstag, 31. Dezember 2020 16:14 > > An: 'Development list for mkgmap' > > Betreff: [mkgmap-dev] Minor documentation patch > > > > Hi Gerd, please find attached a patch that makes some minor > > improvements to > > the documentation. > > > > Please review and commit if OK. > > > > Cheers, > > Mike > > > > > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Minor documentation patch
Hi Parts of what I said is not quite correct (I was looking at my modified version of SeaGenerator). The suggested wording for doc/options.txt is ok. However the trunk SeaGenerator.java does manipulate the coastline way but it is still available for rendering by the style. With option --coastlinefile, no manipulation takes place. Ticker On Sat, 2021-01-02 at 18:09 +, Ticker Berkin wrote: > Hi Mike & Gerd > > I'd suggest something like: > ... > When this option is specified the land and sea polygons are derived > from the given precompiled data rather than the natural=coastline > ways > from the input OSM files. > ... > > The coastline ways not removed or modified, leaving it up the style > to > decide to render then as lines. > > However --coastlinefile is different and doesn't pass them on > > Ticker > On Sat, 2021-01-02 at 17:43 +, Mike Baggaley wrote: > > HI Gerd, > > > > Thanks for the quick response. My issue with the existing wording > > is > > that it > > reads as if the input files are actually being modified. I'd be > > happy > > with > > "filtered out" or "are not loaded from the input OSM files". (Just > > noticed > > it actually says OSM tiles rather than OSM files in the first > > mention, so I > > think that needs changing as well.) Do either of the two > > suggestions > > seem > > better to you? > > > > Cheers, > > Mike > > > > -Original Message- > > From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] > > Sent: 02 January 2021 09:53 > > To: Development list for mkgmap > > Subject: Re: [mkgmap-dev] Minor documentation patch > > > > Hi Mike, > > > > thanks for the patch. I am not sure if I like the part for > > coastlines. I'm > > not 100% sure but I think the tag natural=coastline is really just > > removed > > before the OSM way is processed by the style rules. A way with > > more > > than a > > natural=coastline tag is still processed. That's very different to > > being > > "ignored", isn't it? > > > > Gerd > > > > > > Von: mkgmap-dev im Auftrag > > von Mike > > Baggaley > > Gesendet: Donnerstag, 31. Dezember 2020 16:14 > > An: 'Development list for mkgmap' > > Betreff: [mkgmap-dev] Minor documentation patch > > > > Hi Gerd, please find attached a patch that makes some minor > > improvements to > > the documentation. > > > > Please review and commit if OK. > > > > Cheers, > > Mike > > > > > > ___ > > mkgmap-dev mailing list > > mkgmap-dev@lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Minor documentation patch
Hi Mike & Gerd I'd suggest something like: ... When this option is specified the land and sea polygons are derived from the given precompiled data rather than the natural=coastline ways from the input OSM files. ... The coastline ways not removed or modified, leaving it up the style to decide to render then as lines. However --coastlinefile is different and doesn't pass them on Ticker On Sat, 2021-01-02 at 17:43 +, Mike Baggaley wrote: > HI Gerd, > > Thanks for the quick response. My issue with the existing wording is > that it > reads as if the input files are actually being modified. I'd be happy > with > "filtered out" or "are not loaded from the input OSM files". (Just > noticed > it actually says OSM tiles rather than OSM files in the first > mention, so I > think that needs changing as well.) Do either of the two suggestions > seem > better to you? > > Cheers, > Mike > > -Original Message- > From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] > Sent: 02 January 2021 09:53 > To: Development list for mkgmap > Subject: Re: [mkgmap-dev] Minor documentation patch > > Hi Mike, > > thanks for the patch. I am not sure if I like the part for > coastlines. I'm > not 100% sure but I think the tag natural=coastline is really just > removed > before the OSM way is processed by the style rules. A way with more > than a > natural=coastline tag is still processed. That's very different to > being > "ignored", isn't it? > > Gerd > > > Von: mkgmap-dev im Auftrag > von Mike > Baggaley > Gesendet: Donnerstag, 31. Dezember 2020 16:14 > An: 'Development list for mkgmap' > Betreff: [mkgmap-dev] Minor documentation patch > > Hi Gerd, please find attached a patch that makes some minor > improvements to > the documentation. > > Please review and commit if OK. > > Cheers, > Mike > > > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Minor documentation patch
HI Gerd, Thanks for the quick response. My issue with the existing wording is that it reads as if the input files are actually being modified. I'd be happy with "filtered out" or "are not loaded from the input OSM files". (Just noticed it actually says OSM tiles rather than OSM files in the first mention, so I think that needs changing as well.) Do either of the two suggestions seem better to you? Cheers, Mike -Original Message- From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] Sent: 02 January 2021 09:53 To: Development list for mkgmap Subject: Re: [mkgmap-dev] Minor documentation patch Hi Mike, thanks for the patch. I am not sure if I like the part for coastlines. I'm not 100% sure but I think the tag natural=coastline is really just removed before the OSM way is processed by the style rules. A way with more than a natural=coastline tag is still processed. That's very different to being "ignored", isn't it? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Donnerstag, 31. Dezember 2020 16:14 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch Hi Gerd, please find attached a patch that makes some minor improvements to the documentation. Please review and commit if OK. Cheers, Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Minor documentation patch
Hi Mike, thanks for the patch. I am not sure if I like the part for coastlines. I'm not 100% sure but I think the tag natural=coastline is really just removed before the OSM way is processed by the style rules. A way with more than a natural=coastline tag is still processed. That's very different to being "ignored", isn't it? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Donnerstag, 31. Dezember 2020 16:14 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch Hi Gerd, please find attached a patch that makes some minor improvements to the documentation. Please review and commit if OK. Cheers, Mike ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
