Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
On Tue, Feb 1, 2011 at 4:20 PM, Torsten Leistikow de_m...@gmx.de wrote: Moin, Henning Scholland schrieb am 31.01.2011 21:41: Why you would like to have a POI for an object taged as node and not for a similar POI taged as polygon? In OSM some objets can be mapped in OSM as a node or as an area, depending on the availability of the source data. If they are mapped as a node, I want them to be displayed as a symbol in my map. If they are mapped as an area, I want them to be displayed as a polygon. With the pois-to-area function the latter ones are displayed in a map twice, as a polygon AND as a symbol. That's a bug. If I recall correctly, the POI should only be added if there's no POI with the same name already in the polygon. I should really fix this. Thanks for pointing it out. Cheers, Ben ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
Am 03.02.2011 12:51, schrieb Ben Konrath: On Tue, Feb 1, 2011 at 4:20 PM, Torsten Leistikowde_m...@gmx.de wrote: Moin, Henning Scholland schrieb am 31.01.2011 21:41: Why you would like to have a POI for an object taged as node and not for a similar POI taged as polygon? In OSM some objets can be mapped in OSM as a node or as an area, depending on the availability of the source data. If they are mapped as a node, I want them to be displayed as a symbol in my map. If they are mapped as an area, I want them to be displayed as a polygon. With the pois-to-area function the latter ones are displayed in a map twice, as a polygon AND as a symbol. That's a bug. If I recall correctly, the POI should only be added if there's no POI with the same name already in the polygon. I should really fix this. Thanks for pointing it out No, this is a error in osm-data. One object should only taged once. So if you tag this information to a node, you shouldn't tag same info to the polygon. If add-pois-to-area creates an POI, there shouldn't be any node in OSM-data. If there is already a node and so there are two symbols in the map, it's not an mkgmap-bug. Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
Ben Konrath schrieb am 03.02.2011 12:51: That's a bug. If I recall correctly, the POI should only be added if there's no POI with the same name already in the polygon. I should really fix this. Thanks for pointing it out. No, in the OSM data is only a polygon, and AFTER the POI is added to the area, I have the node and the polygon. The style processing afterwards has no chance to detect, whether there is a polygon belonging to the node or not. So in the resulting map I get both, a polygon area and a symbol. For some types this might be ok, but for some types I do not want the symbol in addition to the polygon. But the add-pois-to-areas function is only working on all types or not working at all. And I can not remove such types from the point style, because in the OSM data there are also nodes of the same type without a corresponding polygon. So my suggestion would be, to mark all created POIs with an extra tag, e.g. mkgmap_created=add-pois-to-areas or something like that. Then I could use in the points-style a rule like type=xyz mkgmap_created!=add-pois-to-areas ... which would only place a symbol in the map if there is no corresponding polygon. Gruss Torsten ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
Am 03.02.2011 12:51, schrieb Ben Konrath: On Tue, Feb 1, 2011 at 4:20 PM, Torsten Leistikowde_m...@gmx.de wrote: Moin, Henning Scholland schrieb am 31.01.2011 21:41: Why you would like to have a POI for an object taged as node and not for a similar POI taged as polygon? In OSM some objets can be mapped in OSM as a node or as an area, depending on the availability of the source data. If they are mapped as a node, I want them to be displayed as a symbol in my map. If they are mapped as an area, I want them to be displayed as a polygon. With the pois-to-area function the latter ones are displayed in a map twice, as a polygon AND as a symbol. That's a bug. If I recall correctly, the POI should only be added if there's no POI with the same name already in the polygon. I should really fix this. Thanks for pointing it out No, this is a error in osm-data. One object should only taged once. So if you tag this information to a node, you shouldn't tag same info to the polygon. If add-pois-to-area creates an POI, there shouldn't be any node in OSM-data. If there is already a node and so there are two symbols in the map, it's not an mkgmap-bug. Henning I think Ben is right. The POI should only be added if there is no point (POI) with the same name (and the same type?) in the polygon. This is what the MapMaker.makeAreaPOIs method does if we believe what the source code comments tell us. WanMil ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
On Thu, Feb 03, 2011 at 05:02:43PM +0100, Torsten Leistikow wrote: For some types this might be ok, but for some types I do not want the symbol in addition to the polygon. For some minor map features, I would want only the symbol, not the polygon. For example, mappers could start drawing bus stop shelters from Bing aerial images. The shelters would be smaller than the Garmin map resolution, and thus the POI would be enough. So my suggestion would be, to mark all created POIs with an extra tag, e.g. mkgmap_created=add-pois-to-areas or something like that. That would scratch your itch (I would use mkgmap:generated), but it would not solve the use case that I outlined above. Obviously, add-pois-to-areas cannot consider areas that are not defined in the polygons file. Maybe if the polygons file contained a special 'no operation' rule, no polygon would be generated, but add-pois-to-areas would still generate POIs. Best regards, Marko ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
Am 03.02.2011 22:36, schrieb Marko Mäkelä: On Thu, Feb 03, 2011 at 05:02:43PM +0100, Torsten Leistikow wrote: For some types this might be ok, but for some types I do not want the symbol in addition to the polygon. For some minor map features, I would want only the symbol, not the polygon. For example, mappers could start drawing bus stop shelters from Bing aerial images. The shelters would be smaller than the Garmin map resolution, and thus the POI would be enough. Did you try my hack with a transparent polygon? All in all I think the best would be an action in polygon-style for creating a POI. Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
On 04.02.2011 08:12, Henning Scholland wrote: Am 03.02.2011 22:36, schrieb Marko Mäkelä: On Thu, Feb 03, 2011 at 05:02:43PM +0100, Torsten Leistikow wrote: For some types this might be ok, but for some types I do not want the symbol in addition to the polygon. For some minor map features, I would want only the symbol, not the polygon. For example, mappers could start drawing bus stop shelters from Bing aerial images. The shelters would be smaller than the Garmin map resolution, and thus the POI would be enough. Did you try my hack with a transparent polygon? All in all I think the best would be an action in polygon-style for creating a POI. Henning I often would like to have only Polygon, but no POI. transparent is possible, but not nice, as at least on old GPS it slows them down A seperate style-file file would be best... For me the reason to use add-pois-to-areas is that I want to be able to find certain stuff via search function, but actually I would even prefer not to have a seperate POI. As that is not possible AFAIK (searching for POI that do not exist in the map but only some indexes - which is what I really would like to have) - at least not have a myriad of POI on top and a seperate file would be needed (twould probably for me cut the number of POI from polygons by 50%). ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
Moin, Henning Scholland schrieb am 31.01.2011 21:41: Why you would like to have a POI for an object taged as node and not for a similar POI taged as polygon? In OSM some objets can be mapped in OSM as a node or as an area, depending on the availability of the source data. If they are mapped as a node, I want them to be displayed as a symbol in my map. If they are mapped as an area, I want them to be displayed as a polygon. With the pois-to-area function the latter ones are displayed in a map twice, as a polygon AND as a symbol. Therefor there is some need, to disable the POI generation for some polygons, or for detecting the automatically generated POIs, to prevent there inclusion in the map. Gruss Torsten ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Replacing --add-pois-to-areas with an add_poi action
Am 31.01.2011 21:20, schrieb Marko Mäkelä: On Mon, Jan 31, 2011 at 08:31:09PM +0100, Henning Scholland wrote: Am 31.01.2011 20:16, schrieb Marko Mäkelä: On a related note, I believe that an alternative to add-pois-to-areas should be implemented, by introducing an add_poi action in the polygons style file. In that way, one could flexibly choose which polygons deserve a POI. I found an easy way to fix this issue. I set one Garmin-polygon-ID with a transparent image. In polygons-style-file I created as example the following rule: shop=supermarket building!=* [0x0D resolution 23] For building=yes I've an extra rule. 0x0D is my transparent Garmin-ID. It works fine. Only default name should be set in the rule and not in TYP-file. Oh, you seem to have a different use case for the add_poi feature. I was thinking that I do not necessarily want to have a POI for certain areas, say, amenity=school name!=* or amenity=parking access=private. You seem to not want a polygon for features for which POIs are to be generated. The add_poi action would help also there: just tell mkgmap to create the POI but not the polygon. For instance, do not create a polygon for amenity=recycling or tourism=lean_to, but just the POI. Marko Yes of cause a better implementation would help both of us. But if you want to search for a POI, it must be a node and so I need to have for some areas a node. If there is no rule for a area-tag in points-file, there wont be an node from --add-pois-to-area. Why you would like to have a POI for an object taged as node and not for a similar POI taged as polygon? Henning ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
