[WikimediaMobile] jquery.accessKeyLabel broke mobile
Looks like jquery.accessKeyLabel now seems to be a required ResourceLoader module. The patch that introduced it is https://gerrit.wikimedia.org/r/#/c/125426/and this has exploded the mobile site with 49 or 50 tests failing since the merge. I'm not quite sure whether this module is useful on mobile. I'm not judging that here - I just want to report this is a consideration. Seems we have 2 options 1) Enable the module on mobile if it is applicable. If it's a small library maybe decide on whether it is important later. 2) Revert this core change and rethink this We need to do _one_ of the above before the next deployment train. The damage can be viewed at http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin - basically JavaScript exception. Bug at https://bugzilla.wikimedia.org/show_bug.cgi?id=64512 On Sat, Apr 26, 2014 at 10:18 PM, jenkins-no-re...@cloudbees.com wrote: * FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome Build #409 https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/ (Sun, 27 Apr 2014 04:52:29 +)* *Test Result*https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/ 50 failed, 20 skipped Failed Tests *Test Name**Duration**Age* Check UI components.Check existence of important UI components on other pages.https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Check%20UI%20components/Check_existence_of_important_UI_components_on_other_pages_22 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Encourage new users to Keep Going.I see a KeepGoing message after completing my VisualEditor edithttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Encourage%20new%20users%20to%20Keep%20Going/I_see_a_KeepGoing_message_after_completing_my_VisualEditor_edit48 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Encourage new users to Keep Going.I see a KeepGoing message after completing my edithttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Encourage%20new%20users%20to%20Keep%20Going/I_see_a_KeepGoing_message_after_completing_my_edit52 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Loginhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Login39 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Nearbyhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Nearby10 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Uploadshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Uploads2.2 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Watchlisthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Watchlist38 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.Clicking page issues opens overlayhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Issues/Clicking_page_issues_opens_overlay12 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.Closing page issueshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Issues/Closing_page_issues12 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.Closing page issues (browser back)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Issues/Closing_page_issues__browser_back_13 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.I see the this page has issues
Re: [WikimediaMobile] Nearby
I'm adding mobile-l to this as I think it is a useful discussion. The plan is to move the nearby code into the Geodata extension. To do this however we must remove the dependency on MobileFrontend code which is not an easy. Check out the Mantle extension. This isn't final but it will give you an idea of a potential plan of action. This patch [1] will also give you an idea of how we could do this. [1] https://gerrit.wikimedia.org/r/129480 On 27 Apr 2014 23:58, Prateek Saxena psax...@wikimedia.org wrote: Should we consider moving Nearby out of MobileFrontend and into its own extension? -prtksxna ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] [Mobile web] Additional notes RE Bugello updates
Head's up that I've disabled Bingle for Mobile Web, copied cards from the Mingle bug backlog into the new Trello bug backlog ( https://trello.com/b/BdoyCeLj/mobile-web-bug-backlog), and reconciled the bugs that Juliusz/Maryana added to Trello by hand. After today's sprint kickoff, I will enable Bugello for Mobile Web and migrate any remaining bugs from Mingle - Trello (the only ones that should need to be migrated are any outstanding bugs from the current iteration). On Fri, Apr 25, 2014 at 6:10 PM, Tomasz Finc tf...@wikimedia.org wrote: Thanks for the update Arthur On Fri, Apr 25, 2014 at 5:33 PM, Arthur Richards aricha...@wikimedia.org wrote: For the mobile web team, I will be migrating bugs that we currently have in our Mingle bug backlog into Trello on Monday before I get Bugello up and running. This will help prevent dupes and make it so backlogged bug cards are still available to us when we're planning, etc. Max, let's sync up sometime on Monday to discuss including PageImages and TextExtracts in the bugs that Bugello pulls in for us. Thanks! -- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687 ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687 ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Definition of Pageview for the API
Yuvi, Monte, Toby, ideas? -Adam On Mon, Apr 28, 2014 at 1:11 PM, Tomasz Finc tf...@wikimedia.org wrote: Adam, lets move this to a public list and engage Yuvi, Monte, and Toby to answer your questions. --tomasz On Fri, Apr 25, 2014 at 4:55 PM, Adam Baso ab...@wikimedia.org wrote: The article loads for iOS and Android apps will no[w] both be in the web logs. But I can't tell if the pageview counting code is still accurate; also, there are two action=mobileview hits per page load in the apps, so it seems like it may be inaccurate from my read of it. How can Analytics be engaged to straighten out the relevant section of code? I think the app release dates may have been pushed out a bit more, so it may not be an emergency, but I wanted to check on next steps. Here's the relevant code from my understanding: https://github.com/wikimedia/kraken/blob/master/kraken-generic/src/main/java/org/wikimedia/analytics/kraken/pageview/PageviewFilter.java#L113 I don't think action=view and action=query qualify as pageviews anymore (at least without even further qualification), if they ever were. It's possible the pageview counting code in the link above is only an intermediate step in the qualification of hits, but until we dig into it, it's an unknown. I wonder if asking Analytics for action=view and action=query to be removed, and then to disqualify 1 of the 2 URL types for the apps would make sense. Or rather, asking them if it sounds okay and if we should then run it by the engineering mailing list for further refinement. -Adam ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Definition of Pageview for the API
+ Maryana/Oliver We're pulling some data for the Metrics meeting this Thursday that you should be aware of. It's one of the first steps in unraveling how to define a pageview (or other engagement/reach metrics) https://meta.wikimedia.org/wiki/Research:Mobile_Metrics#Datasets_and_deliverables Specifically https://meta.wikimedia.org/wiki/Research:Mobile_Traffic/Implementation -Toby On Mon, Apr 28, 2014 at 1:32 PM, Adam Baso ab...@wikimedia.org wrote: Yuvi, Monte, Toby, ideas? -Adam On Mon, Apr 28, 2014 at 1:11 PM, Tomasz Finc tf...@wikimedia.org wrote: Adam, lets move this to a public list and engage Yuvi, Monte, and Toby to answer your questions. --tomasz On Fri, Apr 25, 2014 at 4:55 PM, Adam Baso ab...@wikimedia.org wrote: The article loads for iOS and Android apps will no[w] both be in the web logs. But I can't tell if the pageview counting code is still accurate; also, there are two action=mobileview hits per page load in the apps, so it seems like it may be inaccurate from my read of it. How can Analytics be engaged to straighten out the relevant section of code? I think the app release dates may have been pushed out a bit more, so it may not be an emergency, but I wanted to check on next steps. Here's the relevant code from my understanding: https://github.com/wikimedia/kraken/blob/master/kraken-generic/src/main/java/org/wikimedia/analytics/kraken/pageview/PageviewFilter.java#L113 I don't think action=view and action=query qualify as pageviews anymore (at least without even further qualification), if they ever were. It's possible the pageview counting code in the link above is only an intermediate step in the qualification of hits, but until we dig into it, it's an unknown. I wonder if asking Analytics for action=view and action=query to be removed, and then to disqualify 1 of the 2 URL types for the apps would make sense. Or rather, asking them if it sounds okay and if we should then run it by the engineering mailing list for further refinement. -Adam ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Definition of Pageview for the API
Sounds good. I'm already handling the two-API-requests problem (they request different sections, so it's trivial to uniformly exclude one kind). On 28 April 2014 13:36, Toby Negrin tneg...@wikimedia.org wrote: + Maryana/Oliver We're pulling some data for the Metrics meeting this Thursday that you should be aware of. It's one of the first steps in unraveling how to define a pageview (or other engagement/reach metrics) https://meta.wikimedia.org/wiki/Research:Mobile_Metrics#Datasets_and_deliverables Specifically https://meta.wikimedia.org/wiki/Research:Mobile_Traffic/Implementation -Toby On Mon, Apr 28, 2014 at 1:32 PM, Adam Baso ab...@wikimedia.org wrote: Yuvi, Monte, Toby, ideas? -Adam On Mon, Apr 28, 2014 at 1:11 PM, Tomasz Finc tf...@wikimedia.org wrote: Adam, lets move this to a public list and engage Yuvi, Monte, and Toby to answer your questions. --tomasz On Fri, Apr 25, 2014 at 4:55 PM, Adam Baso ab...@wikimedia.org wrote: The article loads for iOS and Android apps will no[w] both be in the web logs. But I can't tell if the pageview counting code is still accurate; also, there are two action=mobileview hits per page load in the apps, so it seems like it may be inaccurate from my read of it. How can Analytics be engaged to straighten out the relevant section of code? I think the app release dates may have been pushed out a bit more, so it may not be an emergency, but I wanted to check on next steps. Here's the relevant code from my understanding: https://github.com/wikimedia/kraken/blob/master/kraken-generic/src/main/java/org/wikimedia/analytics/kraken/pageview/PageviewFilter.java#L113 I don't think action=view and action=query qualify as pageviews anymore (at least without even further qualification), if they ever were. It's possible the pageview counting code in the link above is only an intermediate step in the qualification of hits, but until we dig into it, it's an unknown. I wonder if asking Analytics for action=view and action=query to be removed, and then to disqualify 1 of the 2 URL types for the apps would make sense. Or rather, asking them if it sounds okay and if we should then run it by the engineering mailing list for further refinement. -Adam -- Oliver Keyes Research Analyst Wikimedia Foundation ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Definition of Pageview for the API
yes -- I should say we need to give Oliver some space until Thursday to get the data in a presentable state. But we look forward to working with you more closely on this in the near future. -Toby On Mon, Apr 28, 2014 at 1:38 PM, Oliver Keyes oke...@wikimedia.org wrote: Sounds good. I'm already handling the two-API-requests problem (they request different sections, so it's trivial to uniformly exclude one kind). On 28 April 2014 13:36, Toby Negrin tneg...@wikimedia.org wrote: + Maryana/Oliver We're pulling some data for the Metrics meeting this Thursday that you should be aware of. It's one of the first steps in unraveling how to define a pageview (or other engagement/reach metrics) https://meta.wikimedia.org/wiki/Research:Mobile_Metrics#Datasets_and_deliverables Specifically https://meta.wikimedia.org/wiki/Research:Mobile_Traffic/Implementation -Toby On Mon, Apr 28, 2014 at 1:32 PM, Adam Baso ab...@wikimedia.org wrote: Yuvi, Monte, Toby, ideas? -Adam On Mon, Apr 28, 2014 at 1:11 PM, Tomasz Finc tf...@wikimedia.orgwrote: Adam, lets move this to a public list and engage Yuvi, Monte, and Toby to answer your questions. --tomasz On Fri, Apr 25, 2014 at 4:55 PM, Adam Baso ab...@wikimedia.org wrote: The article loads for iOS and Android apps will no[w] both be in the web logs. But I can't tell if the pageview counting code is still accurate; also, there are two action=mobileview hits per page load in the apps, so it seems like it may be inaccurate from my read of it. How can Analytics be engaged to straighten out the relevant section of code? I think the app release dates may have been pushed out a bit more, so it may not be an emergency, but I wanted to check on next steps. Here's the relevant code from my understanding: https://github.com/wikimedia/kraken/blob/master/kraken-generic/src/main/java/org/wikimedia/analytics/kraken/pageview/PageviewFilter.java#L113 I don't think action=view and action=query qualify as pageviews anymore (at least without even further qualification), if they ever were. It's possible the pageview counting code in the link above is only an intermediate step in the qualification of hits, but until we dig into it, it's an unknown. I wonder if asking Analytics for action=view and action=query to be removed, and then to disqualify 1 of the 2 URL types for the apps would make sense. Or rather, asking them if it sounds okay and if we should then run it by the engineering mailing list for further refinement. -Adam -- Oliver Keyes Research Analyst Wikimedia Foundation ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Triaging bugs and moving stories to the backlog or sprint 30
Yargg. I'm attempting to go through these, but I think either I'm subscribed to too many Trello boards or I've encountered a weird bug - it won't let me move anything directly to the Apps Backlog; I have to move things to the current sprint and only then will it let me backlog :( So it's taking way longer than I want. But I'll try to get this done by tomorrow! On Mon, Apr 28, 2014 at 12:35 PM, Tomasz Finc tf...@wikimedia.org wrote: Maryana, Can you take a pass through https://trello.com/b/8ADlEuVo/mobile-app-sprint-29-android-to-b (ToDo) and archive, move to sprint 30, or move to backlog as necessary? i'd like like to close sprint 29. thanks --tomasz -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Triaging bugs and moving stories to the backlog or sprint 30
I've never seen that. What do you see in the drop down for moving a card? On Mon, Apr 28, 2014 at 1:51 PM, Maryana Pinchuk mpinc...@wikimedia.org wrote: Yargg. I'm attempting to go through these, but I think either I'm subscribed to too many Trello boards or I've encountered a weird bug – it won't let me move anything directly to the Apps Backlog; I have to move things to the current sprint and only then will it let me backlog :( So it's taking way longer than I want. But I'll try to get this done by tomorrow! On Mon, Apr 28, 2014 at 12:35 PM, Tomasz Finc tf...@wikimedia.org wrote: Maryana, Can you take a pass through https://trello.com/b/8ADlEuVo/mobile-app-sprint-29-android-to-b (ToDo) and archive, move to sprint 30, or move to backlog as necessary? i'd like like to close sprint 29. thanks --tomasz -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] iOS animation library from FB/Paper: Pop
Nice, I bet Monte will have fun playing with this. --tomasz On Mon, Apr 28, 2014 at 2:09 PM, Erik Moeller e...@wikimedia.org wrote: Just open sourced: https://github.com/facebook/pop http://techcrunch.com/2014/04/28/facebook-open-sources-the-animation-engine-that-powers-its-paper-app/ -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Triaging bugs and moving stories to the backlog or sprint 30
I see pretty much every board I'm joined on *except* the Mobile Apps backlog :-/ Investigating to see if dropping some of my boards helps... On Mon, Apr 28, 2014 at 1:58 PM, Tomasz Finc tf...@wikimedia.org wrote: I've never seen that. What do you see in the drop down for moving a card? On Mon, Apr 28, 2014 at 1:51 PM, Maryana Pinchuk mpinc...@wikimedia.org wrote: Yargg. I'm attempting to go through these, but I think either I'm subscribed to too many Trello boards or I've encountered a weird bug - it won't let me move anything directly to the Apps Backlog; I have to move things to the current sprint and only then will it let me backlog :( So it's taking way longer than I want. But I'll try to get this done by tomorrow! On Mon, Apr 28, 2014 at 12:35 PM, Tomasz Finc tf...@wikimedia.org wrote: Maryana, Can you take a pass through https://trello.com/b/8ADlEuVo/mobile-app-sprint-29-android-to-b (ToDo) and archive, move to sprint 30, or move to backlog as necessary? i'd like like to close sprint 29. thanks --tomasz -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] No more Mingle for the mobile web team
I have completed the final steps for fully migrating from Mingle to Trello for the mobile web team: - I have finished reconciling the immediately important differences between Mingle/Trello for the mobile web team.* - I've enabled bugello to run automatically (it just picked up it's first real bug for the web team: https://trello.com/c/s0KRAIIC/32-bug-64575-ve-link-inspector-after-selection-search-field-is-buggy ). - I've made our project on Mingle read-only. So, please use Trello for all your project workflow/planning needs. Some useful links: - Current iteration (Vampire Squid) story wall: https://trello.com/b/NjJtUGAz/mobile-web-current-sprint-22-vampire-squid - Q4 Backlog: https://trello.com/b/sFlwoPUn/mobile-web-q4-backlog Trello is new for me and I am liking what I am seeing so far. Please be patient as we all adjust to the new tool. And finally, let me know if you have any issues/concerns/etc. * Bugello doesn't currently support some of the auto-reconciliation features that Bingle does - most notably, Bugello will not move a bug out of the bug backlog and stick it into 'ready for signoff' when the bug has been marked as resolved in BZ - therefore, our bug backlog on Trello is currently a little larger than on Mingle. -- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687 ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Triaging bugs and moving stories to the backlog or sprint 30
Double weirdly, when I looked at Trello on my personal computer at home just now, it worked just fine. It may be working fine now on my work comp, too.. I'll have to check tomorrow. So, good news is I cleared out the todo pile :) Unfortunately, I wasn't able to get the latest Android build (something weird going on in the Play Store - Yuvi's aware hopefully can help), but I'll work on getting that squared away tomorrow. Sorry for the wait! On Mon, Apr 28, 2014 at 2:40 PM, Maryana Pinchuk mpinc...@wikimedia.orgwrote: I see pretty much every board I'm joined on *except* the Mobile Apps backlog :-/ Investigating to see if dropping some of my boards helps... On Mon, Apr 28, 2014 at 1:58 PM, Tomasz Finc tf...@wikimedia.org wrote: I've never seen that. What do you see in the drop down for moving a card? On Mon, Apr 28, 2014 at 1:51 PM, Maryana Pinchuk mpinc...@wikimedia.org wrote: Yargg. I'm attempting to go through these, but I think either I'm subscribed to too many Trello boards or I've encountered a weird bug - it won't let me move anything directly to the Apps Backlog; I have to move things to the current sprint and only then will it let me backlog :( So it's taking way longer than I want. But I'll try to get this done by tomorrow! On Mon, Apr 28, 2014 at 12:35 PM, Tomasz Finc tf...@wikimedia.org wrote: Maryana, Can you take a pass through https://trello.com/b/8ADlEuVo/mobile-app-sprint-29-android-to-b (ToDo) and archive, move to sprint 30, or move to backlog as necessary? i'd like like to close sprint 29. thanks --tomasz -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org -- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
