Re: [WikimediaMobile] Good job iOS app team for getting todays build out
Seconded! Good job. :-) Dan On 13 February 2015 at 17:50, Tomasz Finc wrote: > Excited to see us push forward on this release and get closer to > delighting our users. > > Big call to everyone else on this list to help us with further testing. > > thanks all > > http://tflig.ht/1dhqz8j > > --tomasz > > ___ > Mobile-l mailing list > Mobile-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/mobile-l > -- Dan Garry Associate Product Manager, Mobile Apps Wikimedia Foundation ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] Good job iOS app team for getting todays build out
Excited to see us push forward on this release and get closer to delighting our users. Big call to everyone else on this list to help us with further testing. thanks all http://tflig.ht/1dhqz8j --tomasz ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] iOS code style
Great! Thanks again for note taking and updates! > On Feb 13, 2015, at 3:17 PM, Brian Gerstle wrote: > > After a meeting in which the team reviewed Corey's suggested coding style > guidelines, I've made the following edits: > Use of dot-notation for instance methods that are cheap & free of side-effects > Added note about auto-trimming trailing whitespace via Xcode settings > More "if" statement examples (one-line w/ curly brackets) > Ternary statement with ?: operator (Ruby/JS "or" behavior) > ObjC method declaration and invocation spacing guidelines > Block declarations as typedef and method arguments > Category instance method prefix > Use of extern for public constants, and static for private ones > Replaced FJ & Flying Jalapeno w/ WMF & Wikimedia Foundation > I decided to leave some other stuff for "best practices" (i.e. not coding > style), e.g. telescoping methods and use of const for local variables. > > Feel free to leave comments on the talk page or add in anything I missed. > > -- > EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle > IRC: bgerstle > ___ > Mobile-l mailing list > Mobile-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] iOS code style
Sorry, forgot the link: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/ObjectiveCStyleGuide On Fri, Feb 13, 2015 at 6:17 PM, Brian Gerstle wrote: > After a meeting in which the team reviewed Corey's suggested coding style > guidelines, I've made the following edits: > >- Use of dot-notation for instance methods that are cheap & free of >side-effects >- Added note about auto-trimming trailing whitespace via Xcode settings >- More "if" statement examples (one-line w/ curly brackets) >- *Ternary statement with ?: operator (Ruby/JS "or" behavior)* >- ObjC method declaration and invocation spacing guidelines >- Block declarations as typedef and method arguments >- Category instance method prefix >- Use of extern for public constants, and static for private ones >- Replaced FJ & Flying Jalapeno w/ WMF & Wikimedia Foundation > > I decided to leave some other stuff for "best practices" (i.e. not coding > style), e.g. telescoping methods and use of *const* for local variables. > > Feel free to leave comments on the talk page or add in anything I missed. > > -- > EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle > IRC: bgerstle > -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] iOS code style
After a meeting in which the team reviewed Corey's suggested coding style guidelines, I've made the following edits: - Use of dot-notation for instance methods that are cheap & free of side-effects - Added note about auto-trimming trailing whitespace via Xcode settings - More "if" statement examples (one-line w/ curly brackets) - *Ternary statement with ?: operator (Ruby/JS "or" behavior)* - ObjC method declaration and invocation spacing guidelines - Block declarations as typedef and method arguments - Category instance method prefix - Use of extern for public constants, and static for private ones - Replaced FJ & Flying Jalapeno w/ WMF & Wikimedia Foundation I decided to leave some other stuff for "best practices" (i.e. not coding style), e.g. telescoping methods and use of *const* for local variables. Feel free to leave comments on the talk page or add in anything I missed. -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Blockskit (iOS App 3rd Party Library)
+ 1 to Brian's 1st person comment :) No reservations. SHIP IT! On Fri, Feb 13, 2015 at 2:27 PM, Brian Gerstle wrote: > I love the first-person perspective. Glad to have you BK! > > On Fri, Feb 13, 2015 at 3:40 PM, Adam Baso wrote: > >> Great writeup. I don't have any reservations. >> >> -Adam >> >> On Fri, Feb 13, 2015 at 12:14 PM, Corey Floyd >> wrote: >> >>> (Testing out our new 3rd party library vetting: >>> https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries >>> ) >>> >>> >>> Early today I interviewed BlocksKit for a potential position in our >>> codebase (Specifically BlocksKit/Core). >>> >>> BlocksKit is a popular functional veneer for the cocoa frameworks. You >>> can find out more about BlocksKit here: >>> https://github.com/zwaldowski/BlocksKit >>> >>> Read BlocksKit's responses to our interview questions below: >>> >>> >>> >>>- Is the license permissive? >>> >>> Yes, I have an MIT license! Use me how you will. >>> >>>- Is the library ubiquitous? >>> >>> I have 3,100+ stars and 407 forks on Github - people like me. >>> >>>- Is it installable via CocoaPods? >>> >>> Of course! >>> >>>- What is the impact on binary size? >>> >>> Negligible, I don't contain any assets and consist mostly of small >>> categories. >>> >>>- How severe, if at all, are inbuilt subdependencies? >>> >>> I don't need no stinking dependencies. >>> >>>- Will this make the code more, or less, understandable for >>>volunteers? >>> >>> Depends on the volunteer - Those with with functional programming skills >>> will be more comfortable with my syntax. I am however a pretty well >>> documented and lightweight library, so I should be easy to understand for >>> anyone how to use me. >>> >>>- What are the performance ramifications of using this library? >>> >>> None, I use foundation classes to perform enumerations so I get all the >>> performance benefits of the Cocoa collections. >>> >>>- What are the complexity ramifications of using this library? >>> >>> My primary purpose is to remove boiler plate code and make developer >>> intent more clear. I should decrease complexity of your code. >>> >>>- Is it actively maintained? >>> >>> Yes - I am very well cared for and have a nice test suite. >>> >>>- Is it compatible with current deployment targets? >>> >>> Yes - I still have a soft spot for iOS 6. >>> >>>- Does it hinder interop (e.g., with Swift)? >>> >>> I love and Obj-C and Swift (but Swift does include some of my >>> functionality in the standard library) >>> >>>- What is the exit plan if the library becomes unmaintained? >>> >>> Since I am pretty lean and have good test coverage, your team should be >>> able to maintain me if needed. If you decide to not maintain me, you can >>> move some of your codebase to swift to replace some of my functionality. >>> >>> >>> Thanks for reading… If you have any other questions for BlocksKit, be >>> sure to leave them here and we will forward them on. >>> >>> >>> >>> ___ >>> Mobile-l mailing list >>> Mobile-l@lists.wikimedia.org >>> https://lists.wikimedia.org/mailman/listinfo/mobile-l >>> >>> >> >> ___ >> Mobile-l mailing list >> Mobile-l@lists.wikimedia.org >> https://lists.wikimedia.org/mailman/listinfo/mobile-l >> >> > > > -- > EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle > IRC: bgerstle > > ___ > Mobile-l mailing list > Mobile-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/mobile-l > > ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Blockskit (iOS App 3rd Party Library)
I love the first-person perspective. Glad to have you BK! On Fri, Feb 13, 2015 at 3:40 PM, Adam Baso wrote: > Great writeup. I don't have any reservations. > > -Adam > > On Fri, Feb 13, 2015 at 12:14 PM, Corey Floyd > wrote: > >> (Testing out our new 3rd party library vetting: >> https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries >> ) >> >> >> Early today I interviewed BlocksKit for a potential position in our >> codebase (Specifically BlocksKit/Core). >> >> BlocksKit is a popular functional veneer for the cocoa frameworks. You >> can find out more about BlocksKit here: >> https://github.com/zwaldowski/BlocksKit >> >> Read BlocksKit's responses to our interview questions below: >> >> >> >>- Is the license permissive? >> >> Yes, I have an MIT license! Use me how you will. >> >>- Is the library ubiquitous? >> >> I have 3,100+ stars and 407 forks on Github - people like me. >> >>- Is it installable via CocoaPods? >> >> Of course! >> >>- What is the impact on binary size? >> >> Negligible, I don't contain any assets and consist mostly of small >> categories. >> >>- How severe, if at all, are inbuilt subdependencies? >> >> I don't need no stinking dependencies. >> >>- Will this make the code more, or less, understandable for >>volunteers? >> >> Depends on the volunteer - Those with with functional programming skills >> will be more comfortable with my syntax. I am however a pretty well >> documented and lightweight library, so I should be easy to understand for >> anyone how to use me. >> >>- What are the performance ramifications of using this library? >> >> None, I use foundation classes to perform enumerations so I get all the >> performance benefits of the Cocoa collections. >> >>- What are the complexity ramifications of using this library? >> >> My primary purpose is to remove boiler plate code and make developer >> intent more clear. I should decrease complexity of your code. >> >>- Is it actively maintained? >> >> Yes - I am very well cared for and have a nice test suite. >> >>- Is it compatible with current deployment targets? >> >> Yes - I still have a soft spot for iOS 6. >> >>- Does it hinder interop (e.g., with Swift)? >> >> I love and Obj-C and Swift (but Swift does include some of my >> functionality in the standard library) >> >>- What is the exit plan if the library becomes unmaintained? >> >> Since I am pretty lean and have good test coverage, your team should be >> able to maintain me if needed. If you decide to not maintain me, you can >> move some of your codebase to swift to replace some of my functionality. >> >> >> Thanks for reading… If you have any other questions for BlocksKit, be >> sure to leave them here and we will forward them on. >> >> >> >> ___ >> Mobile-l mailing list >> Mobile-l@lists.wikimedia.org >> https://lists.wikimedia.org/mailman/listinfo/mobile-l >> >> > > ___ > Mobile-l mailing list > Mobile-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/mobile-l > > -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Blockskit (iOS App 3rd Party Library)
Great writeup. I don't have any reservations. -Adam On Fri, Feb 13, 2015 at 12:14 PM, Corey Floyd wrote: > (Testing out our new 3rd party library vetting: > https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries > ) > > > Early today I interviewed BlocksKit for a potential position in our > codebase (Specifically BlocksKit/Core). > > BlocksKit is a popular functional veneer for the cocoa frameworks. You can > find out more about BlocksKit here: > https://github.com/zwaldowski/BlocksKit > > Read BlocksKit's responses to our interview questions below: > > > >- Is the license permissive? > > Yes, I have an MIT license! Use me how you will. > >- Is the library ubiquitous? > > I have 3,100+ stars and 407 forks on Github - people like me. > >- Is it installable via CocoaPods? > > Of course! > >- What is the impact on binary size? > > Negligible, I don't contain any assets and consist mostly of small > categories. > >- How severe, if at all, are inbuilt subdependencies? > > I don't need no stinking dependencies. > >- Will this make the code more, or less, understandable for >volunteers? > > Depends on the volunteer - Those with with functional programming skills > will be more comfortable with my syntax. I am however a pretty well > documented and lightweight library, so I should be easy to understand for > anyone how to use me. > >- What are the performance ramifications of using this library? > > None, I use foundation classes to perform enumerations so I get all the > performance benefits of the Cocoa collections. > >- What are the complexity ramifications of using this library? > > My primary purpose is to remove boiler plate code and make developer > intent more clear. I should decrease complexity of your code. > >- Is it actively maintained? > > Yes - I am very well cared for and have a nice test suite. > >- Is it compatible with current deployment targets? > > Yes - I still have a soft spot for iOS 6. > >- Does it hinder interop (e.g., with Swift)? > > I love and Obj-C and Swift (but Swift does include some of my > functionality in the standard library) > >- What is the exit plan if the library becomes unmaintained? > > Since I am pretty lean and have good test coverage, your team should be > able to maintain me if needed. If you decide to not maintain me, you can > move some of your codebase to swift to replace some of my functionality. > > > Thanks for reading… If you have any other questions for BlocksKit, be sure > to leave them here and we will forward them on. > > > > ___ > Mobile-l mailing list > Mobile-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/mobile-l > > ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] Blockskit (iOS App 3rd Party Library)
(Testing out our new 3rd party library vetting: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries ) Early today I interviewed BlocksKit for a potential position in our codebase (Specifically BlocksKit/Core). BlocksKit is a popular functional veneer for the cocoa frameworks. You can find out more about BlocksKit here: https://github.com/zwaldowski/BlocksKit Read BlocksKit's responses to our interview questions below: - Is the license permissive? Yes, I have an MIT license! Use me how you will. - Is the library ubiquitous? I have 3,100+ stars and 407 forks on Github - people like me. - Is it installable via CocoaPods? Of course! - What is the impact on binary size? Negligible, I don't contain any assets and consist mostly of small categories. - How severe, if at all, are inbuilt subdependencies? I don't need no stinking dependencies. - Will this make the code more, or less, understandable for volunteers? Depends on the volunteer - Those with with functional programming skills will be more comfortable with my syntax. I am however a pretty well documented and lightweight library, so I should be easy to understand for anyone how to use me. - What are the performance ramifications of using this library? None, I use foundation classes to perform enumerations so I get all the performance benefits of the Cocoa collections. - What are the complexity ramifications of using this library? My primary purpose is to remove boiler plate code and make developer intent more clear. I should decrease complexity of your code. - Is it actively maintained? Yes - I am very well cared for and have a nice test suite. - Is it compatible with current deployment targets? Yes - I still have a soft spot for iOS 6. - Does it hinder interop (e.g., with Swift)? I love and Obj-C and Swift (but Swift does include some of my functionality in the standard library) - What is the exit plan if the library becomes unmaintained? Since I am pretty lean and have good test coverage, your team should be able to maintain me if needed. If you decide to not maintain me, you can move some of your codebase to swift to replace some of my functionality. Thanks for reading… If you have any other questions for BlocksKit, be sure to leave them here and we will forward them on. ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Open Source Third Party Libraries in iOS
Yup, run one that you've discussed recently or are considering to see if this rubric makes the conversation easier and keeps the team aligned. That's what it should be doing. --tomasz On Fri, Feb 13, 2015 at 9:51 AM, Adam Baso wrote: > I don't think we have anything just yet, but maybe we could try looking at > _one_ of the recently added libraries just as a proof of process? iOS crew, > any particular simple one we could try this on? > > -Adam > > On Thu, Feb 12, 2015 at 4:49 PM, Tomasz Finc wrote: >> >> Good to see this drafted. >> >> What's our first use case to vet our criteria ? >> >> --tomasz >> >> On Thu, Feb 12, 2015 at 4:46 PM, Adam Baso wrote: >> > Following up, here's where we arrived: >> > >> > >> > https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries >> > >> > -Adam >> > >> > On Wed, Feb 11, 2015 at 9:37 AM, Adam Baso wrote: >> >> >> >> The apps crew is going to be having a meeting to go over third party >> >> library usage in iOS. We're currently use CocoaPods for package >> >> management. >> >> >> >> In advance of that meeting tomorrow, anybody have advice we should >> >> consider? >> >> >> >> -Adam >> > >> > >> > >> > ___ >> > Mobile-l mailing list >> > Mobile-l@lists.wikimedia.org >> > https://lists.wikimedia.org/mailman/listinfo/mobile-l >> > > > ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Open Source Third Party Libraries in iOS
Great. Mind doing the sweep through the questions? On Fri, Feb 13, 2015 at 9:59 AM, Corey Floyd wrote: > @Adam - we could try blockskit - that is a relatively simple non-UI > library. > > On Fri, Feb 13, 2015 at 12:51 PM, Adam Baso wrote: > >> I don't think we have anything just yet, but maybe we could try looking >> at _one_ of the recently added libraries just as a proof of process? iOS >> crew, any particular simple one we could try this on? >> >> -Adam >> >> On Thu, Feb 12, 2015 at 4:49 PM, Tomasz Finc wrote: >> >>> Good to see this drafted. >>> >>> What's our first use case to vet our criteria ? >>> >>> --tomasz >>> >>> On Thu, Feb 12, 2015 at 4:46 PM, Adam Baso wrote: >>> > Following up, here's where we arrived: >>> > >>> > >>> https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries >>> > >>> > -Adam >>> > >>> > On Wed, Feb 11, 2015 at 9:37 AM, Adam Baso >>> wrote: >>> >> >>> >> The apps crew is going to be having a meeting to go over third party >>> >> library usage in iOS. We're currently use CocoaPods for package >>> management. >>> >> >>> >> In advance of that meeting tomorrow, anybody have advice we should >>> >> consider? >>> >> >>> >> -Adam >>> > >>> > >>> > >>> > ___ >>> > Mobile-l mailing list >>> > Mobile-l@lists.wikimedia.org >>> > https://lists.wikimedia.org/mailman/listinfo/mobile-l >>> > >>> >> >> >> ___ >> Mobile-l mailing list >> Mobile-l@lists.wikimedia.org >> https://lists.wikimedia.org/mailman/listinfo/mobile-l >> >> > > > -- > Corey Floyd > Software Engineer > Mobile Apps / iOS > Wikimedia Foundation > ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Open Source Third Party Libraries in iOS
@Adam - we could try blockskit - that is a relatively simple non-UI library. On Fri, Feb 13, 2015 at 12:51 PM, Adam Baso wrote: > I don't think we have anything just yet, but maybe we could try looking at > _one_ of the recently added libraries just as a proof of process? iOS crew, > any particular simple one we could try this on? > > -Adam > > On Thu, Feb 12, 2015 at 4:49 PM, Tomasz Finc wrote: > >> Good to see this drafted. >> >> What's our first use case to vet our criteria ? >> >> --tomasz >> >> On Thu, Feb 12, 2015 at 4:46 PM, Adam Baso wrote: >> > Following up, here's where we arrived: >> > >> > >> https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries >> > >> > -Adam >> > >> > On Wed, Feb 11, 2015 at 9:37 AM, Adam Baso wrote: >> >> >> >> The apps crew is going to be having a meeting to go over third party >> >> library usage in iOS. We're currently use CocoaPods for package >> management. >> >> >> >> In advance of that meeting tomorrow, anybody have advice we should >> >> consider? >> >> >> >> -Adam >> > >> > >> > >> > ___ >> > Mobile-l mailing list >> > Mobile-l@lists.wikimedia.org >> > https://lists.wikimedia.org/mailman/listinfo/mobile-l >> > >> > > > ___ > Mobile-l mailing list > Mobile-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/mobile-l > > -- Corey Floyd Software Engineer Mobile Apps / iOS Wikimedia Foundation ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Open Source Third Party Libraries in iOS
I don't think we have anything just yet, but maybe we could try looking at _one_ of the recently added libraries just as a proof of process? iOS crew, any particular simple one we could try this on? -Adam On Thu, Feb 12, 2015 at 4:49 PM, Tomasz Finc wrote: > Good to see this drafted. > > What's our first use case to vet our criteria ? > > --tomasz > > On Thu, Feb 12, 2015 at 4:46 PM, Adam Baso wrote: > > Following up, here's where we arrived: > > > > > https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Third_Party_Libraries > > > > -Adam > > > > On Wed, Feb 11, 2015 at 9:37 AM, Adam Baso wrote: > >> > >> The apps crew is going to be having a meeting to go over third party > >> library usage in iOS. We're currently use CocoaPods for package > management. > >> > >> In advance of that meeting tomorrow, anybody have advice we should > >> consider? > >> > >> -Adam > > > > > > > > ___ > > Mobile-l mailing list > > Mobile-l@lists.wikimedia.org > > https://lists.wikimedia.org/mailman/listinfo/mobile-l > > > ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
