Re: [WikimediaMobile] [Web] Outstanding branches
esisupport is not needed anymore, I've nuked it, along with old deployment branches. On Mon, Jul 6, 2015 at 8:47 AM, Sam Smith samsm...@wikimedia.org wrote: Hey y'all, There are a bunch of (stale?) branches open against MobileFrontend. Do we need to keep any of the following around? - esisupport - photouploads3 - sandbox/jdlrobson/ds - sandbox/jgonera/backbone - sandbox/jgonera/backbone-watchlist - sandbox/jgonera/edit - sandbox/jgonera/framework Ta, –Sam ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Performance audit example
cc wikitech - I think this is important for all of us to think about - not just those working on mobile, since mobile still loads a lot of what desktop does... On Mon, Jul 6, 2015 at 8:40 AM, Joaquin Oltra Hernandez jhernan...@wikimedia.org wrote: Hey, I saw the other day a performance audit that Paul Irish did for the mobile site of reddit. It is a great audit and a great example of how to do a performance review of a site, I encourage all to carefully read it as we are going to have to do something similar in the following sprints in order to enable us to do more concrete performance work on the mobile website. https://github.com/reddit/reddit-mobile/issues/247 Awesome stuff. ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- Jon Robson * http://jonrobson.me.uk * https://www.facebook.com/jonrobson * @rakugojon ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Android app bug report template
awesome, Bernd! On Mon, Jul 6, 2015 at 10:07 AM, Bernd Sitzmann be...@wikimedia.org wrote: https://phabricator.wikimedia.org/T104086 is a bug report template for Android issues. The easiest way to file a new bug is to go there and click on the link to file a pre-populated Phab ticket. Most of the time the regular one is what you need. If you fill out bugs coming from OTRS or crash reports then use the second one. You can also find this template in the last column of our Android workboard[1]. Cheers, Bernd [1] https://phabricator.wikimedia.org/tag/wikipedia-android-app/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] Android app bug report template
https://phabricator.wikimedia.org/T104086 is a bug report template for Android issues. The easiest way to file a new bug is to go there and click on the link to file a pre-populated Phab ticket. Most of the time the regular one is what you need. If you fill out bugs coming from OTRS or crash reports then use the second one. You can also find this template in the last column of our Android workboard[1]. Cheers, Bernd [1] https://phabricator.wikimedia.org/tag/wikipedia-android-app/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] [video club] RailsConf 2015 - Implementing a Strong Code Review Culture
Thanks for sharing. It's a good way to think about code review - as taking the best from each other and learning together. Particularly the bit about Is style important resonated with me (The study... found... people who received a lot of style comments on their code, reviewed those reviewers rather negatively) - I feel much happier ever since we discussed and introduced style guides e.g. jscs in many of our projects and it's a reminder when we notice pain in code review, to think of ways to improve the way we work to minimise these. Personally, I will be more mindful about asking questions more than demanding for changes, to help build a better culture in our team. On Wed, Jul 1, 2015 at 9:57 PM, Stephen Niedzielski sniedziel...@wikimedia.org wrote: What a great recommendation! Thanks for sharing! --stephen On Mon, Jun 29, 2015 at 10:51 AM, Toby Negrin tneg...@wikimedia.org wrote: Thanks for posting this Sam -- code review is one of the best parts of our engineering culture, I'll definitely watch this when I get a chance. -Toby On Mon, Jun 29, 2015 at 7:59 AM, Sam Smith samsm...@wikimedia.org wrote: Hey y'all, I watch a lot of talks in my downtime. I even post the ones I like to a Tumblr… sometimes [0]. I felt like sharing Derek Prior's Implementing a Strong Code Review Culture from RailsConf 2015 in particular because it's relevant to the conversations that the Reading Web team are having around process and quality. You can watch the talk on YouTube [1] and, if you're keen, you can read the paper that's referenced over at Microsoft Research [2]. I particularly like the challenge of providing two paragraphs of context in a commit message – to introduce the problem and your solution – and trying to overcome negativity bias in written communication* by offering compliments whenever possible and asking, not telling, while providing critical feedback. I hope you enjoy the talk as much as I did. –Sam [0] http://sometalks.tumblr.com/ [1] https://www.youtube.com/watch?v=PJjmw9TRB7s [2] http://research.microsoft.com/apps/pubs/default.aspx?id=180283 * The speaker said research has shown but I didn't see a citation Notes (width added emphasis) Code review isn't for catching bugs Expectations, Outcomes, and Challenges of Modern Code Review Chief benefits of code review: Knowledge transfer Increased team awareness Finding alternative solutions Code review is the discipline of explaining your code to your peers Process is more important than the result Goes on to define code review as the discipline of discussing your code with your peers If we get better at code review, then we'll get better at communicating technically as a team Rules of Engagement As an author, provide context If content is king, then context is God In a pull request (patch set) the code is the content and the commit message is the context Provide sufficient context - bring the reviewer up to speed with what you've been doing in the past X hours Challenge: provide at least two paragraphs of context in your commit message This additional context lives on in the commit history whereas links to issue trackers might not As a reviewer, ask questions rather than making demands Research has shown that there's a negativity bias in written communication. Offer compliments whenever you can When you need to provide critical feedback, ask, don't tell, e.g. extract a service to reduce some of this duplication could be formulated as what do you think about extracting a service to reduce some of this duplication? Did you consider?, can you clarify? Why didn't you just... is framed negatively and includes the word just Use the Socratic method: asking and answering questions to stimulate critical thinking and to illuminate ideas Insist on high quality reviews, but agree to disagree Conflict is good. Conflict drives a higher standard of coding provided there's healthy debate Everyone has a minimum bar to entry for quality. Once that bar is met, then everything else is a trade-off Reasonable people disagree all the time Review what's important to you SRP (Single Responsibility Principle) (the S from SOLID) Naming Complexity Test Coverage ... (whatever else you're comfortable in giving feedback on) What about style? Style is important People who received style comments on their code perceived that review negatively Adopt a styleguide Benefits of a Strong Code Review Culture Better code Better developers through constant knowledge transfer Team ownership of code, which leads to fewer silos Healthy debate ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Performance audit example
We indeed will in the next sprint to be able to be well informed in order to tackle our performance goals :D On Mon, Jul 6, 2015 at 7:44 PM, Jon Robson jdlrob...@gmail.com wrote: cc wikitech - I think this is important for all of us to think about - not just those working on mobile, since mobile still loads a lot of what desktop does... On Mon, Jul 6, 2015 at 8:40 AM, Joaquin Oltra Hernandez jhernan...@wikimedia.org wrote: Hey, I saw the other day a performance audit that Paul Irish did for the mobile site of reddit. It is a great audit and a great example of how to do a performance review of a site, I encourage all to carefully read it as we are going to have to do something similar in the following sprints in order to enable us to do more concrete performance work on the mobile website. https://github.com/reddit/reddit-mobile/issues/247 Awesome stuff. ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- Jon Robson * http://jonrobson.me.uk * https://www.facebook.com/jonrobson * @rakugojon ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Android app bug report template
Should we link from the app itself? On Mon, Jul 6, 2015 at 12:19 PM, Bernd Sitzmann be...@wikimedia.org wrote: Toby, This is on mobile-l. Did you have any other distribution list in mind? Cheers, Bernd On Mon, Jul 6, 2015 at 1:14 PM, Toby Negrin tneg...@wikimedia.org wrote: Nice Bernd -- is this appropriate to share with community? -Toby On Mon, Jul 6, 2015 at 10:56 AM, Jon Katz jk...@wikimedia.org wrote: awesome, Bernd! On Mon, Jul 6, 2015 at 10:07 AM, Bernd Sitzmann be...@wikimedia.org wrote: https://phabricator.wikimedia.org/T104086 is a bug report template for Android issues. The easiest way to file a new bug is to go there and click on the link to file a pre-populated Phab ticket. Most of the time the regular one is what you need. If you fill out bugs coming from OTRS or crash reports then use the second one. You can also find this template in the last column of our Android workboard[1]. Cheers, Bernd [1] https://phabricator.wikimedia.org/tag/wikipedia-android-app/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Android app bug report template
Nice Bernd -- is this appropriate to share with community? -Toby On Mon, Jul 6, 2015 at 10:56 AM, Jon Katz jk...@wikimedia.org wrote: awesome, Bernd! On Mon, Jul 6, 2015 at 10:07 AM, Bernd Sitzmann be...@wikimedia.org wrote: https://phabricator.wikimedia.org/T104086 is a bug report template for Android issues. The easiest way to file a new bug is to go there and click on the link to file a pre-populated Phab ticket. Most of the time the regular one is what you need. If you fill out bugs coming from OTRS or crash reports then use the second one. You can also find this template in the last column of our Android workboard[1]. Cheers, Bernd [1] https://phabricator.wikimedia.org/tag/wikipedia-android-app/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] [Web] Outstanding branches
Thanks both. The branch list is looking much neater. –Sam On Mon, Jul 6, 2015 at 5:52 PM, Max Semenik maxsem.w...@gmail.com wrote: esisupport is not needed anymore, I've nuked it, along with old deployment branches. On Mon, Jul 6, 2015 at 8:47 AM, Sam Smith samsm...@wikimedia.org wrote: Hey y'all, There are a bunch of (stale?) branches open against MobileFrontend. Do we need to keep any of the following around? - esisupport - photouploads3 - sandbox/jdlrobson/ds - sandbox/jgonera/backbone - sandbox/jgonera/backbone-watchlist - sandbox/jgonera/edit - sandbox/jgonera/framework Ta, –Sam ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Android app bug report template
Toby, This is on mobile-l. Did you have any other distribution list in mind? Cheers, Bernd On Mon, Jul 6, 2015 at 1:14 PM, Toby Negrin tneg...@wikimedia.org wrote: Nice Bernd -- is this appropriate to share with community? -Toby On Mon, Jul 6, 2015 at 10:56 AM, Jon Katz jk...@wikimedia.org wrote: awesome, Bernd! On Mon, Jul 6, 2015 at 10:07 AM, Bernd Sitzmann be...@wikimedia.org wrote: https://phabricator.wikimedia.org/T104086 is a bug report template for Android issues. The easiest way to file a new bug is to go there and click on the link to file a pre-populated Phab ticket. Most of the time the regular one is what you need. If you fill out bugs coming from OTRS or crash reports then use the second one. You can also find this template in the last column of our Android workboard[1]. Cheers, Bernd [1] https://phabricator.wikimedia.org/tag/wikipedia-android-app/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Mobile-Apps' Unbreak now tasks in Phabricator
I closed the iOS ones, which were already in the Done column in Phab 2 sprints ago. Sorry for the confusion, still grappling w/ task state transitions vs. columns. On Mon, Jul 6, 2015 at 6:10 PM, Andre Klapper aklap...@wikimedia.org wrote: Hi, could the Apps Team please update their open tasks with Unbreak Now! priority [1] in Phabricator's Mobile-App-Sprint-58-iOS project? https://phabricator.wikimedia.org/maniphest/query/40ps.K.br_Ri/#R That Sprint ended one month ago and all remaining tasks are in the Done column. Thanks in advance, andre [1] Something is broken and needs to be fixed immediately as per https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities -- Andre Klapper | Wikimedia Bugwrangler http://blogs.gnome.org/aklapper/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Mobile-Apps' Unbreak now tasks in Phabricator
Thanks Brian -- I just pinged Monte since his name was on them. -Toby On Mon, Jul 6, 2015 at 3:40 PM, Brian Gerstle bgers...@wikimedia.org wrote: I closed the iOS ones, which were already in the Done column in Phab 2 sprints ago. Sorry for the confusion, still grappling w/ task state transitions vs. columns. On Mon, Jul 6, 2015 at 6:10 PM, Andre Klapper aklap...@wikimedia.org wrote: Hi, could the Apps Team please update their open tasks with Unbreak Now! priority [1] in Phabricator's Mobile-App-Sprint-58-iOS project? https://phabricator.wikimedia.org/maniphest/query/40ps.K.br_Ri/#R That Sprint ended one month ago and all remaining tasks are in the Done column. Thanks in advance, andre [1] Something is broken and needs to be fixed immediately as per https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities -- Andre Klapper | Wikimedia Bugwrangler http://blogs.gnome.org/aklapper/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] Mobile-Apps' Unbreak now tasks in Phabricator
Hi, could the Apps Team please update their open tasks with Unbreak Now! priority [1] in Phabricator's Mobile-App-Sprint-58-iOS project? https://phabricator.wikimedia.org/maniphest/query/40ps.K.br_Ri/#R That Sprint ended one month ago and all remaining tasks are in the Done column. Thanks in advance, andre [1] Something is broken and needs to be fixed immediately as per https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities -- Andre Klapper | Wikimedia Bugwrangler http://blogs.gnome.org/aklapper/ ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] Mobile MediaViewer and the Seattle Japanese Garden
English Wikipedia's Seattle Japanese Garden article looks good in the Android app, and the MediaViewer-like slideshow feature works well for the gallery. However, I'm unable to scroll through the photos in Mobile Web like I csn using the Android app. Are there any plans to add the slideshow functionality to mobile web? Thanks! Pine ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
[WikimediaMobile] Performance audit example
Hey, I saw the other day a performance audit that Paul Irish did for the mobile site of reddit. It is a great audit and a great example of how to do a performance review of a site, I encourage all to carefully read it as we are going to have to do something similar in the following sprints in order to enable us to do more concrete performance work on the mobile website. https://github.com/reddit/reddit-mobile/issues/247 Awesome stuff. ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] [Web] Outstanding branches
Awww little walk down memory lane. Photo uploads version 1, experiments with ESI for performance gains, experiments with dynamically loaded sections, the first version of the mobile editor and back in the frontend framework days when we were considering Backbone JS around the conception of oojs ui was being built. Nah these are all old and can be removed or preserved in glass jars. On Mon, Jul 6, 2015 at 8:47 AM, Sam Smith samsm...@wikimedia.org wrote: Hey y'all, There are a bunch of (stale?) branches open against MobileFrontend. Do we need to keep any of the following around? esisupport photouploads3 sandbox/jdlrobson/ds sandbox/jgonera/backbone sandbox/jgonera/backbone-watchlist sandbox/jgonera/edit sandbox/jgonera/framework Ta, –Sam ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Re: [WikimediaMobile] Mobile MediaViewer and the Seattle Japanese Garden
https://phabricator.wikimedia.org/T101718 On 5 Jul 2015 11:51 pm, Pine W wiki.p...@gmail.com wrote: English Wikipedia's Seattle Japanese Garden article looks good in the Android app, and the MediaViewer-like slideshow feature works well for the gallery. However, I'm unable to scroll through the photos in Mobile Web like I csn using the Android app. Are there any plans to add the slideshow functionality to mobile web? Thanks! Pine ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
