[PATCH] test, modem-helpers: remove unnecessary NULL check for g_free()
g_free() handles a NULL pointer properly, so there is no need to have a NULL check before calling g_free(). --- src/tests/test-modem-helpers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/tests/test-modem-helpers.c b/src/tests/test-modem-helpers.c index 483b56f5..4a044c68 100644 --- a/src/tests/test-modem-helpers.c +++ b/src/tests/test-modem-helpers.c @@ -3265,8 +3265,7 @@ test_cclk_response (void) g_assert (mm_network_timezone_get_leap_seconds (tz) == MM_NETWORK_TIMEZONE_LEAP_SECONDS_UNKNOWN); } -if (iso8601) -g_free (iso8601); +g_free (iso8601); if (tz) g_object_unref (tz); -- 2.19.0.rc0.228.g281dcd1b4d0-goog ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
[review] Add udev tag for setting RTS/CTS flow control
Hi, I have created this MR that adds a new udev tag (ID_MM_TTY_CRTSCTS) that allows using RTS/CTS flow control in RS232 ports if necessary: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/35 It is ready for review :) Thanks, Alfonso ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
[no subject]
Hi, I have created this MR that adds a new udev tag (ID_MM_TTY_CRTSCTS) that allows using RTS/CTS flow control in RS232 ports if necessary: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/35 It is ready for review :) Thanks, Alfonso ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
Re: [PATCH] libmm-glib,pco: add missing documentation for MMPco
On Mon, Aug 27, 2018 at 9:55 PM, Ben Chan wrote:
> ---
> libmm-glib/mm-modem-3gpp.c | 2 +-
> libmm-glib/mm-pco.c| 25 +
> 2 files changed, 26 insertions(+), 1 deletion(-)
>
Pushed it to git master, and an additional follow up patch to fix
several missing things.
> diff --git a/libmm-glib/mm-modem-3gpp.c b/libmm-glib/mm-modem-3gpp.c
> index 360aaef6..80746f98 100644
> --- a/libmm-glib/mm-modem-3gpp.c
> +++ b/libmm-glib/mm-modem-3gpp.c
> @@ -308,7 +308,7 @@ mm_modem_3gpp_get_eps_ue_mode_operation (MMModem3gpp
> *self)
> * The caller is responsible for freeing the returned #GList with
> * mm_pco_list_free().
> *
> - * Returns: (transfer full): A list of #MMPco.
> + * Returns: (element-type ModemManager.Pco) (transfer full): A list of
> #MMPco.
> */
> GList *
> mm_modem_3gpp_get_pco (MMModem3gpp *self)
> diff --git a/libmm-glib/mm-pco.c b/libmm-glib/mm-pco.c
> index 7ee347b0..0afa1b4b 100644
> --- a/libmm-glib/mm-pco.c
> +++ b/libmm-glib/mm-pco.c
> @@ -193,6 +193,14 @@ mm_pco_from_variant (GVariant *variant,
>
>
> /*/
>
> +/**
> + * mm_pco_to_variant:
> + * @self: a #MMPco.
> + *
> + * Gets a GVariant representation with signature "(ubay)" of @self.
> + *
> + * Returns: (transfer full): A #GVariant representation of the #MMPco
> object. The returned value should be freed with g_variant_unref().
> + */
> GVariant *
> mm_pco_to_variant (MMPco *self)
> {
> @@ -224,12 +232,29 @@ mm_pco_to_variant (MMPco *self)
>
>
> /*/
>
> +/**
> + * mm_pco_list_free:
> + * @pco_list (element-type ModemManager.Pco): a #GList of #MMPco.
> + *
> + * Frees all of the memory used by a #GList of #MMPco.
> + */
> void
> mm_pco_list_free (GList *pco_list)
> {
> g_list_free_full (pco_list, g_object_unref);
> }
>
> +/**
> + * mm_pco_list_add:
> + * @pco_list (element-type ModemManager.Pco): a #GList of #MMPco.
> + * @pco:: a #MMPco to add to the given list.
> + *
> + * Adds a #MMPco to a given PCO list. #MMPco objects stored in the order of
> + * their session ID. An existing PCO with the same session ID is overwritten
> + * with the new value.
> + *
> + * Returns: (element-type ModemManager.Pco): the new start of an updated or
> newly allocated #GList of #MMPco.
> + */
> GList *
> mm_pco_list_add (GList *pco_list,
> MMPco *pco)
> --
> 2.19.0.rc0.228.g281dcd1b4d0-goog
>
--
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
[review] SUPL server address validation
Hey, Most devices allow specifying the SUPL server in two different ways; either as "IP and PORT" or "FQDN and PORT". Our API had support for "IP and PORT" but then we would just fallback to a generic "URL" string, which never wasn't really a valid URL. This patch introduces some minor validation for these two cases, not really fully validating that the FQDN string is a valid domain name, but at least allowing to specify a port explicitly for that case. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/34 Comments? -- Aleksander https://aleksander.es ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
[review] Print LAC/TAC/CID in hex in mmcli output
Hey, How about this? https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/33 Cheers -- Aleksander https://aleksander.es ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
