Re: [PATCH] altair-lte: don't use send-delay=0

2017-08-03 Thread Aleksander Morgado 
On Thu, Aug 3, 2017 at 4:24 PM, Ben Chan  wrote:
>
>
> On Aug 3, 2017 3:35 AM, "Aleksander Morgado" 
> wrote:
>
> On 02/08/17 07:16, Ben Chan wrote:
>> As observed on some modems, send-delay=0 seems to break port probing.
>> ---
>>  plugins/altair/mm-plugin-altair-lte.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>
> But the port probing with send delay 0 here should only happen when the
> Altair LTE modem is the one being probed. Does this mean this modem
> (0x216f:0x0047) doesn't like send-delay 0?
>
>
>  I tested on two variants of the modem (same chipset, same VID:PID,
> different modules; both support LTE band 13, one also supports band 4). The
> newer one, which supports band 4+13,  doesn't like send-delay 0 :(
>

Could you clarify that in the commit message? I think it would be
valuable for future reference.


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH] altair-lte: don't use send-delay=0

2017-08-03 Thread Ben Chan 
On Aug 3, 2017 3:35 AM, "Aleksander Morgado" 
wrote:

On 02/08/17 07:16, Ben Chan wrote:
> As observed on some modems, send-delay=0 seems to break port probing.
> ---
>  plugins/altair/mm-plugin-altair-lte.c | 1 -
>  1 file changed, 1 deletion(-)
>

But the port probing with send delay 0 here should only happen when the
Altair LTE modem is the one being probed. Does this mean this modem
(0x216f:0x0047) doesn't like send-delay 0?


 I tested on two variants of the modem (same chipset, same VID:PID,
different modules; both support LTE band 13, one also supports band 4). The
newer one, which supports band 4+13,  doesn't like send-delay 0 :(


> diff --git a/plugins/altair/mm-plugin-altair-lte.c
b/plugins/altair/mm-plugin-altair-lte.c
> index 2338502b..7f6a7c0b 100644
> --- a/plugins/altair/mm-plugin-altair-lte.c
> +++ b/plugins/altair/mm-plugin-altair-lte.c
> @@ -83,7 +83,6 @@ mm_plugin_create (void)
>MM_PLUGIN_CUSTOM_AT_PROBE, custom_at_probe,
>MM_PLUGIN_ALLOWED_SINGLE_AT,   TRUE,
>MM_PLUGIN_SEND_LF, TRUE,
> -  MM_PLUGIN_SEND_DELAY,  0,
>NULL));
>  }
>
>


--
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH] altair-lte: don't use send-delay=0

2017-08-03 Thread Aleksander Morgado 
On 02/08/17 07:16, Ben Chan wrote:
> As observed on some modems, send-delay=0 seems to break port probing.
> ---
>  plugins/altair/mm-plugin-altair-lte.c | 1 -
>  1 file changed, 1 deletion(-)
> 

But the port probing with send delay 0 here should only happen when the Altair 
LTE modem is the one being probed. Does this mean this modem (0x216f:0x0047) 
doesn't like send-delay 0?

> diff --git a/plugins/altair/mm-plugin-altair-lte.c 
> b/plugins/altair/mm-plugin-altair-lte.c
> index 2338502b..7f6a7c0b 100644
> --- a/plugins/altair/mm-plugin-altair-lte.c
> +++ b/plugins/altair/mm-plugin-altair-lte.c
> @@ -83,7 +83,6 @@ mm_plugin_create (void)
>MM_PLUGIN_CUSTOM_AT_PROBE, custom_at_probe,
>MM_PLUGIN_ALLOWED_SINGLE_AT,   TRUE,
>MM_PLUGIN_SEND_LF, TRUE,
> -  MM_PLUGIN_SEND_DELAY,  0,
>NULL));
>  }
>  
> 


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH] altair-lte: don't use send-delay=0

2017-08-01 Thread Ben Chan 
As observed on some modems, send-delay=0 seems to break port probing.
---
 plugins/altair/mm-plugin-altair-lte.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/altair/mm-plugin-altair-lte.c 
b/plugins/altair/mm-plugin-altair-lte.c
index 2338502b..7f6a7c0b 100644
--- a/plugins/altair/mm-plugin-altair-lte.c
+++ b/plugins/altair/mm-plugin-altair-lte.c
@@ -83,7 +83,6 @@ mm_plugin_create (void)
   MM_PLUGIN_CUSTOM_AT_PROBE, custom_at_probe,
   MM_PLUGIN_ALLOWED_SINGLE_AT,   TRUE,
   MM_PLUGIN_SEND_LF, TRUE,
-  MM_PLUGIN_SEND_DELAY,  0,
   NULL));
 }
 
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel