Re: [PATCH] huawei: remove redundant call to huawei_parse_auth_type()

[Aleksander Morgado]

On 03/08/17 22:34, Dan Williams wrote:
> On Thu, 2017-08-03 at 13:25 -0700, Ben Chan wrote:
>> This patch removes a redundant `encoded_auth = huawei_parse_auth_type
>> (auth)`
>> in connect_3gpp_context_step().
> 
> LGTM
> 

Pushed to git master, thanks!

>> ---
>>  plugins/huawei/mm-broadband-bearer-huawei.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/plugins/huawei/mm-broadband-bearer-huawei.c
>> b/plugins/huawei/mm-broadband-bearer-huawei.c
>> index 175fe5b6..2230e74a 100644
>> --- a/plugins/huawei/mm-broadband-bearer-huawei.c
>> +++ b/plugins/huawei/mm-broadband-bearer-huawei.c
>> @@ -389,7 +389,7 @@ connect_3gpp_context_step (Connect3gppContext
>> *ctx)
>>  encoded_auth = huawei_parse_auth_type (auth);
>>  
>>  /* Default to no authentication if not specified */
>> -if ((encoded_auth = huawei_parse_auth_type (auth)) ==
>> MM_BEARER_HUAWEI_AUTH_UNKNOWN)
>> +if (encoded_auth == MM_BEARER_HUAWEI_AUTH_UNKNOWN)
>>  encoded_auth = MM_BEARER_HUAWEI_AUTH_NONE;
>>  
>>  if (!user && !passwd)


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH] huawei: remove redundant call to huawei_parse_auth_type()

[Ben Chan]

This patch removes a redundant `encoded_auth = huawei_parse_auth_type (auth)`
in connect_3gpp_context_step().
---
 plugins/huawei/mm-broadband-bearer-huawei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/huawei/mm-broadband-bearer-huawei.c 
b/plugins/huawei/mm-broadband-bearer-huawei.c
index 175fe5b6..2230e74a 100644
--- a/plugins/huawei/mm-broadband-bearer-huawei.c
+++ b/plugins/huawei/mm-broadband-bearer-huawei.c
@@ -389,7 +389,7 @@ connect_3gpp_context_step (Connect3gppContext *ctx)
 encoded_auth = huawei_parse_auth_type (auth);
 
 /* Default to no authentication if not specified */
-if ((encoded_auth = huawei_parse_auth_type (auth)) == 
MM_BEARER_HUAWEI_AUTH_UNKNOWN)
+if (encoded_auth == MM_BEARER_HUAWEI_AUTH_UNKNOWN)
 encoded_auth = MM_BEARER_HUAWEI_AUTH_NONE;
 
 if (!user && !passwd)
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel